x86: vmx: add regression test for posted interrupts
PATCH 1/1 x86: vmx: add regression test for posted interrupts
If a guest blocks interrupts for the entirety of running in root mode (RFLAGS.IF=0), a pending interrupt corresponding to the posted-interrupt vector set in the VMCS should result in an interrupt posting to the vIRR at VM-entry. However, on KVM this is not the case. The pending interrupt is not recognized as the posted-interrupt vector and instead results in an external interrupt VM-exit.
Add a regression test to exercise this issue.
--- lib/x86/asm/bitops.h | 8 +++++ x86/vmx_tests.c | 76 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+)
lib/x86/asm/bitops.h +8 -0
@@ -13,4 +13,12 @@#define HAVE_BUILTIN_FLS 1 +static inline void test_and_set_bit (long nr,unsigned long *addr) +{ + asmvolatile ("lock; bts %1, %0" + :"+m" (*addr) + :"Ir" (nr) + :"memory" ); +} +#endif
x86/vmx_tests.c +76 -0
87 lines not on this page · raw message
Signature · 1 line
2.28.0.806.g8561365e88-goog
Quoted 127 lines · Oliver Upton
If a guest blocks interrupts for the entirety of running in root mode (RFLAGS.IF=0), a pending interrupt corresponding to the posted-interrupt vector set in the VMCS should result in an interrupt posting to the vIRR at VM-entry. However, on KVM this is not the case. The pending interrupt is not recognized as the posted-interrupt vector and instead results in an external interrupt VM-exit.
Add a regression test to exercise this issue.
Signed-off-by Oliver Upton <[email protected]>--- lib/x86/asm/bitops.h | 8 +++++ x86/vmx_tests.c | 76 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+)lib/x86/asm/bitops.h +8
-0@@ -13,4 +13,12 @@#define HAVE_BUILTIN_FLS 1 +static inline void test_and_set_bit (long nr,unsigned long *addr) +{ + asmvolatile ("lock; bts %1, %0" + :"+m" (*addr) + :"Ir" (nr) + :"memory" ); +} +#endif x86/vmx_tests.c +76
-1@@ -10430,6 +10430,81 @@ static void atomic_switch_overflow_msrs_test(void)test_skip ("Test is only supported on KVM" ); } +#define PI_VECTOR 0xe0 +#define PI_TEST_VECTOR 0x21 + +static void enable_posted_interrupts (void ) +{ +void *pi_desc =alloc_page (); + +vmcs_set_bits (PIN_CONTROLS ,PIN_POST_INTR ); +vmcs_set_bits (EXI_CONTROLS ,EXI_INTA ); +vmcs_write (PINV ,PI_VECTOR ); +vmcs_write (POSTED_INTR_DESC_ADDR , (u64 )pi_desc); +} + +static unsigned long *get_pi_desc (void ) +{ +return (unsigned long *)vmcs_read (POSTED_INTR_DESC_ADDR ); +} + +static void post_interrupt (u8 vector,u32 dest) +{ +unsigned long *pi_desc =get_pi_desc (); + +test_and_set_bit (vector, pi_desc); +test_and_set_bit (256 , pi_desc); +apic_icr_write (PI_VECTOR , dest); +} + +static struct vmx_posted_interrupt_test_args { +bool isr_fired; +} vmx_posted_interrupt_test_args; + +static void vmx_posted_interrupt_test_isr (isr_regs_t *regs) +{ +volatile struct vmx_posted_interrupt_test_args *args + = &vmx_posted_interrupt_test_args; + + args->isr_fired = true; +eoi (); +} + +static void vmx_posted_interrupt_test_guest (void ) +{ +handle_irq (PI_TEST_VECTOR , vmx_posted_interrupt_test_isr); +irq_enable (); +vmcall (); + asmvolatile ("nop" ); +vmcall (); +} + +static void vmx_posted_interrupt_test (void ) +{ +volatile struct vmx_posted_interrupt_test_args *args + = &vmx_posted_interrupt_test_args; + +if (!cpu_has_apicv ()) { +report_skip (__func__); +return ; + } + +enable_vid (); +enable_posted_interrupts (); +test_set_guest (vmx_posted_interrupt_test_guest); + +enter_guest (); +skip_exit_vmcall (); + +irq_disable (); +post_interrupt (PI_TEST_VECTOR ,apic_id ()); +enter_guest (); + +skip_exit_vmcall (); +TEST_ASSERT (args->isr_fired); +enter_guest (); +} +#define TEST (name) { #name, .v2 = name }/* name/init/guest_main/exit_handler/syscall_handler/guest_regs */ @@ -10533,5 +10608,6 @@ struct vmx_test vmx_tests[] = {TEST (rdtsc_vmexit_diff_test),TEST (vmx_mtf_test),TEST (vmx_mtf_pdpte_test), +TEST (vmx_posted_interrupt_test), { NULL, NULL, NULL, NULL, NULL, {0} }, }; --
Quoted 2 lines
2.28.0.806.g8561365e88-goog
Ping.
Paolo Bonzini
maintainerQuoted 10 lines · Oliver Upton
If a guest blocks interrupts for the entirety of running in root mode (RFLAGS.IF=0), a pending interrupt corresponding to the posted-interrupt vector set in the VMCS should result in an interrupt posting to the vIRR at VM-entry. However, on KVM this is not the case. The pending interrupt is not recognized as the posted-interrupt vector and instead results in an external interrupt VM-exit.
Add a regression test to exercise this issue.
Signed-off-by Oliver Upton <[email protected]>
I am a bit confused. Is this testing the KVM or the bare metal behavior? Or was this fixed in KVM already?
Paolo
Quoted 116 lines
--- lib/x86/asm/bitops.h | 8 +++++ x86/vmx_tests.c | 76 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+)lib/x86/asm/bitops.h +8
-0@@ -13,4 +13,12 @@#define HAVE_BUILTIN_FLS 1 +static inline void test_and_set_bit (long nr,unsigned long *addr) +{ + asmvolatile ("lock; bts %1, %0" + :"+m" (*addr) + :"Ir" (nr) + :"memory" ); +} +#endif x86/vmx_tests.c +76
-0@@ -10430,6 +10430,81 @@ static void atomic_switch_overflow_msrs_test(void)test_skip ("Test is only supported on KVM" ); } +#define PI_VECTOR 0xe0 +#define PI_TEST_VECTOR 0x21 + +static void enable_posted_interrupts (void ) +{ +void *pi_desc =alloc_page (); + +vmcs_set_bits (PIN_CONTROLS ,PIN_POST_INTR ); +vmcs_set_bits (EXI_CONTROLS ,EXI_INTA ); +vmcs_write (PINV ,PI_VECTOR ); +vmcs_write (POSTED_INTR_DESC_ADDR , (u64 )pi_desc); +} + +static unsigned long *get_pi_desc (void ) +{ +return (unsigned long *)vmcs_read (POSTED_INTR_DESC_ADDR ); +} + +static void post_interrupt (u8 vector,u32 dest) +{ +unsigned long *pi_desc =get_pi_desc (); + +test_and_set_bit (vector, pi_desc); +test_and_set_bit (256 , pi_desc); +apic_icr_write (PI_VECTOR , dest); +} + +static struct vmx_posted_interrupt_test_args { +bool isr_fired; +} vmx_posted_interrupt_test_args; + +static void vmx_posted_interrupt_test_isr (isr_regs_t *regs) +{ +volatile struct vmx_posted_interrupt_test_args *args + = &vmx_posted_interrupt_test_args; + + args->isr_fired = true; +eoi (); +} + +static void vmx_posted_interrupt_test_guest (void ) +{ +handle_irq (PI_TEST_VECTOR , vmx_posted_interrupt_test_isr); +irq_enable (); +vmcall (); + asmvolatile ("nop" ); +vmcall (); +} + +static void vmx_posted_interrupt_test (void ) +{ +volatile struct vmx_posted_interrupt_test_args *args + = &vmx_posted_interrupt_test_args; + +if (!cpu_has_apicv ()) { +report_skip (__func__); +return ; + } + +enable_vid (); +enable_posted_interrupts (); +test_set_guest (vmx_posted_interrupt_test_guest); + +enter_guest (); +skip_exit_vmcall (); + +irq_disable (); +post_interrupt (PI_TEST_VECTOR ,apic_id ()); +enter_guest (); + +skip_exit_vmcall (); +TEST_ASSERT (args->isr_fired); +enter_guest (); +} +#define TEST (name) { #name, .v2 = name }/* name/init/guest_main/exit_handler/syscall_handler/guest_regs */ @@ -10533,5 +10608,6 @@ struct vmx_test vmx_tests[] = {TEST (rdtsc_vmexit_diff_test),TEST (vmx_mtf_test),TEST (vmx_mtf_pdpte_test), +TEST (vmx_posted_interrupt_test), { NULL, NULL, NULL, NULL, NULL, {0} }, };
Quoted 9 lines · Paolo Bonzini
Quoted 7 lines · Oliver Upton
If a guest blocks interrupts for the entirety of running in root mode (RFLAGS.IF=0), a pending interrupt corresponding to the posted-interrupt vector set in the VMCS should result in an interrupt posting to the vIRR at VM-entry. However, on KVM this is not the case. The pending interrupt is not recognized as the posted-interrupt vector and instead results in an external interrupt VM-exit.
Quoted 6 lines
Quoted 3 lines
Add a regression test to exercise this issue.
Signed-off-by Oliver Upton <[email protected]>I am a bit confused. Is this testing the KVM or the bare metal behavior? Or was this fixed in KVM already?
This is a directed test case for25bb2cf97139 ("KVM: nVMX: Morph notification vector IRQ on nested VM-Enter to pending PI")
My local version of this patch has changed a bit. I'll send a v2 shortly.
--
Thanks,
Oliver
Quoted 120 lines
Paolo
Quoted 116 lines
--- lib/x86/asm/bitops.h | 8 +++++ x86/vmx_tests.c | 76 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 84 insertions(+)lib/x86/asm/bitops.h +8
-0@@ -13,4 +13,12 @@#define HAVE_BUILTIN_FLS 1 +static inline void test_and_set_bit (long nr,unsigned long *addr) +{ + asmvolatile ("lock; bts %1, %0" + :"+m" (*addr) + :"Ir" (nr) + :"memory" ); +} +#endif x86/vmx_tests.c +76
-0@@ -10430,6 +10430,81 @@ static void atomic_switch_overflow_msrs_test(void)test_skip ("Test is only supported on KVM" ); } +#define PI_VECTOR 0xe0 +#define PI_TEST_VECTOR 0x21 + +static void enable_posted_interrupts (void ) +{ +void *pi_desc =alloc_page (); + +vmcs_set_bits (PIN_CONTROLS ,PIN_POST_INTR ); +vmcs_set_bits (EXI_CONTROLS ,EXI_INTA ); +vmcs_write (PINV ,PI_VECTOR ); +vmcs_write (POSTED_INTR_DESC_ADDR , (u64 )pi_desc); +} + +static unsigned long *get_pi_desc (void ) +{ +return (unsigned long *)vmcs_read (POSTED_INTR_DESC_ADDR ); +} + +static void post_interrupt (u8 vector,u32 dest) +{ +unsigned long *pi_desc =get_pi_desc (); + +test_and_set_bit (vector, pi_desc); +test_and_set_bit (256 , pi_desc); +apic_icr_write (PI_VECTOR , dest); +} + +static struct vmx_posted_interrupt_test_args { +bool isr_fired; +} vmx_posted_interrupt_test_args; + +static void vmx_posted_interrupt_test_isr (isr_regs_t *regs) +{ +volatile struct vmx_posted_interrupt_test_args *args + = &vmx_posted_interrupt_test_args; + + args->isr_fired = true; +eoi (); +} + +static void vmx_posted_interrupt_test_guest (void ) +{ +handle_irq (PI_TEST_VECTOR , vmx_posted_interrupt_test_isr); +irq_enable (); +vmcall (); + asmvolatile ("nop" ); +vmcall (); +} + +static void vmx_posted_interrupt_test (void ) +{ +volatile struct vmx_posted_interrupt_test_args *args + = &vmx_posted_interrupt_test_args; + +if (!cpu_has_apicv ()) { +report_skip (__func__); +return ; + } + +enable_vid (); +enable_posted_interrupts (); +test_set_guest (vmx_posted_interrupt_test_guest); + +enter_guest (); +skip_exit_vmcall (); + +irq_disable (); +post_interrupt (PI_TEST_VECTOR ,apic_id ()); +enter_guest (); + +skip_exit_vmcall (); +TEST_ASSERT (args->isr_fired); +enter_guest (); +} +#define TEST (name) { #name, .v2 = name }/* name/init/guest_main/exit_handler/syscall_handler/guest_regs */ @@ -10533,5 +10608,6 @@ struct vmx_test vmx_tests[] = {TEST (rdtsc_vmexit_diff_test),TEST (vmx_mtf_test),TEST (vmx_mtf_pdpte_test), +TEST (vmx_posted_interrupt_test), { NULL, NULL, NULL, NULL, NULL, {0} }, };
Paolo Bonzini
maintainerQuoted 12 lines · Oliver Upton
Quoted 11 lines · Paolo Bonzini
Quoted 9 lines · Oliver Upton
If a guest blocks interrupts for the entirety of running in root mode (RFLAGS.IF=0), a pending interrupt corresponding to the posted-interrupt vector set in the VMCS should result in an interrupt posting to the vIRR at VM-entry. However, on KVM this is not the case. The pending interrupt is not recognized as the posted-interrupt vector and instead results in an external interrupt VM-exit.
Add a regression test to exercise this issue.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Oliver Upton <[email protected]>I am a bit confused. Is this testing the KVM or the bare metal behavior? Or was this fixed in KVM already?
This is a directed test case for
25bb2cf97139("KVM: nVMX: Morph notification vector IRQ on nested VM-Enter to pending PI")
Ok, thanks. However, the patch currently fails like this:
Test suite: vmx_posted_interrupt_test
VM-Fail on vmlaunch: error number is 7. See Intel 30.4.
I haven't debugged it, so for now I suggest that you just move it to a separate suite.
Paolo
A message that is not in the archive (sent off-list or not yet received): CAOQ_Qsij7LH8XK28XqgbNTJqct6Q7LZsniSB3xAvtbPm1uYL_Q@mail.gmail.com
Paolo Bonzini
maintainerQuoted 11 lines · Oliver Upton
Ok, thanks. However, the patch currently fails like this:
Test suite:
vmx_posted_interrupt_testVM-Fail on vmlaunch: error number is 7. See Intel 30.4.I haven't debugged it, so for now I suggest that you just move it to a separate suite.
What commit are you on? Not reproducing for me.
kvm-unit-tests master + this patch
Linux kvm/queue
It works if I just invoke the test, but not with "./run_tests.sh vmx" or, equivalently
./x86/run x86/vmx.flat -smp 1 -cpu host,+vmx -append "-exit_monitor_from_l2_test -ept_access* -vmx_smp* -vmx_vmcs_shadow_test -atomic_switch_overflow_msrs_test -vmx_init_signal_test -vmx_apic_passthrough_tpr_threshold_test
Paolo