Skip to contentSkip to conversation

ARM: dts: da850-evm: add WP and CD to MMC

PATCH Superseded Adam Ford 2 participants 2 messages Apr 27, 2018 – May 1, 2018 Device tree bindings

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/1 ARM: dts: da850-evm: add WP and CD to MMC

The legacy mode uses the write protect and card detect but DT has not. This patch enables the pinmuxing and detection for WP and CD.

---

V2: Rebase on davinci master and remove GPIO pinmuxing

 arch/arm/boot/dts/da850-evm.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/da850-evm.dts +2 -0
index 4c59dab3362e..a56d43d53ba1 100644
@@ -107,6 +107,8 @@
 			status = "okay";
 			pinctrl-names = "default";
 			pinctrl-0 = <&mmc0_pins>;
+			cd-gpios = <&gpio 64 GPIO_ACTIVE_LOW>;
+			wp-gpios = <&gpio 65 GPIO_ACTIVE_HIGH>;
 		};
 		spi1: spi at 30e000 {
 			status = "okay";
Signature · 1 line
2.17.0
#1 lore raw

PATCH v2 1/1 ARM: dts: da850-evm: add WP and CD to MMC

Quoted 3 lines · Adam Ford

The legacy mode uses the write protect and card detect but DT has not. This patch enables the pinmuxing and detection for WP and CD.

patch description should be readable without reference to headline. So "MMC" should appear somewhere in the description too. Also, you are not doing pinmuxing anymore. I think the reference to that should be dropped or refer to the fact that this happening through gpio-ranges property.

Quoted 2 lines

Thanks,
Sekhar