Skip to contentSkip to conversation

vhost: fix compile error

PATCH In review Jin Yu 4 participants 11 messages Oct 28, 2019 – Nov 6, 2019 Library code

lore
Share & tools
lore

Jin Yu

author
#0 lore raw

PATCH 1/1 vhost: fix compile error

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356
Cc: [email protected]

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +1 -1
index 41c463d92..a30accb29 100644
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
Signature · 1 line
2.17.2
#1 lore raw
Quoted 6 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356
Cc: [email protected]

Fixes 939066d96563 ("vhost/crypto: add public function implementation")
Quoted 11 lines
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +0 -0
index 41c463d92..a30accb29 100644

lib/Makefile DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev · line 49

Quoted 5 lines
lib/Makefile +1 -1
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash

Do we also depend on cryptodev (rte_cryptodev.h)?

Quoted 6 lines
lib/Makefile +0 -0
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
Signature · 1 line
2.17.2
author
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: Bie, Tiwei
Sent: Tuesday, October 29, 2019 9:36 PM
To: Yu, Jin <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [dpdk-stable] [PATCH] vhost: fix compile error

On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:

Quoted 8 lines
Quoted 6 lines

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.

Bugzilla ID: 356
Cc: [email protected]

Fixes 939066d96563 ("vhost/crypto: add public function implementation")

Thanks.

Quoted 13 lines

lib/Makefile DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=

Quoted 12 lines
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile index 41c463d92..a30accb29 renamed from lib/Makefile +0 -0

100644

lib/Makefile +0 -0
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=

librte_rawdev

Quoted 7 lines

lib/Makefile DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev · line 49

Quoted 5 lines

DEPDIRS-librte_rawdev := librte_eal librte_ethdev
DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost DEPDIRS-librte_vhost
:= librte_eal librte_mempool librte_mbuf librte_ethdev \

lib/Makefile +1 -1
-			librte_net
+			librte_net librte_hash

Do we also depend on cryptodev (rte_cryptodev.h)?

Yes, but luckily we didn't meet this error, it seems librte_cryptodev always compile before vhost. Ok, I will add it too. Thanks.

Quoted 7 lines
Quoted 7 lines

DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash DEPDIRS-librte_hash :=
librte_eal librte_ring
DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
--
2.17.2

author
#3 lore raw

PATCH 1/1 vhost: fix compile error

In reply to Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +1 -1
index 41c463d92..b2a143d4f 100644
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash librte_cryptodev
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
Signature · 1 line
2.17.2
author
#4 lore raw

PATCH v2 1/1 vhost: fix compile error

In reply to Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +1 -1
index 41c463d92..b2a143d4f 100644
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash librte_cryptodev
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
Signature · 1 line
2.17.2
Reviewed-by on v2 1/1
#5 lore raw
Quoted 8 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")
Quoted 6 lines

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by on v2 1/1
#6 lore raw
In reply to Jin Yu
Quoted 8 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")
Quoted 6 lines

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Maxime

#7 lore raw
In reply to Jin Yu

Hi Jin,

Quoted 21 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +0 -0
index 41c463d92..b2a143d4f 100644

lib/Makefile DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev · line 52

Quoted 8 lines
lib/Makefile +1 -1
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash librte_cryptodev
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd

http://mails.dpdk.org/archives/test-report/2019-October/105347.html

The Intel compilation reports a breakage with this patch, and the breakage happens in some crypto drivers. Could you please check it is not a regression due to your patch?

*Make Build Failed #1:
OS: CENTOS76-64
Target: x86_64-native-linuxapp-clang
CC zlib_pmd.o.pmd.o
LD qat_device.o
LD zlib_pmd.o
CC hw_atl_utils_fw2x.o
1 error generated.
make[6]: *** [dpaa2_sec_dpseci.o] Error 1
make[5]: *** [dpaa2_sec] Error 2
make[5]: *** Waiting for unfinished jobs....
CC hw_atl_b0.o
CC qat_logs.o
CC zlib_pmd_ops.o
CC rte_pmd_atlantic.o
--
CC axgbe_rxtx_vec_sse.o
AR librte_pmd_octeontx_crypto.a
AR librte_pmd_bond.a
INSTALL-LIB librte_pmd_octeontx_crypto.a
INSTALL-LIB librte_pmd_bond.a
make[4]: *** [crypto] Error 2
make[4]: *** Waiting for unfinished jobs....
CC dpaa2_mux.o
== Build drivers/net/ena
CC dpaa2_sparser.o
CC mc/dpni.o
--
CC hunt_nic.o
CC medford_nic.o
CC medford2_nic.o
AR librte_pmd_sfc_efx.a
INSTALL-LIB librte_pmd_sfc_efx.a
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2

#8 lore raw

Maxime,

Quoted 36 lines · Maxime Coquelin

Hi Jin,

Quoted 21 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +0 -0
index 41c463d92..b2a143d4f 100644

lib/Makefile DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev · line 52

Quoted 8 lines
lib/Makefile +1 -1
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-                     librte_net
+                     librte_net librte_hash librte_cryptodev
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd

http://mails.dpdk.org/archives/test-report/2019-October/105347.html

Quoted 3 lines

The Intel compilation reports a breakage with this patch, and the breakage happens in some crypto drivers. Could you please check it is not a regression due to your patch?

Should be fixed with:
https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84

Quoted 40 lines

*Make Build Failed #1:
OS: CENTOS76-64
Target: x86_64-native-linuxapp-clang
CC zlib_pmd.o.pmd.o
LD qat_device.o
LD zlib_pmd.o
CC hw_atl_utils_fw2x.o
1 error generated.
make[6]: *** [dpaa2_sec_dpseci.o] Error 1
make[5]: *** [dpaa2_sec] Error 2
make[5]: *** Waiting for unfinished jobs....
CC hw_atl_b0.o
CC qat_logs.o
CC zlib_pmd_ops.o
CC rte_pmd_atlantic.o
--
CC axgbe_rxtx_vec_sse.o
AR librte_pmd_octeontx_crypto.a
AR librte_pmd_bond.a
INSTALL-LIB librte_pmd_octeontx_crypto.a
INSTALL-LIB librte_pmd_bond.a
make[4]: *** [crypto] Error 2
make[4]: *** Waiting for unfinished jobs....
CC dpaa2_mux.o
== Build drivers/net/ena
CC dpaa2_sparser.o
CC mc/dpni.o
--
CC hunt_nic.o
CC medford_nic.o
CC medford2_nic.o
AR librte_pmd_sfc_efx.a
INSTALL-LIB librte_pmd_sfc_efx.a
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2

Signature · 1 line
David Marchand
#9 lore raw
Quoted 40 lines · David Marchand

Maxime,

Quoted 36 lines · Maxime Coquelin

Hi Jin,

Quoted 21 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +0 -0
index 41c463d92..b2a143d4f 100644

lib/Makefile DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev · line 52

Quoted 8 lines
lib/Makefile +1 -1
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-                     librte_net
+                     librte_net librte_hash librte_cryptodev
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd

http://mails.dpdk.org/archives/test-report/2019-October/105347.html

Quoted 6 lines
Quoted 3 lines

The Intel compilation reports a breakage with this patch, and the breakage happens in some crypto drivers. Could you please check it is not a regression due to your patch?

Should be fixed with:
https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84

Thanks David! Then it is ok to me.

Quoted 43 lines
Quoted 41 lines

*Make Build Failed #1:
OS: CENTOS76-64
Target: x86_64-native-linuxapp-clang
CC zlib_pmd.o.pmd.o
LD qat_device.o
LD zlib_pmd.o
CC hw_atl_utils_fw2x.o
1 error generated.
make[6]: *** [dpaa2_sec_dpseci.o] Error 1
make[5]: *** [dpaa2_sec] Error 2
make[5]: *** Waiting for unfinished jobs....
CC hw_atl_b0.o
CC qat_logs.o
CC zlib_pmd_ops.o
CC rte_pmd_atlantic.o
--
CC axgbe_rxtx_vec_sse.o
AR librte_pmd_octeontx_crypto.a
AR librte_pmd_bond.a
INSTALL-LIB librte_pmd_octeontx_crypto.a
INSTALL-LIB librte_pmd_bond.a
make[4]: *** [crypto] Error 2
make[4]: *** Waiting for unfinished jobs....
CC dpaa2_mux.o
== Build drivers/net/ena
CC dpaa2_sparser.o
CC mc/dpni.o
--
CC hunt_nic.o
CC medford_nic.o
CC medford2_nic.o
AR librte_pmd_sfc_efx.a
INSTALL-LIB librte_pmd_sfc_efx.a
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2

#10 lore raw
In reply to Jin Yu
Quoted 8 lines · Jin Yu

Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need the librte_hash to be compiled before vhost. Add the DEPDIRs to make sure this.

Bugzilla ID: 356

Fixes 939066d96563 ("vhost/crypto: add public function implementation")
Quoted 6 lines

---
V2 - add the librte_crytodev

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to dpdk-next-virtio/master.

Thanks,
Maxime