Skip to contentSkip to conversation

EDAC polling

DISCUSSION Sodagudi Prasad 2 participants 2 messages Sep 11, 2018 – Sep 12, 2018

lore
Share & tools
lore
#0 lore raw

Hi All,

While adding edac_device control info using edac_device_add_device(), changed the poll_msec at client driver level. For example -.
https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/edac/qcom_llcc_edac.c?h=msm-4.9#n385

I see that client driver request is not considered and always default value(1 second) is considered. During the initialization edac_device_workq_setup sets poll_msed to 1 second.

int edac_device_add_device(struct edac_device_ctl_info *edac_dev) {
...
...

        /* If there IS a check routine, then we are running POLLED */
        if (edac_dev->edac_check != NULL) {
                /* This instance is NOW RUNNING */
                edac_dev->op_state = OP_RUNNING_POLL;

                /*
                 * enable workq processing on this instance,
                 * default = 1000 msec
                 */
                edac_device_workq_setup(edac_dev, 1000);
        } else {
                edac_dev->op_state = OP_RUNNING_INTERRUPT;
        }

May I know why client edev_ctl->poll_msec settings is not considered?

-Thanks, Prasad

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
#1 lore raw
Quoted 1 line · Sodagudi Prasad

May I know why client edev_ctl->poll_msec settings is not considered?

Looks like it has been like this since it was added. But, I take patches :)

Make sure to sanity-check ->poll_msec too, before accepting it. I.e., something like < 1sec doesn't make sense, for example.

Signature · 4 lines
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.