qemu: Do not include file if not exists
PATCH 1/1 qemu: Do not include file if not exists
Script configure checks for if_alg.h and check failed but if_alg.h still included.
Upstream-Status: Submitted [<[email protected]>]
--- linux-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+)
linux-user/syscall.c +2 -0
@@ -109,7 +109,9 @@#include <linux/blkpg.h> #include <netpacket/packet.h> #include <linux/netlink.h> +#if defined(CONFIG_AF_ALG )#include <linux/if_alg.h> +#endif #include <linux/rtc.h> #include <sound/asound.h> #include "linux_loop.h"
Signature · 1 line
2.19.1
Quoted 4 lines · Oleksiy Obitotskyy
Script configure checks for
if_alg.hand check failed butif_alg.hstill included.Upstream-Status: Submitted [<[email protected]>]
^ Mainstream doesn't use such tag.
Otherwise:
Quoted 20 lines
Signed-off-by Oleksiy Obitotskyy <[email protected]>--- linux-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+)linux-user/syscall.c +2
-0@@ -109,7 +109,9 @@#include <linux/blkpg.h> #include <netpacket/packet.h> #include <linux/netlink.h> +#if defined(CONFIG_AF_ALG )#include <linux/if_alg.h> +#endif #include <linux/rtc.h> #include <sound/asound.h> #include "linux_loop.h"
PATCH 1/1 qemu: Do not include file if not exists
Script configure checks for if_alg.h and check failed but if_alg.h still included.
--- linux-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+)
linux-user/syscall.c +2 -0
@@ -109,7 +109,9 @@#include <linux/blkpg.h> #include <netpacket/packet.h> #include <linux/netlink.h> +#if defined(CONFIG_AF_ALG )#include <linux/if_alg.h> +#endif #include <linux/rtc.h> #include <sound/asound.h> #include "linux_loop.h"
Signature · 1 line
2.19.1
Cc'ing maintainers.
Oleksiy, this looks like a respin of your patch. Since it is buried in the original thread, our patch processing automation won't pick it up, and humans may well miss it, too. Next time, start a new thread, with proper [PATCH v2] versioning in the subject, and cc: the maintainers (use scripts/get_maintainer.pl to find them). Also collect the Reviewed-by tags, if any, and explain what changed since the previous version.
https://wiki.qemu.org/Contribute/SubmitAPatch
I know getting everything just right seems overwhelming at first. Don't worry about making innocent mistakes, just learn from them :)
Thanks for your fix!