Skip to contentSkip to conversation

drm/amdgpu: Fix unused variable warning

PATCH In review Luben Tuikov 2 participants 3 messages Jan 10, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Fix unused variable warning

Fix this:

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_query_error_status’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:945:6: warning: unused variable ‘i’ [-Wunused-variable]
945 | int i;

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +0 -1
index b1bedfd4febc4b..517650d286a722 100644
@@ -942,7 +942,6 @@ int amdgpu_ras_query_error_status(struct amdgpu_device *adev,
 	struct amdgpu_ras_block_object* block_obj = NULL;
 	struct ras_manager *obj = amdgpu_ras_find_obj(adev, &info->head);
 	struct ras_err_data err_data = {0, 0, 0, NULL};
-	int i;
 
 	if (!obj)
 		return -EINVAL;

base-commit: 9b7d59707fe1ff51cdfa0a048629446ff3945bfd

Signature · 1 line
2.34.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

[Public]

Please add:

Fixes 36324c09d848 ("drm/amdgpu: Modify sdma block to fit for the unified ras block data and ops")

With that,

________________________________
From: Tuikov, Luben <[email protected]>
Sent: Monday, January 10, 2022 3:32 PM
To: [email protected] <[email protected]>
Cc: Tuikov, Luben <[email protected]>; Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu: Fix unused variable warning

Fix this:

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_query_error_status’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:945:6: warning: unused variable ‘i’ [-Wunused-variable]
945 | int i;

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +0 -1
index b1bedfd4febc4b..517650d286a722 100644
@@ -942,7 +942,6 @@ int amdgpu_ras_query_error_status(struct amdgpu_device *adev,
         struct amdgpu_ras_block_object* block_obj = NULL;
         struct ras_manager *obj = amdgpu_ras_find_obj(adev, &info->head);
         struct ras_err_data err_data = {0, 0, 0, NULL};
-       int i;
 
         if (!obj)
                 return -EINVAL;

base-commit: 9b7d59707fe1ff51cdfa0a048629446ff3945bfd --
2.34.0

#2 lore raw

Okay, no problem.
I was actually wondering whether to add it, since it wasn't a technical failure...

Regards,
Luben

On 2022-01-10 15:49, Deucher, Alexander wrote:
P {margin-top:0;margin-bottom:0;} [Public]

Please add: Fixes: 36324c09d848 ("drm/amdgpu: Modify sdma block to fit for the unified ras block data and ops") With that, Reviewed-by: Alex Deucher <[email protected]>
From:Tuikov, Luben <[email protected]>
Sent:Monday, January 10, 2022 3:32 PM
To: [email protected]<[email protected]>
Cc:Tuikov, Luben <[email protected]>; Deucher, Alexander <[email protected]> Subject:[PATCH] drm/amdgpu: Fix unused variable warning   Fix this:

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_query_error_status’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:945:6: warning: unused variable ‘i’ [-Wunused-variable] 945 |  int i;

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 -

 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +0 -0
index b1bedfd4febc4b..517650d286a722 100644
@@ -942,7 +942,6 @@ int amdgpu_ras_query_error_status(struct amdgpu_device *adev,

         struct amdgpu_ras_block_object* block_obj = NULL; struct ras_manager *obj = amdgpu_ras_find_obj(adev, &info->head); struct ras_err_data err_data = {0, 0, 0, NULL};
-       int i;

         if (!obj)
                 return -EINVAL;

base-commit: 9b7d59707fe1ff51cdfa0a048629446ff3945bfd --
2.34.0