Skip to contentSkip to conversation

gpio: at91_gpio: Add bank names

PATCH New James Byrne 2 participants 4 messages Nov 15, 2019 – Nov 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: at91_gpio: Add bank names

Make the at91_gpio driver set sensible GPIO bank names in the platform data. This makes the 'gpio status' command a lot more useful.

---

 drivers/gpio/at91_gpio.c | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)
drivers/gpio/at91_gpio.c +26 -3
index 965becf77a..94b2b63a04 100644
@@ -19,6 +19,28 @@
 
 #define GPIO_PER_BANK	32
 
+static const char *at91_get_bank_name(uint32_t base_addr)
+{
+	switch (base_addr) {
+	case ATMEL_BASE_PIOA:
+		return "PIOA";
+	case ATMEL_BASE_PIOB:
+		return "PIOB";
+	case ATMEL_BASE_PIOC:
+		return "PIOC";
+#if (ATMEL_PIO_PORTS > 3)
+	case ATMEL_BASE_PIOD:
+		return "PIOD";
+#if (ATMEL_PIO_PORTS > 4)
+	case ATMEL_BASE_PIOE:
+		return "PIOE";
+#endif
+#endif
+	}
+
+	return "";
+}
+
 static struct at91_port *at91_pio_get_port(unsigned port)
 {
 	switch (port) {
@@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev)
 
 	clk_free(&clk);
 
-	uc_priv->bank_name = plat->bank_name;
-	uc_priv->gpio_count = GPIO_PER_BANK;
-
 #if CONFIG_IS_ENABLED(OF_CONTROL)
 	plat->base_addr = (uint32_t)devfdt_get_addr_ptr(dev);
 #endif
+	plat->bank_name = at91_get_bank_name(plat->base_addr);
 	port->regs = (struct at91_port *)plat->base_addr;
 
+	uc_priv->bank_name = plat->bank_name;
+	uc_priv->gpio_count = GPIO_PER_BANK;
+
 	return 0;
 }
 
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/1 gpio: at91_gpio: Add bank names

Quoted 44 lines · James Byrne

Make the at91_gpio driver set sensible GPIO bank names in the platform data. This makes the 'gpio status' command a lot more useful.

---

  drivers/gpio/at91_gpio.c | 29 ++++++++++++++++++++++++++---
  1 file changed, 26 insertions(+), 3 deletions(-)
drivers/gpio/at91_gpio.c +22 -0
index 965becf77a..94b2b63a04 100644
@@ -19,6 +19,28 @@
 
  #define GPIO_PER_BANK  32
 
+static const char *at91_get_bank_name(uint32_t base_addr)
+{
+       switch (base_addr) {
+       case ATMEL_BASE_PIOA:
+               return "PIOA";
+       case ATMEL_BASE_PIOB:
+               return "PIOB";
+       case ATMEL_BASE_PIOC:
+               return "PIOC";
+#if (ATMEL_PIO_PORTS > 3)
+       case ATMEL_BASE_PIOD:
+               return "PIOD";
+#if (ATMEL_PIO_PORTS > 4)
+       case ATMEL_BASE_PIOE:
+               return "PIOE";
+#endif
+#endif
+       }
+
+       return "";
+}
+
  static struct at91_port *at91_pio_get_port(unsigned port)
  {
         switch (port) {

drivers/gpio/at91_gpio.c static int at91_gpio_probe(struct udevice *dev) · line 610

Quoted 10 lines
drivers/gpio/at91_gpio.c +1 -3
@@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev)
 
         clk_free(&clk);
 
-       uc_priv->bank_name = plat->bank_name;
-       uc_priv->gpio_count = GPIO_PER_BANK;
-
  #if CONFIG_IS_ENABLED(OF_CONTROL)
         plat->base_addr = (uint32_t)devfdt_get_addr_ptr(dev);
  #endif
+       plat->bank_name = at91_get_bank_name(plat->base_addr);

Hello James,

Here you are rewriting the plat->bank_name... What was the old name that comes from the platform struct ?

Thanks for the patch,

Eugen

Quoted 12 lines
drivers/gpio/at91_gpio.c +3 -1
         port->regs = (struct at91_port *)plat->base_addr;
 
+       uc_priv->bank_name = plat->bank_name;
+       uc_priv->gpio_count = GPIO_PER_BANK;
+
         return 0;
  }
 
--

2.24.0

#2 lore raw

PATCH 1/1 gpio: at91_gpio: Add bank names

Hi Eugen,

Quoted 14 lines · Eugen.Hristev at microchip.com

drivers/gpio/at91_gpio.c static int at91_gpio_probe(struct udevice *dev) · line 610

Quoted 11 lines
drivers/gpio/at91_gpio.c +1 -3
@@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev)
 
          clk_free(&clk);
 
-       uc_priv->bank_name = plat->bank_name;
-       uc_priv->gpio_count = GPIO_PER_BANK;
-
   #if CONFIG_IS_ENABLED(OF_CONTROL)
          plat->base_addr = (uint32_t)devfdt_get_addr_ptr(dev);
   #endif
+       plat->bank_name = at91_get_bank_name(plat->base_addr);

Hello James,

Quoted 2 lines

Here you are rewriting the plat->bank_name... What was the old name that comes from the platform struct ?

It was unset (null).

Regards,

James

#3 lore raw

PATCH 1/1 gpio: at91_gpio: Add bank names

Quoted 18 lines · James Byrne

Hi Eugen,

Quoted 14 lines · Eugen.Hristev at microchip.com

drivers/gpio/at91_gpio.c static int at91_gpio_probe(struct udevice *dev) · line 610

Quoted 11 lines
drivers/gpio/at91_gpio.c +1 -3
@@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev)
 
           clk_free(&clk);
 
-       uc_priv->bank_name = plat->bank_name;
-       uc_priv->gpio_count = GPIO_PER_BANK;
-
    #if CONFIG_IS_ENABLED(OF_CONTROL)
           plat->base_addr = (uint32_t)devfdt_get_addr_ptr(dev);
    #endif
+       plat->bank_name = at91_get_bank_name(plat->base_addr);

Hello James,

Quoted 4 lines
Quoted 2 lines

Here you are rewriting the plat->bank_name... What was the old name that comes from the platform struct ?

It was unset (null).

Ok. Can you make the default name go to something like 'undefined' instead of an empty string ? Maybe it would be more meaningful, what do you think ? (and easier to spot in the CLI )

Thanks

Quoted 5 lines

Regards,

James