Skip to contentSkip to conversation

two optimizations to speed up the start time

PATCH Superseded Longpeng(Mike) via 3 participants 10 messages Dec 6, 2022 – Dec 20, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover two optimizations to speed up the start time

From: Longpeng <[email protected]>

Changes v2->v1:
Patch-1:
- remove vq_init_count [Jason]
Patch-2:
- new added. [Jason]

v1: https://www.mail-archive.com/[email protected]/msg922499.html

Longpeng (Mike) (2):
vhost: configure all host notifiers in a single MR transaction
vdpa: commit all host notifier MRs in a single MR transaction

 hw/virtio/vhost-vdpa.c | 18 ++++++++++++++++++
 hw/virtio/vhost.c      | 40 ++++++++++++++++++++++++++++++++++++++--
 2 files changed, 56 insertions(+), 2 deletions(-)
Signature · 1 line
2.23.0
#1 lore raw

PATCH v2 1/2 vhost: configure all host notifiers in a single MR transaction

From: Longpeng <[email protected]>

This allows the vhost device to batch the setup of all its host notifiers. This significantly reduces the device starting time, e.g. the time spend on enabling notifiers reduce from 376ms to 9.1ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device)

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
 hw/virtio/vhost.c | 40 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)
hw/virtio/vhost.c +38 -2
index 7fb008bc9e..16f8391d86 100644
@@ -1507,7 +1507,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)
 int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
 {
     BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
-    int i, r, e;
+    int i, n, r, e;
 
     /* We will pass the notifiers to the kernel, make sure that QEMU
      * doesn't interfere.
@@ -1518,6 +1518,12 @@ int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
         goto fail;
     }
 
+    /*
+     * Batch all the host notifiers in a single transaction to avoid
+     * quadratic time complexity in address_space_update_ioeventfds().
+     */
+    memory_region_transaction_begin();
+
     for (i = 0; i < hdev->nvqs; ++i) {
         r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                          true);
@@ -1527,8 +1533,12 @@ int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
         }
     }
 
+    memory_region_transaction_commit();
+
     return 0;
 fail_vq:
+    /* save i for a second iteration after transaction is committed. */
+    n = i;
     while (--i >= 0) {
         e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                          false);
@@ -1536,8 +1546,18 @@ fail_vq:
             error_report("vhost VQ %d notifier cleanup error: %d", i, -r);
         }
         assert (e >= 0);
-        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i);
     }
+
+    /*
+     * The transaction expects the ioeventfds to be open when it
+     * commits. Do it now, before the cleanup loop.
+     */
+    memory_region_transaction_commit();
+
+    while (--n >= 0) {
+        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + n);
+    }
+
     virtio_device_release_ioeventfd(vdev);
 fail:
     return r;
@@ -1553,6 +1573,12 @@ void vhost_dev_disable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
     BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
     int i, r;
 
+    /*
+     * Batch all the host notifiers in a single transaction to avoid
+     * quadratic time complexity in address_space_update_ioeventfds().
+     */
+    memory_region_transaction_begin();
+
     for (i = 0; i < hdev->nvqs; ++i) {
         r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                          false);
@@ -1560,8 +1586,18 @@ void vhost_dev_disable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
             error_report("vhost VQ %d notifier cleanup failed: %d", i, -r);
         }
         assert (r >= 0);
+    }
+
+    /*
+     * The transaction expects the ioeventfds to be open when it
+     * commits. Do it now, before the cleanup loop.
+     */
+    memory_region_transaction_commit();
+
+    for (i = 0; i < hdev->nvqs; ++i) {
         virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i);
     }
+
     virtio_device_release_ioeventfd(vdev);
 }
 
Signature · 1 line
2.23.0
#2 lore raw

Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction

Quoted 63 lines · Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost device to batch the setup of all its host notifiers. This significantly reduces the device starting time, e.g. the time spend on enabling notifiers reduce from 376ms to 9.1ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device)

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
  hw/virtio/vhost.c | 40 ++++++++++++++++++++++++++++++++++++++--
  1 file changed, 38 insertions(+), 2 deletions(-)
hw/virtio/vhost.c +15 -2
index 7fb008bc9e..16f8391d86 100644
@@ -1507,7 +1507,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)
  int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
  {
      BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
-    int i, r, e;
+    int i, n, r, e;
 
      /* We will pass the notifiers to the kernel, make sure that QEMU
       * doesn't interfere.
@@ -1518,6 +1518,12 @@ int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
          goto fail;
      }
 
+    /*
+     * Batch all the host notifiers in a single transaction to avoid
+     * quadratic time complexity in address_space_update_ioeventfds().
+     */
+    memory_region_transaction_begin();
+
      for (i = 0; i < hdev->nvqs; ++i) {
          r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                           true);
@@ -1527,8 +1533,12 @@ int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
          }
      }
 
+    memory_region_transaction_commit();
+
      return 0;
  fail_vq:
+    /* save i for a second iteration after transaction is committed. */
+    n = i;
      while (--i >= 0) {
          e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                           false);
@@ -1536,8 +1546,18 @@ fail_vq:
              error_report("vhost VQ %d notifier cleanup error: %d", i, -r);
          }
          assert (e >= 0);
-        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i);
      }
+
+    /*
+     * The transaction expects the ioeventfds to be open when it
+     * commits. Do it now, before the cleanup loop.

hw/virtio/vhost.c fail_vq: · line 1563

Quoted 10 lines
hw/virtio/vhost.c +7 -0
+     */
+    memory_region_transaction_commit();
+
+    while (--n >= 0) {
+        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + n);
+    }
+
      virtio_device_release_ioeventfd(vdev);
  fail:
      return r;

Similarly to patch #2, removing both goto statement in this function (as a preliminary patch) will 1/ simplify the code 2/ simplify reviewing your changes, resulting in something like:

int vhost_dev_enable_notifiers(struct vhost_dev *hdev,
VirtIODevice *vdev)

{
    BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
    int i, r, e;

    /* We will pass the notifiers to the kernel, make sure that QEMU
     * doesn't interfere.
     */
    r = virtio_device_grab_ioeventfd(vdev);
    if (r < 0) {
        error_report("binding does not support host notifiers");
        return r;
    }

    memory_region_transaction_begin();

    for (i = 0; i < hdev->nvqs; ++i) {
        r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus),
                                         hdev->vq_index + i,
                                         true);
        if (r < 0) {
            error_report("vhost VQ %d notifier binding failed: %d",
                         i, -r);
            while (--i >= 0) {
                e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus),
                                                 hdev->vq_index + i,
                                                 false);
                if (e < 0) {
                    error_report(
                               "vhost VQ %d notifier cleanup error: %d",
                                 i, -r);
                }
                assert (e >= 0);
                virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus),
                                                 hdev->vq_index + i);
            }
            virtio_device_release_ioeventfd(vdev);
            break;
        }
    }

    memory_region_transaction_commit();

    return r;
}

What do you think?

Regards,

Phil.

#3 lore raw

Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction

Quoted 120 lines · Philippe Mathieu-Daudé
Quoted 72 lines · Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost device to batch the setup of all its host notifiers. This significantly reduces the device starting time, e.g. the time spend on enabling notifiers reduce from 376ms to 9.1ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device)

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
  hw/virtio/vhost.c | 40 ++++++++++++++++++++++++++++++++++++++--

  1 file changed, 38 insertions(+), 2 deletions(-)
hw/virtio/vhost.c +9 -1
index 7fb008bc9e..16f8391d86 100644
@@ -1507,7 +1507,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)
   int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
   {
       BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
-    int i, r, e;
+    int i, n, r, e;
       /* We will pass the notifiers to the kernel, make sure that QEMU
        * doesn't interfere.
@@ -1518,6 +1518,12 @@ int vhost_dev_enable_notifiers(struct vhost_dev 
 *hdev, VirtIODevice *vdev)
           goto fail;
       }
+    /*
+     * Batch all the host notifiers in a single transaction to avoid
+     * quadratic time complexity in address_space_update_ioeventfds().
+     */
+    memory_region_transaction_begin();
+
       for (i = 0; i < hdev->nvqs; ++i) {
           r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                            true);
@@ -1527,8 +1533,12 @@ int vhost_dev_enable_notifiers(struct vhost_dev 
 *hdev, VirtIODevice *vdev)
           }
       }
+    memory_region_transaction_commit();
+
       return 0;

  fail_vq:
+    /* save i for a second iteration after transaction is committed. */ +    n = i;
      while (--i >= 0) {
          e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, false);

hw/virtio/vhost.c +11 -1
@@ -1536,8 +1546,18 @@ fail_vq:
               error_report("vhost VQ %d notifier cleanup error: %d", i, -r);
           }
           assert (e >= 0);
-        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), 
 hdev->vq_index + i);
       }
+
+    /*
+     * The transaction expects the ioeventfds to be open when it
+     * commits. Do it now, before the cleanup loop.
+     */
+    memory_region_transaction_commit();
+
+    while (--n >= 0) {
+        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), 
 hdev->vq_index + n);
+    }
+
       virtio_device_release_ioeventfd(vdev);
Quoted 2 lines

  fail:
      return r;

Similarly to patch #2, removing both goto statement in this function (as a preliminary patch) will 1/ simplify the code 2/ simplify reviewing your changes, resulting in something like:

int vhost_dev_enable_notifiers(struct vhost_dev *hdev,
                               VirtIODevice *vdev)
{
    BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev))); int i, r, e;

    /* We will pass the notifiers to the kernel, make sure that QEMU
     * doesn't interfere.
     */
    r = virtio_device_grab_ioeventfd(vdev);
    if (r < 0) {
        error_report("binding does not support host notifiers"); return r;
    }

    memory_region_transaction_begin();

    for (i = 0; i < hdev->nvqs; ++i) {
        r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, true);
        if (r < 0) {
            error_report("vhost VQ %d notifier binding failed: %d", i, -r);
            while (--i >= 0) {
                e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, false);
                if (e < 0) {
                    error_report(
                               "vhost VQ %d notifier cleanup error: %d", i, -r);
                }
                assert (e >= 0); virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i); }
            virtio_device_release_ioeventfd(vdev);
            break;
        }
    }

Quoted 7 lines

    memory_region_transaction_commit();

    return r;
}

What do you think?

Maybe we can use vhost_dev_disable_notifiers to further simplify the error path ?

And we must commit before invoking virtio_bus_cleanup_host_notifier.

Quoted 4 lines

Regards,

Phil.
.

#4 lore raw

Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction

Quoted 123 lines · Cloud Infrastructure Service Product Dept.)
Quoted 120 lines · Philippe Mathieu-Daudé
Quoted 72 lines · Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost device to batch the setup of all its host notifiers. This significantly reduces the device starting time, e.g. the time spend on enabling notifiers reduce from 376ms to 9.1ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device)

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
  hw/virtio/vhost.c | 40 ++++++++++++++++++++++++++++++++++++++--

  1 file changed, 38 insertions(+), 2 deletions(-)
hw/virtio/vhost.c +9 -1
index 7fb008bc9e..16f8391d86 100644
@@ -1507,7 +1507,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)
   int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
   {
       BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
-    int i, r, e;
+    int i, n, r, e;
       /* We will pass the notifiers to the kernel, make sure that QEMU
        * doesn't interfere.
@@ -1518,6 +1518,12 @@ int vhost_dev_enable_notifiers(struct 
 vhost_dev *hdev, VirtIODevice *vdev)
           goto fail;
       }
+    /*
+     * Batch all the host notifiers in a single transaction to avoid
+     * quadratic time complexity in address_space_update_ioeventfds().
+     */
+    memory_region_transaction_begin();
+
       for (i = 0; i < hdev->nvqs; ++i) {
           r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                            true);
@@ -1527,8 +1533,12 @@ int vhost_dev_enable_notifiers(struct 
 vhost_dev *hdev, VirtIODevice *vdev)
           }
       }
+    memory_region_transaction_commit();
+
       return 0;

  fail_vq:
+    /* save i for a second iteration after transaction is committed. */ +    n = i;
      while (--i >= 0) {
          e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, false);

hw/virtio/vhost.c +11 -1
@@ -1536,8 +1546,18 @@ fail_vq:
               error_report("vhost VQ %d notifier cleanup error: %d", i, -r);
           }
           assert (e >= 0);
-        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), 
 hdev->vq_index + i);
       }
+
+    /*
+     * The transaction expects the ioeventfds to be open when it
+     * commits. Do it now, before the cleanup loop.
+     */
+    memory_region_transaction_commit();
+
+    while (--n >= 0) {
+        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), 
 hdev->vq_index + n);
+    }
+
       virtio_device_release_ioeventfd(vdev);
Quoted 2 lines

  fail:
      return r;

Similarly to patch #2, removing both goto statement in this function (as a preliminary patch) will 1/ simplify the code 2/ simplify reviewing your changes, resulting in something like:

int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev) {
     BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev))); int i, r, e;

     /* We will pass the notifiers to the kernel, make sure that QEMU
      * doesn't interfere.
      */
     r = virtio_device_grab_ioeventfd(vdev);
     if (r < 0) {
         error_report("binding does not support host notifiers"); return r;
     }

     memory_region_transaction_begin();

     for (i = 0; i < hdev->nvqs; ++i) {
         r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, true);
         if (r < 0) {
             error_report("vhost VQ %d notifier binding failed: %d", i, -r);
             while (--i >= 0) {
                 e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, false);
                 if (e < 0) {
                     error_report(
                                "vhost VQ %d notifier cleanup error: %d", i, -r);
                 }
                 assert (e >= 0); virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i); }
             virtio_device_release_ioeventfd(vdev);
             break;
         }
     }

Quoted 8 lines
Quoted 7 lines

     memory_region_transaction_commit();

     return r;
}

What do you think?

Maybe we can use vhost_dev_disable_notifiers to further simplify the error path ?

Good idea, but having the BusState resolved on each call seems a waste. Eventually factor it out and pass as argument ...

Quoted 1 line

And we must commit before invoking virtio_bus_cleanup_host_notifier.

... but with that info on top, finally your original patch is simpler.

#5 lore raw

Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction

Quoted 132 lines · Philippe Mathieu-Daudé
Quoted 131 lines · Cloud Infrastructure Service Product Dept.)
Quoted 128 lines · Philippe Mathieu-Daudé
Quoted 73 lines · Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost device to batch the setup of all its host notifiers. This significantly reduces the device starting time, e.g. the time spend on enabling notifiers reduce from 376ms to 9.1ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device)

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
  hw/virtio/vhost.c | 40 ++++++++++++++++++++++++++++++++++++++--

  1 file changed, 38 insertions(+), 2 deletions(-)
hw/virtio/vhost.c +9 -1
index 7fb008bc9e..16f8391d86 100644
@@ -1507,7 +1507,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)
   int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev)
   {
       BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev)));
-    int i, r, e;
+    int i, n, r, e;
       /* We will pass the notifiers to the kernel, make sure that QEMU
        * doesn't interfere.
@@ -1518,6 +1518,12 @@ int vhost_dev_enable_notifiers(struct 
 vhost_dev *hdev, VirtIODevice *vdev)
           goto fail;
       }
+    /*
+     * Batch all the host notifiers in a single transaction to avoid
+     * quadratic time complexity in address_space_update_ioeventfds().
+     */
+    memory_region_transaction_begin();
+
       for (i = 0; i < hdev->nvqs; ++i) {
           r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i,
                                            true);
@@ -1527,8 +1533,12 @@ int vhost_dev_enable_notifiers(struct 
 vhost_dev *hdev, VirtIODevice *vdev)
           }
       }
+    memory_region_transaction_commit();
+
       return 0;

  fail_vq:
+    /* save i for a second iteration after transaction is committed. */
+    n = i;
      while (--i >= 0) {
          e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, false);

hw/virtio/vhost.c +11 -1
@@ -1536,8 +1546,18 @@ fail_vq:
               error_report("vhost VQ %d notifier cleanup error: %d", i, -r);
           }
           assert (e >= 0);
-        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), 
 hdev->vq_index + i);
       }
+
+    /*
+     * The transaction expects the ioeventfds to be open when it
+     * commits. Do it now, before the cleanup loop.
+     */
+    memory_region_transaction_commit();
+
+    while (--n >= 0) {
+        virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), 
 hdev->vq_index + n);
+    }
+
       virtio_device_release_ioeventfd(vdev);
Quoted 2 lines

  fail:
      return r;

Similarly to patch #2, removing both goto statement in this function (as a preliminary patch) will 1/ simplify the code 2/ simplify reviewing your changes, resulting in something like:

int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev) {
     BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(vdev))); int i, r, e;

     /* We will pass the notifiers to the kernel, make sure that QEMU
      * doesn't interfere.
      */
     r = virtio_device_grab_ioeventfd(vdev);
     if (r < 0) {
         error_report("binding does not support host notifiers"); return r;
     }

     memory_region_transaction_begin();

     for (i = 0; i < hdev->nvqs; ++i) {
         r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, true);
         if (r < 0) {
             error_report("vhost VQ %d notifier binding failed: %d", i, -r);
             while (--i >= 0) {
                 e = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i, false);
                 if (e < 0) {
                     error_report(
                                "vhost VQ %d notifier cleanup error: %d", i, -r);
                 }
                 assert (e >= 0); virtio_bus_cleanup_host_notifier(VIRTIO_BUS(qbus), hdev->vq_index + i); }
             virtio_device_release_ioeventfd(vdev);
             break;
         }
     }

     memory_region_transaction_commit();

     return r;
}

What do you think?

Quoted 8 lines
Quoted 1 line

Maybe we can use vhost_dev_disable_notifiers to further simplify the error path ?

Good idea, but having the BusState resolved on each call seems a waste. Eventually factor it out and pass as argument ...

Quoted 1 line

And we must commit before invoking virtio_bus_cleanup_host_notifier.

... but with that info on top, finally your original patch is simpler.

Yes, I'll try in next version, thanks.

Quoted 1 line

.

#6 lore raw

Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction

Quoted 5 lines · Cloud Infrastructure Service Product Dept.)
Quoted 3 lines
Quoted 1 line

And we must commit before invoking virtio_bus_cleanup_host_notifier.

... but with that info on top, finally your original patch is simpler.

Yes, I'll try in next version, thanks.

OK so I'm waiting for v3.

#7 lore raw

PATCH v2 2/2 vdpa: commit all host notifier MRs in a single MR transaction

In reply to Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost-vdpa device to batch the setup of all its MRs of host notifiers.

This significantly reduces the device starting time, e.g. the time spend on setup the host notifier MRs reduce from 423ms to 32ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device).

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
 hw/virtio/vhost-vdpa.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
hw/virtio/vhost-vdpa.c +18 -0
index 7468e44b87..eb233cf08a 100644
@@ -547,9 +547,18 @@ static void vhost_vdpa_host_notifiers_uninit(struct vhost_dev *dev, int n)
 {
     int i;
 
+    /*
+     * Pack all the changes to the memory regions in a single
+     * transaction to avoid a few updating of the address space
+     * topology.
+     */
+    memory_region_transaction_begin();
+
     for (i = dev->vq_index; i < dev->vq_index + n; i++) {
         vhost_vdpa_host_notifier_uninit(dev, i);
     }
+
+    memory_region_transaction_commit();
 }
 
 static void vhost_vdpa_host_notifiers_init(struct vhost_dev *dev)
@@ -562,16 +571,25 @@ static void vhost_vdpa_host_notifiers_init(struct vhost_dev *dev)
         return;
     }
 
+    /*
+     * Pack all the changes to the memory regions in a single
+     * transaction to avoid a few updating of the address space
+     * topology.
+     */
+    memory_region_transaction_begin();
+
     for (i = dev->vq_index; i < dev->vq_index + dev->nvqs; i++) {
         if (vhost_vdpa_host_notifier_init(dev, i)) {
             goto err;
         }
     }
 
+    memory_region_transaction_commit();
     return;
 
 err:
     vhost_vdpa_host_notifiers_uninit(dev, i - dev->vq_index);
+    memory_region_transaction_commit();
     return;
 }
 
Signature · 1 line
2.23.0
#8 lore raw

Re: [PATCH v2 2/2] vdpa: commit all host notifier MRs in a single MR transaction

Quoted 21 lines · Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost-vdpa device to batch the setup of all its MRs of host notifiers.

This significantly reduces the device starting time, e.g. the time spend on setup the host notifier MRs reduce from 423ms to 32ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device).

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
  hw/virtio/vhost-vdpa.c | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)
hw/virtio/vhost-vdpa.c +0 -0
@@ -562,16 +571,25 @@ static void vhost_vdpa_host_notifiers_init(struct vhost_dev *dev)
          return;
      }
 

hw/virtio/vhost-vdpa.c static void vhost_vdpa_host_notifiers_init(struct vhost_dev *dev) · line 583

Quoted 10 lines
hw/virtio/vhost-vdpa.c +7 -0
+    /*
+     * Pack all the changes to the memory regions in a single
+     * transaction to avoid a few updating of the address space
+     * topology.
+     */
+    memory_region_transaction_begin();
+
      for (i = dev->vq_index; i < dev->vq_index + dev->nvqs; i++) {
          if (vhost_vdpa_host_notifier_init(dev, i)) {
              goto err;

Could we simplify by replacing this goto statement with:

               vhost_vdpa_host_notifiers_uninit(dev, i - dev->vq_index);
               break;

?

Quoted 12 lines
hw/virtio/vhost-vdpa.c +2 -0
          }
      }
 
+    memory_region_transaction_commit();
      return;
 
  err:
      vhost_vdpa_host_notifiers_uninit(dev, i - dev->vq_index);
+    memory_region_transaction_commit();
      return;
  }
 
#9 lore raw

Re: [PATCH v2 2/2] vdpa: commit all host notifier MRs in a single MR transaction

Quoted 35 lines · Philippe Mathieu-Daudé
Quoted 21 lines · Longpeng(Mike) via

From: Longpeng <[email protected]>

This allows the vhost-vdpa device to batch the setup of all its MRs of host notifiers.

This significantly reduces the device starting time, e.g. the time spend on setup the host notifier MRs reduce from 423ms to 32ms for a VM with 64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device).

[1] https://www.mail-archive.com/[email protected]/msg921541.html

---
  hw/virtio/vhost-vdpa.c | 18 ++++++++++++++++++

  1 file changed, 18 insertions(+)
hw/virtio/vhost-vdpa.c +0 -0
@@ -562,16 +571,25 @@ static void 
 vhost_vdpa_host_notifiers_init(struct vhost_dev *dev)
           return;
       }

hw/virtio/vhost-vdpa.c static void · line 583

Quoted 10 lines
hw/virtio/vhost-vdpa.c +7 -0
+    /*
+     * Pack all the changes to the memory regions in a single
+     * transaction to avoid a few updating of the address space
+     * topology.
+     */
+    memory_region_transaction_begin();
+
       for (i = dev->vq_index; i < dev->vq_index + dev->nvqs; i++) {
           if (vhost_vdpa_host_notifier_init(dev, i)) {
               goto err;

Could we simplify by replacing this goto statement with:

Quoted 5 lines

               vhost_vdpa_host_notifiers_uninit(dev, i - dev->vq_index); break;

?

Good suggestion! I'll do in v3, thanks.

Quoted 11 lines
Quoted 9 lines
hw/virtio/vhost-vdpa.c +1 -0
           }
       }
+    memory_region_transaction_commit();
       return;

  err:
      vhost_vdpa_host_notifiers_uninit(dev, i - dev->vq_index); +    memory_region_transaction_commit();
      return;
  }

.