Skip to contentSkip to conversation

net: phy: remove checks for unused eee-broken flags

PATCH In review Heiner Kallweit 4 participants 9 messages Apr 15, 2025 – Apr 29, 2025

Subsystems (4)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

cover net: phy: remove checks for unused eee-broken flags

These flags have never had a user, so remove support for them.

Heiner Kallweit (2):
dt-bindings: net: ethernet-phy: remove eee-broken flags which have
never had a user
net: phy: remove checks for unused eee-broken flags

 .../devicetree/bindings/net/ethernet-phy.yaml | 24 -------------------
 drivers/net/phy/phy-core.c                    |  8 -------
 2 files changed, 32 deletions(-)
Signature · 1 line
2.49.0
author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

These flags have never had a user, so remove support for them.

---
 .../devicetree/bindings/net/ethernet-phy.yaml | 24 -------------------
 1 file changed, 24 deletions(-)
Documentation/devicetree/bindings/net/ethernet-phy.yaml +0 -24
index 824bbe433..962bc62e3 100644
@@ -134,30 +134,6 @@ properties:
       Mark the corresponding energy efficient ethernet mode as
       broken and request the ethernet to stop advertising it.
 
-  eee-broken-10gt:
-    $ref: /schemas/types.yaml#/definitions/flag
-    description:
-      Mark the corresponding energy efficient ethernet mode as
-      broken and request the ethernet to stop advertising it.
-
-  eee-broken-1000kx:
-    $ref: /schemas/types.yaml#/definitions/flag
-    description:
-      Mark the corresponding energy efficient ethernet mode as
-      broken and request the ethernet to stop advertising it.
-
-  eee-broken-10gkx4:
-    $ref: /schemas/types.yaml#/definitions/flag
-    description:
-      Mark the corresponding energy efficient ethernet mode as
-      broken and request the ethernet to stop advertising it.
-
-  eee-broken-10gkr:
-    $ref: /schemas/types.yaml#/definitions/flag
-    description:
-      Mark the corresponding energy efficient ethernet mode as
-      broken and request the ethernet to stop advertising it.
-
   timing-role:
     $ref: /schemas/types.yaml#/definitions/string
     enum:
Signature · 1 line
2.49.0
maintainer
#2 lore raw

Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

Quoted 1 line · Heiner Kallweit

These flags have never had a user, so remove support for them.

They have never been used, but they are a logical description of the bits in the EEE registers. Do we think vendors have gotten better with EEE and are less likely to get it wrong at these higher speeds? Are we deleting them to just bring them back later? I don't know.

I don't think there is any maintenance burden from them, so i would just leave them?

Andrew

author maintainer
#3 lore raw

Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

Quoted 8 lines · Andrew Lunn
Quoted 1 line · Heiner Kallweit

These flags have never had a user, so remove support for them.

They have never been used, but they are a logical description of the bits in the EEE registers. Do we think vendors have gotten better with EEE and are less likely to get it wrong at these higher speeds? Are we deleting them to just bring them back later? I don't know.

These modes are not new, and I would expect that if there would be PHY EEE issues, we should know meanwhile.

Even for 100BaseT/1000BaseT most eee-broken DT flags exist as a workaround because the MAC doesn't support EEE. It's not that EEE in the respective PHY's would be broken.

Quoted 3 lines

I don't think there is any maintenance burden from them, so i would just leave them?

I don't have a strong opinion here. If consensus is that we better leave this code in, then fine with me.

Quoted 1 line

Andrew

Heiner

#4 lore raw

Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

In reply to Heiner Kallweit
Quoted 1 line · Heiner Kallweit

These flags have never had a user, so remove support for them.

They have no in-kernel user, but what about all out of tree users in kernel and other projects using bindings?

Best regards,
Krzysztof

author maintainer
#5 lore raw

Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

Quoted 6 lines · Krzysztof Kozlowski
Quoted 1 line · Heiner Kallweit

These flags have never had a user, so remove support for them.

They have no in-kernel user, but what about all out of tree users in kernel and other projects using bindings?

I doubt there's any user outside the kernel. But it's hard to prove that something does not exist. For my understanding:
What would be the needed proof to consider removal of these flag bindings safe?

Quoted 3 lines

Best regards,
Krzysztof

Heiner

#6 lore raw

Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

Quoted 11 lines · Heiner Kallweit
Quoted 6 lines · Krzysztof Kozlowski
Quoted 1 line · Heiner Kallweit

These flags have never had a user, so remove support for them.

They have no in-kernel user, but what about all out of tree users in kernel and other projects using bindings?

I doubt there's any user outside the kernel. But it's hard to prove that something does not exist. For my understanding:
What would be the needed proof to consider removal of these flag bindings safe?

Open source projects you can check at least.

Best regards,
Krzysztof

maintainer
#7 lore raw

Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

In reply to Heiner Kallweit
Quoted 5 lines · Heiner Kallweit
Quoted 3 lines · Krzysztof Kozlowski
Quoted 1 line · Heiner Kallweit

These flags have never had a user, so remove support for them.

Quoted 7 lines
Quoted 3 lines

They have no in-kernel user, but what about all out of tree users in kernel and other projects using bindings?

I doubt there's any user outside the kernel. But it's hard to prove that something does not exist. For my understanding:
What would be the needed proof to consider removal of these flag bindings safe?

Like you say, you can't prove it. So your justification in the commit msg isn't fact. I think if there was some pain to keep them, then removing them and seeing if anyone complains would be fine.

It's not clear to me here why "eee-broken-1000t" is still valid/useful when the others are not.

Rob

author maintainer
#8 lore raw

PATCH 2/2 net: phy: remove checks for unused eee-broken flags

In reply to Heiner Kallweit

These flags have never had a user, so remove support for them.

---
 drivers/net/phy/phy-core.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/net/phy/phy-core.c +0 -8
index e177037f9..2a443d029 100644
@@ -209,14 +209,6 @@ void of_set_phy_eee_broken(struct phy_device *phydev)
 		linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, modes);
 	if (of_property_read_bool(node, "eee-broken-1000t"))
 		linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, modes);
-	if (of_property_read_bool(node, "eee-broken-10gt"))
-		linkmode_set_bit(ETHTOOL_LINK_MODE_10000baseT_Full_BIT, modes);
-	if (of_property_read_bool(node, "eee-broken-1000kx"))
-		linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT, modes);
-	if (of_property_read_bool(node, "eee-broken-10gkx4"))
-		linkmode_set_bit(ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT, modes);
-	if (of_property_read_bool(node, "eee-broken-10gkr"))
-		linkmode_set_bit(ETHTOOL_LINK_MODE_10000baseKR_Full_BIT, modes);
 }
 
 /**
Signature · 1 line
2.49.0