driver: uio: fix possible memory leak in uio_open
PATCH v3 1/1 driver: uio: fix possible memory leak in uio_open
---v1->v2:
rename the "err_infoopen" to "err_idev_info"
v2->3:
put the extra info after the "--"
drivers/uio/uio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/uio/uio.c +4 -3
@@ -496,18 +496,19 @@ static int uio_open(struct inode *inode, struct file *filep)if (!idev->info) {mutex_unlock (&idev->info_lock); ret = -EINVAL ; - goto err_alloc_listener; + goto err_idev_info; }if (idev->info && idev->info->open) ret = idev->info->open (idev->info, inode);mutex_unlock (&idev->info_lock);if (ret) - goto err_infoopen; + goto err_idev_info;return 0 ; -err_infoopen: +err_idev_info: + filep->private_data =NULL ;kfree (listener); err_alloc_listener:
Signature · 1 line
2.7.4
Quoted 7 lines · liujian
Fixes 57c5f4df0a5a ("uio: fix crash after the device is unregistered")Signed-off-by liujian <[email protected]>---
v1->v2:
rename the "err_infoopen" to "err_idev_info"
v2->3:
put the extra info after the "--"
Looks good to me.
Thanks.
BRs
Quoted 30 lines
drivers/uio/uio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/uio/uio.c +4
-3@@ -496,18 +496,19 @@ static int uio_open(struct inode *inode, struct file *filep)if (!idev->info) {mutex_unlock (&idev->info_lock); ret = -EINVAL ; - goto err_alloc_listener; + goto err_idev_info; }if (idev->info && idev->info->open) ret = idev->info->open (idev->info, inode);mutex_unlock (&idev->info_lock);if (ret) - goto err_infoopen; + goto err_idev_info;return 0 ; -err_infoopen: +err_idev_info: + filep->private_data =NULL ;kfree (listener); err_alloc_listener:
Greg KH
maintainerQuoted 2 lines · liujian
Fixes 57c5f4df0a5a ("uio: fix crash after the device is unregistered")Signed-off-by liujian <[email protected]>
I can not take patches without any changelog text at all :(
Also, is "liujian" your full name? We need a real and full name for a signed-off-by line.
thanks,
greg k-h
Quoted 10 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Tuesday, January 08, 2019 12:14 AM
To: liujian (CE) <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH v3] driver: uio: fix possible memory leak inuio_open
Quoted 7 lines
Quoted 3 lines · liujian
Fixes 57c5f4df0a5a ("uio: fix crash after the device isunregistered")
Signed-off-by liujian <[email protected]>I can not take patches without any changelog text at all :(
I am sorry, I will resend the patch~
Quoted 3 lines
Also, is "liujian" your full name? We need a real and full name for a signed-off-by line.
Yes, but as someone do, I may need change 'liujian' to 'Liu Jian' Thanks
Quoted 3 lines
thanks,
greg k-h