Skip to contentSkip to conversation

hwmon: nct6683 Add support for ASRock Z890 Pro-A

PATCH In review Reiner Pröls 2 participants 4 messages May 20 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: nct6683 Add support for ASRock Z890 Pro-A

From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Prö[email protected]>
Date: Wed, 20 May 2026 20:59:57 +0200
Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 drivers/hwmon/nct6683.c | 5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/hwmon/nct6683.c +0 -0
index 0581770380cc..1b9092f48c7d 100644
@@ -177,12 +177,13 @@ superio_exit(int ioreg)

 #define NCT6683_CUSTOMER_ID_MSI3    0x207
 #define NCT6683_CUSTOMER_ID_MSI4    0x20d
 #define NCT6683_CUSTOMER_ID_AMD        0x162b -#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c +#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631 #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621 #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633 +#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A

 #define NCT6683_REG_BUILD_YEAR        0x604
 #define NCT6683_REG_BUILD_MONTH        0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev) break;
     case NCT6683_CUSTOMER_ID_ASROCK6:
         break;
+    case NCT6683_CUSTOMER_ID_ASROCK7:
+        break;
     default:
         if (!force)
             return -ENODEV;

Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 4 lines · Reiner Pröls

From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Prö[email protected]>
Date: Wed, 20 May 2026 20:59:57 +0200
Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard

Subject should be
"hwmon: (nct6683) Add support for ASRock Z890 Pro-A"
or similar. Actually, your outer subject comes close.

Quoted 4 lines

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Description goes here. Look into the driver log for examples.

Also, it looks like you embedded your patch in another patch with a different subject. That probably triggers:

WARNING: From:/Signed-off-by: email address mismatch: 'From: "Reiner Pröls" <Reiner.Prö[email protected]>' != 'Signed-off-by: Reiner Pröls <Reiner.Prö[email protected]>'

Also, when I try to apply the patch, I get "patch is empty".

Please fix this up.

Quoted 11 lines

---
 drivers/hwmon/nct6683.c | 5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/hwmon/nct6683.c +0 -0
index 0581770380cc..1b9092f48c7d 100644
@@ -177,12 +177,13 @@ superio_exit(int ioreg)
  #define NCT6683_CUSTOMER_ID_MSI3    0x207

drivers/hwmon/nct6683.c superio_exit(int ioreg) · line 186

Quoted 10 lines
drivers/hwmon/nct6683.c +2 -1
  #define NCT6683_CUSTOMER_ID_MSI4    0x20d
  #define NCT6683_CUSTOMER_ID_AMD        0x162b
-#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c
+#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c
  #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b
  #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631
  #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e
  #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621
  #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633
+#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A

No C++ comments in this file, please.

Quoted 9 lines
drivers/hwmon/nct6683.c +0 -0
  #define NCT6683_REG_BUILD_YEAR        0x604
  #define NCT6683_REG_BUILD_MONTH        0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
          break;

     case NCT6683_CUSTOMER_ID_ASROCK6:
         break;
+    case NCT6683_CUSTOMER_ID_ASROCK7:
+        break;

Was this cut-and-paste ? There are no tabs, just spaces, meaning the patch would not apply. That would also explain the duplicated headers.

Guenter

Quoted 7 lines

     default:
         if (!force)
             return -ENODEV;

Signature · 1 line
2.43.0
#2 lore raw

Here the patch as attatchment

Am 20.05.26 um 21:54 schrieb Guenter Roeck:

Quoted 58 lines · Reiner Pröls
Quoted 4 lines

From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Prö[email protected]>
Date: Wed, 20 May 2026 20:59:57 +0200
Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard

Subject should be
"hwmon: (nct6683) Add support for ASRock Z890 Pro-A"
or similar. Actually, your outer subject comes close.

Quoted 4 lines

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Description goes here. Look into the driver log for examples.

Also, it looks like you embedded your patch in another patch with a different subject. That probably triggers:

WARNING: From:/Signed-off-by: email address mismatch: 'From: "Reiner Pröls" <Reiner.Prö[email protected]>' != 'Signed-off-by: Reiner Pröls <Reiner.Prö[email protected]>'

Also, when I try to apply the patch, I get "patch is empty".

Please fix this up.

Quoted 11 lines
---
  drivers/hwmon/nct6683.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
drivers/hwmon/nct6683.c +0 -0
index 0581770380cc..1b9092f48c7d 100644
@@ -177,12 +177,13 @@ superio_exit(int ioreg)
  #define NCT6683_CUSTOMER_ID_MSI3    0x207

drivers/hwmon/nct6683.c superio_exit(int ioreg) · line 186

Quoted 10 lines
drivers/hwmon/nct6683.c +2 -1
  #define NCT6683_CUSTOMER_ID_MSI4    0x20d
  #define NCT6683_CUSTOMER_ID_AMD        0x162b
-#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c
+#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c
  #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b
  #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631
  #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e
  #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621
  #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633
+#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A

No C++ comments in this file, please.

drivers/hwmon/nct6683.c static int nct6683_probe(struct platform_device *pdev) · line 1253

Quoted 8 lines
drivers/hwmon/nct6683.c +2 -0
  #define NCT6683_REG_BUILD_YEAR        0x604
  #define NCT6683_REG_BUILD_MONTH        0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
          break;
      case NCT6683_CUSTOMER_ID_ASROCK6:
          break;
+    case NCT6683_CUSTOMER_ID_ASROCK7:
+        break;

Was this cut-and-paste ? There are no tabs, just spaces, meaning the patch would not apply. That would also explain the duplicated headers.

Quoted 9 lines

Guenter

Quoted 7 lines
drivers/hwmon/nct6683.c +0 -0
      default:
          if (!force)
              return -ENODEV;
Signature · 1 line
2.43.0

From 6d88f02e770fd1965a14f975c3a173feeed9e1ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Prö[email protected]>
Date: Wed, 20 May 2026 22:44:45 +0200
Subject: [PATCH] hwmon: Added support for ASRock Z890 Pro-A
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 drivers/hwmon/nct6683.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/hwmon/nct6683.c +4 -1
index 0581770380cc..37405329ba78 100644
@@ -177,12 +177,13 @@ superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_MSI3	0x207
 #define NCT6683_CUSTOMER_ID_MSI4	0x20d
 #define NCT6683_CUSTOMER_ID_AMD		0x162b
-#define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
+#define NCT6683_CUSTOMER_ID_ASROCK	0xe2c
 #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
 #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
 #define NCT6683_CUSTOMER_ID_ASROCK4	0x163e
 #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
 #define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
+#define NCT6683_CUSTOMER_ID_ASROCK7	0x163d 
 
 #define NCT6683_REG_BUILD_YEAR		0x604
 #define NCT6683_REG_BUILD_MONTH		0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK6:
 		break;
+	case NCT6683_CUSTOMER_ID_ASROCK7:
+		break;
 	default:
 		if (!force)
 			return -ENODEV;
Signature · 1 line
2.43.0
maintainer
#3 lore raw
Quoted 2 lines · Reiner Pröls

Here the patch as attatchment

Sending a patch as attachment will cause it to be dropped from the mailing list, the AI review agent wont see it, and I won't even look at it.

Guenter