Skip to contentSkip to conversation

Fix snapshot link in tree view

PATCH In review Petr Baudis 3 participants 4 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix snapshot link in tree view

It would just give HEAD snapshot instead of one of the particular tree.

Perhaps we should also include snapshot in the global navbar? And perhaps stgit should have a way to edit the mail before sending it so that I could note this below the three dashes? ;-)

---

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
gitweb/gitweb.perl +1 -1
index c5f3810..fc31ac3 100755
@@ -2771,7 +2771,7 @@ sub git_tree {
 		if ($have_snapshot) {
 			# FIXME: Should be available when we have no hash base as well.
 			push @views_nav,
-				$cgi->a({-href => href(action=>"snapshot")},
+				$cgi->a({-href => href(action=>"snapshot", hash=>$hash)},
 					"snapshot");
 		}
 		git_print_page_nav('tree','', $hash_base, undef, undef, join(' | ', @views_nav));
#1 lore raw
Quoted 5 lines · Petr Baudis

It would just give HEAD snapshot instead of one of the particular tree.

Perhaps we should also include snapshot in the global navbar? And perhaps stgit should have a way to edit the mail before sending it so that I could note this below the three dashes? ;-)

Personally, I do not mind having the first "Perhaps" in the log message.

Will apply.

#2 lore raw
In reply to Petr Baudis

By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would make this patch easier to read as gitweb patch.

Signature · 3 lines
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
#3 lore raw

Dear diary, on Sat, Sep 23, 2006 at 11:01:15AM CEST, I got a letter where Jakub Narebski <[email protected]> said that...

Quoted 2 lines

By the way, using "[PATCH] gitweb: Fix snapshot link in tree view" would make this patch easier to read as gitweb patch.

Sorry, I try to mark those patches as gitweb but sometimes I forget. :-)

Signature · 5 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)