Skip to contentSkip to conversation

arm64: dts: ti: k3-am65: dtbs_check warnings fixups

PATCH Superseded Nishanth Menon 2 participants 7 messages Jun 6, 2023

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Nishanth Menon

author maintainer
#0 lore raw

v2 cover arm64: dts: ti: k3-am65: dtbs_check warnings fixups

Hi,

Series of minor fixups for AM65x device tree to cleanup some of the dtbs_check warnings.

Changes Since V1:
* Dropped syscon conversion and FSS node rename changes.

V1: https://lore.kernel.org/all/[email protected]/

Nishanth Menon (4):
arm64: dts: ti: k3-am65-main: Fix mux controller node name
arm64: dts: ti: k3-am65-main: Fix mcan node name
arm64: dts: ti: k3-am65-main: Drop deprecated ti,otap-del-sel property
arm64: dts: ti: k3-am65-iot2050-common: Rename rtc8564 nodename

 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi           | 3 +--
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi            | 4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)
Signature · 1 line
2.40.0
author maintainer
#1 lore raw

PATCH v2 1/4 arm64: dts: ti: k3-am65-main: Fix mux controller node name

Add unit address to form a proper node name.

---
No change since V1
V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
index 1adba2f2c153..f64b4e782ec3 100644
@@ -506,7 +506,7 @@ serdes1_clk: clock@4090 {
 			reg = <0x00004090 0x4>;
 		};
 
-		serdes_mux: mux-controller {
+		serdes_mux: mux-controller@4080 {
 			compatible = "mmio-mux";
 			#mux-control-cells = <1>;
 			mux-reg-masks = <0x4080 0x3>, /* SERDES0 lane select */
Signature · 1 line
2.40.0
#2 lore raw

Re: [PATCH V2 1/4] arm64: dts: ti: k3-am65-main: Fix mux controller node name

Quoted 2 lines · Nishanth Menon

Add unit address to form a proper node name.

This is only needed when the node has a reg property, which we have not added yet to this node. This patch instead adds a warning:

Quoted 1 line

node has a unit name, but no reg or ranges property

Andrew

Quoted 21 lines

---
No change since V1
V1: https://lore.kernel.org/r/[email protected]

  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
index 1adba2f2c153..f64b4e782ec3 100644
@@ -506,7 +506,7 @@ serdes1_clk: clock@4090 {
  			reg = <0x00004090 0x4>;
  		};
 
-		serdes_mux: mux-controller {
+		serdes_mux: mux-controller@4080 {
  			compatible = "mmio-mux";
  			#mux-control-cells = <1>;
  			mux-reg-masks = <0x4080 0x3>, /* SERDES0 lane select */
author maintainer
#3 lore raw

Re: [PATCH V2 1/4] arm64: dts: ti: k3-am65-main: Fix mux controller node name

Quoted 9 lines · Andrew Davis
Quoted 2 lines · Nishanth Menon

Add unit address to form a proper node name.

This is only needed when the node has a reg property, which we have not added yet to this node. This patch instead adds a warning:

Quoted 1 line

node has a unit name, but no reg or ranges property

/me bangs head.. I missed it. Thanks for catching it. Will drop this patch from the series. will wait till tomorrow in case of any additional comments.

Signature · 8 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#4 lore raw

PATCH v2 2/4 arm64: dts: ti: k3-am65-main: Fix mcan node name

In reply to Nishanth Menon

s/mcan/can to stay in sync with bindings conventions.

---

No change since V1
V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 5dfa31840e9c..c2519d4607a5 100644
@@ -227,7 +227,7 @@ mcu_udmap: dma-controller@285c0000 {
 		};
 	};
 
-	m_can0: mcan@40528000 {
+	m_can0: can@40528000 {
 		compatible = "bosch,m_can";
 		reg = <0x0 0x40528000 0x0 0x400>,
 		      <0x0 0x40500000 0x0 0x4400>;
@@ -243,7 +243,7 @@ m_can0: mcan@40528000 {
 		status = "disabled";
 	};
 
-	m_can1: mcan@40568000 {
+	m_can1: can@40568000 {
 		compatible = "bosch,m_can";
 		reg = <0x0 0x40568000 0x0 0x400>,
 		      <0x0 0x40540000 0x0 0x4400>;
Signature · 1 line
2.40.0
author maintainer
#5 lore raw

PATCH v2 3/4 arm64: dts: ti: k3-am65-main: Drop deprecated ti,otap-del-sel property

In reply to Nishanth Menon

ti,otap-del-sel has been deprecated in favor of ti,otap-del-sel-legacy.

Drop the duplicate and misleading ti,otap-del-sel property.

---
No change since V1
V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -1
index f64b4e782ec3..c2fe2ada3f0a 100644
@@ -469,7 +469,6 @@ sdhci1: mmc@4fa0000 {
 		ti,otap-del-sel-ddr52 = <0x4>;
 		ti,otap-del-sel-hs200 = <0x7>;
 		ti,clkbuf-sel = <0x7>;
-		ti,otap-del-sel = <0x2>;
 		ti,trm-icp = <0x8>;
 		dma-coherent;
 	};
Signature · 1 line
2.40.0
author maintainer
#6 lore raw

PATCH v2 4/4 arm64: dts: ti: k3-am65-iot2050-common: Rename rtc8564 nodename

In reply to Nishanth Menon

Just use "rtc" as the nodename to better match with the bindings.

---
No change since V1
V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi +1 -1
index 96ac2b476b11..679857ca95ea 100644
@@ -483,7 +483,7 @@ &main_i2c0 {
 	pinctrl-0 = <&main_i2c0_pins_default>;
 	clock-frequency = <400000>;
 
-	rtc: rtc8564@51 {
+	rtc: rtc@51 {
 		compatible = "nxp,pcf8563";
 		reg = <0x51>;
 	};
Signature · 1 line
2.40.0