Skip to contentSkip to conversation

vdpa: mlx5: select VHOST to fix build errors

PATCH In review Randy Dunlap 2 participants 2 messages Sep 17, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vdpa: mlx5: select VHOST to fix build errors

From: Randy Dunlap <[email protected]>

drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select VHOST to eliminate build errors.

ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'

Cc "Michael S. Tsirkin" <[email protected]>
Cc Jason Wang <[email protected]>
Cc Saeed Mahameed <[email protected]>
Cc Leon Romanovsky <[email protected]>

---
Note: This patch may not be the right thing, but it fixes the build errors.

 drivers/vdpa/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/vdpa/Kconfig +1 -0
@@ -32,6 +32,7 @@ config IFCVF
 config MLX5_VDPA
 	bool "MLX5 VDPA support library for ConnectX devices"
 	depends on MLX5_CORE
+	select VHOST
 	default n
 	help
 	  Support library for Mellanox VDPA drivers. Provides code that is

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#1 lore raw
Quoted 38 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

drivers/vdpa/mlx5/ uses vhost_iotlb*() interfaces, so select VHOST to eliminate build errors.

ld: drivers/vdpa/mlx5/core/mr.o: in function `add_direct_chain':
mr.c:(.text+0x106): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x1cf): undefined reference to `vhost_iotlb_itree_next'
ld: mr.c:(.text+0x30d): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x3e8): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `_mlx5_vdpa_create_mr':
mr.c:(.text+0x908): undefined reference to `vhost_iotlb_itree_first'
ld: mr.c:(.text+0x9e6): undefined reference to `vhost_iotlb_itree_next'
ld: drivers/vdpa/mlx5/core/mr.o: in function `mlx5_vdpa_handle_set_map':
mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first'

Cc "Michael S. Tsirkin" <[email protected]>
Cc Jason Wang <[email protected]>
Cc Saeed Mahameed <[email protected]>
Cc Leon Romanovsky <[email protected]>

---
Note: This patch may not be the right thing, but it fixes the build errors.

 drivers/vdpa/Kconfig |    1 +
 1 file changed, 1 insertion(+)

drivers/vdpa/Kconfig config IFCVF · line 35

Quoted 4 lines
drivers/vdpa/Kconfig +1 -0
@@ -32,6 +32,7 @@ config IFCVF
 config MLX5_VDPA
 	bool "MLX5 VDPA support library for ConnectX devices"
 	depends on MLX5_CORE
+	select VHOST

select keyword usually complicates things.
It is better if you add a dependency rather than forcing VHOST. Just do:
depends on VHOST & MLX5_CORE

Quoted 5 lines
drivers/vdpa/Kconfig +0 -0
 	default n
 	help
 	  Support library for Mellanox VDPA drivers. Provides code that

is