Skip to contentSkip to conversation

control applying of no-debug config

PATCH Superseded Hongzhan Chen 3 participants 11 messages Jul 23, 2021 – Jul 26, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover control applying of no-debug config

1. enable IPIPE_DEBUG uniformly for all arch by default in order to use uniform method to control it via applying config fragment or not.
2. create config fragment for earch arch to switch debug off.
3. add control to apply config fragment or not.
4. add kas option to control applying config fragment.

*** BLURB HERE ***

Hongzhan Chen (7):
recipes-kernel: arm64_config: enable IPIPE_DEBUG for arm64 by default
recipes-kernel: armhf_config: enable IPIPE_DEBUG for armhf by default
recipes-kernel: add config fragment file to disable debug for amd64
recipes-kernel: add config fragment file to disable debug for arm64
recipes-kernel: add config fragment file to disable debug for arm recipes-kernel/linux: control appyling of no debug config fragment Add kas option for swithing off debug

 opt-set-nodbg.yml                          | 20 ++++++++++++++++++++
 recipes-kernel/linux/files/amd64_nodbg.cfg |  1 +
 recipes-kernel/linux/files/arm64_defconfig |  9 +++++----
 recipes-kernel/linux/files/arm64_nodbg.cfg |  1 +
 recipes-kernel/linux/files/armhf_defconfig | 15 +++++++++++++--
 recipes-kernel/linux/files/armhf_nodbg.cfg |  1 +
 recipes-kernel/linux/linux-xenomai.inc     | 10 +++++++++-
 7 files changed, 50 insertions(+), 7 deletions(-)
 create mode 100644 opt-set-nodbg.yml
 create mode 100644 recipes-kernel/linux/files/amd64_nodbg.cfg
 create mode 100644 recipes-kernel/linux/files/arm64_nodbg.cfg
 create mode 100644 recipes-kernel/linux/files/armhf_nodbg.cfg
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/7 recipes-kernel: arm64_config: enable IPIPE_DEBUG for arm64 by default

Enable IPIPE_DEBUG for arm64 by default. We enable IPIPE_DEBUG for all arch types uniformly by default in order to controll enabling and disabling them via same method.

---
 recipes-kernel/linux/files/arm64_defconfig | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
recipes-kernel/linux/files/arm64_defconfig +5 -4
index 7634788..a010c30 100644
@@ -191,7 +191,7 @@ CONFIG_KALLSYMS_ALL=y
 CONFIG_KALLSYMS_BASE_RELATIVE=y
 CONFIG_PRINTK=y
 CONFIG_PRINTK_NMI=y
-# CONFIG_RAW_PRINTK is not set
+CONFIG_RAW_PRINTK=y
 CONFIG_BUG=y
 CONFIG_ELF_CORE=y
 CONFIG_BASE_FULL=y
@@ -410,7 +410,6 @@ CONFIG_XENO_OPT_DEBUG_LEGACY=y
 CONFIG_XENO_OPT_DEBUG_TRACE_RELAX=y
 CONFIG_XENO_OPT_WATCHDOG=y
 CONFIG_XENO_OPT_WATCHDOG_TIMEOUT=4
-# CONFIG_XENO_TODO is not set
 
 #
 # Drivers
@@ -449,7 +448,6 @@ CONFIG_XENO_DRIVERS_CAN_BUS_ERR=y
 # CONFIG_XENO_DRIVERS_CAN_CALC_BITTIME_OLD is not set
 CONFIG_XENO_DRIVERS_CAN_VIRT=y
 # CONFIG_XENO_DRIVERS_CAN_FLEXCAN is not set
-# CONFIG_XENO_DRIVERS_CAN_PEAK_CANFD is not set
 CONFIG_XENO_DRIVERS_CAN_SJA1000=y
 CONFIG_XENO_DRIVERS_CAN_SJA1000_ISA=y
 CONFIG_XENO_DRIVERS_CAN_SJA1000_MEM=y
@@ -5907,8 +5905,11 @@ CONFIG_FRAME_POINTER=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE=0x1
 CONFIG_MAGIC_SYSRQ_SERIAL=y
-# CONFIG_IPIPE_DEBUG is not set
+CONFIG_IPIPE_DEBUG=y
+CONFIG_IPIPE_DEBUG_CONTEXT=y
+CONFIG_IPIPE_DEBUG_INTERNAL=y
 CONFIG_HAVE_IPIPE_TRACER_SUPPORT=y
+# CONFIG_IPIPE_TRACE is not set
 CONFIG_DEBUG_KERNEL=y
 
 #
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/7 recipes-kernel: armhf_config: enable IPIPE_DEBUG for armhf by default

In reply to Hongzhan Chen

Enable IPIPE_DEBUG for armhf by default. We enable IPIPE_DEBUG for all arch types uniformly by default in order to controll enabling and disabling them via same method.

---
 recipes-kernel/linux/files/armhf_defconfig | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)
recipes-kernel/linux/files/armhf_defconfig +13 -2
index 3c42582..ef4981d 100644
@@ -162,7 +162,7 @@ CONFIG_KALLSYMS=y
 CONFIG_KALLSYMS_BASE_RELATIVE=y
 CONFIG_PRINTK=y
 CONFIG_PRINTK_NMI=y
-# CONFIG_RAW_PRINTK is not set
+CONFIG_RAW_PRINTK=y
 CONFIG_BUG=y
 CONFIG_ELF_CORE=y
 CONFIG_BASE_FULL=y
@@ -1079,6 +1079,14 @@ CONFIG_IPIPE_CORE_APIREV=2
 CONFIG_IPIPE_WANT_APIREV_2=y
 CONFIG_IPIPE_TARGET_APIREV=2
 CONFIG_IPIPE_HAVE_HOSTRT=y
+
+#
+# CAUTION: DEBUG_LL must be selected, and properly configured for
+#
+
+#
+# RAW_PRINTK to work. Otherwise, you will get no output on raw_printk()
+#
 CONFIG_PREEMPT_NONE=y
 # CONFIG_PREEMPT_VOLUNTARY is not set
 # CONFIG_PREEMPT is not set
@@ -6820,8 +6828,11 @@ CONFIG_SECTION_MISMATCH_WARN_ONLY=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE=0x1
 CONFIG_MAGIC_SYSRQ_SERIAL=y
-# CONFIG_IPIPE_DEBUG is not set
+CONFIG_IPIPE_DEBUG=y
+CONFIG_IPIPE_DEBUG_CONTEXT=y
+CONFIG_IPIPE_DEBUG_INTERNAL=y
 CONFIG_HAVE_IPIPE_TRACER_SUPPORT=y
+# CONFIG_IPIPE_TRACE is not set
 CONFIG_DEBUG_KERNEL=y
 
 #
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/7 recipes-kernel: add config fragment file to disable debug for amd64

In reply to Hongzhan Chen

Add config fragment file to disable debug for amd64. For performance or latency testing and demonstration, debug switches should be off.

---
 recipes-kernel/linux/files/amd64_nodbg.cfg | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-kernel/linux/files/amd64_nodbg.cfg
recipes-kernel/linux/files/amd64_nodbg.cfg new file +1 -0
new file mode 100644
index 0000000..749799d
@@ -0,0 +1 @@
+# CONFIG_IPIPE_DEBUG is not set
Signature · 1 line
2.17.1
#4 lore raw

PATCH 4/7 recipes-kernel: add config fragment file to disable debug for arm64

In reply to Hongzhan Chen

Add config fragment file to disable debug for arm64. For performance or latency testing and demonstration, debug switches should be off.

---
 recipes-kernel/linux/files/arm64_nodbg.cfg | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-kernel/linux/files/arm64_nodbg.cfg
recipes-kernel/linux/files/arm64_nodbg.cfg new file +1 -0
new file mode 100644
index 0000000..749799d
@@ -0,0 +1 @@
+# CONFIG_IPIPE_DEBUG is not set
Signature · 1 line
2.17.1
#5 lore raw

PATCH 5/7 recipes-kernel: add config fragment file to disable debug for arm

In reply to Hongzhan Chen

Add config fragment file to disable debug for arm. For performance or latency testing and demonstration, debug switches should be off.

---
 recipes-kernel/linux/files/armhf_nodbg.cfg | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-kernel/linux/files/armhf_nodbg.cfg
recipes-kernel/linux/files/armhf_nodbg.cfg new file +1 -0
new file mode 100644
index 0000000..749799d
@@ -0,0 +1 @@
+# CONFIG_IPIPE_DEBUG is not set
Signature · 1 line
2.17.1
#6 lore raw

PATCH 6/7 recipes-kernel/linux: control appyling of no debug config fragment

In reply to Hongzhan Chen

For performance or latency testing and demonstration, debug switches should be off but it is on by default.

---
 recipes-kernel/linux/linux-xenomai.inc | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
recipes-kernel/linux/linux-xenomai.inc +9 -1
index 185b60b..98eebf2 100644
@@ -11,9 +11,17 @@
 
 require recipes-kernel/linux/linux-custom.inc
 
+def is_nodbg_support(d):
+    dbg_ver = d.getVar('DISTRO_NODBG') or ''
+    return dbg_ver.startswith('YES') or dbg_ver == 'YES'
+
 KERNEL_DEFCONFIG ?= "${DISTRO_ARCH}_defconfig"
+KERNEL_NODBG_FRAGMENTS ?= "${DISTRO_ARCH}_nodbg.cfg"
+KERNEL_NODBG_FRAGMENTS_append = "${@'' if is_nodbg_support(d) else ';apply=no'}"
 
-SRC_URI += "file://${KERNEL_DEFCONFIG}"
+SRC_URI += "file://${KERNEL_DEFCONFIG} \
+    file://${KERNEL_NODBG_FRAGMENTS} \
+"
 
 DEPENDS += "xenomai-kernel-source"
 KBUILD_DEPENDS += "xenomai-kernel-source"
Signature · 1 line
2.17.1
#7 lore raw

PATCH 7/7 Add kas option for swithing off debug

In reply to Hongzhan Chen

For performance or latency testing and demonstration, debug switches should be off but it is on by default.

---
 opt-set-nodbg.yml | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 opt-set-nodbg.yml
opt-set-nodbg.yml new file +20 -0
new file mode 100644
index 0000000..16a2fec
@@ -0,0 +1,20 @@
+#
+# Xenomai Real-Time System
+#
+# Copyright (C) 2021 Intel Corporation
+#
+# Authors:
+#  Hongzhan Chen <[email protected]>
+#
+# SPDX-License-Identifier: MIT
+#
+
+header:
+  version: 10
+
+# to use kernel config fragments for disabling dbg and
+# improving performance
+
+local_conf_header:
+  distro-nodbg: |
+    DISTRO_NODBG = "YES"
Signature · 1 line
2.17.1
#8 lore raw
In reply to Hongzhan Chen
Quoted 25 lines · Hongzhan Chen via Xenomai

1. enable IPIPE_DEBUG uniformly for all arch by default in order to use uniform method to control it via applying config fragment or not.
2. create config fragment for earch arch to switch debug off.
3. add control to apply config fragment or not.
4. add kas option to control applying config fragment.

*** BLURB HERE ***

Hongzhan Chen (7):
recipes-kernel: arm64_config: enable IPIPE_DEBUG for arm64 by default
recipes-kernel: armhf_config: enable IPIPE_DEBUG for armhf by default
recipes-kernel: add config fragment file to disable debug for amd64
recipes-kernel: add config fragment file to disable debug for arm64
recipes-kernel: add config fragment file to disable debug for arm recipes-kernel/linux: control appyling of no debug config fragment Add kas option for swithing off debug

  opt-set-nodbg.yml                          | 20 ++++++++++++++++++++
  recipes-kernel/linux/files/amd64_nodbg.cfg |  1 +
  recipes-kernel/linux/files/arm64_defconfig |  9 +++++----
  recipes-kernel/linux/files/arm64_nodbg.cfg |  1 +
  recipes-kernel/linux/files/armhf_defconfig | 15 +++++++++++++--
  recipes-kernel/linux/files/armhf_nodbg.cfg |  1 +
  recipes-kernel/linux/linux-xenomai.inc     | 10 +++++++++-
  7 files changed, 50 insertions(+), 7 deletions(-)
Quoted 5 lines

create mode 100644 opt-set-nodbg.yml
create mode 100644 recipes-kernel/linux/files/amd64_nodbg.cfg create mode 100644 recipes-kernel/linux/files/arm64_nodbg.cfg create mode 100644 recipes-kernel/linux/files/armhf_nodbg.cfg

Why is there a *_nodbg,cfg for each Arch? The content for all is the same, so IHMO one file should be enough.

Thanks

Quirin

#9 lore raw
Quoted 42 lines

-----Original Message-----
From: Gylstorff Quirin <[email protected]>
Sent: Friday, July 23, 2021 8:27 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [xenomai-images 0/7] control applying of no-debug config

Quoted 25 lines · Hongzhan Chen via Xenomai

1. enable IPIPE_DEBUG uniformly for all arch by default in order to use uniform method to control it via applying config fragment or not.
2. create config fragment for earch arch to switch debug off.
3. add control to apply config fragment or not.
4. add kas option to control applying config fragment.

*** BLURB HERE ***

Hongzhan Chen (7):
recipes-kernel: arm64_config: enable IPIPE_DEBUG for arm64 by default
recipes-kernel: armhf_config: enable IPIPE_DEBUG for armhf by default
recipes-kernel: add config fragment file to disable debug for amd64
recipes-kernel: add config fragment file to disable debug for arm64
recipes-kernel: add config fragment file to disable debug for arm recipes-kernel/linux: control appyling of no debug config fragment Add kas option for swithing off debug

  opt-set-nodbg.yml                          | 20 ++++++++++++++++++++
  recipes-kernel/linux/files/amd64_nodbg.cfg |  1 +
  recipes-kernel/linux/files/arm64_defconfig |  9 +++++----
  recipes-kernel/linux/files/arm64_nodbg.cfg |  1 +
  recipes-kernel/linux/files/armhf_defconfig | 15 +++++++++++++--
  recipes-kernel/linux/files/armhf_nodbg.cfg |  1 +
  recipes-kernel/linux/linux-xenomai.inc     | 10 +++++++++-
  7 files changed, 50 insertions(+), 7 deletions(-)
Quoted 5 lines

create mode 100644 opt-set-nodbg.yml
create mode 100644 recipes-kernel/linux/files/amd64_nodbg.cfg create mode 100644 recipes-kernel/linux/files/arm64_nodbg.cfg create mode 100644 recipes-kernel/linux/files/armhf_nodbg.cfg

Quoted 2 lines

Why is there a *_nodbg,cfg for each Arch? The content for all is the same, so IHMO one file should be enough.

Current content is same because we just try to switch off IPIPE_DEBUG for all arches. But its final purposes is to improve performance for target image to differentiate it from debug image, which may include other linux options or arch related options. That is why I create *_nodgb.cfg for each arch.

Quoted 4 lines

Thanks

Quirin

#10 lore raw
Quoted 42 lines · Hongzhan via Xenomai
Quoted 42 lines

-----Original Message-----
From: Gylstorff Quirin <[email protected]>
Sent: Friday, July 23, 2021 8:27 PM
To: Chen, Hongzhan <[email protected]>; [email protected]
Subject: Re: [xenomai-images 0/7] control applying of no-debug config

Quoted 30 lines · Hongzhan Chen via Xenomai

1. enable IPIPE_DEBUG uniformly for all arch by default in order to use uniform method to control it via applying config fragment or not.
2. create config fragment for earch arch to switch debug off.
3. add control to apply config fragment or not.
4. add kas option to control applying config fragment.

*** BLURB HERE ***

Hongzhan Chen (7):
recipes-kernel: arm64_config: enable IPIPE_DEBUG for arm64 by default
recipes-kernel: armhf_config: enable IPIPE_DEBUG for armhf by default
recipes-kernel: add config fragment file to disable debug for amd64
recipes-kernel: add config fragment file to disable debug for arm64
recipes-kernel: add config fragment file to disable debug for arm recipes-kernel/linux: control appyling of no debug config fragment Add kas option for swithing off debug

  opt-set-nodbg.yml                          | 20 ++++++++++++++++++++
  recipes-kernel/linux/files/amd64_nodbg.cfg |  1 +
  recipes-kernel/linux/files/arm64_defconfig |  9 +++++----
  recipes-kernel/linux/files/arm64_nodbg.cfg |  1 +
  recipes-kernel/linux/files/armhf_defconfig | 15 +++++++++++++--
  recipes-kernel/linux/files/armhf_nodbg.cfg |  1 +
  recipes-kernel/linux/linux-xenomai.inc     | 10 +++++++++-
  7 files changed, 50 insertions(+), 7 deletions(-)

create mode 100644 opt-set-nodbg.yml
create mode 100644 recipes-kernel/linux/files/amd64_nodbg.cfg create mode 100644 recipes-kernel/linux/files/arm64_nodbg.cfg create mode 100644 recipes-kernel/linux/files/armhf_nodbg.cfg

Quoted 7 lines
Quoted 2 lines

Why is there a *_nodbg,cfg for each Arch? The content for all is the same, so IHMO one file should be enough.

Current content is same because we just try to switch off IPIPE_DEBUG for all arches. But its final purposes is to improve performance for target image to differentiate it from debug image, which may include other linux options or arch related options. That is why I create *_nodgb.cfg for each arch.

Duplicating is never a good things. So let's keep the common switches in a common_nodbg.cfg and add the <arch>_nodbg.cfg files once they are needed.

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux