drm/i915: make i915_drm_client_fdinfo() reference conditional again
Subsystems (2)
PATCH 1/1 drm/i915: make i915_drm_client_fdinfo() reference conditional again
From: Arnd Bergmann <[email protected]>
The function is only defined if CONFIG_PROC_FS is enabled:
ld.lld: error: undefined symbol: i915_drm_client_fdinfo
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
i915_driver.cdrivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.a
Use the PTR_IF() helper to make the reference NULL otherwise.
--- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +1 -1
@@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { .open = i915_driver_open, .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, - .show_fdinfo = i915_drm_client_fdinfo, + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
drivers/gpu/drm/i915/i915_drm_client.h +0 -2
@@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_alloc (void ); -#ifdef CONFIG_PROC_FS void i915_drm_client_fdinfo (struct drm_printer *p,struct drm_file *file); -#endif #endif /* !__I915_DRM_CLIENT_H__ */
Signature · 1 line
2.39.2
Hi Arnd,
Quoted 35 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The function is only defined if
CONFIG_PROC_FSis enabled:ld.lld: error: undefined symbol:
i915_drm_client_fdinfoQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
i915_driver.cdrivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.aUse the
PTR_IF()helper to make the reference NULL otherwise.Fixes e894b724c316d ("drm/i915: Use the fdinfo helper")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/i915/i915_driver.c +1
-1@@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { .open = i915_driver_open, .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, - .show_fdinfo = i915_drm_client_fdinfo, + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,drivers/gpu/drm/i915/i915_drm_client.h +0
-0
drivers/gpu/drm/i915/i915_drm_client.h static inline void i915_drm_client_put(struct i915_drm_client *client) · line 52
Quoted 6 lines
drivers/gpu/drm/i915/i915_drm_client.h +0
-2@@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_alloc (void ); -#ifdef CONFIG_PROC_FS void i915_drm_client_fdinfo (struct drm_printer *p,struct drm_file *file); -#endif
nice! This is becoming the new trend now.
Andi
Quoted 41 lines · Andi Shyti
Hi Arnd,
Quoted 38 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The function is only defined if
CONFIG_PROC_FSis enabled:ld.lld: error: undefined symbol:
i915_drm_client_fdinfoQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
i915_driver.cdrivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.aUse the
PTR_IF()helper to make the reference NULL otherwise.Fixes e894b724c316d ("drm/i915: Use the fdinfo helper")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/i915/i915_driver.c +1
-1@@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { .open = i915_driver_open, .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, - .show_fdinfo = i915_drm_client_fdinfo, + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,drivers/gpu/drm/i915/i915_drm_client.h +0
-0@@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_alloc (void );
Quoted 7 lines
drivers/gpu/drm/i915/i915_drm_client.h static inline void i915_drm_client_put(struct i915_drm_client *client) · line 52
Quoted 3 lines
drivers/gpu/drm/i915/i915_drm_client.h +0
-2-#ifdef CONFIG_PROC_FS void i915_drm_client_fdinfo (struct drm_printer *p,struct drm_file *file); -#endif nice! This is becoming the new trend now.
Reviewed-by Andi Shyti <[email protected]>
Thanks for the fix and review! (And I got to learn about existence of PTR_IF too.)
Andi will you merge once green or should I?
Regards,
Tvrtko
Hi Tvrtko,
Quoted 46 lines · Tvrtko Ursulin
Quoted 44 lines · Andi Shyti
Hi Arnd,
Quoted 34 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The function is only defined if
CONFIG_PROC_FSis enabled:ld.lld: error: undefined symbol:
i915_drm_client_fdinfoQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
i915_driver.cdrivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.aUse the
PTR_IF()helper to make the reference NULL otherwise.Fixes e894b724c316d ("drm/i915: Use the fdinfo helper")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/i915/i915_driver.c +1
-1@@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { .open = i915_driver_open, .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, - .show_fdinfo = i915_drm_client_fdinfo, + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,drivers/gpu/drm/i915/i915_drm_client.h +0
-0drivers/gpu/drm/i915/i915_drm_client.h static inline void i915_drm_client_put(struct i915_drm_client *client) · line 50
Quoted 4 lines
drivers/gpu/drm/i915/i915_drm_client.h +0
-2@@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_alloc (void ); -#ifdef CONFIG_PROC_FS void i915_drm_client_fdinfo (struct drm_printer *p,struct drm_file *file); -#endif nice! This is becoming the new trend now.
Quoted 6 lines
Quoted 1 line
Reviewed-by Andi Shyti <[email protected]>Thanks for the fix and review! (And I got to learn about existence of
PTR_IFtoo.)Andi will you merge once green or should I?
will do! Thanks!
Andi
Quoted 3 lines
Regards,
Tvrtko
Quoted 49 lines · Tvrtko Ursulin
Quoted 47 lines · Andi Shyti
Hi Arnd,
Quoted 36 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The function is only defined if
CONFIG_PROC_FSis enabled:ld.lld: error: undefined symbol:
i915_drm_client_fdinfoQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
referenced by
i915_driver.cdrivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.a
Use the
PTR_IF()helper to make the reference NULL otherwise.Fixes e894b724c316d ("drm/i915: Use the fdinfo helper")Signed-off-by Arnd Bergmann <[email protected]>---
drivers/gpu/drm/i915/i915_driver.c | 2 +-
drivers/gpu/drm/i915/i915_drm_client.h| 2 --2 files changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/i915/i915_driver.c +1
-1@@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { .open = i915_driver_open, .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, - .show_fdinfo = i915_drm_client_fdinfo, + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,drivers/gpu/drm/i915/i915_drm_client.h +0
-0drivers/gpu/drm/i915/i915_drm_client.h static inline void i915_drm_client_put(struct · line 51
Quoted 5 lines
drivers/gpu/drm/i915/i915_drm_client.h +0
-2@@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client) struct i915_drm_client *i915_drm_client_alloc(void); -#ifdef CONFIG_PROC_FS void i915_drm_client_fdinfo(struct drm_printer *p, struct drm_file *file); -#endif nice! This is becoming the new trend now.
Quoted 5 lines
Quoted 1 line
Reviewed-by Andi Shyti <[email protected]>Thanks for the fix and review! (And I got to learn about existence of
PTR_IFtoo.)Andi will you merge once green or should I?
Pushed, thanks for the fixup and review!
Regards,
Tvrtko
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: make i915_drm_client_fdinfo() reference conditional again
In reply to Arnd Bergmann== Series Details ==
== Series Details ==
Series: drm/i915: make i915_drm_client_fdinfo() reference conditional again
URL : https://patchwork.freedesktop.org/series/119441/
State : warning
== Summary ==
Error: dim checkpatch failede48e1d622c43 drm/i915: make i915_drm_client_fdinfo() reference conditional again
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11:
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.a
-:15: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: e894b724c316 ("drm/i915: Use the fdinfo helper")' #15:
total: 0 errors, 2 warnings, 0 checks, 16 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: make i915_drm_client_fdinfo() reference conditional again
In reply to Arnd Bergmann== Series Details ==
== Series Details ==
Series: drm/i915: make i915_drm_client_fdinfo() reference conditional again
URL : https://patchwork.freedesktop.org/series/119441/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make i915_drm_client_fdinfo() reference conditional again
In reply to Arnd Bergmann== Series Details ==
== Series Details ==
Series: drm/i915: make i915_drm_client_fdinfo() reference conditional again
URL : https://patchwork.freedesktop.org/series/119441/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13278 -> Patchwork_119441v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/index.html
Participating hosts (42 -> 40)
------------------------------
Missing (2): bat-mtlp-8 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_119441v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_lrc:
- bat-adlp-9: [PASS][1] -> [INCOMPLETE][2] ([i915#4983] / [i915#7913])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][3] ([i915#7828])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-dg2-11/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [INCOMPLETE][4] ([i915#7609] / [i915#7913]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][6] ([i915#7059]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][8] ([i915#6367]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-mtlp-6/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-mtlp-6/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-rpls-2: [DMESG-FAIL][10] ([i915#6763] / [i915#7913]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-rpls-2/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [FAIL][12] ([i915#7932]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
#### Warnings ####
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-edp-1:
- bat-adlp-6: [ABORT][14] ([i915#7977]) -> [ABORT][15] ([i915#7977] / [i915#8434])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/bat-adlp-6/igt@kms_pipe_crc_basic@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/bat-adlp-6/igt@kms_pipe_crc_basic@[email protected]
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
Build changes
-------------
* Linux: CI_DRM_13278 -> Patchwork_119441v1
CI-20190529: 20190529
CI_DRM_13278: 3c942541e24c0aaab070d498c57647e7b4e9aa6e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7334: 9dd259184050af3e5217e1a63e6b90b1b946e7c4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119441v1: 3c942541e24c0aaab070d498c57647e7b4e9aa6e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
7af97a6e3f88 drm/i915: make i915_drm_client_fdinfo() reference conditional again
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: make i915_drm_client_fdinfo() reference conditional again
In reply to Arnd Bergmann== Series Details ==
== Series Details ==
Series: drm/i915: make i915_drm_client_fdinfo() reference conditional again
URL : https://patchwork.freedesktop.org/series/119441/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13278_full -> Patchwork_119441v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_119441v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][1] -> [FAIL][2] ([i915#6268])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-1/igt@[email protected]
- shard-tglu: [PASS][3] -> [FAIL][4] ([i915#6268])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-tglu-7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-tglu-10/igt@[email protected]
* igt@gem_exec_endless@dispatch@rcs0:
- shard-tglu: [PASS][5] -> [TIMEOUT][6] ([i915#3778] / [i915#7392] / [i915#7921])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-tglu-5/igt@gem_exec_endless@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-tglu-9/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-glk9/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-tglu: [PASS][9] -> [FAIL][10] ([i915#3989] / [i915#454])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-tglu-9/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-tglu-3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +11 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-snb4/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rpm@modeset-lpsp:
- shard-rkl: [PASS][12] -> [SKIP][13] ([i915#1397])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-6/igt@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][14] -> [FAIL][15] ([fdo#103375]) +6 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-1/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-6/igt@[email protected]
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][16] ([i915#8502]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3886])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-apl3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
- shard-glk: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3886])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: NOTRUN -> [FAIL][19] ([i915#2346])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk7/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][20] ([i915#2346])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-apl3/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][21] -> [ABORT][22] ([i915#180])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-apl2/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-apl3/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4579])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-apl3/igt@kms_flip_scaled_crc@[email protected]
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk7/igt@kms_flip_scaled_crc@[email protected]
* igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271]) +14 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-apl3/igt@[email protected]
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][26] ([i915#8292])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][27] ([i915#5176]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-7/igt@kms_plane_scaling@[email protected]
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +13 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-snb1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][29] ([i915#4579] / [i915#5176]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][30] ([i915#4579] / [i915#5235]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][31] ([i915#5235]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-6/igt@kms_plane_scaling@[email protected]
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][32] ([i915#5465]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-snb5/igt@kms_setmode@[email protected]
* igt@v3d/v3d_perfmon@destroy-invalid-perfmon:
- shard-glk: NOTRUN -> [SKIP][33] ([fdo#109271]) +10 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk7/igt@v3d/[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][34] ([i915#7742]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-4/igt@drm_fdinfo@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-4/igt@drm_fdinfo@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][36] ([i915#2842]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-6/igt@gem_exec_fair@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-7/igt@gem_exec_fair@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][38] ([i915#5566]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-apl3/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-apl3/igt@[email protected]
- shard-glk: [ABORT][40] ([i915#5566]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-glk6/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk7/igt@[email protected]
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][42] ([i915#1397]) -> [PASS][43] +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-7/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-1/igt@[email protected]
* igt@kms_cursor_legacy@forked-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][44] ([i915#8011] / [i915#8347]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-dg1-19/igt@kms_cursor_legacy@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-dg1-15/igt@kms_cursor_legacy@[email protected]
* igt@kms_cursor_legacy@single-bo@pipe-b:
- shard-rkl: [INCOMPLETE][46] ([i915#8011]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-6/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][48] ([i915#79]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-glk9/igt@kms_flip@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-snb: [SKIP][50] ([fdo#109271]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-snb5/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-snb1/igt@[email protected]
#### Warnings ####
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][52] ([i915#4070] / [i915#4816]) -> [SKIP][53] ([i915#4816])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13278/shard-rkl-6/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/shard-rkl-7/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7921]: https://gitlab.freedesktop.org/drm/intel/issues/7921
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
Build changes
-------------
* Linux: CI_DRM_13278 -> Patchwork_119441v1
CI-20190529: 20190529
CI_DRM_13278: 3c942541e24c0aaab070d498c57647e7b4e9aa6e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7334: 9dd259184050af3e5217e1a63e6b90b1b946e7c4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119441v1: 3c942541e24c0aaab070d498c57647e7b4e9aa6e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119441v1/index.html
Quoted 4 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The function is only defined if
CONFIG_PROC_FSis enabled:
Quoted 8 lines
ld.lld: error: undefined symbol:
i915_drm_client_fdinfoQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
i915_driver.cdrivers/gpu/drm/i915/i915_driver.o:(i915_drm_driver) in archive vmlinux.aUse the
PTR_IF()helper to make the reference NULL otherwise.Fixes e894b724c316d ("drm/i915: Use the fdinfo helper")Signed-off-by Arnd Bergmann <[email protected]>
Thanks.
Quoted 31 lines
--- drivers/gpu/drm/i915/i915_driver.c | 2 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/i915/i915_driver.c +1
-1@@ -1816,7 +1816,7 @@ static const struct drm_driver i915_drm_driver = { .open = i915_driver_open, .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, - .show_fdinfo = i915_drm_client_fdinfo, + .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo), .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle,drivers/gpu/drm/i915/i915_drm_client.h +0
-2@@ -47,8 +47,6 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_alloc (void ); -#ifdef CONFIG_PROC_FS void i915_drm_client_fdinfo (struct drm_printer *p,struct drm_file *file); -#endif #endif /* !__I915_DRM_CLIENT_H__ */
Signature · 1 line
~Randy