mx6: Fix imx6_is_bmode_from_gpr9 always returns 0
Subsystems (2)
PATCH 1/1 mx6: Fix imx6_is_bmode_from_gpr9 always returns 0
Due to the cast to u8, this function always returned 0.
CC Stefano Babic <[email protected]>
---
arch/arm/include/asm/mach-imx/sys_proto.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/include/asm/mach-imx/sys_proto.h +0 -0
@@ -86,7 +86,8 @@ enum imx6_bmode {
static inline u8 imx6_is_bmode_from_gpr9(void)
{
- return readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE;
+ return (readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE)
+ == IMX6_SRC_GPR10_BMODE;
}
u32 imx6_src_get_boot_mode(void);
--
1.7.10.4
Fabio Estevam
reviewerPATCH 1/1 mx6: Fix imx6_is_bmode_from_gpr9 always returns 0
Hi Jeroen,
Quoted 13 lines · Jeroen Vollenbrock
Due to the cast to u8, this function always returned 0.
CC Stefano Babic <[email protected]>--- arch/arm/include/asm/mach-imx/sys_proto.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/include/asm/mach-imx/sys_proto.h +0
-0
arch/arm/include/asm/mach-imx/sys_proto.h enum imx6_bmode { · line 87
Quoted 2 lines
arch/arm/include/asm/mach-imx/sys_proto.h +0
-0@@ -86,7 +86,8 @@ enum imx6_bmode {static inline u8 imx6_is_bmode_from_gpr9 (void )
Maybe make it 'static inline bool' instead?
Regards,
Fabio Estevam