Skip to contentSkip to conversation

CSESS22: increase the limit above latest knfsd limit

PATCH In review Jeff Layton 2 participants 2 messages Dec 20, 2024 – Jan 2, 2025

Subsystems (2)
lore
Share & tools
lore

Jeff Layton

author maintainer
#0 lore raw

PATCH 1/1 CSESS22: increase the limit above latest knfsd limit

With the latest code in Chuck's nfsd-testing branch, the limit on the number of fore-channel session slots has been increased to 2048. Increase the TOO_MANY_SLOTS variable to 2049.

---
Maybe we should increase this to a much higher number instead? I half wonder if we ought to just eliminate this test altogether. It seems sort of arbitrary.

---
 nfs4.1/server41tests/st_create_session.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
nfs4.1/server41tests/st_create_session.py +1 -1
index 43166443ef6f86a6b44de70f3793bd93a330bc9d..740f8bf274c4eeb3ff9da20c0de241a31f80ac26 100644
@@ -395,7 +395,7 @@ def testMaxreqs(t, env):
     """
     # Assuming this is too large for any server; increase if necessary:
     # but too huge will eat many memory for replay_cache, be careful!
-    TOO_MANY_SLOTS = 500
+    TOO_MANY_SLOTS = 2049
 
     c = env.c1.new_client(env.testname(t))
     # CREATE_SESSION with fore_channel = TOO_MANY_SLOTS

---
base-commit: fa786a7217128e6e5c9ef20da9dd6069f5f593e7
change-id: 20241220-master-2b43693225b0

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>
#1 lore raw
Quoted 10 lines · Jeff Layton

With the latest code in Chuck's nfsd-testing branch, the limit on the number of fore-channel session slots has been increased to 2048. Increase the TOO_MANY_SLOTS variable to 2049.

---
Maybe we should increase this to a much higher number instead? I half wonder if we ought to just eliminate this test altogether. It seems sort of arbitrary.
---

I've applied this as is, thanks Jeff; will have a further think about whether the test is still useful.

cheers,
c.

Quoted 22 lines
  nfs4.1/server41tests/st_create_session.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
nfs4.1/server41tests/st_create_session.py +1 -2
index 43166443ef6f86a6b44de70f3793bd93a330bc9d..740f8bf274c4eeb3ff9da20c0de241a31f80ac26 100644
@@ -395,7 +395,7 @@ def testMaxreqs(t, env):
      """
      # Assuming this is too large for any server; increase if necessary:
      # but too huge will eat many memory for replay_cache, be careful!
-    TOO_MANY_SLOTS = 500
+    TOO_MANY_SLOTS = 2049
 
      c = env.c1.new_client(env.testname(t))
      # CREATE_SESSION with fore_channel = TOO_MANY_SLOTS
 
---

base-commit: fa786a7217128e6e5c9ef20da9dd6069f5f593e7
change-id: 20241220-master-2b43693225b0

Best regards,