Skip to contentSkip to conversation

mm/mempolicy: Fix memory leak in set_mempolicy_home_node system call

RFC PATCH In review Mathieu Desnoyers 6 participants 10 messages Dec 14, 2022 – Dec 15, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 mm/mempolicy: Fix memory leak in set_mempolicy_home_node system call

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>
---
 mm/mempolicy.c | 1 +
 1 file changed, 1 insertion(+)
mm/mempolicy.c +1 -0
index 61aa9aedb728..02c8a712282f 100644
@@ -1540,6 +1540,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		 * the home node for vmas we already updated before.
 		 */
 		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+			mpol_put(new);
 			err = -EOPNOTSUPP;
 			break;
 		}
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Mathieu Desnoyers

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Quoted 8 lines
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>

Thanks.

Quoted 16 lines
---
 mm/mempolicy.c | 1 +
 1 file changed, 1 insertion(+)
mm/mempolicy.c +1 -0
index 61aa9aedb728..02c8a712282f 100644
@@ -1540,6 +1540,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		 * the home node for vmas we already updated before.
 		 */
 		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+			mpol_put(new);
 			err = -EOPNOTSUPP;
 			break;
 		}
Signature · 1 line
~Randy
Reviewed-by on v1 1/1
#2 lore raw
In reply to Mathieu Desnoyers
Quoted 16 lines · Mathieu Desnoyers

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Quoted 8 lines
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>

Thanks!

Quoted 16 lines
---
 mm/mempolicy.c | 1 +
 1 file changed, 1 insertion(+)
mm/mempolicy.c +1 -0
index 61aa9aedb728..02c8a712282f 100644
@@ -1540,6 +1540,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		 * the home node for vmas we already updated before.
 		 */
 		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+			mpol_put(new);
 			err = -EOPNOTSUPP;
 			break;
 		}
Acked-by on v1 1/1
#3 lore raw
In reply to Mathieu Desnoyers
Quoted 16 lines · Mathieu Desnoyers

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Quoted 8 lines
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>

Thanks for catching this!

Btw. looking at the code again it seems rather pointless to duplicate the policy just to throw it away anyway. A slightly bigger diff but this looks more reasonable to me. What do you think? I can also send it as a clean up on top of your fix.
---

mm/mempolicy.c +13 -15
index 61aa9aedb728..918cdc8a7f0c 100644
@@ -1489,7 +1489,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 {
 	struct mm_struct *mm = current->mm;
 	struct vm_area_struct *vma;
-	struct mempolicy *new;
+	struct mempolicy *new. *old;
 	unsigned long vmstart;
 	unsigned long vmend;
 	unsigned long end;
@@ -1521,30 +1521,28 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		return 0;
 	mmap_write_lock(mm);
 	for_each_vma_range(vmi, vma, end) {
-		vmstart = max(start, vma->vm_start);
-		vmend   = min(end, vma->vm_end);
-		new = mpol_dup(vma_policy(vma));
-		if (IS_ERR(new)) {
-			err = PTR_ERR(new);
-			break;
-		}
-		/*
-		 * Only update home node if there is an existing vma policy
-		 */
-		if (!new)
-			continue;
-
 		/*
 		 * If any vma in the range got policy other than MPOL_BIND
 		 * or MPOL_PREFERRED_MANY we return error. We don't reset
 		 * the home node for vmas we already updated before.
 		 */
-		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+		old = vma_policy(vma);
+		if (!old)
+			continue;
+		if (old->mode != MPOL_BIND && old->mode != MPOL_PREFERRED_MANY) {
 			err = -EOPNOTSUPP;
 			break;
 		}
 
+		new = mpol_dup(vma_policy(vma));
+		if (IS_ERR(new)) {
+			err = PTR_ERR(new);
+			break;
+		}
+
 		new->home_node = home_node;
+		vmstart = max(start, vma->vm_start);
+		vmend   = min(end, vma->vm_end);
 		err = mbind_range(mm, vmstart, vmend, new);
 		mpol_put(new);
 		if (err)
Signature · 2 lines
Michal Hocko
SUSE Labs
#4 lore raw
Quoted 69 lines · Michal Hocko
Quoted 16 lines · Mathieu Desnoyers

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Quoted 8 lines
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>

Thanks for catching this!

Btw. looking at the code again it seems rather pointless to duplicate the policy just to throw it away anyway. A slightly bigger diff but this looks more reasonable to me. What do you think? I can also send it as a clean up on top of your fix.
---

mm/mempolicy.c +1 -14
index 61aa9aedb728..918cdc8a7f0c 100644
@@ -1489,7 +1489,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 {
 	struct mm_struct *mm = current->mm;
 	struct vm_area_struct *vma;
-	struct mempolicy *new;
+	struct mempolicy *new. *old;
 	unsigned long vmstart;
 	unsigned long vmend;
 	unsigned long end;
@@ -1521,30 +1521,28 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		return 0;
 	mmap_write_lock(mm);
 	for_each_vma_range(vmi, vma, end) {
-		vmstart = max(start, vma->vm_start);
-		vmend   = min(end, vma->vm_end);
-		new = mpol_dup(vma_policy(vma));
-		if (IS_ERR(new)) {
-			err = PTR_ERR(new);
-			break;
-		}
-		/*
-		 * Only update home node if there is an existing vma policy
-		 */
-		if (!new)
-			continue;
-
 		/*
 		 * If any vma in the range got policy other than MPOL_BIND
 		 * or MPOL_PREFERRED_MANY we return error. We don't reset
 		 * the home node for vmas we already updated before.
 		 */

mm/mempolicy.c SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le · line 1537

Quoted 10 lines
mm/mempolicy.c +5 -1
-		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+		old = vma_policy(vma);
+		if (!old)
+			continue;
+		if (old->mode != MPOL_BIND && old->mode != MPOL_PREFERRED_MANY) {
 			err = -EOPNOTSUPP;
 			break;
 		}
 
+		new = mpol_dup(vma_policy(vma));
		new = mpol_dup(old);
Quoted 14 lines
mm/mempolicy.c +7 -0
+		if (IS_ERR(new)) {
+			err = PTR_ERR(new);
+			break;
+		}
+
 		new->home_node = home_node;
+		vmstart = max(start, vma->vm_start);
+		vmend   = min(end, vma->vm_end);
 		err = mbind_range(mm, vmstart, vmend, new);
 		mpol_put(new);
 		if (err)
Signature · 2 lines
Michal Hocko
SUSE Labs
#5 lore raw
In reply to Michal Hocko
Quoted 26 lines · Michal Hocko
Quoted 16 lines · Mathieu Desnoyers

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Quoted 8 lines
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>
Quoted 7 lines

Thanks for catching this!

Btw. looking at the code again it seems rather pointless to duplicate the policy just to throw it away anyway. A slightly bigger diff but this looks more reasonable to me. What do you think? I can also send it as a clean up on top of your fix.

I think it would be best if this comes as a cleanup on top of my fix. The diff is larger than the minimal change needed to fix the leak in stable branches.

Your approach looks fine, except for the vma_policy(vma) -> old change already spotted by Aneesh.

Thanks,

Mathieu

Quoted 57 lines

---

mm/mempolicy.c +13 -15
index 61aa9aedb728..918cdc8a7f0c 100644
@@ -1489,7 +1489,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
  {
  	struct mm_struct *mm = current->mm;
  	struct vm_area_struct *vma;
-	struct mempolicy *new;
+	struct mempolicy *new. *old;
  	unsigned long vmstart;
  	unsigned long vmend;
  	unsigned long end;
@@ -1521,30 +1521,28 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
  		return 0;
  	mmap_write_lock(mm);
  	for_each_vma_range(vmi, vma, end) {
-		vmstart = max(start, vma->vm_start);
-		vmend   = min(end, vma->vm_end);
-		new = mpol_dup(vma_policy(vma));
-		if (IS_ERR(new)) {
-			err = PTR_ERR(new);
-			break;
-		}
-		/*
-		 * Only update home node if there is an existing vma policy
-		 */
-		if (!new)
-			continue;
-
  		/*
  		 * If any vma in the range got policy other than MPOL_BIND
  		 * or MPOL_PREFERRED_MANY we return error. We don't reset
  		 * the home node for vmas we already updated before.
  		 */
-		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+		old = vma_policy(vma);
+		if (!old)
+			continue;
+		if (old->mode != MPOL_BIND && old->mode != MPOL_PREFERRED_MANY) {
  			err = -EOPNOTSUPP;
  			break;
  		}
 
+		new = mpol_dup(vma_policy(vma));
+		if (IS_ERR(new)) {
+			err = PTR_ERR(new);
+			break;
+		}
+
  		new->home_node = home_node;
+		vmstart = max(start, vma->vm_start);
+		vmend   = min(end, vma->vm_end);
  		err = mbind_range(mm, vmstart, vmend, new);
  		mpol_put(new);
  		if (err)
Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
#6 lore raw

PATCH 1/1 mm/mempolicy: do not duplicate policy if it is not applicable for set_mempolicy_home_node

Quoted 1 line · Mathieu Desnoyers

On 2022-12-15 02:51, Michal Hocko wrote:

[...]

Quoted 11 lines
Quoted 4 lines

Btw. looking at the code again it seems rather pointless to duplicate the policy just to throw it away anyway. A slightly bigger diff but this looks more reasonable to me. What do you think? I can also send it as a clean up on top of your fix.

I think it would be best if this comes as a cleanup on top of my fix. The diff is larger than the minimal change needed to fix the leak in stable branches.

Your approach looks fine, except for the vma_policy(vma) -> old change already spotted by Aneesh.

This shouldn't have any real effect on the functionality. Anyway, here is a follow up cleanup:
---
From f3fdb6f65fa3977aab13378b8e299b168719577c Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Thu, 15 Dec 2022 15:41:27 +0100
Subject: [PATCH] mm/mempolicy: do not duplicate policy if it is not applicable
for set_mempolicy_home_node

set_mempolicy_home_node tries to duplicate a memory policy before checking it whether it is applicable for the operation. There is no real reason for doing that and it might actually be a pointless memory allocation and deallocation exercise for MPOL_INTERLEAVE.

Not a big problem but we can do better. Simply check the policy before acting on it.

---
 mm/mempolicy.c | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)
mm/mempolicy.c +12 -16
index 02c8a712282f..becf41e10076 100644
@@ -1489,7 +1489,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 {
 	struct mm_struct *mm = current->mm;
 	struct vm_area_struct *vma;
-	struct mempolicy *new;
+	struct mempolicy *new, *old;
 	unsigned long vmstart;
 	unsigned long vmend;
 	unsigned long end;
@@ -1521,31 +1521,27 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		return 0;
 	mmap_write_lock(mm);
 	for_each_vma_range(vmi, vma, end) {
-		vmstart = max(start, vma->vm_start);
-		vmend   = min(end, vma->vm_end);
-		new = mpol_dup(vma_policy(vma));
-		if (IS_ERR(new)) {
-			err = PTR_ERR(new);
-			break;
-		}
-		/*
-		 * Only update home node if there is an existing vma policy
-		 */
-		if (!new)
-			continue;
-
 		/*
 		 * If any vma in the range got policy other than MPOL_BIND
 		 * or MPOL_PREFERRED_MANY we return error. We don't reset
 		 * the home node for vmas we already updated before.
 		 */
-		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
-			mpol_put(new);
+		old = vma_policy(vma);
+		if (!old)
+			continue;
+		if (old->mode != MPOL_BIND && old->mode != MPOL_PREFERRED_MANY) {
 			err = -EOPNOTSUPP;
 			break;
 		}
+		new = mpol_dup(old);
+		if (IS_ERR(new)) {
+			err = PTR_ERR(new);
+			break;
+		}
 
 		new->home_node = home_node;
+		vmstart = max(start, vma->vm_start);
+		vmend   = min(end, vma->vm_end);
 		err = mbind_range(mm, vmstart, vmend, new);
 		mpol_put(new);
 		if (err)
Signature · 5 lines
2.30.2

-- 
Michal Hocko
SUSE Labs
#7 lore raw

Re: [PATCH] mm/mempolicy: do not duplicate policy if it is not applicable for set_mempolicy_home_node

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH] mm/mempolicy: do not duplicate policy if it is not applicable for set_mempolicy_home_node

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp
author Reviewed-by on v1 1/1
#8 lore raw

Re: [PATCH] mm/mempolicy: do not duplicate policy if it is not applicable for set_mempolicy_home_node

In reply to Michal Hocko
Quoted 29 lines · Michal Hocko
Quoted 1 line · Mathieu Desnoyers

On 2022-12-15 02:51, Michal Hocko wrote:

[...]

Quoted 11 lines
Quoted 4 lines

Btw. looking at the code again it seems rather pointless to duplicate the policy just to throw it away anyway. A slightly bigger diff but this looks more reasonable to me. What do you think? I can also send it as a clean up on top of your fix.

I think it would be best if this comes as a cleanup on top of my fix. The diff is larger than the minimal change needed to fix the leak in stable branches.

Your approach looks fine, except for the vma_policy(vma) -> old change already spotted by Aneesh.

This shouldn't have any real effect on the functionality. Anyway, here is a follow up cleanup:
---
From f3fdb6f65fa3977aab13378b8e299b168719577c Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Thu, 15 Dec 2022 15:41:27 +0100
Subject: [PATCH] mm/mempolicy: do not duplicate policy if it is not applicable
for set_mempolicy_home_node

set_mempolicy_home_node tries to duplicate a memory policy before checking it whether it is applicable for the operation. There is no real reason for doing that and it might actually be a pointless memory allocation and deallocation exercise for MPOL_INTERLEAVE.

Quoted 4 lines

Not a big problem but we can do better. Simply check the policy before acting on it.

Quoted 60 lines
---
  mm/mempolicy.c | 28 ++++++++++++----------------
  1 file changed, 12 insertions(+), 16 deletions(-)
mm/mempolicy.c +12 -16
index 02c8a712282f..becf41e10076 100644
@@ -1489,7 +1489,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
  {
  	struct mm_struct *mm = current->mm;
  	struct vm_area_struct *vma;
-	struct mempolicy *new;
+	struct mempolicy *new, *old;
  	unsigned long vmstart;
  	unsigned long vmend;
  	unsigned long end;
@@ -1521,31 +1521,27 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
  		return 0;
  	mmap_write_lock(mm);
  	for_each_vma_range(vmi, vma, end) {
-		vmstart = max(start, vma->vm_start);
-		vmend   = min(end, vma->vm_end);
-		new = mpol_dup(vma_policy(vma));
-		if (IS_ERR(new)) {
-			err = PTR_ERR(new);
-			break;
-		}
-		/*
-		 * Only update home node if there is an existing vma policy
-		 */
-		if (!new)
-			continue;
-
  		/*
  		 * If any vma in the range got policy other than MPOL_BIND
  		 * or MPOL_PREFERRED_MANY we return error. We don't reset
  		 * the home node for vmas we already updated before.
  		 */
-		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
-			mpol_put(new);
+		old = vma_policy(vma);
+		if (!old)
+			continue;
+		if (old->mode != MPOL_BIND && old->mode != MPOL_PREFERRED_MANY) {
  			err = -EOPNOTSUPP;
  			break;
  		}
+		new = mpol_dup(old);
+		if (IS_ERR(new)) {
+			err = PTR_ERR(new);
+			break;
+		}
 
  		new->home_node = home_node;
+		vmstart = max(start, vma->vm_start);
+		vmend   = min(end, vma->vm_end);
  		err = mbind_range(mm, vmstart, vmend, new);
  		mpol_put(new);
  		if (err)
Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
Reviewed-by on v1 1/1
#9 lore raw
In reply to Mathieu Desnoyers
Quoted 6 lines · Mathieu Desnoyers

When encountering any vma in the range with policy other than MPOL_BIND or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put on the policy just allocated with mpol_dup().

This allows arbitrary users to leak kernel memory.

Quoted 36 lines
Fixes c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
Cc Aneesh Kumar K.V <[email protected]>
Cc Ben Widawsky <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Feng Tang <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Mike Kravetz <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Dan Williams <[email protected]>
Cc Huang Ying <[email protected]>
Cc Andrew Morton <[email protected]>
---
 mm/mempolicy.c | 1 +
 1 file changed, 1 insertion(+)
mm/mempolicy.c +1 -0
index 61aa9aedb728..02c8a712282f 100644
@@ -1540,6 +1540,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		 * the home node for vmas we already updated before.
 		 */
 		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
+			mpol_put(new);
 			err = -EOPNOTSUPP;
 			break;
 		}
Signature · 1 line
2.25.1