spi: Mark non-dm spi drivers as BROKEN
cover spi: Mark non-dm spi drivers as BROKEN
We have trigger a zap patches about the legacy spi driver which are not converted into dm, but the seems like most of the associated developers are unaware about the migration plan for SPI.
So, as per Tom request and make the removal smooth mark these non-dm drivers into BROKEN. The configs which enabled these drivers are now getting warnings saying that the resulting .config has broken config enabled and more over the code associated with these configs will be removed in v2019.07 release.
Any inputs?
Jagan.
Jagan Teki (8):
Kconfig: Update CONFIG_BROKEN help text
Makefile: Trigger a Warning if BROKEN defined
Makefile: Trigger a warning for legcay spi drivers
spi: Kconfig: Mark MXS_SPI has BROKEN
spi: Kconfig: Mark SH_SPI has BROKEN
spi: Kconfig: Mark SOFT_SPI has BROKEN
spi: Kconfig: Mark FSL_ESPI has BROKEN
spi: Kconfig: Mark LPC32XX_SSP has BROKEN
Kconfig | 7 ++++++- Makefile | 19 ++++++++----------- drivers/spi/Kconfig | 5 +++++ 3 files changed, 19 insertions(+), 12 deletions(-)
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 1/8 Kconfig: Update CONFIG_BROKEN help text
Add bool text to describe what configurations is this for.
Update help text to describe the example use-case configs which comes under CONFIG_BROKEN, they are
- legacy driver that would need dm conversion.
- legacy driver that doesn't have proper update since from the releases.
--- Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
Kconfig +6 -1
@@ -15,11 +15,16 @@ source "arch/Kconfig" menu "General setup" config BROKEN - bool + bool "Broken configuration" help This option cannot be enabled. It is used as dependency for broken and incomplete features. + These broken configurations may comes under, + - legacy driver that would need dm conversion. + - legacy driver that doesn't have proper update since + from the releases. + config LOCALVERSION string "Local version - append to U-Boot release" help
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 1/8 Kconfig: Update CONFIG_BROKEN help text
Quoted 19 lines · Jagan Teki
Add bool text to describe what configurations is this for.
Update help text to describe the example use-case configs which comes under
CONFIG_BROKEN, they are
- legacy driver that would need dm conversion.
- legacy driver that doesn't have proper update since from the releases.Cc Heinrich Schuchardt <[email protected]>Signed-off-by Jagan Teki <[email protected]>--- Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)Kconfig +0
-0
Kconfig source "arch/Kconfig" · line 23
Quoted 10 lines
Kconfig +2
-1@@ -15,11 +15,16 @@ source "arch/Kconfig" menu "General setup" config BROKEN - bool + bool "Broken configuration" help This option cannot be enabled. It is used as dependency for broken and incomplete features. + These broken configurations may comes under,
Thanks for adding clarification. I suggest to rewrite it as:
This dependency is assigned to
- legacy drivers requiring driver model conversion
- legacy drivers lacking maintenance
Best regards
Heinrich
Quoted 8 lines
Kconfig +4
-0+ - legacy driver that would need dm conversion. + - legacy driver that doesn't have proper update since + from the releases. + config LOCALVERSION string "Local version - append to U-Boot release" help
PATCH 2/8 Makefile: Trigger a Warning if BROKEN defined
In reply to Jagan TekiIf configured target has broken config enabled, trigger a warning saying that the desired .config has broken configuration.
--- Makefile | 3 +++ 1 file changed, 3 insertions(+)
Makefile +3 -0
@@ -918,6 +918,9 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ $(srctree)/scripts/config_whitelist.txt $(srctree) all: $(ALL-y) +ifeq ($(CONFIG_BROKEN),y) + $(warning "You have broken configuration in your .config! Please check your configuration.") +endif # broken ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo >&2 "===================== WARNING ======================" @echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 2/8 Makefile: Trigger a Warning if BROKEN defined
Quoted 14 lines · Jagan Teki
If configured target has broken config enabled, trigger a warning saying that the desired .config has broken configuration.
Cc Heinrich Schuchardt <[email protected]>Signed-off-by Jagan Teki <[email protected]>--- Makefile | 3 +++ 1 file changed, 3 insertions(+)Makefile +0
-0
Makefile cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ · line 924
Quoted 7 lines
Makefile +3
-0@@ -918,6 +918,9 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ $(srctree)/scripts/config_whitelist.txt $(srctree) all: $(ALL-y) +ifeq ($(CONFIG_BROKEN),y) + $(warning "You have broken configuration in your .config! Please check your configuration.") + $(warning "Your .config file selects a feature marked as broken.
Please check your configuration.")
Regards
Heinrich
Quoted 5 lines
Makefile +1
-0+endif # broken ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo >&2 "===================== WARNING ======================" @echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
PATCH 3/8 Makefile: Trigger a warning for legcay spi drivers
In reply to Jagan TekiWe have a warning text for non dm converted spi drivers, but the plan is to mark all these respetive drivers into CONFIG_BROKEN.
So, trigger a warning saying that these driver configurations and associated code will remove in v2019.07 (earlier plan is to remove it from v2019.04)
--- Makefile | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-)
Makefile +5 -11
@@ -920,6 +920,11 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \ all: $(ALL-y) ifeq ($(CONFIG_BROKEN),y) $(warning "You have broken configuration in your .config! Please check your configuration.") +ifeq ($(CONFIG_SPI),y) +ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) + $(warning "The relevant config item with associated code will remove in v2019.07 release.") +endif +endif endif # broken ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) @echo >&2 "===================== WARNING ======================"
@@ -997,17 +1002,6 @@ ifeq ($(CONFIG_OF_EMBED),y) @echo >&2 "See doc/README.fdt-control for more info." @echo >&2 "====================================================" endif -ifeq ($(CONFIG_SPI),y) -ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy) - @echo >&2 "===================== WARNING ======================" - @echo >&2 "This board does not use CONFIG_DM_SPI. Please update" - @echo >&2 "the board before v2019.04 for no dm conversion" - @echo >&2 "and v2019.07 for partially dm converted drivers." - @echo >&2 "Failure to update can lead to driver/board removal" - @echo >&2 "See doc/driver-model/MIGRATION.txt for more info." - @echo >&2 "====================================================" -endif -endif ifeq ($(CONFIG_SPI_FLASH),y) ifneq ($(CONFIG_DM_SPI_FLASH)$(CONFIG_OF_CONTROL),yy) @echo >&2 "===================== WARNING ======================"
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
In reply to Jagan TekiMark MXS_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
@@ -377,6 +377,7 @@ config MXC_SPI config MXS_SPI bool "MXS SPI Driver" + select BROKEN help Enable the MXS SPI controller driver. This driver can be used on the i.MX23 and i.MX28 SoCs.
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
But the code is not broken, it works fine, right ?
Quoted 21 lines
Cc Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Michael Trimarchi <[email protected]>Signed-off-by Jagan Teki <[email protected]>--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/spi/Kconfig +1
-0@@ -377,6 +377,7 @@ config MXC_SPI config MXS_SPI bool "MXS SPI Driver" + select BROKEN help Enable the MXS SPI controller driver. This driver can be used on the i.MX23 and i.MX28 SoCs.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the CONFIG_BROKEN can mark the driver configs which doesn't convert dm yet, so the associated code will drop wrt MIGRATION deadline (similar like what we showed on the Makefile before).
It is something like caution, before dropping it as suggested Tom.
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dm
That makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 5 lines
yet, so the associated code will drop wrt MIGRATION deadline (similar like what we showed on the
Makefilebefore).It is something like caution, before dropping it as suggested Tom.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 9 lines · Marek Vasut
Quoted 7 lines · Jagan Teki
Quoted 6 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 12 lines · Jagan Teki
Quoted 11 lines · Marek Vasut
Quoted 9 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The Makefile warnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.
All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUD Makefile warnings are also easy enough to miss if you're just automating the build and not doing it manually.
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190429/ccd42d22/attachment.sig>
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 53 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUDMakefilewarnings are also easy enough to miss if you're just automating the build and not doing it manually.
Quoted 5 lines
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Seems there was some offer from Amarula to convert it , no ?
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Hi Marek
Quoted 55 lines · Marek Vasut
Quoted 53 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUDMakefilewarnings are also easy enough to miss if you're just automating the build and not doing it manually.
Quoted 8 lines
Quoted 5 lines
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
Michael
Quoted 3 lines
--
Best regards,
Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 64 lines · Michael Nazzareno Trimarchi
Hi Marek
Quoted 61 lines · Marek Vasut
Quoted 58 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUDMakefilewarnings are also easy enough to miss if you're just automating the build and not doing it manually.But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.
Quoted 4 lines
Quoted 1 line
Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
OK, good. Can you and Marek please coordinate on:
- Updating MAINTAINERS files
- Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?).
And Michael, can you please subscribe to the u-boot-maintainers list?
Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190429/aa6c9007/attachment.sig>
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 67 lines · Tom Rini
Quoted 66 lines · Michael Nazzareno Trimarchi
Hi Marek
Quoted 62 lines · Marek Vasut
Quoted 53 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUDMakefilewarnings are also easy enough to miss if you're just automating the build and not doing it manually.Quoted 5 lines
But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.Seems there was some offer from Amarula to convert it , no ?
Quoted 8 lines
Quoted 2 lines
we can do some job on imx28 because we have a board there. I have asked to mainline it
OK, good. Can you and Marek please coordinate on:
- UpdatingMAINTAINERSfiles
- Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?).
Might make sense to keep the MX28EVK, I'll ask about the other boards, but I think they could be dropped.
Quoted 5 lines
And Michael, can you please subscribe to the u-boot-maintainers list?
Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
In reply to Tom Rini+ Akash
Quoted 77 lines · Tom Rini
Quoted 64 lines · Michael Nazzareno Trimarchi
Hi Marek
Quoted 61 lines · Marek Vasut
Quoted 58 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.All that said, I continue to be open to delaying conversion / removal if we're having:
- A discussion and proposed patches to do the conversion, but people need more time. The work is in progress, but people need time as it's not as easy to convert as hoped for various reasons.
- A problem converting the driver to DM as it's highlighting some other problem within DM or hitting a size constraint or other problem.
- Someone who is willing to do the DM work is just now seeing this. Yes, this is possible especially since our LOUDMakefilewarnings are also easy enough to miss if you're just automating the build and not doing it manually.But I am not fine with:
- Code that isn't converted AND
- Code that no one seems to be converting AND
- Code that no one says they are going to convert AND
- The conversion deadline has past.Quoted 4 lines
Quoted 1 line
Seems there was some offer from Amarula to convert it , no ?
we can do some job on imx28 because we have a board there. I have asked to mainline it
OK, good. Can you and Marek please coordinate on:
- UpdatingMAINTAINERSfiles
- Dropping the boards that won't be supported moving forward (even if you can't mainline the custom board, there must be a ref platform you have/use, yes?).
Quoted 4 lines
And Michael, can you please subscribe to the u-boot-maintainers list?
Jagan, was there an old patch to try and convert this driver that may be of help to Michael? Thanks!
I have asked previous version[1] author, Akash. He said he is going to send the next version. He don't have hardware to test, but Michael or someone can test his change, thanks.
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
In reply to Tom RiniQuoted 28 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.
Quoted 5 lines
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
Quoted 8 lines
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 49 lines · Jagan Teki
Quoted 28 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.Quoted 5 lines
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
Quoted 8 lines
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.
Quoted 3 lines
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is
https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yank CONFIG_SPI for example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols to Kconfig in order to be able to properly express "You need to depend on BROKEN to use this option now".
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190514/c0be28bf/attachment.sig>
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 54 lines · Tom Rini
Quoted 49 lines · Jagan Teki
Quoted 28 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.Quoted 5 lines
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
Quoted 8 lines
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.Quoted 3 lines
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
Quoted 12 lines
What I'm after is
https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yankCONFIG_SPIfor example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols toKconfigin order to be able to properly express "You need to depend on BROKEN to use this option now".
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive Kconfig option please.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 68 lines · Marek Vasut
Quoted 54 lines · Tom Rini
Quoted 49 lines · Jagan Teki
Quoted 28 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.Quoted 5 lines
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
Quoted 8 lines
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.Quoted 3 lines
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
Quoted 12 lines
What I'm after is
https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yankCONFIG_SPIfor example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols toKconfigin order to be able to properly express "You need to depend on BROKEN to use this option now".
Quoted 3 lines
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive
Kconfigoption please.
I also still disagree, but, fine, I'll add CONFIG_DEPRECATED.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190514/a8b1a33f/attachment.sig>
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 69 lines · Tom Rini
Quoted 68 lines · Marek Vasut
Quoted 66 lines · Tom Rini
Quoted 49 lines · Jagan Teki
Quoted 28 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.Quoted 5 lines
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
Quoted 8 lines
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.Quoted 3 lines
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is
https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yankCONFIG_SPIfor example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols toKconfigin order to be able to properly express "You need to depend on BROKEN to use this option now".
Quoted 5 lines
Quoted 3 lines
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive
Kconfigoption please.I also still disagree, but, fine, I'll add
CONFIG_DEPRECATED.
CONFIG_DM_NEED_MIGRATION or something ?
Signature · 2 lines
Best regards, Marek Vasut
PATCH 4/8 spi: Kconfig: Mark MXS_SPI has BROKEN
Quoted 70 lines · Marek Vasut
Quoted 69 lines · Tom Rini
Quoted 68 lines · Marek Vasut
Quoted 66 lines · Tom Rini
Quoted 49 lines · Jagan Teki
Quoted 28 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Jagan Teki
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Jagan Teki
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Jagan Teki
Mark
MXS_SPIhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.But the code is not broken, it works fine, right ?
Yes the code work fine, but dm conversion not done yet. Now the
CONFIG_BROKENcan mark the driver configs which doesn't convert dmThat makes no sense, if the code works, it works and thus it is NOT broken. Find some other way to flag it as non-DM-converted, not this hack.
Quoted 6 lines
Quoted 2 lines
np, It depends on whether we consider non-dm code(for legacy SPI drivers) is broken or not, let Tom comment on this.
Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload
CONFIG_BROKENfor such things. TheMakefilewarning seems sufficient to me.Quoted 5 lines
The code is broken because it doesn't work with DM and is going to be removed due to lack of maintenance soon. My problem with this series, but I need to check that we can do what I want to do and still keep travis green, is have this (and the other non-converted and thus non-maintained drivers) depend on, not select BROKEN.
Yes, the idea here is to build the broken one by selecting BROKEN so-that the travis-CI is green and have warning on the build, otherwise it is another rework of selecting BROKEN for those non-converted drivers if they depends.
Quoted 8 lines
The
Makefilewarnings tell people the code is going to be removed and I'm trying to have the window be:
1) LOUD warning about needing work
2) 1 release past those loud deadlines of the code there, but not built unless you enable BROKEN (as yes, I see code that's not updated to use DM as being broken)
3) Code removed.Quoted 3 lines
ie what this series does. Driver (for example) will select BROKEN, that means it is still working bu would like to remove in next versions and so..
What I'm after is
https://github.com/trini/u-boot/commits/WIP-BROKEN-test which is close, but not quite there. We no longer build the drivers marked as BROKEN by default, and the fallout from that has been:
- Some missing dependencies (I'm trying to fix that now) leading to build problems.
- Needing to yankCONFIG_SPIfor example from configs that had been using a now-not-built driver as the subsystem fails to link if there's no controller. I don't think that's a problem however.
- Needing to migrate a few more symbols toKconfigin order to be able to properly express "You need to depend on BROKEN to use this option now".
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
I still disagree with marking drivers that need DM conversion, but are otherwise working perfectly fine, as broken. That's just misleading and in fact incorrect. Invent some new, more descriptive
Kconfigoption please.I also still disagree, but, fine, I'll add
CONFIG_DEPRECATED.
CONFIG_DM_NEED_MIGRATIONor something ?
No, I think given the definition of deprecated:
"to withdraw official support for or discourage the use of (something, such as a software product) in favor of a newer or better alternative" (from https://www.merriam-webster.com/dictionary/deprecated) this is good enough.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190514/9a998e2c/attachment.sig>
PATCH 5/8 spi: Kconfig: Mark SH_SPI has BROKEN
In reply to Jagan TekiMark SH_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
@@ -348,6 +348,7 @@ config DAVINCI_SPI config SH_SPI bool "SuperH SPI driver" + select BROKEN help Enable the SuperH SPI controller driver. This driver can be used on various SuperH SoCs, such as SH7757.
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 6/8 spi: Kconfig: Mark SOFT_SPI has BROKEN
In reply to Jagan TekiMark SOFT_SPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
@@ -308,6 +308,7 @@ endif # if DM_SPI config SOFT_SPI bool "Soft SPI driver" + select BROKEN if !DM_SPI help Enable Soft SPI driver. This driver is to use GPIO simulate the SPI protocol.
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 7/8 spi: Kconfig: Mark FSL_ESPI has BROKEN
In reply to Jagan TekiMark FSL_ESPI has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
@@ -328,6 +328,7 @@ config CF_SPI config FSL_ESPI bool "Freescale eSPI driver" + select BROKEN help Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 8/8 spi: Kconfig: Mark LPC32XX_SSP has BROKEN
In reply to Jagan TekiMark LPC32XX_SSP has BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.
--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
@@ -369,6 +369,7 @@ config KIRKWOOD_SPI config LPC32XX_SSP bool "LPC32XX SPI Driver" + select BROKEN help Enable support for SPI on LPC32xx
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH 8/8 spi: Kconfig: Mark LPC32XX_SSP has BROKEN
Hi Jagan,
Quoted 17 lines · Jagan Teki
Mark
LPC32XX_SSPhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.Cc Vladimir Zapolskiy <[email protected]>Cc Albert ARIBAUD <[email protected]>Signed-off-by Jagan Teki <[email protected]>--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/spi/Kconfig +0
-0
drivers/spi/Kconfig config KIRKWOOD_SPI · line 375
Quoted 7 lines
drivers/spi/Kconfig +1
-0@@ -369,6 +369,7 @@ config KIRKWOOD_SPI config LPC32XX_SSP bool "LPC32XX SPI Driver" + select BROKEN help Enable support for SPI on LPC32xx
Thank you for the change, as we've discussed earlier I won't have objections against the driver removal when time is up.
Thus you can locally prepare a removal change in advance, the one which you've sent earlier needs a minor update, please also remove lpc32xx_ssp_init() function and its usage in the board files.
--
Best wishes,
Vladimir
PATCH 8/8 spi: Kconfig: Mark LPC32XX_SSP has BROKEN
Quoted 41 lines · Vladimir Zapolskiy
Hi Jagan,
Quoted 17 lines · Jagan Teki
Mark
LPC32XX_SSPhas BROKEN, this so the resulting build shows warning for broken configuration enabled and associated code will remove in v2019.07 release.Cc Vladimir Zapolskiy <[email protected]>Cc Albert ARIBAUD <[email protected]>Signed-off-by Jagan Teki <[email protected]>--- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/spi/Kconfig +0
-0drivers/spi/Kconfig config KIRKWOOD_SPI · line 375
Quoted 7 lines
drivers/spi/Kconfig +1
-0@@ -369,6 +369,7 @@ config KIRKWOOD_SPI config LPC32XX_SSP bool "LPC32XX SPI Driver" + select BROKEN help Enable support for SPI on LPC32xxThank you for the change, as we've discussed earlier I won't have objections against the driver removal when time is up.
Thus you can locally prepare a removal change in advance, the one which you've sent earlier needs a minor update, please also remove
lpc32xx_ssp_init()function and its usage in the board files.--
Best wishes,
Vladimir