wavpack: needs wchar support
PATCH 1/2 wavpack: needs wchar support
Building wavpack using a toolchain without wchar support fails:
``` import_id3.c:37:34: error: unknown type name 'wchar_t' ```
Fixes:
http://autobuild.buildroot.net/results/9a6/9a693f5b798571917f36cfb7661e2f2638aac550/
http://autobuild.buildroot.net/results/44c/44c8227043045baf4f043da44b8129e43dfff687/
http://autobuild.buildroot.net/results/a80/a80221dcc0860046ebdf0bbf454e056b1e20df83/
.. and more.
--- package/wavpack/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
package/wavpack/Config.in +4 -0
@@ -1,8 +1,12 @@ config BR2_PACKAGE_WAVPACK bool "wavpack" + depends on BR2_USE_WCHAR select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help WavPack is a completely open audio compression format providing lossless, high-quality lossy, and a unique hybrid compression mode. http://www.wavpack.com/ + +comment "wavpack needs a toolchain w/ wchar" + depends on !BR2_USE_WCHAR
Signature · 1 line
2.11.1
PATCH 2/2 wavpack: properly wrap help text
--- package/wavpack/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/wavpack/Config.in +3 -2
@@ -3,8 +3,9 @@ config BR2_PACKAGE_WAVPACK depends on BR2_USE_WCHAR select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help - WavPack is a completely open audio compression format providing - lossless, high-quality lossy, and a unique hybrid compression mode. + WavPack is a completely open audio compression format + providing lossless, high-quality lossy, and a unique + hybrid compression mode. http://www.wavpack.com/
Signature · 1 line
2.11.1
PATCH 1/2 wavpack: needs wchar support
In reply to Jörg KrauseHello,
Quoted 6 lines · J?rg Krause
Building wavpack using a toolchain without wchar support fails:
``` import_id3.c:37:34: error: unknown type name 'wchar_t' ```
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/9a6/9a693f5b798571917f36cfb7661e2f2638aac550/
http://autobuild.buildroot.net/results/44c/44c8227043045baf4f043da44b8129e43dfff687/
http://autobuild.buildroot.net/results/a80/a80221dcc0860046ebdf0bbf454e056b1e20df83/
.. and more.Signed-off-by J?rg Krause <[email protected]>
This dependency is only needed for one specific tool in wavpack added by the recent bump to 5.1.0. So I've reported this issue upstream:
https://github.com/dbry/WavPack/issues/19
But OK, I agree we don't really care if wavpack needs wchar support, so we certainly don't need to wait for the answer to this upstream bug report.
package/wavpack/Config.in line 3
Quoted 8 lines
package/wavpack/Config.in +1
-0@@ -1,8 +1,12 @@ config BR2_PACKAGE_WAVPACK bool "wavpack" + depends on BR2_USE_WCHAR
None of the places that select wavpack need to be fixed for the wchar dependency?
package/gstreamer/gst-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK
package/gstreamer1/gst1-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK package/mpd/Config.in: select BR2_PACKAGE_WAVPACK
From a quick look, it seems to be OK, but it would have been to indicate it in the commit log (and maybe update the comments in those packages to explain why we have the wchar dependency).
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/2 wavpack: needs wchar support
Hi Thomas,
Am Thu, 16 Feb 2017 22:19:07 +0100 schrieb Thomas Petazzoni:
Quoted 4 lines
None of the places that select wavpack need to be fixed for the wchar dependency?
package/gstreamer/gst-plugins-good/Config.in: select
BR2_PACKAGE_WAVPACK
"depends on BR2_USE_WCHAR" needs to be backported, same was valid for BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC.
Quoted 1 line
package/gstreamer1/gst1-plugins-good/Config.in: select
BR2_PACKAGE_WAVPACK
"depends on BR2_USE_WCHAR" needs to be backported, same was valid for BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB.
Quoted 1 line
package/mpd/Config.in: select
BR2_PACKAGE_WAVPACK
mpd itself depends on BR2_USE_WCHAR, no backport needed.
Regards, Bernd
PATCH 1/2 wavpack: needs wchar support
Hi Thomas,
Hi Bernd,
Quoted 17 lines · Bernd Kuhls
Hi Thomas,
Am Thu, 16 Feb 2017 22:19:07 +0100 schrieb Thomas Petazzoni:
Quoted 6 lines
None of the places that select wavpack need to be fixed for the wchar
dependency?package/gstreamer/gst-plugins-good/Config.in:???select
BR2_PACKAGE_WAVPACK"depends on
BR2_USE_WCHAR" needs to be backported, same was valid forBR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC.Quoted 2 lines
package/gstreamer1/gst1-plugins-good/Config.in: select
BR2_PACKAGE_WAVPACK
Quoted 7 lines
"depends on
BR2_USE_WCHAR" needs to be backported, same was valid forBR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB.Quoted 1 line
package/mpd/Config.in:??select
BR2_PACKAGE_WAVPACKmpd itself depends on
BR2_USE_WCHAR, no backport needed.
Upstream committed a fix [1] (thanks to Thomas for reporting the issue) which drops the dependency on wchar. Maybe we should apply this to remove BR2_USE_WCHAR?
[1] https://github.com/dbry/WavPack/commit/876fc3f3907e871d0938ac6c8c5252f5f31abd1f
J?rg
PATCH 1/2 wavpack: needs wchar support
Hello,
Quoted 3 lines · J?rg Krause
Upstream committed a fix [1] (thanks to Thomas for reporting the issue) which drops the dependency on wchar. Maybe we should apply this to remove
BR2_USE_WCHAR?
Yes, it would be best. Could you send a patch for this, of course after checking it really fixes the build for a non-wchar toolchain.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com