mmc: ftsdc010: make command timeout 250 ms as in the comment
PATCH 1/1 mmc: ftsdc010: make command timeout 250 ms as in the comment
Get rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16.
So change code to shift by 2 and make the timeout value 250 ms.
--- drivers/mmc/ftsdc010_mci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/ftsdc010_mci.c +1 -1
@@ -30,7 +30,7 @@#include <syscon.h> #include <linux/err.h> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4)/* 250 ms */ +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2)/* 250 ms */ #define CFG_RST_TIMEOUT CONFIG_SYS_HZ/* 1 sec reset timeout */ #if CONFIG_IS_ENABLED (OF_PLATDATA )
Signature · 1 line
2.34.1
A message that is not in the archive (sent off-list or not yet received): HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com
Rick Chen
Reviewed-byQuoted 18 lines
From: Sergei Antonov <[email protected]>
Sent: Friday, September 02, 2022 3:40 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Rick Jian-Zhi Chen(陳建志) <[email protected]>; Sergei Antonov <[email protected]>
Subject: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the commentGet rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16. So change code to shift by 2 and make the timeout value 250 ms.
Signed-off-by Sergei Antonov <[email protected]>--- drivers/mmc/ftsdc010_mci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/ftsdc010_mci.c line 33
Quoted 5 lines
drivers/mmc/ftsdc010_mci.c +1
-1@@ -30,7 +30,7 @@#include <syscon.h> #include <linux/err.h> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4)/* 250 ms */ +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2)/* 250 ms */
Hi
Quoted 5 lines · Sergei Antonov
Get rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16.
So change code to shift by 2 and make the timeout value 250 ms.Signed-off-by Sergei Antonov <[email protected]>
Best Regards,
Jaehoon Chung
Quoted 17 lines
--- drivers/mmc/ftsdc010_mci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/ftsdc010_mci.c +1
-1@@ -30,7 +30,7 @@#include <syscon.h> #include <linux/err.h> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4)/* 250 ms */ +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2)/* 250 ms */ #define CFG_RST_TIMEOUT CONFIG_SYS_HZ/* 1 sec reset timeout */ #if CONFIG_IS_ENABLED (OF_PLATDATA )
Quoted 7 lines · Sergei Antonov
Get rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16.
So change code to shift by 2 and make the timeout value 250 ms.Signed-off-by Sergei Antonov <[email protected]>Reviewed-by Rick Chen <[email protected]>Reviewed-by Jaehoon Chung <[email protected]>
Applied to u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
Quoted 17 lines
--- drivers/mmc/ftsdc010_mci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/ftsdc010_mci.c +1
-1@@ -30,7 +30,7 @@#include <syscon.h> #include <linux/err.h> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4)/* 250 ms */ +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2)/* 250 ms */ #define CFG_RST_TIMEOUT CONFIG_SYS_HZ/* 1 sec reset timeout */ #if CONFIG_IS_ENABLED (OF_PLATDATA )