Baby steps towards saner headers
Subsystems (14)
v4 cover Baby steps towards saner headers
Back in 2016, we discussed rules for headers, and these were generally liked:
1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h. If exceptions are needed for some reason, they must be documented in the header. If all that's needed from a header is typedefs, put those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
Message-ID: <[email protected]>
http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
Trouble is we're not exactly close to obeying 2. This series demonstrates a possible path towards obeying it: enforce it in "make check", except for known-bad headers. We can then whittle down known-bad headers step by step in future patches.
PATCH 1-4 are preparatory build system improvements. I think they are useful by themselves. If reviewers agree, I can extract them into their own non-RFC series.
PATCH 5 adds the tests, but only for include/. 764 headers, 179 known-bad. We may decide to clean up include/ some before we apply PATCH 6+7.
PATCH 6 extends them to all headers, except for generated ones. Adds 797 headers, 409 known-bad.
PATCH 7 extends them to generated headers. Adds 177 headers, 3 known-bad.
Known issues:
(1) More testing needed.
(2) PATCH 7 has a FIXME on computation of generated target-dependent headers.
(3) Some "known-bad" headers aren't actually bad, but intended for special configurations only. The test should be taught how to test these correctly.
We obviously want (1) before we merge the test.
I think we can and should address (3) when we whittle down known-bad headers in future patches.
I think leaving PATCH 6-7 for later would make sense. No need to crack (2) right now then.
Please have a look and tell me what you think.
v4:
* PATCH 1-4: New.
* PATCH 5:
- Implement testing of target-dependent headers
- Replace crude "expected to fail with WIN32" by a set of "expected to fail without FOO".
* Old PATCH 3-5: Dropped. These were examples for whittling down known-bad headers.
v3:
* Old PATH 1 moved to another series
* PATCH 1:
- Skip the test unless $(SRC_PATH)/.git exists
- Exclude third-party headers [Peter]
- Exclude Coccinelle header
- Fix egrep vs. fgrep typos
- Mark and exclude headers that die due to poison.h, because testing them isn't implemented, yet
- tests/header-test-template.c not omitted (d'oh)
* PATCH 3: Replaced
* PATCH 5: New
v2:
* PATCH 2:
- Use fixed-format FIXME comments in headers instead of a blacklist in the makefile [Paolo]
- Make target check-source [Peter]
- Special-case CONFIG_WIN32
* PATCH 3:
- replaced by an unrelated one that makes actual sense (I hope)
Markus Armbruster (7):
Makefile: Remove code to smooth transition to config.status
Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def
Makefile: Rename targets for make recursion
Makefile: Reuse all's recursion machinery for clean and install
tests: New make target check-source
tests: Don't limit check-headers to include/
tests: Make check-source cover generated headers
Makefile | 75 +++++++++++----------- Makefile.target | 19 ++++++ accel/tcg/atomic_template.h | 3 + accel/tcg/tcg-runtime.h | 3 + accel/tcg/translate-all.h | 4 ++ audio/audio_int.h | 2 + audio/audio_template.h | 2 + audio/audio_win_int.h | 2 + audio/dsound_template.h | 3 + audio/mixeng_template.h | 2 + audio/rate_template.h | 2 + block/crypto.h | 2 + block/qcow2.h | 2 + block/vhdx.h | 2 + bsd-user/i386/target_signal.h | 3 + bsd-user/i386/target_syscall.h | 2 + bsd-user/qemu.h | 4 ++ bsd-user/sparc/target_signal.h | 3 + bsd-user/sparc/target_syscall.h | 2 + bsd-user/sparc64/target_signal.h | 3 + bsd-user/sparc64/target_syscall.h | 2 + bsd-user/syscall_defs.h | 2 + bsd-user/x86_64/target_signal.h | 3 + bsd-user/x86_64/target_syscall.h | 2 + configure | 6 +- contrib/ivshmem-client/ivshmem-client.h | 2 + contrib/ivshmem-server/ivshmem-server.h | 2 + contrib/libvhost-user/libvhost-user-glib.h | 2 + contrib/libvhost-user/libvhost-user.h | 2 + contrib/rdmacm-mux/rdmacm-mux.h | 2 + crypto/afalgpriv.h | 2 + crypto/cipherpriv.h | 2 + crypto/hashpriv.h | 2 + crypto/hmacpriv.h | 2 + disas/nanomips.h | 2 + fpu/softfloat-specialize.h | 3 + fsdev/file-op-9p.h | 2 + fsdev/qemu-fsdev.h | 3 + hw/9pfs/9p-local.h | 2 + hw/9pfs/9p-proxy.h | 2 + hw/9pfs/9p-synth.h | 2 + hw/9pfs/9p-util.h | 2 + hw/9pfs/9p-xattr.h | 2 + hw/9pfs/9p.h | 2 + hw/9pfs/coth.h | 2 + hw/9pfs/virtio-9p.h | 2 + hw/9pfs/xen-9pfs.h | 3 +- hw/arm/smmu-internal.h | 2 + hw/arm/smmuv3-internal.h | 2 + hw/audio/hda-codec-common.h | 3 +- hw/audio/lm4549.h | 2 + hw/block/dataplane/xen-block.h | 2 + hw/block/nvme.h | 2 + hw/block/xen_blkif.h | 2 + hw/cris/boot.h | 2 + hw/display/ati_int.h | 2 + hw/display/cirrus_vga_internal.h | 2 + hw/display/cirrus_vga_rop.h | 2 + hw/display/cirrus_vga_rop2.h | 2 + hw/display/framebuffer.h | 2 + hw/display/milkymist-vgafb_template.h | 3 +- hw/display/omap_lcd_template.h | 3 + hw/display/pl110_template.h | 2 + hw/display/pxa2xx_template.h | 2 + hw/display/qxl.h | 4 ++ hw/display/sm501_template.h | 2 + hw/display/tc6393xb_template.h | 2 + hw/display/vga-helpers.h | 2 + hw/display/vga_int.h | 2 + hw/ide/ahci_internal.h | 2 + hw/input/adb-internal.h | 2 + hw/lm32/lm32.h | 2 + hw/lm32/lm32_hwsetup.h | 3 + hw/lm32/milkymist-hw.h | 2 + hw/microblaze/boot.h | 2 + hw/net/can/can_sja1000.h | 3 + hw/net/e1000e_core.h | 2 + hw/net/e1000x_common.h | 2 + hw/net/pcnet.h | 2 + hw/net/rocker/rocker_desc.h | 2 + hw/net/rocker/rocker_fp.h | 2 + hw/net/rocker/rocker_of_dpa.h | 2 + hw/net/rocker/rocker_tlv.h | 2 + hw/net/rocker/rocker_world.h | 2 + hw/net/vmware_utils.h | 2 + hw/net/vmxnet3_defs.h | 3 +- hw/nios2/boot.h | 3 + hw/ppc/ppc405.h | 2 + hw/ppc/ppc440.h | 2 + hw/rdma/rdma_backend.h | 2 + hw/rdma/rdma_backend_defs.h | 2 + hw/rdma/rdma_rm.h | 2 + hw/rdma/rdma_rm_defs.h | 2 + hw/rdma/vmw/pvrdma.h | 2 + hw/rdma/vmw/pvrdma_dev_ring.h | 2 + hw/rdma/vmw/pvrdma_qp_ops.h | 2 + hw/s390x/ccw-device.h | 3 + hw/s390x/ipl.h | 3 + hw/s390x/s390-pci-bus.h | 3 + hw/s390x/s390-pci-inst.h | 3 + hw/s390x/s390-virtio-hcall.h | 2 + hw/s390x/virtio-ccw.h | 3 + hw/scsi/mptsas.h | 2 + hw/scsi/viosrp.h | 3 + hw/sd/sdhci-internal.h | 3 + hw/timer/m48t59-internal.h | 2 + hw/tpm/tpm_ioctl.h | 2 + hw/usb/desc.h | 2 + hw/usb/hcd-ohci.h | 2 + hw/usb/hcd-xhci.h | 2 + hw/usb/quirks.h | 2 + hw/vfio/pci.h | 3 + hw/xen/xen_pt.h | 2 + hw/xtensa/bootparam.h | 2 + hw/xtensa/xtensa_memory.h | 3 + include/block/raw-aio.h | 3 + include/block/write-threshold.h | 3 + include/chardev/char-win.h | 3 + include/chardev/spice.h | 2 + include/disas/disas.h | 2 + include/exec/cpu-all.h | 4 ++ include/exec/cpu-defs.h | 4 ++ include/exec/cpu_ldst.h | 4 ++ include/exec/cpu_ldst_template.h | 3 + include/exec/cpu_ldst_useronly_template.h | 3 + include/exec/cputlb.h | 3 + include/exec/exec-all.h | 3 + include/exec/gen-icount.h | 2 + include/exec/helper-gen.h | 2 + include/exec/helper-proto.h | 2 + include/exec/helper-tcg.h | 2 + include/exec/ioport.h | 2 + include/exec/memory-internal.h | 2 + include/exec/memory_ldst.inc.h | 2 + include/exec/memory_ldst_cached.inc.h | 2 + include/exec/memory_ldst_phys.inc.h | 2 + include/exec/ram_addr.h | 3 + include/exec/softmmu-semi.h | 3 + include/exec/tb-hash.h | 3 + include/exec/tb-lookup.h | 3 + include/exec/translator.h | 3 + include/exec/user/abitypes.h | 2 + include/exec/user/thunk.h | 4 ++ include/fpu/softfloat-macros.h | 2 + include/fpu/softfloat.h | 2 + include/hw/acpi/piix4.h | 2 + include/hw/acpi/tco.h | 3 + include/hw/adc/stm32f2xx_adc.h | 2 + include/hw/arm/allwinner-a10.h | 2 + include/hw/arm/armsse.h | 3 + include/hw/arm/armv7m.h | 3 + include/hw/arm/aspeed_soc.h | 2 + include/hw/arm/bcm2835_peripherals.h | 2 + include/hw/arm/bcm2836.h | 2 + include/hw/arm/digic.h | 3 + include/hw/arm/fsl-imx25.h | 2 + include/hw/arm/fsl-imx31.h | 2 + include/hw/arm/fsl-imx6.h | 3 + include/hw/arm/fsl-imx6ul.h | 3 + include/hw/arm/fsl-imx7.h | 3 + include/hw/arm/msf2-soc.h | 3 + include/hw/arm/nrf51_soc.h | 3 + include/hw/arm/omap.h | 3 + include/hw/arm/sharpsl.h | 3 + include/hw/arm/stm32f205_soc.h | 3 + include/hw/arm/xlnx-zynqmp.h | 2 + include/hw/block/fdc.h | 2 + include/hw/block/flash.h | 2 + include/hw/char/escc.h | 2 + include/hw/char/xilinx_uartlite.h | 2 + include/hw/core/generic-loader.h | 2 + include/hw/cris/etraxfs.h | 2 + include/hw/cris/etraxfs_dma.h | 2 + include/hw/display/bcm2835_fb.h | 2 + include/hw/display/i2c-ddc.h | 2 + include/hw/display/xlnx_dp.h | 2 + include/hw/dma/xlnx_dpdma.h | 2 + include/hw/elf_ops.h | 2 + include/hw/empty_slot.h | 2 + include/hw/gpio/bcm2835_gpio.h | 2 + include/hw/hyperv/hyperv.h | 2 + include/hw/i2c/aspeed_i2c.h | 3 + include/hw/i386/apic_internal.h | 3 + include/hw/i386/ioapic_internal.h | 2 + include/hw/input/hid.h | 2 + include/hw/input/tsc2xxx.h | 2 + include/hw/intc/allwinner-a10-pic.h | 2 + include/hw/intc/armv7m_nvic.h | 3 + include/hw/intc/heathrow_pic.h | 2 + include/hw/intc/mips_gic.h | 3 + include/hw/isa/vt82c686.h | 2 + include/hw/kvm/clock.h | 4 +- include/hw/mips/bios.h | 2 + include/hw/mips/cps.h | 3 + include/hw/mips/cpudevs.h | 2 + include/hw/misc/bcm2835_property.h | 2 + include/hw/misc/macio/cuda.h | 2 + include/hw/misc/macio/gpio.h | 2 + include/hw/misc/macio/macio.h | 2 + include/hw/misc/macio/pmu.h | 2 + include/hw/misc/mips_cmgcr.h | 2 + include/hw/misc/mips_cpc.h | 2 + include/hw/misc/pvpanic.h | 3 + include/hw/net/allwinner_emac.h | 2 + include/hw/net/lance.h | 2 + include/hw/nvram/chrp_nvram.h | 2 + include/hw/pci-bridge/simba.h | 2 + include/hw/pci-host/sabre.h | 2 + include/hw/pci-host/spapr.h | 3 + include/hw/pci-host/uninorth.h | 2 + include/hw/pci/pcie_aer.h | 2 + include/hw/ppc/fdt.h | 2 + include/hw/ppc/pnv.h | 2 + include/hw/ppc/pnv_core.h | 2 + include/hw/ppc/pnv_xscom.h | 2 + include/hw/ppc/ppc.h | 2 + include/hw/ppc/ppc4xx.h | 2 + include/hw/ppc/spapr.h | 3 + include/hw/ppc/spapr_cpu_core.h | 4 ++ include/hw/ppc/spapr_irq.h | 2 + include/hw/ppc/spapr_ovec.h | 2 + include/hw/ppc/spapr_vio.h | 2 + include/hw/ppc/spapr_xive.h | 2 + include/hw/ppc/xics_spapr.h | 3 + include/hw/ppc/xive_regs.h | 2 + include/hw/riscv/riscv_hart.h | 2 + include/hw/riscv/riscv_htif.h | 3 + include/hw/riscv/sifive_clint.h | 2 + include/hw/riscv/sifive_e.h | 2 + include/hw/riscv/sifive_plic.h | 2 + include/hw/riscv/sifive_prci.h | 2 + include/hw/riscv/sifive_test.h | 2 + include/hw/riscv/sifive_u.h | 2 + include/hw/riscv/sifive_uart.h | 2 + include/hw/riscv/spike.h | 2 + include/hw/riscv/virt.h | 2 + include/hw/s390x/3270-ccw.h | 3 + include/hw/s390x/ap-device.h | 3 + include/hw/s390x/css-bridge.h | 2 + include/hw/s390x/css.h | 3 + include/hw/s390x/s390-ccw.h | 3 + include/hw/s390x/storage-attributes.h | 3 + include/hw/s390x/tod.h | 2 + include/hw/s390x/vfio-ccw.h | 3 + include/hw/sh4/sh.h | 2 + include/hw/sh4/sh_intc.h | 2 + include/hw/sparc/grlib.h | 2 + include/hw/sparc/sparc64.h | 1 + include/hw/ssi/aspeed_smc.h | 2 + include/hw/ssi/xilinx_spips.h | 2 + include/hw/timer/allwinner-a10-pit.h | 2 + include/hw/timer/i8254_internal.h | 2 + include/hw/timer/m48t59.h | 2 + include/hw/timer/mc146818rtc.h | 2 + include/hw/timer/mc146818rtc_regs.h | 2 + include/hw/timer/sun4v-rtc.h | 2 + include/hw/timer/xlnx-zynqmp-rtc.h | 2 + include/hw/vfio/vfio-amd-xgbe.h | 2 + include/hw/vfio/vfio-calxeda-xgmac.h | 2 + include/hw/vfio/vfio-common.h | 2 + include/hw/vfio/vfio-platform.h | 2 + include/hw/virtio/virtio-access.h | 3 + include/hw/virtio/virtio-gpu.h | 2 + include/hw/virtio/virtio-input.h | 2 + include/hw/virtio/virtio-rng.h | 2 + include/hw/xen/io/ring.h | 2 + include/hw/xen/xen-backend.h | 2 + include/hw/xen/xen-block.h | 2 + include/hw/xen/xen-bus-helper.h | 2 + include/hw/xen/xen-bus.h | 2 + include/hw/xen/xen-legacy-backend.h | 2 + include/hw/xen/xen_common.h | 2 + include/hw/xen/xen_pvdev.h | 2 + include/libdecnumber/decNumberLocal.h | 2 + include/migration/cpu.h | 4 ++ include/monitor/hmp-target.h | 3 + include/qemu/atomic128.h | 2 + include/qemu/futex.h | 2 + include/qemu/ratelimit.h | 2 + include/qemu/thread-win32.h | 2 + include/qemu/xattr.h | 3 + include/sysemu/balloon.h | 2 + include/sysemu/cryptodev-vhost-user.h | 3 + include/sysemu/dump.h | 2 + include/sysemu/hvf.h | 3 + include/sysemu/iothread.h | 2 + include/sysemu/kvm_int.h | 2 + include/sysemu/memory_mapping.h | 2 + include/sysemu/os-posix.h | 2 + include/sysemu/os-win32.h | 2 + include/sysemu/xen-mapcache.h | 2 + include/trace-tcg.h | 2 + include/ui/console.h | 2 + include/ui/egl-context.h | 3 + include/ui/egl-helpers.h | 2 + include/ui/gtk.h | 2 + include/ui/input.h | 2 + include/ui/pixel_ops.h | 2 + include/ui/qemu-pixman.h | 2 + include/ui/sdl2.h | 2 + include/ui/shader.h | 2 + include/ui/spice-display.h | 2 + linux-user/aarch64/target_cpu.h | 3 + linux-user/aarch64/target_fcntl.h | 3 + linux-user/aarch64/target_signal.h | 2 + linux-user/aarch64/target_structs.h | 3 + linux-user/aarch64/target_syscall.h | 3 + linux-user/aarch64/termbits.h | 2 + linux-user/alpha/target_cpu.h | 3 + linux-user/alpha/target_fcntl.h | 3 + linux-user/alpha/target_signal.h | 2 + linux-user/alpha/target_structs.h | 3 + linux-user/alpha/target_syscall.h | 2 + linux-user/alpha/termbits.h | 2 + linux-user/arm/nwfpe/fpa11.h | 3 + linux-user/arm/nwfpe/fpopcode.h | 2 + linux-user/arm/target_cpu.h | 3 + linux-user/arm/target_fcntl.h | 3 + linux-user/arm/target_signal.h | 2 + linux-user/arm/target_structs.h | 3 + linux-user/arm/target_syscall.h | 3 + linux-user/arm/termbits.h | 2 + linux-user/cpu_loop-common.h | 3 + linux-user/cris/target_cpu.h | 3 + linux-user/cris/target_fcntl.h | 3 + linux-user/cris/target_signal.h | 2 + linux-user/cris/target_structs.h | 3 + linux-user/cris/termbits.h | 2 + linux-user/fd-trans.h | 2 + linux-user/flat.h | 2 + linux-user/generic/fcntl.h | 3 + linux-user/host/aarch64/hostdep.h | 2 + linux-user/host/arm/hostdep.h | 2 + linux-user/host/i386/hostdep.h | 2 + linux-user/host/ppc64/hostdep.h | 2 + linux-user/host/riscv64/hostdep.h | 2 + linux-user/host/s390x/hostdep.h | 2 + linux-user/host/x86_64/hostdep.h | 2 + linux-user/hppa/target_cpu.h | 3 + linux-user/hppa/target_fcntl.h | 3 + linux-user/hppa/target_signal.h | 2 + linux-user/hppa/target_structs.h | 3 + linux-user/hppa/target_syscall.h | 2 + linux-user/hppa/termbits.h | 2 + linux-user/i386/target_cpu.h | 3 + linux-user/i386/target_fcntl.h | 3 + linux-user/i386/target_signal.h | 2 + linux-user/i386/target_structs.h | 3 + linux-user/i386/target_syscall.h | 2 + linux-user/i386/termbits.h | 2 + linux-user/ioctls.h | 2 + linux-user/linux_loop.h | 2 + linux-user/m68k/target_cpu.h | 2 + linux-user/m68k/target_elf.h | 2 + linux-user/m68k/target_fcntl.h | 3 + linux-user/m68k/target_signal.h | 2 + linux-user/m68k/target_structs.h | 3 + linux-user/m68k/target_syscall.h | 2 + linux-user/m68k/termbits.h | 2 + linux-user/microblaze/target_cpu.h | 3 + linux-user/microblaze/target_fcntl.h | 3 + linux-user/microblaze/target_signal.h | 2 + linux-user/microblaze/target_structs.h | 3 + linux-user/microblaze/termbits.h | 2 + linux-user/mips/target_cpu.h | 3 + linux-user/mips/target_elf.h | 2 + linux-user/mips/target_fcntl.h | 3 + linux-user/mips/target_signal.h | 3 + linux-user/mips/target_structs.h | 3 + linux-user/mips/target_syscall.h | 2 + linux-user/mips/termbits.h | 2 + linux-user/mips64/syscall_nr.h | 2 + linux-user/mips64/target_cpu.h | 3 + linux-user/mips64/target_elf.h | 2 + linux-user/mips64/target_fcntl.h | 3 + linux-user/mips64/target_signal.h | 2 + linux-user/mips64/target_structs.h | 2 + linux-user/mips64/target_syscall.h | 2 + linux-user/mips64/termbits.h | 2 + linux-user/nios2/target_cpu.h | 2 + linux-user/nios2/target_fcntl.h | 3 + linux-user/nios2/target_signal.h | 2 + linux-user/nios2/target_structs.h | 3 + linux-user/nios2/termbits.h | 2 + linux-user/openrisc/target_cpu.h | 2 + linux-user/openrisc/target_fcntl.h | 3 + linux-user/openrisc/target_signal.h | 2 + linux-user/openrisc/target_structs.h | 3 + linux-user/openrisc/target_syscall.h | 3 + linux-user/openrisc/termbits.h | 2 + linux-user/ppc/syscall_nr.h | 3 + linux-user/ppc/target_cpu.h | 4 ++ linux-user/ppc/target_elf.h | 2 + linux-user/ppc/target_fcntl.h | 3 + linux-user/ppc/target_signal.h | 3 + linux-user/ppc/target_structs.h | 3 + linux-user/ppc/target_syscall.h | 3 + linux-user/ppc/termbits.h | 2 + linux-user/qemu.h | 2 + linux-user/riscv/target_cpu.h | 2 + linux-user/riscv/target_fcntl.h | 3 + linux-user/riscv/target_signal.h | 2 + linux-user/riscv/target_structs.h | 3 + linux-user/riscv/target_syscall.h | 2 + linux-user/riscv/termbits.h | 2 + linux-user/s390x/syscall_nr.h | 2 + linux-user/s390x/target_cpu.h | 3 + linux-user/s390x/target_fcntl.h | 3 + linux-user/s390x/target_signal.h | 2 + linux-user/s390x/target_structs.h | 3 + linux-user/s390x/target_syscall.h | 2 + linux-user/s390x/termbits.h | 2 + linux-user/sh4/target_cpu.h | 3 + linux-user/sh4/target_fcntl.h | 3 + linux-user/sh4/target_signal.h | 2 + linux-user/sh4/target_structs.h | 3 + linux-user/sh4/target_syscall.h | 2 + linux-user/sh4/termbits.h | 2 + linux-user/signal-common.h | 3 + linux-user/socket.h | 2 + linux-user/sparc/target_cpu.h | 4 ++ linux-user/sparc/target_elf.h | 2 + linux-user/sparc/target_fcntl.h | 3 + linux-user/sparc/target_signal.h | 2 + linux-user/sparc/target_structs.h | 3 + linux-user/sparc/target_syscall.h | 2 + linux-user/sparc/termbits.h | 2 + linux-user/sparc64/target_cpu.h | 3 + linux-user/sparc64/target_fcntl.h | 3 + linux-user/sparc64/target_signal.h | 2 + linux-user/sparc64/target_structs.h | 3 + linux-user/sparc64/target_syscall.h | 3 + linux-user/sparc64/termbits.h | 2 + linux-user/syscall_defs.h | 2 + linux-user/syscall_types.h | 2 + linux-user/tilegx/target_cpu.h | 3 + linux-user/tilegx/target_fcntl.h | 3 + linux-user/tilegx/target_signal.h | 2 + linux-user/tilegx/target_structs.h | 3 + linux-user/tilegx/target_syscall.h | 2 + linux-user/uname.h | 2 + linux-user/x86_64/target_cpu.h | 3 + linux-user/x86_64/target_fcntl.h | 3 + linux-user/x86_64/target_signal.h | 2 + linux-user/x86_64/target_structs.h | 3 + linux-user/x86_64/target_syscall.h | 2 + linux-user/x86_64/termbits.h | 2 + linux-user/xtensa/target_cpu.h | 3 + linux-user/xtensa/target_elf.h | 2 + linux-user/xtensa/target_fcntl.h | 3 + linux-user/xtensa/target_signal.h | 2 + linux-user/xtensa/target_structs.h | 3 + linux-user/xtensa/target_syscall.h | 2 + linux-user/xtensa/termbits.h | 2 + migration/postcopy-ram.h | 3 + migration/qemu-file.h | 2 + net/colo-compare.h | 2 + qemu-options-wrapper.h | 1 + qga/guest-agent-core.h | 3 + qga/service-win32.h | 2 + qga/vss-win32.h | 2 + qga/vss-win32/install.h | 2 + qga/vss-win32/requester.h | 2 + qga/vss-win32/vss-common.h | 2 + replay/replay-internal.h | 2 + replication.h | 2 + target/alpha/cpu.h | 3 + target/alpha/helper.h | 2 + target/arm/arm-powerctl.h | 3 + target/arm/arm_ldst.h | 3 + target/arm/cpu.h | 3 + target/arm/helper-a64.h | 3 + target/arm/helper-sve.h | 2 + target/arm/helper.h | 3 + target/arm/internals.h | 2 + target/arm/kvm-consts.h | 4 ++ target/arm/kvm_arm.h | 3 + target/arm/op_addsub.h | 2 + target/arm/translate-a64.h | 2 + target/arm/translate.h | 3 + target/cris/cpu.h | 3 + target/cris/helper.h | 2 + target/cris/mmu.h | 2 + target/hppa/cpu.h | 3 + target/hppa/helper.h | 2 + target/i386/cc_helper_template.h | 2 + target/i386/cpu-qom.h | 3 + target/i386/cpu.h | 3 + target/i386/hax-i386.h | 3 + target/i386/hax-posix.h | 2 + target/i386/hax-windows.h | 2 + target/i386/helper.h | 3 + target/i386/hvf/hvf-i386.h | 3 + target/i386/hvf/vmcs.h | 2 + target/i386/hvf/vmx.h | 2 + target/i386/hvf/x86.h | 2 + target/i386/hvf/x86_decode.h | 3 + target/i386/hvf/x86_descr.h | 2 + target/i386/hvf/x86_emu.h | 3 + target/i386/hvf/x86_flags.h | 3 + target/i386/hvf/x86_mmu.h | 2 + target/i386/hvf/x86_task.h | 2 + target/i386/hvf/x86hvf.h | 4 ++ target/i386/hyperv.h | 3 + target/i386/kvm_i386.h | 3 + target/i386/ops_sse.h | 3 + target/i386/ops_sse_header.h | 4 ++ target/i386/sev_i386.h | 3 + target/i386/shift_helper_template.h | 2 + target/i386/whp-dispatch.h | 2 + target/lm32/cpu.h | 3 + target/lm32/helper.h | 2 + target/m68k/cpu.h | 3 + target/m68k/helper.h | 3 + target/m68k/softfloat.h | 2 + target/m68k/softfloat_fpsp_tables.h | 2 + target/microblaze/cpu.h | 3 + target/microblaze/helper.h | 2 + target/microblaze/mmu.h | 2 + target/mips/cpu-qom.h | 3 + target/mips/cpu.h | 3 + target/mips/helper.h | 3 + target/mips/internal.h | 3 + target/mips/kvm_mips.h | 2 + target/mips/mips-defs.h | 2 + target/moxie/cpu.h | 3 + target/moxie/helper.h | 2 + target/moxie/machine.h | 2 + target/moxie/mmu.h | 2 + target/nios2/cpu.h | 3 + target/nios2/helper.h | 2 + target/nios2/mmu.h | 2 + target/openrisc/cpu.h | 3 + target/openrisc/exception.h | 3 + target/openrisc/helper.h | 2 + target/ppc/cpu-models.h | 3 + target/ppc/cpu-qom.h | 3 + target/ppc/cpu.h | 3 + target/ppc/helper.h | 3 + target/ppc/helper_regs.h | 3 + target/ppc/internal.h | 3 + target/ppc/kvm_ppc.h | 3 + target/ppc/mmu-book3s-v3.h | 3 + target/ppc/mmu-hash32.h | 2 + target/ppc/mmu-hash64.h | 3 + target/ppc/mmu-radix64.h | 3 + target/riscv/cpu.h | 3 + target/riscv/helper.h | 2 + target/riscv/instmap.h | 2 + target/riscv/pmp.h | 2 + target/s390x/cpu.h | 2 + target/s390x/cpu_features.h | 2 + target/s390x/cpu_models.h | 2 + target/s390x/helper.h | 2 + target/s390x/internal.h | 2 + target/s390x/tcg_s390x.h | 2 + target/sh4/cpu.h | 3 + target/sh4/helper.h | 2 + target/sparc/cpu-qom.h | 3 + target/sparc/cpu.h | 3 + target/sparc/helper.h | 3 + target/tilegx/cpu.h | 3 + target/tilegx/helper.h | 2 + target/tricore/cpu.h | 3 + target/tricore/helper.h | 2 + target/tricore/tricore-defs.h | 2 + target/tricore/tricore-opcodes.h | 2 + target/unicore32/cpu.h | 3 + target/unicore32/helper.h | 2 + target/xtensa/cpu.h | 3 + target/xtensa/helper.h | 2 + target/xtensa/overlay_tool.h | 3 + target/xtensa/xtensa-isa-internal.h | 2 + tcg/aarch64/tcg-target.h | 2 + tcg/aarch64/tcg-target.opc.h | 3 + tcg/arm/tcg-target.h | 2 + tcg/i386/tcg-target.h | 3 + tcg/i386/tcg-target.opc.h | 2 + tcg/mips/tcg-target.h | 2 + tcg/ppc/tcg-target.h | 2 + tcg/riscv/tcg-target.h | 3 + tcg/s390/tcg-target.h | 3 + tcg/tcg-gvec-desc.h | 2 + tcg/tcg-op-gvec.h | 2 + tcg/tcg-op.h | 2 + tcg/tcg-opc.h | 4 ++ tcg/tcg.h | 2 + tcg/tci/tcg-target.h | 2 + tests/Makefile.include | 35 +++++++++- tests/check-headers.mak | 54 ++++++++++++++++ tests/crypto-tls-x509-helpers.h | 2 + tests/fp/platform.h | 3 + tests/header-test-template.c | 16 +++++ tests/libqos/virtio-9p.h | 2 + tests/libqos/virtio-balloon.h | 2 + tests/libqos/virtio-blk.h | 2 + tests/libqos/virtio-net.h | 2 + tests/libqos/virtio-rng.h | 2 + tests/libqos/virtio-scsi.h | 2 + tests/libqos/virtio-serial.h | 2 + tests/migration/Makefile | 2 + tests/migration/aarch64/a-b-kernel.h | 3 + tests/migration/i386/a-b-bootblock.h | 3 + tests/migration/s390x/a-b-bios.h | 2 + tests/ptimer-test.h | 2 + tests/socket-helpers.h | 3 +- tests/tpm-emu.h | 2 + tests/tpm-tests.h | 2 + tests/tpm-util.h | 2 + trace/control-internal.h | 2 + trace/mem-internal.h | 2 + trace/mem.h | 2 + ui/curses_keys.h | 2 + ui/vgafont.h | 2 + ui/vnc-auth-sasl.h | 2 + ui/vnc-auth-vencrypt.h | 2 + ui/vnc-enc-hextile-template.h | 2 + ui/vnc-jobs.h | 2 + ui/vnc-ws.h | 2 + ui/vnc.h | 2 + ui/vnc_keysym.h | 1 + ui/x_keymap.h | 2 + util/qemu-thread-common.h | 2 + win_dump.h | 2 + 624 files changed, 1623 insertions(+), 51 deletions(-) create mode 100644 tests/check-headers.mak create mode 100644 tests/header-test-template.c
Signature · 1 line
2.17.2
RFC v4 1/7 Makefile: Remove code to smooth transition to config.status
When commit bdf523e6923 made configure generate config.status, it added a fallback to Makefile to smooth the transition, with a TODO "code can be removed after QEMU 1.7." It's been more than five years. Remove it.
--- Makefile | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
Makefile +1 -8
@@ -69,14 +69,7 @@ CONFIG_ALL=y config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION @echo $@ is out-of-date, running configure - @# TODO: The next lines include code which supports a smooth - @# transition from old configurations without config.status. - @# This code can be removed after QEMU 1.7. - @if test -x config.status; then \ - ./config.status; \ - else \ - sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh; \ - fi + ./config.status else config-host.mak: ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
Signature · 1 line
2.17.2
Re: [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status
Quoted 9 lines · Markus Armbruster
When commit
bdf523e6923made configure generate config.status, it added a fallback toMakefileto smooth the transition, with a TODO "code can be removed after QEMU 1.7." It's been more than five years. Remove it.Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
r~
Re: [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status
In reply to Markus ArmbrusterHi Markus,
Quoted 17 lines · Markus Armbruster
When commit
bdf523e6923made configure generate config.status, it added a fallback toMakefileto smooth the transition, with a TODO "code can be removed after QEMU 1.7." It's been more than five years. Remove it.Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)Makefile +0
-0@@ -69,14 +69,7 @@ CONFIG_ALL=y config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION
Makefile CONFIG_ALL=y · line 72
Quoted 10 lines
Makefile +1
-8@echo $@ is out-of-date, running configure - @# TODO: The next lines include code which supports a smooth - @# transition from old configurations without config.status. - @# This code can be removed after QEMU 1.7. - @if test -x config.status; then \ - ./config.status; \ - else \ - sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh; \ - fi + ./config.status
We could prepend a '@' since we already describe what this rule does ("config-host.mak is out-of-date, running configure").
Quoted 4 lines
Makefile +0
-0else config-host.mak: ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if $(MAKECMDGOALS),,fail))
Re: [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status
Quoted 19 lines · Philippe Mathieu-Daudé
Hi Markus,
Quoted 16 lines · Markus Armbruster
When commit
bdf523e6923made configure generate config.status, it added a fallback toMakefileto smooth the transition, with a TODO "code can be removed after QEMU 1.7." It's been more than five years. Remove it.Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)Makefile +0
-0@@ -69,14 +69,7 @@ CONFIG_ALL=y
Quoted 14 lines
Makefile CONFIG_ALL=y · line 72
Quoted 11 lines
Makefile +1
-8config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VERSION @echo $@ is out-of-date, running configure - @# TODO: The next lines include code which supports a smooth - @# transition from old configurations without config.status. - @# This code can be removed after QEMU 1.7. - @if test -x config.status; then \ - ./config.status; \ - else \ - sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh; \ - fi + ./config.statusWe could prepend a '@' since we already describe what this rule does ("config-host.mak is out-of-date, running configure").
You're right, my patch loses the @.
Quoted 2 lines
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Thanks!
[...]
RFC v4 2/7 Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def
In reply to Markus ArmbrusterWhen commit df2943ba3c7 moved "rm -f qemu-options.def" from distclean to clean, it also added "rm -f $$d/qemu-options.def" to the for d in $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken rm.
--- Makefile | 1 - 1 file changed, 1 deletion(-)
Makefile +0 -1
@@ -647,7 +647,6 @@ clean: rm -rf qga/qapi-generated for d in $(ALL_SUBDIRS); do \ if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ - rm -f $$d/qemu-options.def; \ done rm -f config-all-devices.mak
Signature · 1 line
2.17.2
Re: [Qemu-devel] [RFC v4 2/7] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def
Quoted 9 lines · Markus Armbruster
When commit
df2943ba3c7moved "rm -f qemu-options.def" from distclean to clean, it also added "rm -f $$d/qemu-options.def" to the for d in $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken rm.Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 1 - 1 file changed, 1 deletion(-)
r~
Re: [Qemu-devel] [RFC v4 2/7] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def
In reply to Markus ArmbrusterQuoted 16 lines · Markus Armbruster
When commit
df2943ba3c7moved "rm -f qemu-options.def" from distclean to clean, it also added "rm -f $$d/qemu-options.def" to the for d in $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken rm.Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 1 - 1 file changed, 1 deletion(-)Makefile +0
-0
Makefile clean: · line 652
Quoted 7 lines
Makefile +0
-1@@ -647,7 +647,6 @@ clean: rm -rf qga/qapi-generated for d in $(ALL_SUBDIRS); do \ if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ - rm -f $$d/qemu-options.def; \ done rm -f config-all-devices.mak
RFC v4 3/7 Makefile: Rename targets for make recursion
In reply to Markus ArmbrusterWe make a few sub-directories recursively, in particular $(TARGET_DIRS).
For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k.
For other goals such as "clean" and "install", the recipe runs make recursively in a for loop. Ignores -j and -k.
The next commit will fix that for "clean" and "install". This commit prepares the ground by renaming the targets we use for "all" to include the goal for the sub-make. This will permit reusing them for goals other than "all".
Targets subdir-T for T in $(TARGET_DIRS) run "make all" in T. Rename to T/all, and declare phony.
Targets romsubdir-R for R in $(ROMS) run "make" in pc-bios/R. Default goal is "all" for all R. Rename to pc-bios/R/all, and declare phony.
The remainder are renamed just for consistency.
Target subdir-dtc runs "make libbft/libfdt.a" in dtc. Rename to dtc/all, and declare phony.
Target subdir-capstone runs make $(BUILD_DIR)/capstone/$(LIBCAPSTONE) in $(SRC_PATH)/capstone. Rename to capstone/all, and declare phony.
Target subdir-slirp runs "make" in $(SRC_PATH)/slirp. Default goal is all, which builds $(BUILD_DIR)/libslirp.a. Rename to slirp/all, and declare phony.
--- Makefile | 30 ++++++++++++++++++------------ configure | 6 +++--- tests/Makefile.include | 3 ++- 3 files changed, 23 insertions(+), 16 deletions(-)
Makefile +18 -12
@@ -436,8 +436,8 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) -SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES)) +SUBDIR_RULES=$(addsuffix /all, $(TARGET_DIRS)) +SOFTMMU_SUBDIR_RULES=$(filter %-softmmu/all,$(SUBDIR_RULES)) $(SOFTMMU_SUBDIR_RULES): $(authz-obj-y) $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
@@ -447,14 +447,16 @@ $(SOFTMMU_SUBDIR_RULES): $(io-obj-y) $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak $(SOFTMMU_SUBDIR_RULES): $(edk2-decompressed) -subdir-%: - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) +.PHONY: $(SUBDIR_RULES) +$(SUBDIR_RULES): + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" all,) DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) DTC_CPPFLAGS=-I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt -subdir-dtc: .git-submodule-status dtc/libfdt dtc/tests +.PHONY: dtc/all +dtc/all: .git-submodule-status dtc/libfdt dtc/tests $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CPPFLAGS)" CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,) dtc/%: .git-submodule-status
@@ -472,21 +474,25 @@ CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 CAP_CFLAGS += -DCAPSTONE_HAS_POWERPC CAP_CFLAGS += -DCAPSTONE_HAS_X86 -subdir-capstone: .git-submodule-status +.PHONY: capstone/all +capstone/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=no BUILDDIR="$(BUILD_DIR)/capstone" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(CAP_CFLAGS)" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/$(LIBCAPSTONE)) -subdir-slirp: .git-submodule-status +.PHONY: slirp/all +slirp/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)") $(SUBDIR_RULES): libqemuutil.a $(common-obj-y) \ $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY)) -ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) +ROM_DIRS = $(addprefix pc-bios/, $(ROMS)) +ROMSUBDIR_RULES=$(addsuffix /all, $(ROM_DIRS)) # Only keep -O and -g cflags -romsubdir-%: - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pc-bios/$* V="$(V)" TARGET_DIR="$*/" CFLAGS="$(filter -O% -g%,$(CFLAGS))",) +.PHONY: $(ROMSUBDIR_RULES) +$(ROMSUBDIR_RULES): + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))",) -ALL_SUBDIRS=$(TARGET_DIRS) $(patsubst %,pc-bios/%, $(ROMS)) +ALL_SUBDIRS=$(TARGET_DIRS) $(ROM_DIRS) recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)
@@ -1087,7 +1093,7 @@ endif @$(if $(TARGET_DIRS), \ echo 'Architecture specific targets:'; \ $(foreach t, $(TARGET_DIRS), \ - printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \ + printf " %-30s - Build for %s\\n" $(t)/all $(t);) \ echo '') @echo 'Cleaning targets:' @echo ' clean - Remove most generated files but keep the config'
configure +3 -3
@@ -6570,7 +6570,7 @@ if test "$slirp" != "no"; then echo "SLIRP_LIBS=$slirp_libs" >> $config_host_mak fi if [ "$slirp" = "git" -o "$slirp" = "internal" ]; then - echo "config-host.h: subdir-slirp" >> $config_host_mak + echo "config-host.h: slirp/all" >> $config_host_mak fi if test "$vde" = "yes" ; then echo "CONFIG_VDE=y" >> $config_host_mak
@@ -7836,10 +7836,10 @@ if test -n "$enabled_cross_compilers"; then fi if [ "$fdt" = "git" ]; then - echo "config-host.h: subdir-dtc" >> $config_host_mak + echo "config-host.h: dtc/all" >> $config_host_mak fi if [ "$capstone" = "git" -o "$capstone" = "internal" ]; then - echo "config-host.h: subdir-capstone" >> $config_host_mak + echo "config-host.h: capstone/all" >> $config_host_mak fi if test -n "$LIBCAPSTONE"; then echo "LIBCAPSTONE=$LIBCAPSTONE" >> $config_host_mak
tests/Makefile.include +2 -1
@@ -1,3 +1,4 @@ +# -*- Mode: makefile -*- .PHONY: check-help check-help:
@@ -880,7 +881,7 @@ define do_test_tap endef .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: %-softmmu/all $(check-qtest-y) $(call do_test_human,$(check-qtest-$*-y) $(check-qtest-generic-y), \ QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF))
Signature · 1 line
2.17.2
Re: [Qemu-devel] [RFC v4 3/7] Makefile: Rename targets for make recursion
Quoted 33 lines · Markus Armbruster
We make a few sub-directories recursively, in particular $(TARGET_DIRS).
For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k.
For other goals such as "clean" and "install", the recipe runs make recursively in a for loop. Ignores -j and -k.
The next commit will fix that for "clean" and "install". This commit prepares the ground by renaming the targets we use for "all" to include the goal for the sub-make. This will permit reusing them for goals other than "all".
Targets subdir-T for T in $(TARGET_DIRS) run "make all" in T. Rename to T/all, and declare phony.
Targets romsubdir-R for R in $(ROMS) run "make" in pc-bios/R. Default goal is "all" for all R. Rename to pc-bios/R/all, and declare phony.
The remainder are renamed just for consistency.
Target subdir-dtc runs "make libbft/libfdt.a" in dtc. Rename to dtc/all, and declare phony.
Target subdir-capstone runs make $(BUILD_DIR)/capstone/$(LIBCAPSTONE) in $(SRC_PATH)/capstone. Rename to capstone/all, and declare phony.
Target subdir-slirp runs "make" in $(SRC_PATH)/slirp. Default goal is all, which builds $(BUILD_DIR)/libslirp.a. Rename to slirp/all, and declare phony.
Quoted 6 lines
Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 30 ++++++++++++++++++------------ configure | 6 +++--- tests/Makefile.include | 3 ++- 3 files changed, 23 insertions(+), 16 deletions(-)
r~
Re: [Qemu-devel] [RFC v4 3/7] Makefile: Rename targets for make recursion
In reply to Markus ArmbrusterQuoted 63 lines · Markus Armbruster
We make a few sub-directories recursively, in particular $(TARGET_DIRS).
For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k.
For other goals such as "clean" and "install", the recipe runs make recursively in a for loop. Ignores -j and -k.
The next commit will fix that for "clean" and "install". This commit prepares the ground by renaming the targets we use for "all" to include the goal for the sub-make. This will permit reusing them for goals other than "all".
Targets subdir-T for T in $(TARGET_DIRS) run "make all" in T. Rename to T/all, and declare phony.
Targets romsubdir-R for R in $(ROMS) run "make" in pc-bios/R. Default goal is "all" for all R. Rename to pc-bios/R/all, and declare phony.
The remainder are renamed just for consistency.
Target subdir-dtc runs "make libbft/libfdt.a" in dtc. Rename to dtc/all, and declare phony.
Target subdir-capstone runs make $(BUILD_DIR)/capstone/$(LIBCAPSTONE) in $(SRC_PATH)/capstone. Rename to capstone/all, and declare phony.
Target subdir-slirp runs "make" in $(SRC_PATH)/slirp. Default goal is all, which builds $(BUILD_DIR)/libslirp.a. Rename to slirp/all, and declare phony.
Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 30 ++++++++++++++++++------------ configure | 6 +++--- tests/Makefile.include | 3 ++- 3 files changed, 23 insertions(+), 16 deletions(-)Makefile +4
-4@@ -436,8 +436,8 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) -SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES)) +SUBDIR_RULES=$(addsuffix /all, $(TARGET_DIRS)) +SOFTMMU_SUBDIR_RULES=$(filter %-softmmu/all,$(SUBDIR_RULES)) $(SOFTMMU_SUBDIR_RULES): $(authz-obj-y) $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)@@ -447,14 +447,16 @@ $(SOFTMMU_SUBDIR_RULES): $(io-obj-y) $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak $(SOFTMMU_SUBDIR_RULES): $(edk2-decompressed) -subdir-%: - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) +.PHONY: $(SUBDIR_RULES) +$(SUBDIR_RULES):
Makefile $(SOFTMMU_SUBDIR_RULES): $(io-obj-y) · line 460
Quoted 10 lines
Makefile +3
-1+ $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" all,) DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) DTC_CPPFLAGS=-I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt -subdir-dtc: .git-submodule-status dtc/libfdt dtc/tests +.PHONY: dtc/all +dtc/all: .git-submodule-status dtc/libfdt dtc/tests $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CPPFLAGS)" CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,)
OK
Makefile CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 · line 479
Quoted 10 lines
Makefile +2
-1dtc/%: .git-submodule-status@@ -472,21 +474,25 @@ CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 CAP_CFLAGS += -DCAPSTONE_HAS_POWERPC CAP_CFLAGS += -DCAPSTONE_HAS_X86 -subdir-capstone: .git-submodule-status +.PHONY: capstone/all +capstone/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=no BUILDDIR="$(BUILD_DIR)/capstone" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(CAP_CFLAGS)" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/$(LIBCAPSTONE))
OK
Makefile CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 · line 483
Quoted 5 lines
Makefile +2
-1-subdir-slirp: .git-submodule-status +.PHONY: slirp/all +slirp/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")
OK
Makefile CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 · line 493
Quoted 13 lines
Makefile +5
-3$(SUBDIR_RULES): libqemuutil.a $(common-obj-y) \ $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY)) -ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) +ROM_DIRS = $(addprefix pc-bios/, $(ROMS)) +ROMSUBDIR_RULES=$(addsuffix /all, $(ROM_DIRS)) # Only keep -O and -g cflags -romsubdir-%: - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pc-bios/$* V="$(V)" TARGET_DIR="$*/" CFLAGS="$(filter -O% -g%,$(CFLAGS))",) +.PHONY: $(ROMSUBDIR_RULES) +$(ROMSUBDIR_RULES): + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))",)
OK
Makefile endif · line 1096
Quoted 12 lines
Makefile +2
-2-ALL_SUBDIRS=$(TARGET_DIRS) $(patsubst %,pc-bios/%, $(ROMS)) +ALL_SUBDIRS=$(TARGET_DIRS) $(ROM_DIRS) recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)@@ -1087,7 +1093,7 @@ endif @$(if $(TARGET_DIRS), \ echo 'Architecture specific targets:'; \ $(foreach t, $(TARGET_DIRS), \ - printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \ + printf " %-30s - Build for %s\\n" $(t)/all $(t);) \
OK
Quoted 40 lines
Makefile +0
-0echo '') @echo 'Cleaning targets:' @echo ' clean - Remove most generated files but keep the config'configure +3
-3@@ -6570,7 +6570,7 @@ if test "$slirp" != "no"; then echo "SLIRP_LIBS=$slirp_libs" >> $config_host_mak fi if [ "$slirp" = "git" -o "$slirp" = "internal" ]; then - echo "config-host.h: subdir-slirp" >> $config_host_mak + echo "config-host.h: slirp/all" >> $config_host_mak fi if test "$vde" = "yes" ; then echo "CONFIG_VDE=y" >> $config_host_mak@@ -7836,10 +7836,10 @@ if test -n "$enabled_cross_compilers"; then fi if [ "$fdt" = "git" ]; then - echo "config-host.h: subdir-dtc" >> $config_host_mak + echo "config-host.h: dtc/all" >> $config_host_mak fi if [ "$capstone" = "git" -o "$capstone" = "internal" ]; then - echo "config-host.h: subdir-capstone" >> $config_host_mak + echo "config-host.h: capstone/all" >> $config_host_mak fi if test -n "$LIBCAPSTONE"; then echo "LIBCAPSTONE=$LIBCAPSTONE" >> $config_host_maktests/Makefile.include +1
-0@@ -1,3 +1,4 @@ +# -*- Mode: makefile -*- .PHONY: check-help check-help:
tests/Makefile.include define do_test_tap · line 887
Quoted 8 lines
tests/Makefile.include +1
-1@@ -880,7 +881,7 @@ define do_test_tap endef .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: %-softmmu/all $(check-qtest-y) $(call do_test_human,$(check-qtest-$*-y) $(check-qtest-generic-y), \ QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF))
There is another one:
-- >8 --
# gtester tests with TAP output
-$(patsubst %, check-report-qtest-%.tap, $(QTEST_TARGETS)):
check-report-qtest-%.tap: subdir-%-softmmu $(check-qtest-y) +$(patsubst %, check-report-qtest-%.tap, $(QTEST_TARGETS)):
check-report-qtest-%.tap: %-softmmu/all $(check-qtest-y)
$(call do_test_tap, $(check-qtest-$*-y) $(check-qtest-generic-y), \
QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
QTEST_QEMU_IMG=qemu-img$(EXESUF))---
With the fix amended:
Regards,
Phil.
Re: [Qemu-devel] [RFC v4 3/7] Makefile: Rename targets for make recursion
Quoted 180 lines · Philippe Mathieu-Daudé
Quoted 63 lines · Markus Armbruster
We make a few sub-directories recursively, in particular $(TARGET_DIRS).
For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k.
For other goals such as "clean" and "install", the recipe runs make recursively in a for loop. Ignores -j and -k.
The next commit will fix that for "clean" and "install". This commit prepares the ground by renaming the targets we use for "all" to include the goal for the sub-make. This will permit reusing them for goals other than "all".
Targets subdir-T for T in $(TARGET_DIRS) run "make all" in T. Rename to T/all, and declare phony.
Targets romsubdir-R for R in $(ROMS) run "make" in pc-bios/R. Default goal is "all" for all R. Rename to pc-bios/R/all, and declare phony.
The remainder are renamed just for consistency.
Target subdir-dtc runs "make libbft/libfdt.a" in dtc. Rename to dtc/all, and declare phony.
Target subdir-capstone runs make $(BUILD_DIR)/capstone/$(LIBCAPSTONE) in $(SRC_PATH)/capstone. Rename to capstone/all, and declare phony.
Target subdir-slirp runs "make" in $(SRC_PATH)/slirp. Default goal is all, which builds $(BUILD_DIR)/libslirp.a. Rename to slirp/all, and declare phony.
Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 30 ++++++++++++++++++------------ configure | 6 +++--- tests/Makefile.include | 3 ++- 3 files changed, 23 insertions(+), 16 deletions(-)Makefile +4
-4@@ -436,8 +436,8 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) -SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES)) +SUBDIR_RULES=$(addsuffix /all, $(TARGET_DIRS)) +SOFTMMU_SUBDIR_RULES=$(filter %-softmmu/all,$(SUBDIR_RULES)) $(SOFTMMU_SUBDIR_RULES): $(authz-obj-y) $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)@@ -447,14 +447,16 @@ $(SOFTMMU_SUBDIR_RULES): $(io-obj-y) $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak $(SOFTMMU_SUBDIR_RULES): $(edk2-decompressed) -subdir-%: - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,) +.PHONY: $(SUBDIR_RULES) +$(SUBDIR_RULES):Makefile $(SOFTMMU_SUBDIR_RULES): $(io-obj-y) · line 460
Quoted 10 lines
Makefile +3
-1+ $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" all,) DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) DTC_CPPFLAGS=-I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt -subdir-dtc: .git-submodule-status dtc/libfdt dtc/tests +.PHONY: dtc/all +dtc/all: .git-submodule-status dtc/libfdt dtc/tests $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CPPFLAGS)" CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,)OK
Makefile CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 · line 479
Quoted 10 lines
Makefile +2
-1dtc/%: .git-submodule-status@@ -472,21 +474,25 @@ CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 CAP_CFLAGS += -DCAPSTONE_HAS_POWERPC CAP_CFLAGS += -DCAPSTONE_HAS_X86 -subdir-capstone: .git-submodule-status +.PHONY: capstone/all +capstone/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=no BUILDDIR="$(BUILD_DIR)/capstone" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(CAP_CFLAGS)" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/$(LIBCAPSTONE))OK
Makefile CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 · line 483
Quoted 5 lines
Makefile +2
-1-subdir-slirp: .git-submodule-status +.PHONY: slirp/all +slirp/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")OK
Makefile CAP_CFLAGS += -DCAPSTONE_HAS_ARM64 · line 493
Quoted 13 lines
Makefile +5
-3$(SUBDIR_RULES): libqemuutil.a $(common-obj-y) \ $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY)) -ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) +ROM_DIRS = $(addprefix pc-bios/, $(ROMS)) +ROMSUBDIR_RULES=$(addsuffix /all, $(ROM_DIRS)) # Only keep -O and -g cflags -romsubdir-%: - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pc-bios/$* V="$(V)" TARGET_DIR="$*/" CFLAGS="$(filter -O% -g%,$(CFLAGS))",) +.PHONY: $(ROMSUBDIR_RULES) +$(ROMSUBDIR_RULES): + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))",)OK
Makefile endif · line 1096
Quoted 12 lines
Makefile +2
-2-ALL_SUBDIRS=$(TARGET_DIRS) $(patsubst %,pc-bios/%, $(ROMS)) +ALL_SUBDIRS=$(TARGET_DIRS) $(ROM_DIRS) recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)@@ -1087,7 +1093,7 @@ endif @$(if $(TARGET_DIRS), \ echo 'Architecture specific targets:'; \ $(foreach t, $(TARGET_DIRS), \ - printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \ + printf " %-30s - Build for %s\\n" $(t)/all $(t);) \OK
Quoted 40 lines
Makefile +0
-0echo '') @echo 'Cleaning targets:' @echo ' clean - Remove most generated files but keep the config'configure +3
-3@@ -6570,7 +6570,7 @@ if test "$slirp" != "no"; then echo "SLIRP_LIBS=$slirp_libs" >> $config_host_mak fi if [ "$slirp" = "git" -o "$slirp" = "internal" ]; then - echo "config-host.h: subdir-slirp" >> $config_host_mak + echo "config-host.h: slirp/all" >> $config_host_mak fi if test "$vde" = "yes" ; then echo "CONFIG_VDE=y" >> $config_host_mak@@ -7836,10 +7836,10 @@ if test -n "$enabled_cross_compilers"; then fi if [ "$fdt" = "git" ]; then - echo "config-host.h: subdir-dtc" >> $config_host_mak + echo "config-host.h: dtc/all" >> $config_host_mak fi if [ "$capstone" = "git" -o "$capstone" = "internal" ]; then - echo "config-host.h: subdir-capstone" >> $config_host_mak + echo "config-host.h: capstone/all" >> $config_host_mak fi if test -n "$LIBCAPSTONE"; then echo "LIBCAPSTONE=$LIBCAPSTONE" >> $config_host_maktests/Makefile.include +1
-0@@ -1,3 +1,4 @@ +# -*- Mode: makefile -*- .PHONY: check-help check-help:tests/Makefile.include define do_test_tap · line 887
Quoted 8 lines
tests/Makefile.include +1
-1@@ -880,7 +881,7 @@ define do_test_tap endef .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: %-softmmu/all $(check-qtest-y) $(call do_test_human,$(check-qtest-$*-y) $(check-qtest-generic-y), \ QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF))There is another one:
Quoted 8 lines
-- >8 --
# gtester tests with TAP output-$(patsubst %, check-report-qtest-%.tap, $(QTEST_TARGETS)): check-report-qtest-%.tap: subdir-%-softmmu $(check-qtest-y) +$(patsubst %, check-report-qtest-%.tap, $(QTEST_TARGETS)): check-report-qtest-%.tap: %-softmmu/all $(check-qtest-y)
$(call do_test_tap, $(check-qtest-$*-y) $(check-qtest-generic-y), \ QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF))
Good catch.
Quoted 5 lines
---
With the fix amended:
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Thanks!
RFC v4 4/7 Makefile: Reuse all's recursion machinery for clean and install
In reply to Markus ArmbrusterTargets "clean" and "install" run make recursively in a for loop. This ignores -j and -k. Target "all" depends on SUBDIR/all to recurse into each SUBDIR. Behaves nicely with -j and -k. Put that to use for "clean" and "install": depend on SUBDIR/clean or SUBDIR/install, respectively, and delete the loop.
--- Makefile | 53 +++++++++++++++++++++++++---------------------------- 1 file changed, 25 insertions(+), 28 deletions(-)
Makefile +25 -28
@@ -436,20 +436,22 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -SUBDIR_RULES=$(addsuffix /all, $(TARGET_DIRS)) -SOFTMMU_SUBDIR_RULES=$(filter %-softmmu/all,$(SUBDIR_RULES)) +TARGET_DIRS_RULES := $(foreach t, all clean install, $(addsuffix /$(t), $(TARGET_DIRS))) -$(SOFTMMU_SUBDIR_RULES): $(authz-obj-y) -$(SOFTMMU_SUBDIR_RULES): $(block-obj-y) -$(SOFTMMU_SUBDIR_RULES): $(chardev-obj-y) -$(SOFTMMU_SUBDIR_RULES): $(crypto-obj-y) -$(SOFTMMU_SUBDIR_RULES): $(io-obj-y) -$(SOFTMMU_SUBDIR_RULES): config-all-devices.mak -$(SOFTMMU_SUBDIR_RULES): $(edk2-decompressed) +SOFTMMU_ALL_RULES=$(filter %-softmmu/all, $(TARGET_DIRS_RULES)) +$(SOFTMMU_ALL_RULES): $(authz-obj-y) +$(SOFTMMU_ALL_RULES): $(block-obj-y) +$(SOFTMMU_ALL_RULES): $(chardev-obj-y) +$(SOFTMMU_ALL_RULES): $(crypto-obj-y) +$(SOFTMMU_ALL_RULES): $(io-obj-y) +$(SOFTMMU_ALL_RULES): config-all-devices.mak +$(SOFTMMU_ALL_RULES): $(edk2-decompressed) -.PHONY: $(SUBDIR_RULES) -$(SUBDIR_RULES): - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" all,) +.PHONY: $(TARGET_DIRS_RULES) +# The $(TARGET_DIRS_RULES) are of the form SUBDIR/GOAL, so that +# $(dir $@) yields the sub-directory, and $(notdir $@) yields the sub-goal +$(TARGET_DIRS_RULES): + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" $(notdir $@),) DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS)
@@ -482,19 +484,19 @@ capstone/all: .git-submodule-status slirp/all: .git-submodule-status $(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)") -$(SUBDIR_RULES): libqemuutil.a $(common-obj-y) \ +$(filter %/all, $(TARGET_DIRS_RULES)): libqemuutil.a $(common-obj-y) \ $(qom-obj-y) $(crypto-aes-obj-$(CONFIG_USER_ONLY)) ROM_DIRS = $(addprefix pc-bios/, $(ROMS)) -ROMSUBDIR_RULES=$(addsuffix /all, $(ROM_DIRS)) +ROM_DIRS_RULES=$(foreach t, all clean, $(addsuffix /$(t), $(ROM_DIRS))) # Only keep -O and -g cflags -.PHONY: $(ROMSUBDIR_RULES) -$(ROMSUBDIR_RULES): - $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))",) +.PHONY: $(ROM_DIRS_RULES) +$(ROM_DIRS_RULES): + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))" $(notdir $@),) -ALL_SUBDIRS=$(TARGET_DIRS) $(ROM_DIRS) - -recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES) +recurse-all: $(addsuffix /all, $(TARGET_DIRS) $(ROM_DIRS)) +recurse-clean: $(addsuffix /clean, $(TARGET_DIRS) $(ROM_DIRS)) +recurse-install: $(addsuffix /install, $(TARGET_DIRS)) $(BUILD_DIR)/version.o: $(SRC_PATH)/version.rc config-host.h $(call quiet-command,$(WINDRES) -I$(BUILD_DIR) -o $@ $<,"RC","version.o")
@@ -630,7 +632,7 @@ clean-coverage: "CLEAN", "coverage files") endif -clean: +clean: recurse-clean # avoid old build problems by removing potentially incorrect old files rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h rm -f qemu-options.def
@@ -651,9 +653,6 @@ clean: rm -f $(foreach f,$(generated-files-y),$(f) $(f)-timestamp) rm -f qapi-gen-timestamp rm -rf qga/qapi-generated - for d in $(ALL_SUBDIRS); do \ - if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ - done rm -f config-all-devices.mak VERSION ?= $(shell cat VERSION)
@@ -799,7 +798,8 @@ endif ICON_SIZES=16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 install: all $(if $(BUILD_DOCS),install-doc) install-datadir install-localstatedir \ - $(if $(INSTALL_BLOBS),$(edk2-decompressed)) + $(if $(INSTALL_BLOBS),$(edk2-decompressed)) \ + recurse-install ifneq ($(TOOLS),) $(call install-prog,$(subst qemu-ga,qemu-ga$(EXESUF),$(TOOLS)),$(DESTDIR)$(bindir)) endif
@@ -859,9 +859,6 @@ endif $(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \ done $(INSTALL_DATA) $(BUILD_DIR)/trace-events-all "$(DESTDIR)$(qemu_datadir)/trace-events-all" - for d in $(TARGET_DIRS); do \ - $(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \ - done .PHONY: ctags ctags:
Signature · 1 line
2.17.2
Re: [Qemu-devel] [RFC v4 4/7] Makefile: Reuse all's recursion machinery for clean and install
Quoted 10 lines · Markus Armbruster
Targets "clean" and "install" run make recursively in a for loop. This ignores -j and -k. Target "all" depends on SUBDIR/all to recurse into each SUBDIR. Behaves nicely with -j and -k. Put that to use for "clean" and "install": depend on SUBDIR/clean or SUBDIR/install, respectively, and delete the loop.
Signed-off-by Markus Armbruster <[email protected]>--- Makefile | 53 +++++++++++++++++++++++++---------------------------- 1 file changed, 25 insertions(+), 28 deletions(-)
r~
RFC v4 5/7 tests: New make target check-source
In reply to Markus ArmbrusterMake target check-source is for checking the source code itself. For now, there's just one such check, make target check-headers. It checks basic header sanity: for each header "FOO.h", test whether
#include "qemu/osdep.h" #include "FOO.h" #include "FOO.h"
compiles.
The test works only in a git tree, with git installed. It is skipped unless $(SRC_PATH)/.git exists.
Third-party headers we don't intend to clean up are excluded from this test. So are a few "funny" headers. See make variable excluded-headers.
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside include/ for now.
Headers known to fail the test are marked with
/* FIXME Does not pass make check-headers, yet! */
Headers known to work only in certain configurations are marked like
/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */
I tried to find and mark all of them by testing various configurations. Still, "make check" might fail for configurations I didn't test.
Known issue: some of these don't actually need fixing; they're *meant* to work only in certain configurations. We'll want to invent a suitable marker that doesn't claim FIXME.
Some headers may only be included into target-dependent code: they use identifiers poisoned by exec/poison.h, or include cpu.h. These headers are marked with a comment
/* NOTE: May only be included into target-dependent code */
The test treats them specially.
Known issue: some of these are intended for specific targets. The test should skip them for other targets, but doesn't. They're marked FIXME instead, which is wrong.
New make target check-bad-headers runs the test for headers expected to fail it. This helps with examining the failures.
--- Makefile | 4 ++- Makefile.target | 19 ++++++++++ include/block/raw-aio.h | 3 ++ include/block/write-threshold.h | 3 ++ include/chardev/char-win.h | 3 ++ include/chardev/spice.h | 2 ++ include/disas/disas.h | 2 ++ include/exec/cpu-all.h | 4 +++ include/exec/cpu-defs.h | 4 +++ include/exec/cpu_ldst.h | 4 +++ include/exec/cpu_ldst_template.h | 3 ++ include/exec/cpu_ldst_useronly_template.h | 3 ++ include/exec/cputlb.h | 3 ++ include/exec/exec-all.h | 3 ++ include/exec/gen-icount.h | 2 ++ include/exec/helper-gen.h | 2 ++ include/exec/helper-proto.h | 2 ++ include/exec/helper-tcg.h | 2 ++ include/exec/ioport.h | 2 ++ include/exec/memory-internal.h | 2 ++ include/exec/memory_ldst.inc.h | 2 ++ include/exec/memory_ldst_cached.inc.h | 2 ++ include/exec/memory_ldst_phys.inc.h | 2 ++ include/exec/ram_addr.h | 3 ++ include/exec/softmmu-semi.h | 3 ++ include/exec/tb-hash.h | 3 ++ include/exec/tb-lookup.h | 3 ++ include/exec/translator.h | 3 ++ include/exec/user/abitypes.h | 2 ++ include/exec/user/thunk.h | 4 +++ include/fpu/softfloat-macros.h | 2 ++ include/fpu/softfloat.h | 2 ++ include/hw/acpi/piix4.h | 2 ++ include/hw/acpi/tco.h | 3 ++ include/hw/adc/stm32f2xx_adc.h | 2 ++ include/hw/arm/allwinner-a10.h | 2 ++ include/hw/arm/armsse.h | 3 ++ include/hw/arm/armv7m.h | 3 ++ include/hw/arm/aspeed_soc.h | 2 ++ include/hw/arm/bcm2835_peripherals.h | 2 ++ include/hw/arm/bcm2836.h | 2 ++ include/hw/arm/digic.h | 3 ++ include/hw/arm/fsl-imx25.h | 2 ++ include/hw/arm/fsl-imx31.h | 2 ++ include/hw/arm/fsl-imx6.h | 3 ++ include/hw/arm/fsl-imx6ul.h | 3 ++ include/hw/arm/fsl-imx7.h | 3 ++ include/hw/arm/msf2-soc.h | 3 ++ include/hw/arm/nrf51_soc.h | 3 ++ include/hw/arm/omap.h | 3 ++ include/hw/arm/sharpsl.h | 3 ++ include/hw/arm/stm32f205_soc.h | 3 ++ include/hw/arm/xlnx-zynqmp.h | 2 ++ include/hw/block/fdc.h | 2 ++ include/hw/block/flash.h | 2 ++ include/hw/char/escc.h | 2 ++ include/hw/char/xilinx_uartlite.h | 2 ++ include/hw/core/generic-loader.h | 2 ++ include/hw/cris/etraxfs.h | 2 ++ include/hw/cris/etraxfs_dma.h | 2 ++ include/hw/display/bcm2835_fb.h | 2 ++ include/hw/display/i2c-ddc.h | 2 ++ include/hw/display/xlnx_dp.h | 2 ++ include/hw/dma/xlnx_dpdma.h | 2 ++ include/hw/elf_ops.h | 2 ++ include/hw/empty_slot.h | 2 ++ include/hw/gpio/bcm2835_gpio.h | 2 ++ include/hw/hyperv/hyperv.h | 2 ++ include/hw/i2c/aspeed_i2c.h | 3 ++ include/hw/i386/apic_internal.h | 3 ++ include/hw/i386/ioapic_internal.h | 2 ++ include/hw/input/hid.h | 2 ++ include/hw/input/tsc2xxx.h | 2 ++ include/hw/intc/allwinner-a10-pic.h | 2 ++ include/hw/intc/armv7m_nvic.h | 3 ++ include/hw/intc/heathrow_pic.h | 2 ++ include/hw/intc/mips_gic.h | 3 ++ include/hw/isa/vt82c686.h | 2 ++ include/hw/kvm/clock.h | 4 ++- include/hw/mips/bios.h | 2 ++ include/hw/mips/cps.h | 3 ++ include/hw/mips/cpudevs.h | 2 ++ include/hw/misc/bcm2835_property.h | 2 ++ include/hw/misc/macio/cuda.h | 2 ++ include/hw/misc/macio/gpio.h | 2 ++ include/hw/misc/macio/macio.h | 2 ++ include/hw/misc/macio/pmu.h | 2 ++ include/hw/misc/mips_cmgcr.h | 2 ++ include/hw/misc/mips_cpc.h | 2 ++ include/hw/misc/pvpanic.h | 3 ++ include/hw/net/allwinner_emac.h | 2 ++ include/hw/net/lance.h | 2 ++ include/hw/nvram/chrp_nvram.h | 2 ++ include/hw/pci-bridge/simba.h | 2 ++ include/hw/pci-host/sabre.h | 2 ++ include/hw/pci-host/spapr.h | 3 ++ include/hw/pci-host/uninorth.h | 2 ++ include/hw/pci/pcie_aer.h | 2 ++ include/hw/ppc/fdt.h | 2 ++ include/hw/ppc/pnv.h | 2 ++ include/hw/ppc/pnv_core.h | 2 ++ include/hw/ppc/pnv_xscom.h | 2 ++ include/hw/ppc/ppc.h | 2 ++ include/hw/ppc/ppc4xx.h | 2 ++ include/hw/ppc/spapr.h | 3 ++ include/hw/ppc/spapr_cpu_core.h | 4 +++ include/hw/ppc/spapr_irq.h | 2 ++ include/hw/ppc/spapr_ovec.h | 2 ++ include/hw/ppc/spapr_vio.h | 2 ++ include/hw/ppc/spapr_xive.h | 2 ++ include/hw/ppc/xics_spapr.h | 3 ++ include/hw/ppc/xive_regs.h | 2 ++ include/hw/riscv/riscv_hart.h | 2 ++ include/hw/riscv/riscv_htif.h | 3 ++ include/hw/riscv/sifive_clint.h | 2 ++ include/hw/riscv/sifive_e.h | 2 ++ include/hw/riscv/sifive_plic.h | 2 ++ include/hw/riscv/sifive_prci.h | 2 ++ include/hw/riscv/sifive_test.h | 2 ++ include/hw/riscv/sifive_u.h | 2 ++ include/hw/riscv/sifive_uart.h | 2 ++ include/hw/riscv/spike.h | 2 ++ include/hw/riscv/virt.h | 2 ++ include/hw/s390x/3270-ccw.h | 3 ++ include/hw/s390x/ap-device.h | 3 ++ include/hw/s390x/css-bridge.h | 2 ++ include/hw/s390x/css.h | 3 ++ include/hw/s390x/s390-ccw.h | 3 ++ include/hw/s390x/storage-attributes.h | 3 ++ include/hw/s390x/tod.h | 2 ++ include/hw/s390x/vfio-ccw.h | 3 ++ include/hw/sh4/sh.h | 2 ++ include/hw/sh4/sh_intc.h | 2 ++ include/hw/sparc/grlib.h | 2 ++ include/hw/sparc/sparc64.h | 1 + include/hw/ssi/aspeed_smc.h | 2 ++ include/hw/ssi/xilinx_spips.h | 2 ++ include/hw/timer/allwinner-a10-pit.h | 2 ++ include/hw/timer/i8254_internal.h | 2 ++ include/hw/timer/m48t59.h | 2 ++ include/hw/timer/mc146818rtc.h | 2 ++ include/hw/timer/mc146818rtc_regs.h | 2 ++ include/hw/timer/sun4v-rtc.h | 2 ++ include/hw/timer/xlnx-zynqmp-rtc.h | 2 ++ include/hw/vfio/vfio-amd-xgbe.h | 2 ++ include/hw/vfio/vfio-calxeda-xgmac.h | 2 ++ include/hw/vfio/vfio-common.h | 2 ++ include/hw/vfio/vfio-platform.h | 2 ++ include/hw/virtio/virtio-access.h | 3 ++ include/hw/virtio/virtio-gpu.h | 2 ++ include/hw/virtio/virtio-input.h | 2 ++ include/hw/virtio/virtio-rng.h | 2 ++ include/hw/xen/io/ring.h | 2 ++ include/hw/xen/xen-backend.h | 2 ++ include/hw/xen/xen-block.h | 2 ++ include/hw/xen/xen-bus-helper.h | 2 ++ include/hw/xen/xen-bus.h | 2 ++ include/hw/xen/xen-legacy-backend.h | 2 ++ include/hw/xen/xen_common.h | 2 ++ include/hw/xen/xen_pvdev.h | 2 ++ include/libdecnumber/decNumberLocal.h | 2 ++ include/migration/cpu.h | 4 +++ include/monitor/hmp-target.h | 3 ++ include/qemu/atomic128.h | 2 ++ include/qemu/futex.h | 2 ++ include/qemu/ratelimit.h | 2 ++ include/qemu/thread-win32.h | 2 ++ include/qemu/xattr.h | 3 ++ include/sysemu/balloon.h | 2 ++ include/sysemu/cryptodev-vhost-user.h | 3 ++ include/sysemu/dump.h | 2 ++ include/sysemu/hvf.h | 3 ++ include/sysemu/iothread.h | 2 ++ include/sysemu/kvm_int.h | 2 ++ include/sysemu/memory_mapping.h | 2 ++ include/sysemu/os-posix.h | 2 ++ include/sysemu/os-win32.h | 2 ++ include/sysemu/xen-mapcache.h | 2 ++ include/trace-tcg.h | 2 ++ include/ui/console.h | 2 ++ include/ui/egl-context.h | 3 ++ include/ui/egl-helpers.h | 2 ++ include/ui/gtk.h | 2 ++ include/ui/input.h | 2 ++ include/ui/pixel_ops.h | 2 ++ include/ui/qemu-pixman.h | 2 ++ include/ui/sdl2.h | 2 ++ include/ui/shader.h | 2 ++ include/ui/spice-display.h | 2 ++ tests/Makefile.include | 32 +++++++++++++++-- tests/check-headers.mak | 42 +++++++++++++++++++++++ tests/header-test-template.c | 16 +++++++++ 192 files changed, 542 insertions(+), 4 deletions(-) create mode 100644 tests/check-headers.mak create mode 100644 tests/header-test-template.c
Makefile +3 -1
@@ -416,6 +416,8 @@ dummy := $(call unnest-vars,, \ audio-obj-m \ trace-obj-y) +RECURSIVE_TARGETS := all clean install + include $(SRC_PATH)/tests/Makefile.include all: $(DOCS) $(if $(BUILD_DOCS),sphinxdocs) $(TOOLS) $(HELPERS-y) recurse-all modules
@@ -436,7 +438,7 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -TARGET_DIRS_RULES := $(foreach t, all clean install, $(addsuffix /$(t), $(TARGET_DIRS))) +TARGET_DIRS_RULES:=$(foreach t, $(RECURSIVE_TARGETS), $(addsuffix /$(t), $(TARGET_DIRS))) SOFTMMU_ALL_RULES=$(filter %-softmmu/all, $(TARGET_DIRS_RULES)) $(SOFTMMU_ALL_RULES): $(authz-obj-y)
Makefile.target +19 -0
@@ -41,6 +41,7 @@ STPFILES= # Makefile Tests include $(SRC_PATH)/tests/tcg/Makefile.include +include $(SRC_PATH)/tests/check-headers.mak config-target.h: config-target.h-timestamp config-target.h-timestamp: config-target.mak
@@ -216,6 +217,22 @@ hmp-commands.h: $(SRC_PATH)/hmp-commands.hx $(SRC_PATH)/scripts/hxtool hmp-commands-info.h: $(SRC_PATH)/hmp-commands-info.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$(TARGET_DIR)$@") +.PHONY: check-headers +ifeq ($(wildcard $(SRC_PATH)/.git),) +check-headers check-bad-headers: + @echo " SKIP $@ (requires a git tree)" +else +check-headers: $(check-target-header-tests:.c=.o) + +# Expected to fail: +check-bad-headers: $(check-bad-target-header-tests:.c=.o) + +.SECONDARY: $(check-target-header-tests) +$(check-target-header-tests) $(check-bad-target-header-tests): tests/header-test-template.c + @mkdir -p $(dir $@) + @sed 's,@header@,$(subst tests/headers/,,$(@:.c=.h)),' <$< >$@ +endif + clean: clean-target rm -f *.a *~ $(PROGS) rm -f $(shell find . -name '*.[od]')
@@ -238,3 +255,5 @@ endif generated-files-y += config-target.h Makefile: $(generated-files-y) + +-include $(check-target-header-tests:.c=.d) $(check-bad-target-header-tests:.c=.d)
include/block/raw-aio.h +3 -0
@@ -12,6 +12,9 @@* Contributions after 2012-01-13 are licensed under the terms of the * GNU GPL, version 2 or (at your option) any later version. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_RAW_AIO_H #define QEMU_RAW_AIO_H
include/block/write-threshold.h +3 -0
@@ -9,6 +9,9 @@* This work is licensed under the terms of the GNU LGPL, version 2 or later. * See the COPYING.LIB file in the top-level directory. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef BLOCK_WRITE_THRESHOLD_H #define BLOCK_WRITE_THRESHOLD_H
include/chardev/char-win.h +3 -0
@@ -21,6 +21,9 @@* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ + +/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */ +#ifndef CHAR_WIN_H #define CHAR_WIN_H
include/chardev/spice.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_SPICE, yet! */ +#ifndef CHARDEV_SPICE_H #define CHARDEV_SPICE_H
include/disas/disas.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_DISAS_H #define QEMU_DISAS_H
include/exec/cpu-all.h +4 -0
@@ -16,6 +16,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CPU_ALL_H #define CPU_ALL_H
include/exec/cpu-defs.h +4 -0
@@ -16,6 +16,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CPU_DEFS_H #define CPU_DEFS_H
include/exec/cpu_ldst.h +4 -0
@@ -44,6 +44,10 @@* (for softmmu configs) a target-specific MMU mode suffix as defined * in target cpu.h. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CPU_LDST_H #define CPU_LDST_H
include/exec/cpu_ldst_template.h +3 -0
@@ -24,6 +24,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#if !defined(SOFTMMU_CODE_ACCESS )#include "trace-root.h" #endif
include/exec/cpu_ldst_useronly_template.h +3 -0
@@ -23,6 +23,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#if !defined(CODE_ACCESS )#include "trace-root.h" #endif
include/exec/cputlb.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CPUTLB_H #define CPUTLB_H
include/exec/exec-all.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef EXEC_ALL_H #define EXEC_ALL_H
include/exec/gen-icount.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef GEN_ICOUNT_H #define GEN_ICOUNT_H
include/exec/helper-gen.h +2 -0
@@ -1,6 +1,8 @@/* Helper file for declaring TCG helper functions. This one expands generation functions for tcg opcodes. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HELPER_GEN_H #define HELPER_GEN_H
include/exec/helper-proto.h +2 -0
@@ -1,6 +1,8 @@/* Helper file for declaring TCG helper functions. This one expands prototypes for the helper functions. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HELPER_PROTO_H #define HELPER_PROTO_H
include/exec/helper-tcg.h +2 -0
@@ -1,6 +1,8 @@/* Helper file for declaring TCG helper functions. This one defines data structures private to tcg.c. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HELPER_TCG_H #define HELPER_TCG_H
include/exec/ioport.h +2 -0
@@ -21,6 +21,8 @@* IO ports API */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef IOPORT_H #define IOPORT_H
include/exec/memory-internal.h +2 -0
@@ -17,6 +17,8 @@* internals and the TCG TLB code. Do not include it from elsewhere. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MEMORY_INTERNAL_H #define MEMORY_INTERNAL_H
include/exec/memory_ldst.inc.h +2 -0
@@ -19,6 +19,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifdef TARGET_ENDIANNESS extern uint32_t glue (address_space_lduw ,SUFFIX )(ARG1_DECL ,hwaddr addr,MemTxAttrs attrs,MemTxResult *result);
include/exec/memory_ldst_cached.inc.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define ADDRESS_SPACE_LD_CACHED (size) \ glue(glue(address_space_ld, size), glue(ENDIANNESS, _cached))#define ADDRESS_SPACE_LD_CACHED_SLOW (size) \
include/exec/memory_ldst_phys.inc.h +2 -0
@@ -19,6 +19,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifdef TARGET_ENDIANNESS static inline uint32_t glue (ldl_phys ,SUFFIX )(ARG1_DECL ,hwaddr addr) {
include/exec/ram_addr.h +3 -0
@@ -16,6 +16,9 @@* The functions declared here will be removed soon. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RAM_ADDR_H #define RAM_ADDR_H
include/exec/softmmu-semi.h +3 -0
@@ -7,6 +7,9 @@* This code is licensed under the GPL */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SOFTMMU_SEMI_H #define SOFTMMU_SEMI_H
include/exec/tb-hash.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef EXEC_TB_HASH_H #define EXEC_TB_HASH_H
include/exec/tb-lookup.h +3 -0
@@ -4,6 +4,9 @@* License: GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ + +/* NOTE: May only be included into target-dependent code */ +#ifndef EXEC_TB_LOOKUP_H #define EXEC_TB_LOOKUP_H
include/exec/translator.h +3 -0
@@ -7,6 +7,9 @@* See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef EXEC__TRANSLATOR_H #define EXEC__TRANSLATOR_H
include/exec/user/abitypes.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifndef EXEC_USER_ABITYPES_H #define EXEC_USER_ABITYPES_H
include/exec/user/thunk.h +4 -0
@@ -16,6 +16,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef THUNK_H #define THUNK_H
include/fpu/softfloat-macros.h +2 -0
@@ -79,6 +79,8 @@ this code that are retained.* version 2 or later. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +/*---------------------------------------------------------------------------- | Shifts `a' right by the number of bits given in `count'. If any nonzero | bits are shifted off, they are ``jammed'' into the least significant bit of
include/fpu/softfloat.h +2 -0
@@ -79,6 +79,8 @@ this code that are retained.* version 2 or later. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef SOFTFLOAT_H #define SOFTFLOAT_H
include/hw/acpi/piix4.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ACPI_PIIX4_H #define HW_ACPI_PIIX4_H
include/hw/acpi/tco.h +3 -0
@@ -6,6 +6,9 @@* This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ACPI_TCO_H #define HW_ACPI_TCO_H
include/hw/adc/stm32f2xx_adc.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_STM32F2XX_ADC_H #define HW_STM32F2XX_ADC_H
include/hw/arm/allwinner-a10.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALLWINNER_H_ #include "qemu-common.h"
include/hw/arm/armsse.h +3 -0
@@ -81,6 +81,9 @@* + named GPIO outputs mscexp_ns[0..15] */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARMSSE_H #define ARMSSE_H
include/hw/arm/armv7m.h +3 -0
@@ -7,6 +7,9 @@* This code is licensed under the GPL version 2 or later. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_ARMV7M_H #define HW_ARM_ARMV7M_H
include/hw/arm/aspeed_soc.h +2 -0
@@ -9,6 +9,8 @@* the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ASPEED_SOC_H #define ASPEED_SOC_H
include/hw/arm/bcm2835_peripherals.h +2 -0
@@ -8,6 +8,8 @@* This code is licensed under the GNU GPLv2 and later. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef BCM2835_PERIPHERALS_H #define BCM2835_PERIPHERALS_H
include/hw/arm/bcm2836.h +2 -0
@@ -8,6 +8,8 @@* This code is licensed under the GNU GPLv2 and later. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef BCM2836_H #define BCM2836_H
include/hw/arm/digic.h +3 -0
@@ -15,6 +15,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_DIGIC_H #define HW_ARM_DIGIC_H
include/hw/arm/fsl-imx25.h +2 -0
@@ -14,6 +14,8 @@* for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FSL_IMX25_H #define FSL_IMX25_H
include/hw/arm/fsl-imx31.h +2 -0
@@ -14,6 +14,8 @@* for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FSL_IMX31_H #define FSL_IMX31_H
include/hw/arm/fsl-imx6.h +3 -0
@@ -14,6 +14,9 @@* for more details. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FSL_IMX6_H #define FSL_IMX6_H
include/hw/arm/fsl-imx6ul.h +3 -0
@@ -14,6 +14,9 @@* GNU General Public License for more details. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FSL_IMX6UL_H #define FSL_IMX6UL_H
include/hw/arm/fsl-imx7.h +3 -0
@@ -16,6 +16,9 @@* GNU General Public License for more details. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FSL_IMX7_H #define FSL_IMX7_H
include/hw/arm/msf2-soc.h +3 -0
@@ -22,6 +22,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_MSF2_SOC_H #define HW_ARM_MSF2_SOC_H
include/hw/arm/nrf51_soc.h +3 -0
@@ -7,6 +7,9 @@* the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NRF51_SOC_H #define NRF51_SOC_H
include/hw/arm/omap.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU General Public License along * with this program; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef hw_omap_h#include "exec/memory.h" # define hw_omap_h "omap.h"
include/hw/arm/sharpsl.h +3 -0
@@ -3,6 +3,9 @@* * This file is licensed under the GNU GPL. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_SHARPSL_H #define QEMU_SHARPSL_H
include/hw/arm/stm32f205_soc.h +3 -0
@@ -22,6 +22,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_STM32F205_SOC_H #define HW_ARM_STM32F205_SOC_H
include/hw/arm/xlnx-zynqmp.h +2 -0
@@ -15,6 +15,8 @@* for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XLNX_ZYNQMP_H #include "qemu-common.h"
include/hw/block/fdc.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_FDC_H #define HW_FDC_H
include/hw/block/flash.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_FLASH_H #define HW_FLASH_H
include/hw/char/escc.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ESCC_H #define HW_ESCC_H
include/hw/char/xilinx_uartlite.h +2 -0
@@ -12,6 +12,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XILINX_UARTLITE_H #define XILINX_UARTLITE_H
include/hw/core/generic-loader.h +2 -0
@@ -15,6 +15,8 @@* for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef GENERIC_LOADER_H #define GENERIC_LOADER_H
include/hw/cris/etraxfs.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ETRAXFS_H #define HW_ETRAXFS_H
include/hw/cris/etraxfs_dma.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ETRAXFS_DMA_H #define HW_ETRAXFS_DMA_H
include/hw/display/bcm2835_fb.h +2 -0
@@ -8,6 +8,8 @@* This code is licensed under the GNU GPLv2 and later. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef BCM2835_FB_H #define BCM2835_FB_H
include/hw/display/i2c-ddc.h +2 -0
@@ -16,6 +16,8 @@* with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I2C_DDC_H #define I2C_DDC_H
include/hw/display/xlnx_dp.h +2 -0
@@ -22,6 +22,8 @@* */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#include "hw/sysbus.h" #include "ui/console.h" #include "hw/misc/auxbus.h"
include/hw/dma/xlnx_dpdma.h +2 -0
@@ -22,6 +22,8 @@* */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef XLNX_DPDMA_H #define XLNX_DPDMA_H
include/hw/elf_ops.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +static void glue (bswap_ehdr ,SZ )(struct elfhdr *ehdr) {bswap16s (&ehdr->e_type);/* Object file type */
include/hw/empty_slot.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_EMPTY_SLOT_H #define HW_EMPTY_SLOT_H
include/hw/gpio/bcm2835_gpio.h +2 -0
@@ -11,6 +11,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef BCM2835_GPIO_H #define BCM2835_GPIO_H
include/hw/hyperv/hyperv.h +2 -0
@@ -7,6 +7,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_HYPERV_HYPERV_H #define HW_HYPERV_HYPERV_H
include/hw/i2c/aspeed_i2c.h +3 -0
@@ -17,6 +17,9 @@* with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ASPEED_I2C_H #define ASPEED_I2C_H
include/hw/i386/apic_internal.h +3 -0
@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/> */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_APIC_INTERNAL_H #define QEMU_APIC_INTERNAL_H
include/hw/i386/ioapic_internal.h +2 -0
@@ -19,6 +19,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_IOAPIC_INTERNAL_H #define QEMU_IOAPIC_INTERNAL_H
include/hw/input/hid.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_HID_H #define QEMU_HID_H
include/hw/input/tsc2xxx.h +2 -0
@@ -8,6 +8,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_INPUT_TSC2XXX_H #define HW_INPUT_TSC2XXX_H
include/hw/intc/allwinner-a10-pic.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALLWINNER_A10_PIC_H #define ALLWINNER_A10_PIC_H
include/hw/intc/armv7m_nvic.h +3 -0
@@ -7,6 +7,9 @@* This code is licensed under the GPL version 2 or later. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_ARMV7M_NVIC_H #define HW_ARM_ARMV7M_NVIC_H
include/hw/intc/heathrow_pic.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_INTC_HEATHROW_PIC_H #define HW_INTC_HEATHROW_PIC_H
include/hw/intc/mips_gic.h +3 -0
@@ -8,6 +8,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_GIC_H #define MIPS_GIC_H
include/hw/isa/vt82c686.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_VT82C686_H #define HW_VT82C686_H
include/hw/kvm/clock.h +3 -1
@@ -8,9 +8,11 @@* * This work is licensed under the terms of the GNU GPL version 2. * See the COPYING file in the top-level directory. -* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifdef CONFIG_KVM void kvmclock_create (void );
include/hw/mips/bios.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#include "qemu/units.h" #include "cpu.h"
include/hw/mips/cps.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_CPS_H #define MIPS_CPS_H
include/hw/mips/cpudevs.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifndef HW_MIPS_CPUDEVS_H #define HW_MIPS_CPUDEVS_H
include/hw/misc/bcm2835_property.h +2 -0
@@ -3,6 +3,8 @@* This code is licensed under the GNU GPLv2 and later. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef BCM2835_PROPERTY_H #define BCM2835_PROPERTY_H
include/hw/misc/macio/cuda.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CUDA_H #define CUDA_H
include/hw/misc/macio/gpio.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MACIO_GPIO_H #define MACIO_GPIO_H
include/hw/misc/macio/macio.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MACIO_H #define MACIO_H
include/hw/misc/macio/pmu.h +2 -0
@@ -7,6 +7,8 @@* Copyright (C) 2016 Ben Herrenschmidt */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PMU_H #define PMU_H
include/hw/misc/mips_cmgcr.h +2 -0
@@ -7,6 +7,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_CMGCR_H #define MIPS_CMGCR_H
include/hw/misc/mips_cpc.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_CPC_H #define MIPS_CPC_H
include/hw/misc/pvpanic.h +3 -0
@@ -11,6 +11,9 @@* See the COPYING file in the top-level directory. * */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_MISC_PVPANIC_H #define HW_MISC_PVPANIC_H
include/hw/net/allwinner_emac.h +2 -0
@@ -20,6 +20,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALLWINNER_EMAC_H #define ALLWINNER_EMAC_H
include/hw/net/lance.h +2 -0
@@ -26,6 +26,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef LANCE_H #define LANCE_H
include/hw/nvram/chrp_nvram.h +2 -0
@@ -15,6 +15,8 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CHRP_NVRAM_H #define CHRP_NVRAM_H
include/hw/pci-bridge/simba.h +2 -0
@@ -24,6 +24,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#include "hw/pci/pci_bridge.h"
include/hw/pci-host/sabre.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_PCI_HOST_SABRE_H #define HW_PCI_HOST_SABRE_H
include/hw/pci-host/spapr.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PCI_HOST_SPAPR_H #define PCI_HOST_SPAPR_H
include/hw/pci-host/uninorth.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef UNINORTH_H #define UNINORTH_H
include/hw/pci/pcie_aer.h +2 -0
@@ -18,6 +18,8 @@* with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_PCIE_AER_H #define QEMU_PCIE_AER_H
include/hw/ppc/fdt.h +2 -0
@@ -7,6 +7,8 @@* COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef PPC_FDT_H #define PPC_FDT_H
include/hw/ppc/pnv.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_PNV_H #define PPC_PNV_H
include/hw/ppc/pnv_core.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_PNV_CORE_H #define PPC_PNV_CORE_H
include/hw/ppc/pnv_xscom.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_PNV_XSCOM_H #define PPC_PNV_XSCOM_H
include/hw/ppc/ppc.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifndef HW_PPC_H #define HW_PPC_H
include/hw/ppc/ppc4xx.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC4XX_H #define PPC4XX_H
include/hw/ppc/spapr.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SPAPR_H #define HW_SPAPR_H
include/hw/ppc/spapr_cpu_core.h +4 -0
@@ -6,6 +6,10 @@* This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SPAPR_CPU_CORE_H #define HW_SPAPR_CPU_CORE_H
include/hw/ppc/spapr_irq.h +2 -0
@@ -7,6 +7,8 @@* COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SPAPR_IRQ_H #define HW_SPAPR_IRQ_H
include/hw/ppc/spapr_ovec.h +2 -0
@@ -34,6 +34,8 @@* See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef SPAPR_OVEC_H #define SPAPR_OVEC_H
include/hw/ppc/spapr_vio.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SPAPR_VIO_H #define HW_SPAPR_VIO_H
include/hw/ppc/spapr_xive.h +2 -0
@@ -7,6 +7,8 @@* COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_SPAPR_XIVE_H #define PPC_SPAPR_XIVE_H
include/hw/ppc/xics_spapr.h +3 -0
@@ -24,6 +24,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XICS_SPAPR_H #define XICS_SPAPR_H
include/hw/ppc/xive_regs.h +2 -0
@@ -13,6 +13,8 @@* COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_XIVE_REGS_H #define PPC_XIVE_REGS_H
include/hw/riscv/riscv_hart.h +2 -0
@@ -18,6 +18,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_RISCV_HART_H #define HW_RISCV_HART_H
include/hw/riscv/riscv_htif.h +3 -0
@@ -17,6 +17,9 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_RISCV_HTIF_H #define HW_RISCV_HTIF_H
include/hw/riscv/sifive_clint.h +2 -0
@@ -17,6 +17,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_CLINT_H #define HW_SIFIVE_CLINT_H
include/hw/riscv/sifive_e.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_E_H #define HW_SIFIVE_E_H
include/hw/riscv/sifive_plic.h +2 -0
@@ -18,6 +18,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_PLIC_H #define HW_SIFIVE_PLIC_H
include/hw/riscv/sifive_prci.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_PRCI_H #define HW_SIFIVE_PRCI_H
include/hw/riscv/sifive_test.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_TEST_H #define HW_SIFIVE_TEST_H
include/hw/riscv/sifive_u.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_U_H #define HW_SIFIVE_U_H
include/hw/riscv/sifive_uart.h +2 -0
@@ -17,6 +17,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_SIFIVE_UART_H #define HW_SIFIVE_UART_H
include/hw/riscv/spike.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_RISCV_SPIKE_H #define HW_RISCV_SPIKE_H
include/hw/riscv/virt.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_RISCV_VIRT_H #define HW_RISCV_VIRT_H
include/hw/s390x/3270-ccw.h +3 -0
@@ -10,6 +10,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390X_3270_CCW_H #define HW_S390X_3270_CCW_H
include/hw/s390x/ap-device.h +3 -0
@@ -7,6 +7,9 @@* your option) any later version. See the COPYING file in the top-level * directory. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390X_AP_DEVICE_H #define HW_S390X_AP_DEVICE_H
include/hw/s390x/css-bridge.h +2 -0
@@ -10,6 +10,8 @@* directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390X_CSS_BRIDGE_H #define HW_S390X_CSS_BRIDGE_H #include "qom/object.h"
include/hw/s390x/css.h +3 -0
@@ -9,6 +9,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CSS_H #define CSS_H
include/hw/s390x/s390-ccw.h +3 -0
@@ -10,6 +10,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390_CCW_H #define HW_S390_CCW_H
include/hw/s390x/storage-attributes.h +3 -0
@@ -9,6 +9,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390_STORAGE_ATTRIBUTES_H #define S390_STORAGE_ATTRIBUTES_H
include/hw/s390x/tod.h +2 -0
@@ -8,6 +8,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390_TOD_H #define HW_S390_TOD_H
include/hw/s390x/vfio-ccw.h +3 -0
@@ -11,6 +11,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_VFIO_CCW_H #define HW_VFIO_CCW_H
include/hw/sh4/sh.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_SH_H #define QEMU_SH_H /* Definitions for SH board emulation. */
include/hw/sh4/sh_intc.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH_INTC_H #define SH_INTC_H
include/hw/sparc/grlib.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef GRLIB_H #define GRLIB_H
include/hw/sparc/sparc64.h +1 -0
@@ -1,3 +1,4 @@ +/* FIXME Does not pass make check-headers, yet! */ #define IVEC_MAX 0x40
include/hw/ssi/aspeed_smc.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ASPEED_SMC_H #define ASPEED_SMC_H
include/hw/ssi/xilinx_spips.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XILINX_SPIPS_H #define XILINX_SPIPS_H
include/hw/timer/allwinner-a10-pit.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALLWINNER_A10_PIT_H #define ALLWINNER_A10_PIT_H
include/hw/timer/i8254_internal.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_I8254_INTERNAL_H #define QEMU_I8254_INTERNAL_H
include/hw/timer/m48t59.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_M48T59_H #define HW_M48T59_H
include/hw/timer/mc146818rtc.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MC146818RTC_H #define MC146818RTC_H
include/hw/timer/mc146818rtc_regs.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MC146818RTC_REGS_H #define MC146818RTC_REGS_H
include/hw/timer/sun4v-rtc.h +2 -0
@@ -1 +1,3 @@ +/* FIXME Does not pass make check-headers, yet! */ +void sun4v_rtc_init (hwaddr addr);
include/hw/timer/xlnx-zynqmp-rtc.h +2 -0
@@ -24,6 +24,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#include "hw/register.h" #define TYPE_XLNX_ZYNQMP_RTC "xlnx-zynmp.rtc"
include/hw/vfio/vfio-amd-xgbe.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_VFIO_VFIO_AMD_XGBE_H #define HW_VFIO_VFIO_AMD_XGBE_H
include/hw/vfio/vfio-calxeda-xgmac.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_VFIO_VFIO_CALXEDA_XGMAC_H #define HW_VFIO_VFIO_CALXEDA_XGMAC_H
include/hw/vfio/vfio-common.h +2 -0
@@ -18,6 +18,8 @@* Copyright (C) 2008, IBM, Muli Ben-Yehuda ([email protected]) */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_VFIO_VFIO_COMMON_H #define HW_VFIO_VFIO_COMMON_H
include/hw/vfio/vfio-platform.h +2 -0
@@ -13,6 +13,8 @@* Copyright Red Hat, Inc. 2012 */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_VFIO_VFIO_PLATFORM_H #define HW_VFIO_VFIO_PLATFORM_H
include/hw/virtio/virtio-access.h +3 -0
@@ -13,6 +13,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_VIRTIO_ACCESS_H #define QEMU_VIRTIO_ACCESS_H
include/hw/virtio/virtio-gpu.h +2 -0
@@ -11,6 +11,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_VIRTIO_GPU_H #define HW_VIRTIO_GPU_H
include/hw/virtio/virtio-input.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_VIRTIO_INPUT_H #define QEMU_VIRTIO_INPUT_H
include/hw/virtio/virtio-rng.h +2 -0
@@ -9,6 +9,8 @@* top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_VIRTIO_RNG_H #define QEMU_VIRTIO_RNG_H
include/hw/xen/io/ring.h +2 -0
@@ -24,6 +24,8 @@* Tim Deegan and Andrew Warfield November 2004. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef __XEN_PUBLIC_IO_RING_H__#define __XEN_PUBLIC_IO_RING_H__
include/hw/xen/xen-backend.h +2 -0
@@ -5,6 +5,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef HW_XEN_BACKEND_H #define HW_XEN_BACKEND_H
include/hw/xen/xen-block.h +2 -0
@@ -5,6 +5,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef HW_XEN_BLOCK_H #define HW_XEN_BLOCK_H
include/hw/xen/xen-bus-helper.h +2 -0
@@ -5,6 +5,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef HW_XEN_BUS_HELPER_H #define HW_XEN_BUS_HELPER_H
include/hw/xen/xen-bus.h +2 -0
@@ -5,6 +5,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef HW_XEN_BUS_H #define HW_XEN_BUS_H
include/hw/xen/xen-legacy-backend.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef HW_XEN_LEGACY_BACKEND_H #define HW_XEN_LEGACY_BACKEND_H
include/hw/xen/xen_common.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef QEMU_HW_XEN_COMMON_H #define QEMU_HW_XEN_COMMON_H
include/hw/xen/xen_pvdev.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef QEMU_HW_XEN_PVDEV_H #define QEMU_HW_XEN_PVDEV_H
include/libdecnumber/decNumberLocal.h +2 -0
@@ -37,6 +37,8 @@/* decNumber.h or one of decDouble (etc.) must be included first. */ /* ------------------------------------------------------------------ */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef DECNUMBERLOCAL_H #define DECNUMBERLOCAL_H
include/migration/cpu.h +4 -0
@@ -1,4 +1,8 @@/* Declarations for use for CPU state serialization. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIGRATION_CPU_H #define MIGRATION_CPU_H
include/monitor/hmp-target.h +3 -0
@@ -22,6 +22,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MONITOR_HMP_TARGET_H #define MONITOR_HMP_TARGET_H
include/qemu/atomic128.h +2 -0
@@ -10,6 +10,8 @@* atomic primitive is meant to provide. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_ATOMIC128_H #define QEMU_ATOMIC128_H
include/qemu/futex.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_FUTEX_H #define QEMU_FUTEX_H
include/qemu/ratelimit.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_RATELIMIT_H #define QEMU_RATELIMIT_H
include/qemu/thread-win32.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_THREAD_WIN32_H #define QEMU_THREAD_WIN32_H
include/qemu/xattr.h +3 -0
@@ -10,6 +10,9 @@* later version. See the COPYING file in the top-level directory. * */ + +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_XATTR_H #define QEMU_XATTR_H
include/sysemu/balloon.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_BALLOON_H #define QEMU_BALLOON_H
include/sysemu/cryptodev-vhost-user.h +3 -0
@@ -20,6 +20,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. * */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CRYPTODEV_VHOST_USER_H #define CRYPTODEV_VHOST_USER_H
include/sysemu/dump.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef DUMP_H #define DUMP_H
include/sysemu/hvf.h +3 -0
@@ -10,6 +10,9 @@/* header to be included in non-HVF-specific code */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HVF_H #define HVF_H
include/sysemu/iothread.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef IOTHREAD_H #define IOTHREAD_H
include/sysemu/kvm_int.h +2 -0
@@ -6,6 +6,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_KVM_INT_H #define QEMU_KVM_INT_H
include/sysemu/memory_mapping.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MEMORY_MAPPING_H #define MEMORY_MAPPING_H
include/sysemu/os-posix.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers without CONFIG_POSIX, yet! */ +#ifndef QEMU_OS_POSIX_H #define QEMU_OS_POSIX_H
include/sysemu/os-win32.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */ +#ifndef QEMU_OS_WIN32_H #define QEMU_OS_WIN32_H
include/sysemu/xen-mapcache.h +2 -0
@@ -6,6 +6,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XEN_MAPCACHE_H #define XEN_MAPCACHE_H
include/trace-tcg.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TRACE_TCG_H #define TRACE_TCG_H
include/ui/console.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef CONSOLE_H #define CONSOLE_H
include/ui/egl-context.h +3 -0
@@ -1,3 +1,6 @@ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +/* FIXME Does not pass make check-headers without CONFIG_OPENGL, yet! */ +#ifndef EGL_CONTEXT_H #define EGL_CONTEXT_H
include/ui/egl-helpers.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef EGL_HELPERS_H #define EGL_HELPERS_H
include/ui/gtk.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef UI_GTK_H #define UI_GTK_H
include/ui/input.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef INPUT_H #define INPUT_H
include/ui/pixel_ops.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +static inline unsigned int rgb_to_pixel8 (unsigned int r,unsigned int g,unsigned int b) {
include/ui/qemu-pixman.h +2 -0
@@ -3,6 +3,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef QEMU_PIXMAN_H #define QEMU_PIXMAN_H
include/ui/sdl2.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SDL2_H #define SDL2_H
include/ui/shader.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_OPENGL, yet! */ +#ifndef QEMU_SHADER_H #define QEMU_SHADER_H
include/ui/spice-display.h +2 -0
@@ -15,6 +15,8 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#include <spice/ipc_ring.h> #include <spice/enums.h> #include <spice/qxl_dev.h>
tests/Makefile.include +30 -2
@@ -15,6 +15,7 @@ check-help: @echo " $(MAKE) check-tcg Run TCG tests" @echo " $(MAKE) check-softfloat Run FPU emulation tests" @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" + @echo " $(MAKE) check-source Run source code tests" @echo @echo " $(MAKE) check-report.html Generates an HTML test report" @echo " $(MAKE) check-venv Creates a Python venv for tests"
@@ -485,6 +486,7 @@ generated-files-y += tests/test-qapi-introspect.h QEMU_CFLAGS += -I$(SRC_PATH)/tests +include $(SRC_PATH)/tests/check-headers.mak # Deps that are common to various different sets of tests below test-util-obj-y = libqemuutil.a
@@ -1147,13 +1149,38 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) --failfast=on $(SRC_PATH)/tests/acceptance, \ "AVOCADO", "tests/acceptance") +# Header sanity checking + +RECURSIVE_TARGETS += check-headers check-bad-headers + +.PHONY: check-headers check-bad-headers +ifeq ($(wildcard $(SRC_PATH)/.git),) +check-headers check-bad-headers: + @echo " SKIP $@ (requires a git tree)" +else +check-headers: $(check-header-tests:.c=.o) +check-headers: $(addsuffix /check-headers, $(TARGET_DIRS)) + +# Expected to fail: +check-bad-headers: $(check-bad-header-tests:.c=.o) +check-bad-headers: $(addsuffix /check-bad-headers, $(TARGET_DIRS)) + +.SECONDARY: $(check-header-tests) $(check-bad-header-tests) +$(check-header-tests) $(check-bad-header-tests): tests/header-test-template.c + @mkdir -p $(dir $@) + @sed 's,@header@,$(subst tests/headers/,,$(@:.c=.h)),' <$< >$@ +endif + # Consolidated targets -.PHONY: check-block check-qapi-schema check-qtest check-unit check check-clean +.PHONY: check-block check-qapi-schema check-qtest check-unit check-source +.PHONY: check check-clean check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y)) check-tests/qapi-schema/doc-good.texi check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) check-block: $(patsubst %,check-%, $(check-block-y)) -check: check-qapi-schema check-unit check-softfloat check-qtest check-decodetree +check-source: check-headers +check: check-qapi-schema check-unit check-softfloat check-qtest check-decodetree check-source + check-clean: rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) rm -rf $(sort $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(target)-y)) $(check-qtest-generic-y))
@@ -1168,5 +1195,6 @@ all: $(QEMU_IOTESTS_HELPERS-y) -include $(wildcard tests/*.d) -include $(wildcard tests/libqos/*.d) +-include $(check-header-tests:.c=.d) $(check-bad-header-tests:.c=.d) endif
tests/check-headers.mak new file +42 -0
42 lines not on this page · raw message
tests/header-test-template.c new file +16 -0
@@ -0,0 +1,16 @@ +/* +* Template for make check-headers +* +* Copyright (C) 2016 Red Hat, Inc. +* +* Authors: +* Markus Armbruster <[email protected]> +* +* This work is licensed under the terms of the GNU GPL, version 2 or +* later. See the COPYING file in the top-level directory. +*/ + +#include "qemu/osdep.h" +#include "@header@" +/* Include a second time to catch missing header guard */ +#include "@header@"
Signature · 1 line
2.17.2
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
Quoted 3 lines · Markus Armbruster
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside
include/for now.
A lot of these, either in include/ or outside, are _meant_ to be included many times. What about renaming those to .inc.h and whitelisting them in the script?
Paolo
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
Quoted 8 lines · Paolo Bonzini
Quoted 3 lines · Markus Armbruster
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside
include/for now.A lot of these, either in
include/or outside, are _meant_ to be included many times. What about renaming those to.inc.hand whitelisting them in the script?
Yes, that would be nice.
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
Quoted 7 lines · Markus Armbruster
Quoted 6 lines
Quoted 3 lines
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside
include/for now.A lot of these, either in
include/or outside, are _meant_ to be included many times. What about renaming those to.inc.hand whitelisting them in the script?Yes, that would be nice.
Another suggestion: are there headers that cannot even be included once (due to dependencies)? Is it worth including a test for those even in the first iteration?
.inc.h files would skip that test too.
Paolo
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
Quoted 7 lines · Paolo Bonzini
Quoted 6 lines · Markus Armbruster
Quoted 6 lines
Quoted 3 lines
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside
include/for now.A lot of these, either in
include/or outside, are _meant_ to be included many times. What about renaming those to.inc.hand whitelisting them in the script?
Quoted 7 lines
Quoted 1 line
Yes, that would be nice.
Another suggestion: are there headers that cannot even be included once (due to dependencies)? Is it worth including a test for those even in the first iteration?
.inc.hfiles would skip that test too.
I'm not sure I get what you mean.
Most headers failing the test fail it in the first #include: they fail to conform to 2. Headers should normally include everything they need beyond osdep.h.
The only way to fail in the second #include is a missing header guard. If it's missing intentionally, it's "_meant_ to be included many times", and you propose renaming to .inc.h. Else, easy fix.
I think I'll make a list of headers that fail in the second #include, and try to sort them into "intentional" and "bug" buckets.
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
Quoted 9 lines · Markus Armbruster
Quoted 4 lines
Another suggestion: are there headers that cannot even be included once (due to dependencies)? Is it worth including a test for those even in the first iteration?
I'm not sure I get what you mean.
Most headers failing the test fail it in the first #include: they fail to conform to 2. Headers should normally include everything they need beyond
osdep.h.
Ok, good to know.
Quoted 6 lines
The only way to fail in the second #include is a missing header guard. If it's missing intentionally, it's "_meant_ to be included many times", and you propose renaming to
.inc.h. Else, easy fix.I think I'll make a list of headers that fail in the second #include, and try to sort them into "intentional" and "bug" buckets.
The proposal is to make two tests, but it can come later.
Another idea could be to make it print the result as TAP. But I could work on that later.
Paolo
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
In reply to Markus ArmbrusterQuoted 49 lines · Markus Armbruster
Make target check-source is for checking the source code itself. For now, there's just one such check, make target check-headers. It checks basic header sanity: for each header "
FOO.h", test whether#include "qemu/osdep.h" #include "FOO.h" #include "FOO.h"compiles.
The test works only in a git tree, with git installed. It is skipped unless $(SRC_PATH)/.git exists.
Third-party headers we don't intend to clean up are excluded from this test. So are a few "funny" headers. See make variable excluded-headers.
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside
include/for now.Headers known to fail the test are marked with
/* FIXME Does not pass make check-headers, yet! */Headers known to work only in certain configurations are marked like
/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */I tried to find and mark all of them by testing various configurations. Still, "make check" might fail for configurations I didn't test.
Known issue: some of these don't actually need fixing; they're *meant* to work only in certain configurations. We'll want to invent a suitable marker that doesn't claim FIXME.
Some headers may only be included into target-dependent code: they use identifiers poisoned by
exec/poison.h, or includecpu.h. These headers are marked with a comment/* NOTE: May only be included into target-dependent code */The test treats them specially.
Known issue: some of these are intended for specific targets. The test should skip them for other targets, but doesn't. They're marked FIXME instead, which is wrong.
Quoted 5 lines
New make target check-bad-headers runs the test for headers expected to fail it. This helps with examining the failures.
Signed-off-by Markus Armbruster <[email protected]>---
[...]>
Quoted 58 lines
Makefile +3
-1@@ -416,6 +416,8 @@ dummy := $(call unnest-vars,, \ audio-obj-m \ trace-obj-y) +RECURSIVE_TARGETS := all clean install + include $(SRC_PATH)/tests/Makefile.include all: $(DOCS) $(if $(BUILD_DOCS),sphinxdocs) $(TOOLS) $(HELPERS-y) recurse-all modules@@ -436,7 +438,7 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -TARGET_DIRS_RULES := $(foreach t, all clean install, $(addsuffix /$(t), $(TARGET_DIRS))) +TARGET_DIRS_RULES:=$(foreach t, $(RECURSIVE_TARGETS), $(addsuffix /$(t), $(TARGET_DIRS))) SOFTMMU_ALL_RULES=$(filter %-softmmu/all, $(TARGET_DIRS_RULES)) $(SOFTMMU_ALL_RULES): $(authz-obj-y)Makefile.target +17
-0@@ -41,6 +41,7 @@ STPFILES= # Makefile Tests include $(SRC_PATH)/tests/tcg/Makefile.include +include $(SRC_PATH)/tests/check-headers.mak config-target.h: config-target.h-timestamp config-target.h-timestamp: config-target.mak@@ -216,6 +217,22 @@ hmp-commands.h: $(SRC_PATH)/hmp-commands.hx $(SRC_PATH)/scripts/hxtool hmp-commands-info.h: $(SRC_PATH)/hmp-commands-info.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$(TARGET_DIR)$@") +.PHONY: check-headers +ifeq ($(wildcard $(SRC_PATH)/.git),) +check-headers check-bad-headers: + @echo " SKIP $@ (requires a git tree)" +else +check-headers: $(check-target-header-tests:.c=.o) + +# Expected to fail: +check-bad-headers: $(check-bad-target-header-tests:.c=.o) + +.SECONDARY: $(check-target-header-tests) +$(check-target-header-tests) $(check-bad-target-header-tests): tests/header-test-template.c + @mkdir -p $(dir $@) + @sed 's,@header@,$(subst tests/headers/,,$(@:.c=.h)),' <$< >$@ +endif + clean: clean-target rm -f *.a *~ $(PROGS) rm -f $(shell find . -name '*.[od]')
Makefile.target endif · line 259
Quoted 5 lines
Makefile.target +2
-0@@ -238,3 +255,5 @@ endif generated-files-y += config-target.h Makefile: $(generated-files-y) + +-include $(check-target-header-tests:.c=.d) $(check-bad-target-header-tests:.c=.d)
$ make microblazeel-softmmu/tests/headers/include/exec/user/abitypes.o ./include/exec/user/abitypes.h:6:10: fatal error: cpu.h: No such file or directory make: *** [./rules.mak:69: microblazeel-softmmu/tests/headers/include/exec/user/abitypes.o] Error 1
^ this one looks legit, it's arch-specific, right?
$ make tests/headers/include/hw/net/lance.o
CC tests/headers/include/hw/net/lance.o
In file included from tests/headers/include/hw/net/lance.c:14:
./include/hw/net/lance.h:42:5: error: unknown type name ‘SysBusDevice’
SysBusDevice parent_obj;
^~~~~~~~~~~~
make: *** [./rules.mak:69: tests/headers/include/hw/net/lance.o] Error 1$ make tests/headers/include/hw/isa/vt82c686.o
CC tests/headers/include/hw/isa/vt82c686.o
In file included from tests/headers/include/hw/isa/vt82c686.c:14:
./include/hw/isa/vt82c686.h:13:27: error: unknown type name ‘qemu_irq’
qemu_irq sci_irq);
^~~~~~~~
make: *** [./rules.mak:69: tests/headers/include/hw/isa/vt82c686.o]Nice, I like it :)
The rule pattern is not obvious (in particular with arch-specific targets), but it has probably always been like that.
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
Quoted 126 lines · Philippe Mathieu-Daudé
Quoted 49 lines · Markus Armbruster
Make target check-source is for checking the source code itself. For now, there's just one such check, make target check-headers. It checks basic header sanity: for each header "
FOO.h", test whether#include "qemu/osdep.h" #include "FOO.h" #include "FOO.h"compiles.
The test works only in a git tree, with git installed. It is skipped unless $(SRC_PATH)/.git exists.
Third-party headers we don't intend to clean up are excluded from this test. So are a few "funny" headers. See make variable excluded-headers.
A large number of headers don't pass this test, by design or by accident. To keep things more manageable, exclude all headers outside
include/for now.Headers known to fail the test are marked with
/* FIXME Does not pass make check-headers, yet! */Headers known to work only in certain configurations are marked like
/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */I tried to find and mark all of them by testing various configurations. Still, "make check" might fail for configurations I didn't test.
Known issue: some of these don't actually need fixing; they're *meant* to work only in certain configurations. We'll want to invent a suitable marker that doesn't claim FIXME.
Some headers may only be included into target-dependent code: they use identifiers poisoned by
exec/poison.h, or includecpu.h. These headers are marked with a comment/* NOTE: May only be included into target-dependent code */The test treats them specially.
Known issue: some of these are intended for specific targets. The test should skip them for other targets, but doesn't. They're marked FIXME instead, which is wrong.
Quoted 5 lines
New make target check-bad-headers runs the test for headers expected to fail it. This helps with examining the failures.
Signed-off-by Markus Armbruster <[email protected]>---
[...]>
Quoted 58 lines
Makefile +3
-1@@ -416,6 +416,8 @@ dummy := $(call unnest-vars,, \ audio-obj-m \ trace-obj-y) +RECURSIVE_TARGETS := all clean install + include $(SRC_PATH)/tests/Makefile.include all: $(DOCS) $(if $(BUILD_DOCS),sphinxdocs) $(TOOLS) $(HELPERS-y) recurse-all modules@@ -436,7 +438,7 @@ config-host.h-timestamp: config-host.mak qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$@") -TARGET_DIRS_RULES := $(foreach t, all clean install, $(addsuffix /$(t), $(TARGET_DIRS))) +TARGET_DIRS_RULES:=$(foreach t, $(RECURSIVE_TARGETS), $(addsuffix /$(t), $(TARGET_DIRS))) SOFTMMU_ALL_RULES=$(filter %-softmmu/all, $(TARGET_DIRS_RULES)) $(SOFTMMU_ALL_RULES): $(authz-obj-y)Makefile.target +17
-0@@ -41,6 +41,7 @@ STPFILES= # Makefile Tests include $(SRC_PATH)/tests/tcg/Makefile.include +include $(SRC_PATH)/tests/check-headers.mak config-target.h: config-target.h-timestamp config-target.h-timestamp: config-target.mak@@ -216,6 +217,22 @@ hmp-commands.h: $(SRC_PATH)/hmp-commands.hx $(SRC_PATH)/scripts/hxtool hmp-commands-info.h: $(SRC_PATH)/hmp-commands-info.hx $(SRC_PATH)/scripts/hxtool $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,"GEN","$(TARGET_DIR)$@") +.PHONY: check-headers +ifeq ($(wildcard $(SRC_PATH)/.git),) +check-headers check-bad-headers: + @echo " SKIP $@ (requires a git tree)" +else +check-headers: $(check-target-header-tests:.c=.o) + +# Expected to fail: +check-bad-headers: $(check-bad-target-header-tests:.c=.o) + +.SECONDARY: $(check-target-header-tests) +$(check-target-header-tests) $(check-bad-target-header-tests): tests/header-test-template.c + @mkdir -p $(dir $@) + @sed 's,@header@,$(subst tests/headers/,,$(@:.c=.h)),' <$< >$@ +endif + clean: clean-target rm -f *.a *~ $(PROGS) rm -f $(shell find . -name '*.[od]')Makefile.target endif · line 259
Quoted 5 lines
Makefile.target +2
-0@@ -238,3 +255,5 @@ endif generated-files-y += config-target.h Makefile: $(generated-files-y) + +-include $(check-target-header-tests:.c=.d) $(check-bad-target-header-tests:.c=.d)$ make microblazeel-softmmu/tests/headers/include/exec/user/abitypes.o ./include/exec/user/abitypes.h:6:10: fatal error: cpu.h: No such file or directory make: *** [./rules.mak:69: microblazeel-softmmu/tests/headers/include/exec/user/abitypes.o] Error 1
Quoted 1 line
^ this one looks legit, it's arch-specific, right?
Yes: it includes cpu.h.
Quoted 16 lines
$ make tests/headers/include/hw/net/lance.o CC tests/headers/include/hw/net/lance.o In file included from tests/headers/include/hw/net/lance.c:14: ./include/hw/net/lance.h:42:5: error: unknown type name ‘SysBusDevice’ SysBusDevice parent_obj; ^~~~~~~~~~~~ make: *** [./rules.mak:69: tests/headers/include/hw/net/lance.o] Error 1$ make tests/headers/include/hw/isa/vt82c686.o CC tests/headers/include/hw/isa/vt82c686.o In file included from tests/headers/include/hw/isa/vt82c686.c:14: ./include/hw/isa/vt82c686.h:13:27: error: unknown type name ‘qemu_irq’ qemu_irq sci_irq); ^~~~~~~~ make: *** [./rules.mak:69: tests/headers/include/hw/isa/vt82c686.o]
Quoted 6 lines
Nice, I like it :)
The rule pattern is not obvious (in particular with arch-specific targets), but it has probably always been like that.
Thanks!
RFC v4 6/7 tests: Don't limit check-headers to include/
In reply to Markus Armbruster--- accel/tcg/atomic_template.h | 3 +++ accel/tcg/tcg-runtime.h | 3 +++ accel/tcg/translate-all.h | 4 ++++ audio/audio_int.h | 2 ++ audio/audio_template.h | 2 ++ audio/audio_win_int.h | 2 ++ audio/dsound_template.h | 3 +++ audio/mixeng_template.h | 2 ++ audio/rate_template.h | 2 ++ block/crypto.h | 2 ++ block/qcow2.h | 2 ++ block/vhdx.h | 2 ++ bsd-user/i386/target_signal.h | 3 +++ bsd-user/i386/target_syscall.h | 2 ++ bsd-user/qemu.h | 4 ++++ bsd-user/sparc/target_signal.h | 3 +++ bsd-user/sparc/target_syscall.h | 2 ++ bsd-user/sparc64/target_signal.h | 3 +++ bsd-user/sparc64/target_syscall.h | 2 ++ bsd-user/syscall_defs.h | 2 ++ bsd-user/x86_64/target_signal.h | 3 +++ bsd-user/x86_64/target_syscall.h | 2 ++ contrib/ivshmem-client/ivshmem-client.h | 2 ++ contrib/ivshmem-server/ivshmem-server.h | 2 ++ contrib/libvhost-user/libvhost-user-glib.h | 2 ++ contrib/libvhost-user/libvhost-user.h | 2 ++ contrib/rdmacm-mux/rdmacm-mux.h | 2 ++ crypto/afalgpriv.h | 2 ++ crypto/cipherpriv.h | 2 ++ crypto/hashpriv.h | 2 ++ crypto/hmacpriv.h | 2 ++ disas/nanomips.h | 2 ++ fpu/softfloat-specialize.h | 3 +++ fsdev/file-op-9p.h | 2 ++ fsdev/qemu-fsdev.h | 3 +++ hw/9pfs/9p-local.h | 2 ++ hw/9pfs/9p-proxy.h | 2 ++ hw/9pfs/9p-synth.h | 2 ++ hw/9pfs/9p-util.h | 2 ++ hw/9pfs/9p-xattr.h | 2 ++ hw/9pfs/9p.h | 2 ++ hw/9pfs/coth.h | 2 ++ hw/9pfs/virtio-9p.h | 2 ++ hw/9pfs/xen-9pfs.h | 3 ++- hw/arm/smmu-internal.h | 2 ++ hw/arm/smmuv3-internal.h | 2 ++ hw/audio/hda-codec-common.h | 3 ++- hw/audio/lm4549.h | 2 ++ hw/block/dataplane/xen-block.h | 2 ++ hw/block/nvme.h | 2 ++ hw/block/xen_blkif.h | 2 ++ hw/cris/boot.h | 2 ++ hw/display/ati_int.h | 2 ++ hw/display/cirrus_vga_internal.h | 2 ++ hw/display/cirrus_vga_rop.h | 2 ++ hw/display/cirrus_vga_rop2.h | 2 ++ hw/display/framebuffer.h | 2 ++ hw/display/milkymist-vgafb_template.h | 3 ++- hw/display/omap_lcd_template.h | 3 +++ hw/display/pl110_template.h | 2 ++ hw/display/pxa2xx_template.h | 2 ++ hw/display/qxl.h | 4 ++++ hw/display/sm501_template.h | 2 ++ hw/display/tc6393xb_template.h | 2 ++ hw/display/vga-helpers.h | 2 ++ hw/display/vga_int.h | 2 ++ hw/ide/ahci_internal.h | 2 ++ hw/input/adb-internal.h | 2 ++ hw/lm32/lm32.h | 2 ++ hw/lm32/lm32_hwsetup.h | 3 +++ hw/lm32/milkymist-hw.h | 2 ++ hw/microblaze/boot.h | 2 ++ hw/net/can/can_sja1000.h | 3 +++ hw/net/e1000e_core.h | 2 ++ hw/net/e1000x_common.h | 2 ++ hw/net/pcnet.h | 2 ++ hw/net/rocker/rocker_desc.h | 2 ++ hw/net/rocker/rocker_fp.h | 2 ++ hw/net/rocker/rocker_of_dpa.h | 2 ++ hw/net/rocker/rocker_tlv.h | 2 ++ hw/net/rocker/rocker_world.h | 2 ++ hw/net/vmware_utils.h | 2 ++ hw/net/vmxnet3_defs.h | 3 ++- hw/nios2/boot.h | 3 +++ hw/ppc/ppc405.h | 2 ++ hw/ppc/ppc440.h | 2 ++ hw/rdma/rdma_backend.h | 2 ++ hw/rdma/rdma_backend_defs.h | 2 ++ hw/rdma/rdma_rm.h | 2 ++ hw/rdma/rdma_rm_defs.h | 2 ++ hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_dev_ring.h | 2 ++ hw/rdma/vmw/pvrdma_qp_ops.h | 2 ++ hw/s390x/ccw-device.h | 3 +++ hw/s390x/ipl.h | 3 +++ hw/s390x/s390-pci-bus.h | 3 +++ hw/s390x/s390-pci-inst.h | 3 +++ hw/s390x/s390-virtio-hcall.h | 2 ++ hw/s390x/virtio-ccw.h | 3 +++ hw/scsi/mptsas.h | 2 ++ hw/scsi/viosrp.h | 3 +++ hw/sd/sdhci-internal.h | 3 +++ hw/timer/m48t59-internal.h | 2 ++ hw/tpm/tpm_ioctl.h | 2 ++ hw/usb/desc.h | 2 ++ hw/usb/hcd-ohci.h | 2 ++ hw/usb/hcd-xhci.h | 2 ++ hw/usb/quirks.h | 2 ++ hw/vfio/pci.h | 3 +++ hw/xen/xen_pt.h | 2 ++ hw/xtensa/bootparam.h | 2 ++ hw/xtensa/xtensa_memory.h | 3 +++ linux-user/aarch64/target_cpu.h | 3 +++ linux-user/aarch64/target_fcntl.h | 3 +++ linux-user/aarch64/target_signal.h | 2 ++ linux-user/aarch64/target_structs.h | 3 +++ linux-user/aarch64/target_syscall.h | 3 +++ linux-user/aarch64/termbits.h | 2 ++ linux-user/alpha/target_cpu.h | 3 +++ linux-user/alpha/target_fcntl.h | 3 +++ linux-user/alpha/target_signal.h | 2 ++ linux-user/alpha/target_structs.h | 3 +++ linux-user/alpha/target_syscall.h | 2 ++ linux-user/alpha/termbits.h | 2 ++ linux-user/arm/nwfpe/fpa11.h | 3 +++ linux-user/arm/nwfpe/fpopcode.h | 2 ++ linux-user/arm/target_cpu.h | 3 +++ linux-user/arm/target_fcntl.h | 3 +++ linux-user/arm/target_signal.h | 2 ++ linux-user/arm/target_structs.h | 3 +++ linux-user/arm/target_syscall.h | 3 +++ linux-user/arm/termbits.h | 2 ++ linux-user/cpu_loop-common.h | 3 +++ linux-user/cris/target_cpu.h | 3 +++ linux-user/cris/target_fcntl.h | 3 +++ linux-user/cris/target_signal.h | 2 ++ linux-user/cris/target_structs.h | 3 +++ linux-user/cris/termbits.h | 2 ++ linux-user/fd-trans.h | 2 ++ linux-user/flat.h | 2 ++ linux-user/generic/fcntl.h | 3 +++ linux-user/host/aarch64/hostdep.h | 2 ++ linux-user/host/arm/hostdep.h | 2 ++ linux-user/host/i386/hostdep.h | 2 ++ linux-user/host/ppc64/hostdep.h | 2 ++ linux-user/host/riscv64/hostdep.h | 2 ++ linux-user/host/s390x/hostdep.h | 2 ++ linux-user/host/x86_64/hostdep.h | 2 ++ linux-user/hppa/target_cpu.h | 3 +++ linux-user/hppa/target_fcntl.h | 3 +++ linux-user/hppa/target_signal.h | 2 ++ linux-user/hppa/target_structs.h | 3 +++ linux-user/hppa/target_syscall.h | 2 ++ linux-user/hppa/termbits.h | 2 ++ linux-user/i386/target_cpu.h | 3 +++ linux-user/i386/target_fcntl.h | 3 +++ linux-user/i386/target_signal.h | 2 ++ linux-user/i386/target_structs.h | 3 +++ linux-user/i386/target_syscall.h | 2 ++ linux-user/i386/termbits.h | 2 ++ linux-user/ioctls.h | 2 ++ linux-user/linux_loop.h | 2 ++ linux-user/m68k/target_cpu.h | 2 ++ linux-user/m68k/target_elf.h | 2 ++ linux-user/m68k/target_fcntl.h | 3 +++ linux-user/m68k/target_signal.h | 2 ++ linux-user/m68k/target_structs.h | 3 +++ linux-user/m68k/target_syscall.h | 2 ++ linux-user/m68k/termbits.h | 2 ++ linux-user/microblaze/target_cpu.h | 3 +++ linux-user/microblaze/target_fcntl.h | 3 +++ linux-user/microblaze/target_signal.h | 2 ++ linux-user/microblaze/target_structs.h | 3 +++ linux-user/microblaze/termbits.h | 2 ++ linux-user/mips/target_cpu.h | 3 +++ linux-user/mips/target_elf.h | 2 ++ linux-user/mips/target_fcntl.h | 3 +++ linux-user/mips/target_signal.h | 3 +++ linux-user/mips/target_structs.h | 3 +++ linux-user/mips/target_syscall.h | 2 ++ linux-user/mips/termbits.h | 2 ++ linux-user/mips64/syscall_nr.h | 2 ++ linux-user/mips64/target_cpu.h | 3 +++ linux-user/mips64/target_elf.h | 2 ++ linux-user/mips64/target_fcntl.h | 3 +++ linux-user/mips64/target_signal.h | 2 ++ linux-user/mips64/target_structs.h | 2 ++ linux-user/mips64/target_syscall.h | 2 ++ linux-user/mips64/termbits.h | 2 ++ linux-user/nios2/target_cpu.h | 2 ++ linux-user/nios2/target_fcntl.h | 3 +++ linux-user/nios2/target_signal.h | 2 ++ linux-user/nios2/target_structs.h | 3 +++ linux-user/nios2/termbits.h | 2 ++ linux-user/openrisc/target_cpu.h | 2 ++ linux-user/openrisc/target_fcntl.h | 3 +++ linux-user/openrisc/target_signal.h | 2 ++ linux-user/openrisc/target_structs.h | 3 +++ linux-user/openrisc/target_syscall.h | 3 +++ linux-user/openrisc/termbits.h | 2 ++ linux-user/ppc/syscall_nr.h | 3 +++ linux-user/ppc/target_cpu.h | 4 ++++ linux-user/ppc/target_elf.h | 2 ++ linux-user/ppc/target_fcntl.h | 3 +++ linux-user/ppc/target_signal.h | 3 +++ linux-user/ppc/target_structs.h | 3 +++ linux-user/ppc/target_syscall.h | 3 +++ linux-user/ppc/termbits.h | 2 ++ linux-user/qemu.h | 2 ++ linux-user/riscv/target_cpu.h | 2 ++ linux-user/riscv/target_fcntl.h | 3 +++ linux-user/riscv/target_signal.h | 2 ++ linux-user/riscv/target_structs.h | 3 +++ linux-user/riscv/target_syscall.h | 2 ++ linux-user/riscv/termbits.h | 2 ++ linux-user/s390x/syscall_nr.h | 2 ++ linux-user/s390x/target_cpu.h | 3 +++ linux-user/s390x/target_fcntl.h | 3 +++ linux-user/s390x/target_signal.h | 2 ++ linux-user/s390x/target_structs.h | 3 +++ linux-user/s390x/target_syscall.h | 2 ++ linux-user/s390x/termbits.h | 2 ++ linux-user/sh4/target_cpu.h | 3 +++ linux-user/sh4/target_fcntl.h | 3 +++ linux-user/sh4/target_signal.h | 2 ++ linux-user/sh4/target_structs.h | 3 +++ linux-user/sh4/target_syscall.h | 2 ++ linux-user/sh4/termbits.h | 2 ++ linux-user/signal-common.h | 3 +++ linux-user/socket.h | 2 ++ linux-user/sparc/target_cpu.h | 4 ++++ linux-user/sparc/target_elf.h | 2 ++ linux-user/sparc/target_fcntl.h | 3 +++ linux-user/sparc/target_signal.h | 2 ++ linux-user/sparc/target_structs.h | 3 +++ linux-user/sparc/target_syscall.h | 2 ++ linux-user/sparc/termbits.h | 2 ++ linux-user/sparc64/target_cpu.h | 3 +++ linux-user/sparc64/target_fcntl.h | 3 +++ linux-user/sparc64/target_signal.h | 2 ++ linux-user/sparc64/target_structs.h | 3 +++ linux-user/sparc64/target_syscall.h | 3 +++ linux-user/sparc64/termbits.h | 2 ++ linux-user/syscall_defs.h | 2 ++ linux-user/syscall_types.h | 2 ++ linux-user/tilegx/target_cpu.h | 3 +++ linux-user/tilegx/target_fcntl.h | 3 +++ linux-user/tilegx/target_signal.h | 2 ++ linux-user/tilegx/target_structs.h | 3 +++ linux-user/tilegx/target_syscall.h | 2 ++ linux-user/uname.h | 2 ++ linux-user/x86_64/target_cpu.h | 3 +++ linux-user/x86_64/target_fcntl.h | 3 +++ linux-user/x86_64/target_signal.h | 2 ++ linux-user/x86_64/target_structs.h | 3 +++ linux-user/x86_64/target_syscall.h | 2 ++ linux-user/x86_64/termbits.h | 2 ++ linux-user/xtensa/target_cpu.h | 3 +++ linux-user/xtensa/target_elf.h | 2 ++ linux-user/xtensa/target_fcntl.h | 3 +++ linux-user/xtensa/target_signal.h | 2 ++ linux-user/xtensa/target_structs.h | 3 +++ linux-user/xtensa/target_syscall.h | 2 ++ linux-user/xtensa/termbits.h | 2 ++ migration/postcopy-ram.h | 3 +++ migration/qemu-file.h | 2 ++ net/colo-compare.h | 2 ++ qemu-options-wrapper.h | 1 + qga/guest-agent-core.h | 3 +++ qga/service-win32.h | 2 ++ qga/vss-win32.h | 2 ++ qga/vss-win32/install.h | 2 ++ qga/vss-win32/requester.h | 2 ++ qga/vss-win32/vss-common.h | 2 ++ replay/replay-internal.h | 2 ++ replication.h | 2 ++ target/alpha/cpu.h | 3 +++ target/alpha/helper.h | 2 ++ target/arm/arm-powerctl.h | 3 +++ target/arm/arm_ldst.h | 3 +++ target/arm/cpu.h | 3 +++ target/arm/helper-a64.h | 3 +++ target/arm/helper-sve.h | 2 ++ target/arm/helper.h | 3 +++ target/arm/internals.h | 2 ++ target/arm/kvm-consts.h | 4 ++++ target/arm/kvm_arm.h | 3 +++ target/arm/op_addsub.h | 2 ++ target/arm/translate-a64.h | 2 ++ target/arm/translate.h | 3 +++ target/cris/cpu.h | 3 +++ target/cris/helper.h | 2 ++ target/cris/mmu.h | 2 ++ target/hppa/cpu.h | 3 +++ target/hppa/helper.h | 2 ++ target/i386/cc_helper_template.h | 2 ++ target/i386/cpu-qom.h | 3 +++ target/i386/cpu.h | 3 +++ target/i386/hax-i386.h | 3 +++ target/i386/hax-posix.h | 2 ++ target/i386/hax-windows.h | 2 ++ target/i386/helper.h | 3 +++ target/i386/hvf/hvf-i386.h | 3 +++ target/i386/hvf/vmcs.h | 2 ++ target/i386/hvf/vmx.h | 2 ++ target/i386/hvf/x86.h | 2 ++ target/i386/hvf/x86_decode.h | 3 +++ target/i386/hvf/x86_descr.h | 2 ++ target/i386/hvf/x86_emu.h | 3 +++ target/i386/hvf/x86_flags.h | 3 +++ target/i386/hvf/x86_mmu.h | 2 ++ target/i386/hvf/x86_task.h | 2 ++ target/i386/hvf/x86hvf.h | 4 ++++ target/i386/hyperv.h | 3 +++ target/i386/kvm_i386.h | 3 +++ target/i386/ops_sse.h | 3 +++ target/i386/ops_sse_header.h | 4 ++++ target/i386/sev_i386.h | 3 +++ target/i386/shift_helper_template.h | 2 ++ target/i386/whp-dispatch.h | 2 ++ target/lm32/cpu.h | 3 +++ target/lm32/helper.h | 2 ++ target/m68k/cpu.h | 3 +++ target/m68k/helper.h | 3 +++ target/m68k/softfloat.h | 2 ++ target/m68k/softfloat_fpsp_tables.h | 2 ++ target/microblaze/cpu.h | 3 +++ target/microblaze/helper.h | 2 ++ target/microblaze/mmu.h | 2 ++ target/mips/cpu-qom.h | 3 +++ target/mips/cpu.h | 3 +++ target/mips/helper.h | 3 +++ target/mips/internal.h | 3 +++ target/mips/kvm_mips.h | 2 ++ target/mips/mips-defs.h | 2 ++ target/moxie/cpu.h | 3 +++ target/moxie/helper.h | 2 ++ target/moxie/machine.h | 2 ++ target/moxie/mmu.h | 2 ++ target/nios2/cpu.h | 3 +++ target/nios2/helper.h | 2 ++ target/nios2/mmu.h | 2 ++ target/openrisc/cpu.h | 3 +++ target/openrisc/exception.h | 3 +++ target/openrisc/helper.h | 2 ++ target/ppc/cpu-models.h | 3 +++ target/ppc/cpu-qom.h | 3 +++ target/ppc/cpu.h | 3 +++ target/ppc/helper.h | 3 +++ target/ppc/helper_regs.h | 3 +++ target/ppc/internal.h | 3 +++ target/ppc/kvm_ppc.h | 3 +++ target/ppc/mmu-book3s-v3.h | 3 +++ target/ppc/mmu-hash32.h | 2 ++ target/ppc/mmu-hash64.h | 3 +++ target/ppc/mmu-radix64.h | 3 +++ target/riscv/cpu.h | 3 +++ target/riscv/helper.h | 2 ++ target/riscv/instmap.h | 2 ++ target/riscv/pmp.h | 2 ++ target/s390x/cpu.h | 2 ++ target/s390x/cpu_features.h | 2 ++ target/s390x/cpu_models.h | 2 ++ target/s390x/helper.h | 2 ++ target/s390x/internal.h | 2 ++ target/s390x/tcg_s390x.h | 2 ++ target/sh4/cpu.h | 3 +++ target/sh4/helper.h | 2 ++ target/sparc/cpu-qom.h | 3 +++ target/sparc/cpu.h | 3 +++ target/sparc/helper.h | 3 +++ target/tilegx/cpu.h | 3 +++ target/tilegx/helper.h | 2 ++ target/tricore/cpu.h | 3 +++ target/tricore/helper.h | 2 ++ target/tricore/tricore-defs.h | 2 ++ target/tricore/tricore-opcodes.h | 2 ++ target/unicore32/cpu.h | 3 +++ target/unicore32/helper.h | 2 ++ target/xtensa/cpu.h | 3 +++ target/xtensa/helper.h | 2 ++ target/xtensa/overlay_tool.h | 3 +++ target/xtensa/xtensa-isa-internal.h | 2 ++ tcg/aarch64/tcg-target.h | 2 ++ tcg/aarch64/tcg-target.opc.h | 3 +++ tcg/arm/tcg-target.h | 2 ++ tcg/i386/tcg-target.h | 3 +++ tcg/i386/tcg-target.opc.h | 2 ++ tcg/mips/tcg-target.h | 2 ++ tcg/ppc/tcg-target.h | 2 ++ tcg/riscv/tcg-target.h | 3 +++ tcg/s390/tcg-target.h | 3 +++ tcg/tcg-gvec-desc.h | 2 ++ tcg/tcg-op-gvec.h | 2 ++ tcg/tcg-op.h | 2 ++ tcg/tcg-opc.h | 4 ++++ tcg/tcg.h | 2 ++ tcg/tci/tcg-target.h | 2 ++ tests/check-headers.mak | 7 ++++--- tests/crypto-tls-x509-helpers.h | 2 ++ tests/fp/platform.h | 3 +++ tests/libqos/virtio-9p.h | 2 ++ tests/libqos/virtio-balloon.h | 2 ++ tests/libqos/virtio-blk.h | 2 ++ tests/libqos/virtio-net.h | 2 ++ tests/libqos/virtio-rng.h | 2 ++ tests/libqos/virtio-scsi.h | 2 ++ tests/libqos/virtio-serial.h | 2 ++ tests/migration/Makefile | 2 ++ tests/migration/aarch64/a-b-kernel.h | 3 +++ tests/migration/i386/a-b-bootblock.h | 3 +++ tests/migration/s390x/a-b-bios.h | 2 ++ tests/ptimer-test.h | 2 ++ tests/socket-helpers.h | 3 ++- tests/tpm-emu.h | 2 ++ tests/tpm-tests.h | 2 ++ tests/tpm-util.h | 2 ++ trace/control-internal.h | 2 ++ trace/mem-internal.h | 2 ++ trace/mem.h | 2 ++ ui/curses_keys.h | 2 ++ ui/vgafont.h | 2 ++ ui/vnc-auth-sasl.h | 2 ++ ui/vnc-auth-vencrypt.h | 2 ++ ui/vnc-enc-hextile-template.h | 2 ++ ui/vnc-jobs.h | 2 ++ ui/vnc-ws.h | 2 ++ ui/vnc.h | 2 ++ ui/vnc_keysym.h | 1 + ui/x_keymap.h | 2 ++ util/qemu-thread-common.h | 2 ++ win_dump.h | 2 ++ 432 files changed, 1035 insertions(+), 8 deletions(-)
accel/tcg/atomic_template.h +3 -0
@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#include "trace/mem.h" #if DATA_SIZE ==16
accel/tcg/tcg-runtime.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_FLAGS_2(div_i32, TCG_CALL_NO_RWG_SE, s32, s32, s32) DEF_HELPER_FLAGS_2(rem_i32, TCG_CALL_NO_RWG_SE, s32, s32, s32)DEF_HELPER_FLAGS_2 (divu_i32,TCG_CALL_NO_RWG_SE , i32, i32, i32)
accel/tcg/translate-all.h +4 -0
@@ -16,6 +16,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TRANSLATE_ALL_H #define TRANSLATE_ALL_H
audio/audio_int.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_AUDIO_INT_H #define QEMU_AUDIO_INT_H
audio/audio_template.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifdef DAC #define NAME "playback"#define HWBUF hw->mix_buf
audio/audio_win_int.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AUDIO_WIN_INT_H #define AUDIO_WIN_INT_H
audio/dsound_template.h +3 -0
@@ -21,6 +21,9 @@* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifdef DSBTYPE_IN #define NAME "capture buffer"#define NAME2 "DirectSoundCapture"
audio/mixeng_template.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +/* * Tusen tack till Mike Nordell * dec++'ified by Dscho
audio/rate_template.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +/* * Processed signed long samples from ibuf to obuf. * Return number of samples processed.
block/crypto.h +2 -0
@@ -18,6 +18,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef BLOCK_CRYPTO_H #define BLOCK_CRYPTO_H
block/qcow2.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef BLOCK_QCOW2_H #define BLOCK_QCOW2_H
block/vhdx.h +2 -0
@@ -15,6 +15,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef BLOCK_VHDX_H #define BLOCK_VHDX_H #include "qemu/units.h"
bsd-user/i386/target_signal.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SIGNAL_H #define TARGET_SIGNAL_H
bsd-user/i386/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SYSCALL_H #define TARGET_SYSCALL_H
bsd-user/qemu.h +4 -0
@@ -14,6 +14,10 @@* You should have received a copy of the GNU General Public License * along with this program; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_H #define QEMU_H
bsd-user/sparc/target_signal.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SIGNAL_H #define TARGET_SIGNAL_H
bsd-user/sparc/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SYSCALL_H #define TARGET_SYSCALL_H
bsd-user/sparc64/target_signal.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SIGNAL_H #define TARGET_SIGNAL_H
bsd-user/sparc64/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SYSCALL_H #define TARGET_SYSCALL_H
bsd-user/syscall_defs.h +2 -0
@@ -37,6 +37,8 @@* @(#)signal.h 8.2 (Berkeley) 1/21/94 */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NSIG 32/* counting 0; could be 33 (mask is 1-32) */ #define TARGET_SIGHUP 1/* hangup */
bsd-user/x86_64/target_signal.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SIGNAL_H #define TARGET_SIGNAL_H
bsd-user/x86_64/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SYSCALL_H #define TARGET_SYSCALL_H
contrib/ivshmem-client/ivshmem-client.h +2 -0
@@ -6,6 +6,8 @@* top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_POSIX, yet! */ +#ifndef IVSHMEM_CLIENT_H #define IVSHMEM_CLIENT_H
contrib/ivshmem-server/ivshmem-server.h +2 -0
@@ -6,6 +6,8 @@* top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_POSIX, yet! */ +#ifndef IVSHMEM_SERVER_H #define IVSHMEM_SERVER_H
contrib/libvhost-user/libvhost-user-glib.h +2 -0
@@ -12,6 +12,8 @@* later. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef LIBVHOST_USER_GLIB_H #define LIBVHOST_USER_GLIB_H
contrib/libvhost-user/libvhost-user.h +2 -0
@@ -11,6 +11,8 @@* later. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef LIBVHOST_USER_H #define LIBVHOST_USER_H
contrib/rdmacm-mux/rdmacm-mux.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef RDMACM_MUX_H #define RDMACM_MUX_H
crypto/afalgpriv.h +2 -0
@@ -11,6 +11,8 @@* top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QCRYPTO_AFALGPRIV_H #define QCRYPTO_AFALGPRIV_H
crypto/cipherpriv.h +2 -0
@@ -12,6 +12,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QCRYPTO_CIPHERPRIV_H #define QCRYPTO_CIPHERPRIV_H
crypto/hashpriv.h +2 -0
@@ -12,6 +12,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QCRYPTO_HASHPRIV_H #define QCRYPTO_HASHPRIV_H
crypto/hmacpriv.h +2 -0
@@ -12,6 +12,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QCRYPTO_HMACPRIV_H #define QCRYPTO_HMACPRIV_H
disas/nanomips.h +2 -0
@@ -20,6 +20,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef DISAS_NANOMIPS_H #define DISAS_NANOMIPS_H
fpu/softfloat-specialize.h +3 -0
@@ -79,6 +79,9 @@ this code that are retained.* version 2 or later. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +/* Define for architectures which deviate from IEEE in not supporting * signaling NaNs (so all NaNs are treated as quiet). */
fsdev/file-op-9p.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef FILE_OP_9P_H #define FILE_OP_9P_H
fsdev/qemu-fsdev.h +3 -0
@@ -10,6 +10,9 @@* the COPYING file in the top-level directory. * */ + +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_FSDEV_H #define QEMU_FSDEV_H #include "file-op-9p.h"
hw/9pfs/9p-local.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_9P_LOCAL_H #define QEMU_9P_LOCAL_H
hw/9pfs/9p-proxy.h +2 -0
@@ -10,6 +10,8 @@* the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_9P_PROXY_H #define QEMU_9P_PROXY_H
hw/9pfs/9p-synth.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_9P_SYNTH_H #define QEMU_9P_SYNTH_H
hw/9pfs/9p-util.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_9P_UTIL_H #define QEMU_9P_UTIL_H
hw/9pfs/9p-xattr.h +2 -0
@@ -11,6 +11,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_9P_XATTR_H #define QEMU_9P_XATTR_H
hw/9pfs/9p.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_9P_H #define QEMU_9P_H
hw/9pfs/coth.h +2 -0
@@ -12,6 +12,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_9P_COTH_H #define QEMU_9P_COTH_H
hw/9pfs/virtio-9p.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef QEMU_VIRTIO_9P_H #define QEMU_VIRTIO_9P_H
hw/9pfs/xen-9pfs.h +2 -1
@@ -8,9 +8,10 @@* * This work is licensed under the terms of the GNU GPL version 2 or * later. See the COPYING file in the top-level directory. -* */ +/* FIXME Does not pass make check-headers, yet! */ +#include <xen/io/protocols.h> #include "hw/xen/io/ring.h"
hw/arm/smmu-internal.h +2 -0
@@ -18,6 +18,8 @@* with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_SMMU_INTERNAL_H #define HW_ARM_SMMU_INTERNAL_H
hw/arm/smmuv3-internal.h +2 -0
@@ -18,6 +18,8 @@* with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_ARM_SMMUV3_INTERNAL_H #define HW_ARM_SMMUV3_INTERNAL_H
hw/audio/hda-codec-common.h +2 -1
@@ -20,10 +20,11 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +/* * HDA codec descriptions */ -#ifdef HDA_MIXER #define QEMU_HDA_ID_OUTPUT ((QEMU_HDA_ID_VENDOR << 16) | 0x12)#define QEMU_HDA_ID_DUPLEX ((QEMU_HDA_ID_VENDOR << 16) | 0x22)
hw/audio/lm4549.h +2 -0
@@ -9,6 +9,8 @@* ***************************************************************** */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_LM4549_H #define HW_LM4549_H
hw/block/dataplane/xen-block.h +2 -0
@@ -5,6 +5,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef HW_BLOCK_DATAPLANE_XEN_BLOCK_H #define HW_BLOCK_DATAPLANE_XEN_BLOCK_H
hw/block/nvme.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_NVME_H #define HW_NVME_H #include "block/nvme.h"
hw/block/xen_blkif.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XEN_BLKIF_H #define XEN_BLKIF_H
hw/cris/boot.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_CRIS_BOOT_H #define HW_CRIS_BOOT_H
hw/display/ati_int.h +2 -0
@@ -6,6 +6,8 @@* This work is licensed under the GNU GPL license version 2 or later. */ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef ATI_INT_H #define ATI_INT_H
hw/display/cirrus_vga_internal.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CIRRUS_VGA_INTERNAL_H #define CIRRUS_VGA_INTERNAL_H
hw/display/cirrus_vga_rop.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +static inline void glue (rop_8_ ,ROP_NAME )(CirrusVGAState *s,uint32_t dstaddr,uint8_t src) {
hw/display/cirrus_vga_rop2.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#if DEPTH ==8 #define PUTPIXEL (s, a, c) ROP_OP(s, a, c)#elif DEPTH ==16
hw/display/framebuffer.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_FRAMEBUFFER_H #define QEMU_FRAMEBUFFER_H
hw/display/milkymist-vgafb_template.h +2 -1
@@ -15,9 +15,10 @@* * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. -* */ +/* FIXME Does not pass make check-headers, yet! */ +#if BITS ==8 #define COPY_PIXEL (to, r, g, b) \ do { \
hw/display/omap_lcd_template.h +3 -0
@@ -27,6 +27,9 @@* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#if DEPTH ==32 # define BPP 4# define PIXEL_TYPE uint32_t
hw/display/pl110_template.h +2 -0
@@ -9,6 +9,8 @@* Framebuffer format conversion routines. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ORDER #if BITS ==8
hw/display/pxa2xx_template.h +2 -0
@@ -9,6 +9,8 @@* Framebuffer format conversion routines. */ +/* FIXME Does not pass make check-headers, yet! */ +# define SKIP_PIXEL (to) to += deststep#if BITS ==8 # define COPY_PIXEL (to, from) do { *to = from; SKIP_PIXEL(to); } while (0)
hw/display/qxl.h +4 -0
@@ -1,3 +1,7 @@ +/* FIXME Does not pass make check-headers without system emulation, yet! */ +/* FIXME Does not pass make check-headers without CONFIG_SPICE, yet! */ + +#ifndef HW_QXL_H #define HW_QXL_H
hw/display/sm501_template.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#if DEPTH ==8 #define BPP 1#define PIXEL_TYPE uint8_t
hw/display/tc6393xb_template.h +2 -0
@@ -21,6 +21,8 @@* with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#if BITS ==8 # define SET_PIXEL (addr, color) (*(uint8_t *)addr = color)#elif BITS ==15 ||BITS ==16
hw/display/vga-helpers.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +static inline void vga_draw_glyph_line (uint8_t *d,uint32_t font_data,uint32_t xorcol,uint32_t bgcol) {
hw/display/vga_int.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_VGA_INT_H #define HW_VGA_INT_H
hw/ide/ahci_internal.h +2 -0
@@ -21,6 +21,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_IDE_AHCI_INTERNAL_H #define HW_IDE_AHCI_INTERNAL_H
hw/input/adb-internal.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +/* ADB commands */ #define ADB_BUSRESET 0x00
hw/lm32/lm32.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_LM32_H #define HW_LM32_H
hw/lm32/lm32_hwsetup.h +3 -0
@@ -22,6 +22,9 @@* in the Theobroma's uClinux port. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_HW_LM32_HWSETUP_H #define QEMU_HW_LM32_HWSETUP_H
hw/lm32/milkymist-hw.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_HW_MILKYMIST_HW_H #define QEMU_HW_MILKYMIST_HW_H
hw/microblaze/boot.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MICROBLAZE_BOOT_H #define MICROBLAZE_BOOT_H
hw/net/can/can_sja1000.h +3 -0
@@ -24,6 +24,9 @@* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_CAN_SJA1000_H #define HW_CAN_SJA1000_H
hw/net/e1000e_core.h +2 -0
@@ -33,6 +33,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define E1000E_PHY_PAGE_SIZE (0x20)#define E1000E_PHY_PAGES (0x07)#define E1000E_MAC_SIZE (0x8000)
hw/net/e1000x_common.h +2 -0
@@ -22,6 +22,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#include "e1000_regs.h" #define defreg (x) x = (E1000_##x >> 2)
hw/net/pcnet.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_PCNET_H #define HW_PCNET_H
hw/net/rocker/rocker_desc.h +2 -0
@@ -14,6 +14,8 @@* GNU General Public License for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ROCKER_DESC_H #define ROCKER_DESC_H
hw/net/rocker/rocker_fp.h +2 -0
@@ -14,6 +14,8 @@* GNU General Public License for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ROCKER_FP_H #define ROCKER_FP_H
hw/net/rocker/rocker_of_dpa.h +2 -0
@@ -14,6 +14,8 @@* GNU General Public License for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ROCKER_OF_DPA_H #define ROCKER_OF_DPA_H
hw/net/rocker/rocker_tlv.h +2 -0
@@ -14,6 +14,8 @@* GNU General Public License for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ROCKER_TLV_H #define ROCKER_TLV_H
hw/net/rocker/rocker_world.h +2 -0
@@ -14,6 +14,8 @@* GNU General Public License for more details. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ROCKER_WORLD_H #define ROCKER_WORLD_H
hw/net/vmware_utils.h +2 -0
@@ -14,6 +14,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef VMWARE_UTILS_H #define VMWARE_UTILS_H
hw/net/vmxnet3_defs.h +2 -1
@@ -12,9 +12,10 @@* * This work is licensed under the terms of the GNU GPL, version 2. * See the COPYING file in the top-level directory. -* */ +/* FIXME Does not pass make check-headers, yet! */ +#include "net/net.h" #include "hw/net/vmxnet3.h"
hw/nios2/boot.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_BOOT_H #define NIOS2_BOOT_H
hw/ppc/ppc405.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC405_H #define PPC405_H
hw/ppc/ppc440.h +2 -0
@@ -8,6 +8,8 @@* */ +/* NOTE: May only be included into target-dependent code */ +#ifndef PPC440_H #define PPC440_H
hw/rdma/rdma_backend.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef RDMA_BACKEND_H #define RDMA_BACKEND_H
hw/rdma/rdma_backend_defs.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef RDMA_BACKEND_DEFS_H #define RDMA_BACKEND_DEFS_H
hw/rdma/rdma_rm.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef RDMA_RM_H #define RDMA_RM_H
hw/rdma/rdma_rm_defs.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef RDMA_RM_DEFS_H #define RDMA_RM_DEFS_H
hw/rdma/vmw/pvrdma.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef PVRDMA_PVRDMA_H #define PVRDMA_PVRDMA_H
hw/rdma/vmw/pvrdma_dev_ring.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PVRDMA_DEV_RING_H #define PVRDMA_DEV_RING_H
hw/rdma/vmw/pvrdma_qp_ops.h +2 -0
@@ -13,6 +13,8 @@* */ +/* FIXME Does not pass make check-headers without CONFIG_RDMA, yet! */ +#ifndef PVRDMA_QP_OPS_H #define PVRDMA_QP_OPS_H
hw/s390x/ccw-device.h +3 -0
@@ -9,6 +9,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390X_CCW_DEVICE_H #define HW_S390X_CCW_DEVICE_H #include "qom/object.h"
hw/s390x/ipl.h +3 -0
@@ -9,6 +9,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390_IPL_H #define HW_S390_IPL_H
hw/s390x/s390-pci-bus.h +3 -0
@@ -11,6 +11,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390_PCI_BUS_H #define HW_S390_PCI_BUS_H
hw/s390x/s390-pci-inst.h +3 -0
@@ -11,6 +11,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390_PCI_INST_H #define HW_S390_PCI_INST_H
hw/s390x/s390-virtio-hcall.h +2 -0
@@ -9,6 +9,8 @@* directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390_VIRTIO_HCALL_H #define HW_S390_VIRTIO_HCALL_H
hw/s390x/virtio-ccw.h +3 -0
@@ -10,6 +10,9 @@* directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_S390X_VIRTIO_CCW_H #define HW_S390X_VIRTIO_CCW_H
hw/scsi/mptsas.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MPTSAS_H #define MPTSAS_H
hw/scsi/viosrp.h +3 -0
@@ -31,6 +31,9 @@/* of Linux and other operating systems (AIX, OS/400) that talk this protocol*/ /* between logical partitions */ /*****************************************************************************/ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_VIOSRP_H #define PPC_VIOSRP_H
hw/sd/sdhci-internal.h +3 -0
@@ -21,6 +21,9 @@* You should have received a copy of the GNU General Public License along * with this program; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SDHCI_INTERNAL_H #define SDHCI_INTERNAL_H
hw/timer/m48t59-internal.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_M48T59_INTERNAL_H #define HW_M48T59_INTERNAL_H
hw/tpm/tpm_ioctl.h +2 -0
@@ -6,6 +6,8 @@* This file is licensed under the terms of the 3-clause BSD license */ +/* FIXME Does not pass make check-headers without CONFIG_POSIX, yet! */ +#ifndef TPM_IOCTL_H #define TPM_IOCTL_H
hw/usb/desc.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_HW_USB_DESC_H #define QEMU_HW_USB_DESC_H
hw/usb/hcd-ohci.h +2 -0
@@ -18,6 +18,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HCD_OHCI_H #define HCD_OHCI_H
hw/usb/hcd-xhci.h +2 -0
@@ -19,6 +19,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define TYPE_XHCI "base-xhci"#define TYPE_NEC_XHCI "nec-usb-xhci"#define TYPE_QEMU_XHCI "qemu-xhci"
hw/usb/quirks.h +2 -0
@@ -12,6 +12,8 @@* (at your option) any later version. */ +/* FIXME Does not pass make check-headers, yet! */ +/* 1 on 1 copy of linux/drivers/usb/serial/ftdi_sio_ids.h */ #include "quirks-ftdi-ids.h" /* 1 on 1 copy of linux/drivers/usb/serial/pl2303.h */
hw/vfio/pci.h +3 -0
@@ -9,6 +9,9 @@* This work is licensed under the terms of the GNU GPL, version 2. See * the COPYING file in the top-level directory. */ + +/* FIXME Does not pass make check-headers without system emulation, yet! */ +#ifndef HW_VFIO_VFIO_PCI_H #define HW_VFIO_VFIO_PCI_H
hw/xen/xen_pt.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_XEN, yet! */ +#ifndef XEN_PT_H #define XEN_PT_H
hw/xtensa/bootparam.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HW_XTENSA_BOOTPARAM_H #define HW_XTENSA_BOOTPARAM_H
hw/xtensa/xtensa_memory.h +3 -0
@@ -25,6 +25,9 @@* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_MEMORY_H #define XTENSA_MEMORY_H
linux-user/aarch64/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AARCH64_TARGET_CPU_H #define AARCH64_TARGET_CPU_H
linux-user/aarch64/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AARCH64_TARGET_FCNTL_H #define AARCH64_TARGET_FCNTL_H
linux-user/aarch64/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AARCH64_TARGET_SIGNAL_H #define AARCH64_TARGET_SIGNAL_H
linux-user/aarch64/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AARCH64_TARGET_STRUCTS_H #define AARCH64_TARGET_STRUCTS_H
linux-user/aarch64/target_syscall.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AARCH64_TARGET_SYSCALL_H #define AARCH64_TARGET_SYSCALL_H
linux-user/aarch64/termbits.h +2 -0
@@ -1,6 +1,8 @@/* from asm/termbits.h */ /* NOTE: exactly the same as i386 */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/alpha/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALPHA_TARGET_CPU_H #define ALPHA_TARGET_CPU_H
linux-user/alpha/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALPHA_TARGET_FCNTL_H #define ALPHA_TARGET_FCNTL_H
linux-user/alpha/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALPHA_TARGET_SIGNAL_H #define ALPHA_TARGET_SIGNAL_H
linux-user/alpha/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALPHA_TARGET_STRUCTS_H #define ALPHA_TARGET_STRUCTS_H
linux-user/alpha/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALPHA_TARGET_SYSCALL_H #define ALPHA_TARGET_SYSCALL_H
linux-user/alpha/termbits.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +typedef unsigned char target_cc_t ;typedef unsigned int target_speed_t ;typedef unsigned int target_tcflag_t ;
linux-user/arm/nwfpe/fpa11.h +3 -0
@@ -18,6 +18,9 @@along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FPA11_H #define FPA11_H
linux-user/arm/nwfpe/fpopcode.h +2 -0
@@ -18,6 +18,8 @@along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FPOPCODE_H #define FPOPCODE_H
linux-user/arm/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_TARGET_CPU_H #define ARM_TARGET_CPU_H
linux-user/arm/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_TARGET_FCNTL_H #define ARM_TARGET_FCNTL_H
linux-user/arm/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_TARGET_SIGNAL_H #define ARM_TARGET_SIGNAL_H
linux-user/arm/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_TARGET_STRUCTS_H #define ARM_TARGET_STRUCTS_H
linux-user/arm/target_syscall.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_TARGET_SYSCALL_H #define ARM_TARGET_SYSCALL_H
linux-user/arm/termbits.h +2 -0
@@ -1,6 +1,8 @@/* from asm/termbits.h */ /* NOTE: exactly the same as i386 */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/cpu_loop-common.h +3 -0
@@ -17,6 +17,9 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CPU_LOOP_COMMON_H #define CPU_LOOP_COMMON_H
linux-user/cris/target_cpu.h +3 -0
@@ -17,6 +17,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CRIS_TARGET_CPU_H #define CRIS_TARGET_CPU_H
linux-user/cris/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CRIS_TARGET_FCNTL_H #define CRIS_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/cris/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CRIS_TARGET_SIGNAL_H #define CRIS_TARGET_SIGNAL_H
linux-user/cris/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CRIS_TARGET_STRUCTS_H #define CRIS_TARGET_STRUCTS_H
linux-user/cris/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/fd-trans.h +2 -0
@@ -13,6 +13,8 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef FD_TRANS_H #define FD_TRANS_H
linux-user/flat.h +2 -0
@@ -7,6 +7,8 @@* support uClinux flat-format executables. */ +/* FIXME Does not pass make check-headers, yet! */ +#define FLAT_VERSION 0x00000004L#ifdef CONFIG_BINFMT_SHARED_FLAT
linux-user/generic/fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef GENERIC_FCNTL_H #define GENERIC_FCNTL_H
linux-user/host/aarch64/hostdep.h +2 -0
@@ -9,6 +9,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef AARCH64_HOSTDEP_H #define AARCH64_HOSTDEP_H
linux-user/host/arm/hostdep.h +2 -0
@@ -9,6 +9,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_HOSTDEP_H #define ARM_HOSTDEP_H
linux-user/host/i386/hostdep.h +2 -0
@@ -9,6 +9,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_HOSTDEP_H #define I386_HOSTDEP_H
linux-user/host/ppc64/hostdep.h +2 -0
@@ -9,6 +9,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC64_HOSTDEP_H #define PPC64_HOSTDEP_H
linux-user/host/riscv64/hostdep.h +2 -0
@@ -5,6 +5,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV64_HOSTDEP_H #define RISCV64_HOSTDEP_H
linux-user/host/s390x/hostdep.h +2 -0
@@ -9,6 +9,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_HOSTDEP_H #define S390X_HOSTDEP_H
linux-user/host/x86_64/hostdep.h +2 -0
@@ -9,6 +9,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef X86_64_HOSTDEP_H #define X86_64_HOSTDEP_H
linux-user/hppa/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HPPA_TARGET_CPU_H #define HPPA_TARGET_CPU_H
linux-user/hppa/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HPPA_TARGET_FCNTL_H #define HPPA_TARGET_FCNTL_H
linux-user/hppa/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HPPA_TARGET_SIGNAL_H #define HPPA_TARGET_SIGNAL_H
linux-user/hppa/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HPPA_TARGET_STRUCTS_H #define HPPA_TARGET_STRUCTS_H
linux-user/hppa/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HPPA_TARGET_SYSCALL_H #define HPPA_TARGET_SYSCALL_H
linux-user/hppa/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/i386/target_cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_TARGET_CPU_H #define I386_TARGET_CPU_H
linux-user/i386/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_TARGET_FCNTL_H #define I386_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/i386/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_TARGET_SIGNAL_H #define I386_TARGET_SIGNAL_H
linux-user/i386/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_TARGET_STRUCTS_H #define I386_TARGET_STRUCTS_H
linux-user/i386/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_TARGET_SYSCALL_H #define I386_TARGET_SYSCALL_H
linux-user/i386/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/ioctls.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +/* emulated ioctl list */ IOCTL (TCGETS ,IOC_R ,MK_PTR (MK_STRUCT (STRUCT_termios)))
linux-user/linux_loop.h +2 -0
@@ -2,6 +2,8 @@* and subsequently updated to match newer additions to the API. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef LINUX_LOOP_H #define LINUX_LOOP_H
linux-user/m68k/target_cpu.h +2 -0
@@ -18,6 +18,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_TARGET_CPU_H #define M68K_TARGET_CPU_H
linux-user/m68k/target_elf.h +2 -0
@@ -5,6 +5,8 @@* later version. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_TARGET_ELF_H #define M68K_TARGET_ELF_H static inline const char *cpu_get_model (uint32_t eflags)
linux-user/m68k/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_TARGET_FCNTL_H #define M68K_TARGET_FCNTL_H
linux-user/m68k/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_TARGET_SIGNAL_H #define M68K_TARGET_SIGNAL_H
linux-user/m68k/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_TARGET_STRUCTS_H #define M68K_TARGET_STRUCTS_H
linux-user/m68k/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_TARGET_SYSCALL_H #define M68K_TARGET_SYSCALL_H
linux-user/m68k/termbits.h +2 -0
@@ -1,6 +1,8 @@/* from asm/termbits.h */ /* NOTE: exactly the same as i386 */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/microblaze/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MICROBLAZE_TARGET_CPU_H #define MICROBLAZE_TARGET_CPU_H
linux-user/microblaze/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MICROBLAZE_TARGET_FCNTL_H #define MICROBLAZE_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/microblaze/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MICROBLAZE_TARGET_SIGNAL_H #define MICROBLAZE_TARGET_SIGNAL_H
linux-user/microblaze/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MICROBLAZE_TARGET_STRUCTS_H #define MICROBLAZE_TARGET_STRUCTS_H
linux-user/microblaze/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/mips/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TARGET_CPU_H #define MIPS_TARGET_CPU_H
linux-user/mips/target_elf.h +2 -0
@@ -5,6 +5,8 @@* later version. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TARGET_ELF_H #define MIPS_TARGET_ELF_H static inline const char *cpu_get_model (uint32_t eflags)
linux-user/mips/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TARGET_FCNTL_H #define MIPS_TARGET_FCNTL_H
linux-user/mips/target_signal.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TARGET_SIGNAL_H #define MIPS_TARGET_SIGNAL_H
linux-user/mips/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TARGET_STRUCTS_H #define MIPS_TARGET_STRUCTS_H
linux-user/mips/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TARGET_SYSCALL_H #define MIPS_TARGET_SYSCALL_H
linux-user/mips/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 23struct target_termios {
linux-user/mips64/syscall_nr.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifdef TARGET_ABI32 /* * Linux N32 syscalls are in the range from 6000 to 6999.
linux-user/mips64/target_cpu.h +3 -0
@@ -16,4 +16,7 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#include "../mips/target_cpu.h"
linux-user/mips64/target_elf.h +2 -0
@@ -5,6 +5,8 @@* later version. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS64_TARGET_ELF_H #define MIPS64_TARGET_ELF_H static inline const char *cpu_get_model (uint32_t eflags)
linux-user/mips64/target_fcntl.h +3 -0
@@ -1 +1,4 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#include "../mips/target_fcntl.h"
linux-user/mips64/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS64_TARGET_SIGNAL_H #define MIPS64_TARGET_SIGNAL_H
linux-user/mips64/target_structs.h +2 -0
@@ -1,2 +1,4 @@ +/* FIXME Does not pass make check-headers, yet! */ +#include "../mips/target_structs.h"
linux-user/mips64/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS64_TARGET_SYSCALL_H #define MIPS64_TARGET_SYSCALL_H
linux-user/mips64/termbits.h +2 -0
@@ -1,2 +1,4 @@ +/* FIXME Does not pass make check-headers, yet! */ +#include "../mips/termbits.h"
linux-user/nios2/target_cpu.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_TARGET_CPU_H #define NIOS2_TARGET_CPU_H
linux-user/nios2/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_TARGET_FCNTL_H #define NIOS2_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/nios2/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_TARGET_SIGNAL_H #define NIOS2_TARGET_SIGNAL_H
linux-user/nios2/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_TARGET_STRUCTS_H #define NIOS2_TARGET_STRUCTS_H
linux-user/nios2/termbits.h +2 -0
@@ -1,6 +1,8 @@/* from asm/termbits.h */ /* NOTE: exactly the same as i386 */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/openrisc/target_cpu.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef OPENRISC_TARGET_CPU_H #define OPENRISC_TARGET_CPU_H
linux-user/openrisc/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef OPENRISC_TARGET_FCNTL_H #define OPENRISC_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/openrisc/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef OPENRISC_TARGET_SIGNAL_H #define OPENRISC_TARGET_SIGNAL_H
linux-user/openrisc/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef OPENRISC_TARGET_STRUCTS_H #define OPENRISC_TARGET_STRUCTS_H
linux-user/openrisc/target_syscall.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef OPENRISC_TARGET_SYSCALL_H #define OPENRISC_TARGET_SYSCALL_H
linux-user/openrisc/termbits.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +typedef unsigned char target_openrisc_cc ;/*cc_t*/ typedef unsigned int target_openrisc_speed ;/*speed_t*/ typedef unsigned int target_openrisc_tcflag ;/*tcflag_t*/
linux-user/ppc/syscall_nr.h +3 -0
@@ -1,6 +1,9 @@/* * This file contains the system call numbers. */ + +/* NOTE: May only be included into target-dependent code */ +#define TARGET_NR_restart_syscall 0#define TARGET_NR_exit 1#define TARGET_NR_fork 2
linux-user/ppc/target_cpu.h +4 -0
@@ -16,6 +16,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_TARGET_CPU_H #define PPC_TARGET_CPU_H
linux-user/ppc/target_elf.h +2 -0
@@ -5,6 +5,8 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef PPC_TARGET_ELF_H #define PPC_TARGET_ELF_H static inline const char *cpu_get_model (uint32_t eflags)
linux-user/ppc/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_TARGET_FCNTL_H #define PPC_TARGET_FCNTL_H
linux-user/ppc/target_signal.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_TARGET_SIGNAL_H #define PPC_TARGET_SIGNAL_H
linux-user/ppc/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_TARGET_STRUCTS_H #define PPC_TARGET_STRUCTS_H
linux-user/ppc/target_syscall.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_TARGET_SYSCALL_H #define PPC_TARGET_SYSCALL_H
linux-user/ppc/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/qemu.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_H #define QEMU_H
linux-user/riscv/target_cpu.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_TARGET_CPU_H #define RISCV_TARGET_CPU_H
linux-user/riscv/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_TARGET_FCNTL_H #define RISCV_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/riscv/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_TARGET_SIGNAL_H #define RISCV_TARGET_SIGNAL_H
linux-user/riscv/target_structs.h +3 -0
@@ -4,6 +4,9 @@* This is a copy of ../aarch64/target_structs.h atm. * */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_TARGET_STRUCTS_H #define RISCV_TARGET_STRUCTS_H
linux-user/riscv/target_syscall.h +2 -0
@@ -5,6 +5,8 @@* Reference: linux/arch/riscv/include/uapi/asm/ptrace.h */ +/* FIXME Does not pass make check-headers, yet! */ +struct target_pt_regs {abi_long sepc;abi_long ra;
linux-user/riscv/termbits.h +2 -0
@@ -1,6 +1,8 @@/* from asm/termbits.h */ /* NOTE: exactly the same as i386 */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/s390x/syscall_nr.h +2 -0
@@ -2,6 +2,8 @@* This file contains the system call numbers. */ +/* NOTE: May only be included into target-dependent code */ +#define TARGET_NR_exit 1#define TARGET_NR_fork 2#define TARGET_NR_read 3
linux-user/s390x/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU General Public License * along with this program; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_TARGET_CPU_H #define S390X_TARGET_CPU_H
linux-user/s390x/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_TARGET_FCNTL_H #define S390X_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/s390x/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_TARGET_SIGNAL_H #define S390X_TARGET_SIGNAL_H
linux-user/s390x/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_TARGET_STRUCTS_H #define S390X_TARGET_STRUCTS_H
linux-user/s390x/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_TARGET_SYSCALL_H #define S390X_TARGET_SYSCALL_H
linux-user/s390x/termbits.h +2 -0
@@ -6,6 +6,8 @@* Derived from "include/asm-i386/termbits.h" */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {unsigned int c_iflag;/* input mode flags */
linux-user/sh4/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH4_TARGET_CPU_H #define SH4_TARGET_CPU_H
linux-user/sh4/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH4_TARGET_FCNTL_H #define SH4_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/sh4/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH4_TARGET_SIGNAL_H #define SH4_TARGET_SIGNAL_H
linux-user/sh4/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH4_TARGET_STRUCTS_H #define SH4_TARGET_STRUCTS_H
linux-user/sh4/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH4_TARGET_SYSCALL_H #define SH4_TARGET_SYSCALL_H
linux-user/sh4/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/signal-common.h +3 -0
@@ -17,6 +17,9 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SIGNAL_COMMON_H #define SIGNAL_COMMON_H extern struct target_sigaltstack target_sigaltstack_used;
linux-user/socket.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#include "sockbits.h" #ifndef TARGET_ARCH_HAS_SOCKET_TYPES
linux-user/sparc/target_cpu.h +4 -0
@@ -17,6 +17,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC_TARGET_CPU_H #define SPARC_TARGET_CPU_H
linux-user/sparc/target_elf.h +2 -0
@@ -5,6 +5,8 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef SPARC_TARGET_ELF_H #define SPARC_TARGET_ELF_H static inline const char *cpu_get_model (uint32_t eflags)
linux-user/sparc/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC_TARGET_FCNTL_H #define SPARC_TARGET_FCNTL_H
linux-user/sparc/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC_TARGET_SIGNAL_H #define SPARC_TARGET_SIGNAL_H
linux-user/sparc/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC_TARGET_STRUCTS_H #define SPARC_TARGET_STRUCTS_H
linux-user/sparc/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC_TARGET_SYSCALL_H #define SPARC_TARGET_SYSCALL_H
linux-user/sparc/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/sparc64/target_cpu.h +3 -0
@@ -1 +1,4 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#include "../sparc/target_cpu.h"
linux-user/sparc64/target_fcntl.h +3 -0
@@ -1 +1,4 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#include "../sparc/target_fcntl.h"
linux-user/sparc64/target_signal.h +2 -0
@@ -1 +1,3 @@ +/* FIXME Does not pass make check-headers, yet! */ +#include "../sparc/target_signal.h"
linux-user/sparc64/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC64_TARGET_STRUCTS_H #define SPARC64_TARGET_STRUCTS_H
linux-user/sparc64/target_syscall.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC64_TARGET_SYSCALL_H #define SPARC64_TARGET_SYSCALL_H
linux-user/sparc64/termbits.h +2 -0
@@ -1,5 +1,7 @@/* from asm/termbits.h */ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19struct target_termios {
linux-user/syscall_defs.h +2 -0
@@ -4,6 +4,8 @@most of them stay the same, so we handle it by putting ifdefs if necessary */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SYSCALL_DEFS_H #define SYSCALL_DEFS_H
linux-user/syscall_types.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + STRUCT_SPECIAL(termios) STRUCT(winsize,
linux-user/tilegx/target_cpu.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TILEGX_TARGET_CPU_H #define TILEGX_TARGET_CPU_H
linux-user/tilegx/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TILEGX_TARGET_FCNTL_H #define TILEGX_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/tilegx/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TILEGX_TARGET_SIGNAL_H #define TILEGX_TARGET_SIGNAL_H
linux-user/tilegx/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TILEGX_TARGET_STRUCTS_H #define TILEGX_TARGET_STRUCTS_H
linux-user/tilegx/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifndef TILEGX_TARGET_SYSCALL_H #define TILEGX_TARGET_SYSCALL_H
linux-user/uname.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef UNAME_H #define UNAME_H
linux-user/x86_64/target_cpu.h +3 -0
@@ -1 +1,4 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#include "../i386/target_cpu.h"
linux-user/x86_64/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_64_TARGET_FCNTL_H #define X86_64_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/x86_64/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_64_TARGET_SIGNAL_H #define X86_64_TARGET_SIGNAL_H
linux-user/x86_64/target_structs.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_64_TARGET_STRUCTS_H #define X86_64_TARGET_STRUCTS_H
linux-user/x86_64/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_64_TARGET_SYSCALL_H #define X86_64_TARGET_SYSCALL_H
linux-user/x86_64/termbits.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#define TARGET_NCCS 19typedef unsigned char target_cc_t ;
linux-user/xtensa/target_cpu.h +3 -0
@@ -1,6 +1,9 @@/* * Xtensa-specific CPU ABI and functions for linux-user */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_TARGET_CPU_H #define XTENSA_TARGET_CPU_H
linux-user/xtensa/target_elf.h +2 -0
@@ -5,6 +5,8 @@* later version. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_TARGET_ELF_H #define XTENSA_TARGET_ELF_H
linux-user/xtensa/target_fcntl.h +3 -0
@@ -5,6 +5,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_TARGET_FCNTL_H #define XTENSA_TARGET_FCNTL_H #include "../generic/fcntl.h"
linux-user/xtensa/target_signal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_TARGET_SIGNAL_H #define XTENSA_TARGET_SIGNAL_H
linux-user/xtensa/target_structs.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_TARGET_STRUCTS_H #define XTENSA_TARGET_STRUCTS_H
linux-user/xtensa/target_syscall.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifndef XTENSA_TARGET_SYSCALL_H #define XTENSA_TARGET_SYSCALL_H
linux-user/xtensa/termbits.h +2 -0
@@ -10,6 +10,8 @@* Copyright (C) 2001 - 2005 Tensilica Inc. */ +/* FIXME Does not pass make check-headers without CONFIG_LINUX, yet! */ +#ifndef XTENSA_TERMBITS_H #define XTENSA_TERMBITS_H
migration/postcopy-ram.h +3 -0
@@ -10,6 +10,9 @@* See the COPYING file in the top-level directory. * */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_POSTCOPY_RAM_H #define QEMU_POSTCOPY_RAM_H
migration/qemu-file.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIGRATION_QEMU_FILE_H #define MIGRATION_QEMU_FILE_H
net/colo-compare.h +2 -0
@@ -14,6 +14,8 @@* later. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_COLO_COMPARE_H #define QEMU_COLO_COMPARE_H
qemu-options-wrapper.h +1 -0
@@ -1,3 +1,4 @@ +/* FIXME Does not pass make check-headers, yet! */ #if defined(QEMU_OPTIONS_GENERATE_ENUM )
qga/guest-agent-core.h +3 -0
@@ -10,6 +10,9 @@* This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ + +/* FIXME Does not pass make check-headers, yet! */ +#ifndef GUEST_AGENT_CORE_H #define GUEST_AGENT_CORE_H
qga/service-win32.h +2 -0
@@ -11,6 +11,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */ +#ifndef QGA_SERVICE_WIN32_H #define QGA_SERVICE_WIN32_H
qga/vss-win32.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef VSS_WIN32_H #define VSS_WIN32_H
qga/vss-win32/install.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */ +#ifndef INSTALL_H #define INSTALL_H
qga/vss-win32/requester.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_WIN32, yet! */ +#ifndef VSS_WIN32_REQUESTER_H #define VSS_WIN32_REQUESTER_H
qga/vss-win32/vss-common.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef VSS_COMMON_H #define VSS_COMMON_H
replay/replay-internal.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef REPLAY_INTERNAL_H #define REPLAY_INTERNAL_H
replication.h +2 -0
@@ -12,6 +12,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers without CONFIG_REPLICATION, yet! */ +#ifndef REPLICATION_H #define REPLICATION_H
target/alpha/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ALPHA_CPU_H #define ALPHA_CPU_H
target/alpha/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_3(excp, noreturn, env, int, int)DEF_HELPER_FLAGS_1 (load_pcc,TCG_CALL_NO_RWG_SE , i64, env)
target/arm/arm-powerctl.h +3 -0
@@ -8,6 +8,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_ARM_POWERCTL_H #define QEMU_ARM_POWERCTL_H
target/arm/arm_ldst.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_LDST_H #define ARM_LDST_H
target/arm/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_CPU_H #define ARM_CPU_H
target/arm/helper-a64.h +3 -0
@@ -16,6 +16,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_FLAGS_2(udiv64, TCG_CALL_NO_RWG_SE, i64, i64, i64) DEF_HELPER_FLAGS_2(sdiv64, TCG_CALL_NO_RWG_SE, s64, s64, s64)DEF_HELPER_FLAGS_1 (rbit64,TCG_CALL_NO_RWG_SE , i64, i64)
target/arm/helper-sve.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_FLAGS_2(sve_predtest1, TCG_CALL_NO_WG, i32, i64, i64)DEF_HELPER_FLAGS_3 (sve_predtest,TCG_CALL_NO_WG , i32, ptr, ptr, i32)
target/arm/helper.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_FLAGS_1(sxtb16, TCG_CALL_NO_RWG_SE, i32, i32)DEF_HELPER_FLAGS_1 (uxtb16,TCG_CALL_NO_RWG_SE , i32, i32)
target/arm/internals.h +2 -0
@@ -22,6 +22,8 @@* private to it and not required by the rest of QEMU. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_ARM_INTERNALS_H #define TARGET_ARM_INTERNALS_H
target/arm/kvm-consts.h +4 -0
@@ -11,6 +11,10 @@* This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef ARM_KVM_CONSTS_H #define ARM_KVM_CONSTS_H
target/arm/kvm_arm.h +3 -0
@@ -8,6 +8,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_KVM_ARM_H #define QEMU_KVM_ARM_H
target/arm/op_addsub.h +2 -0
@@ -7,6 +7,8 @@* This code is licensed under the GPL. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifdef ARITH_GE #define GE_ARG , void *gep#define DECLARE_GE uint32_t ge = 0
target/arm/translate-a64.h +2 -0
@@ -15,6 +15,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_ARM_TRANSLATE_A64_H #define TARGET_ARM_TRANSLATE_A64_H
target/arm/translate.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_ARM_TRANSLATE_H #define TARGET_ARM_TRANSLATE_H
target/cris/cpu.h +3 -0
@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CRIS_CPU_H #define CRIS_CPU_H
target/cris/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(raise_exception, void, env, i32) DEF_HELPER_2(tlb_flush_pid, void, env, i32)DEF_HELPER_2 (spc_write, void, env, i32)
target/cris/mmu.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#define CRIS_MMU_ERR_EXEC 0#define CRIS_MMU_ERR_READ 1#define CRIS_MMU_ERR_WRITE 2
target/hppa/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HPPA_CPU_H #define HPPA_CPU_H
target/hppa/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#if TARGET_REGISTER_BITS ==64 # define dh_alias_tr i64# define dh_is_64bit_tr 1
target/i386/cc_helper_template.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define DATA_BITS (1 << (3 + SHIFT))#if DATA_BITS ==8
target/i386/cpu-qom.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see * <http://www.gnu.org/licenses/lgpl-2.1.html> */ + +/* NOTE: May only be included into target-dependent code */ +#ifndef QEMU_I386_CPU_QOM_H #define QEMU_I386_CPU_QOM_H
target/i386/cpu.h +3 -0
@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_CPU_H #define I386_CPU_H
target/i386/hax-i386.h +3 -0
@@ -10,6 +10,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HAX_I386_H #define HAX_I386_H
target/i386/hax-posix.h +2 -0
@@ -12,6 +12,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_I386_HAX_POSIX_H #define TARGET_I386_HAX_POSIX_H
target/i386/hax-windows.h +2 -0
@@ -17,6 +17,8 @@* */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_I386_HAX_WINDOWS_H #define TARGET_I386_HAX_WINDOWS_H
target/i386/helper.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_FLAGS_4(cc_compute_all, TCG_CALL_NO_RWG_SE, tl, tl, tl, tl, int)DEF_HELPER_FLAGS_4 (cc_compute_c,TCG_CALL_NO_RWG_SE , tl, tl, tl, tl, int)
target/i386/hvf/hvf-i386.h +3 -0
@@ -13,6 +13,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HVF_I386_H #define HVF_I386_H
target/i386/hvf/vmcs.h +2 -0
@@ -26,6 +26,8 @@* $FreeBSD$ */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef VMCS_H #define VMCS_H
target/i386/hvf/vmx.h +2 -0
@@ -22,6 +22,8 @@* https://github.com/mist64/hvdos */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef VMX_H #define VMX_H
target/i386/hvf/x86.h +2 -0
@@ -16,6 +16,8 @@* License along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HVF_X86_H #define HVF_X86_H
target/i386/hvf/x86_decode.h +3 -0
@@ -15,6 +15,9 @@* License along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HVF_X86_DECODE_H #define HVF_X86_DECODE_H
target/i386/hvf/x86_descr.h +2 -0
@@ -16,6 +16,8 @@* License along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HVF_X86_DESCR_H #define HVF_X86_DESCR_H
target/i386/hvf/x86_emu.h +3 -0
@@ -16,6 +16,9 @@* License along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_EMU_H #define X86_EMU_H
target/i386/hvf/x86_flags.h +3 -0
@@ -21,6 +21,9 @@* x86 eflags functions */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_FLAGS_H #define X86_FLAGS_H
target/i386/hvf/x86_mmu.h +2 -0
@@ -16,6 +16,8 @@* License along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86_MMU_H #define X86_MMU_H
target/i386/hvf/x86_task.h +2 -0
@@ -12,6 +12,8 @@* with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HVF_X86_TASK_H #define HVF_X86_TASK_H
target/i386/hvf/x86hvf.h +4 -0
@@ -15,6 +15,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this program; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef X86HVF_H #define X86HVF_H #include "cpu.h"
target/i386/hyperv.h +3 -0
@@ -11,6 +11,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_I386_HYPERV_H #define TARGET_I386_HYPERV_H
target/i386/kvm_i386.h +3 -0
@@ -8,6 +8,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_KVM_I386_H #define QEMU_KVM_I386_H
target/i386/ops_sse.h +3 -0
@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#include "crypto/aes.h" #if SHIFT ==0
target/i386/ops_sse_header.h +4 -0
@@ -16,6 +16,10 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#if SHIFT ==0 #define Reg MMXReg#define SUFFIX _mmx
target/i386/sev_i386.h +3 -0
@@ -11,6 +11,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef QEMU_SEV_I386_H #define QEMU_SEV_I386_H
target/i386/shift_helper_template.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define DATA_BITS (1 << (3 + SHIFT))#define SHIFT_MASK (DATA_BITS - 1)#if DATA_BITS <=32
target/i386/whp-dispatch.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#include <windows.h> #include <WinHvPlatform.h>
target/lm32/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef LM32_CPU_H #define LM32_CPU_H
target/lm32/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(raise_exception, void, env, i32) DEF_HELPER_1(hlt, void, env)DEF_HELPER_3 (wcsr_bp, void, env, i32, i32)
target/m68k/cpu.h +3 -0
@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef M68K_CPU_H #define M68K_CPU_H
target/m68k/helper.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_1(bitrev, i32, i32) DEF_HELPER_1(ff1, i32, i32)DEF_HELPER_FLAGS_2 (sats,TCG_CALL_NO_RWG_SE , i32, i32, i32)
target/m68k/softfloat.h +2 -0
@@ -18,6 +18,8 @@* version 2 or later. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef TARGET_M68K_SOFTFLOAT_H #define TARGET_M68K_SOFTFLOAT_H #include "fpu/softfloat.h"
target/m68k/softfloat_fpsp_tables.h +2 -0
@@ -18,6 +18,8 @@* version 2 or later. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_M68K_SOFTFLOAT_FPSP_TABLES_H #define TARGET_M68K_SOFTFLOAT_FPSP_TABLES_H
target/microblaze/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MICROBLAZE_CPU_H #define MICROBLAZE_CPU_H
target/microblaze/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(raise_exception, void, env, i32) DEF_HELPER_1(debug, void, env)DEF_HELPER_FLAGS_3 (carry,TCG_CALL_NO_RWG_SE , i32, i32, i32, i32)
target/microblaze/mmu.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define MMU_R_PID 0#define MMU_R_ZPR 1#define MMU_R_TLBX 2
target/mips/cpu-qom.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see * <http://www.gnu.org/licenses/lgpl-2.1.html> */ + +/* NOTE: May only be included into target-dependent code */ +#ifndef QEMU_MIPS_CPU_QOM_H #define QEMU_MIPS_CPU_QOM_H
target/mips/cpu.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_CPU_H #define MIPS_CPU_H
target/mips/helper.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_3(raise_exception_err, noreturn, env, i32, int) DEF_HELPER_2(raise_exception, noreturn, env, i32)DEF_HELPER_1 (raise_exception_debug, noreturn, env)
target/mips/internal.h +3 -0
@@ -4,6 +4,9 @@* See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_INTERNAL_H #define MIPS_INTERNAL_H
target/mips/kvm_mips.h +2 -0
@@ -9,6 +9,8 @@* Authors: Sanjay Lal <[email protected]> */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef KVM_MIPS_H #define KVM_MIPS_H
target/mips/mips-defs.h +2 -0
@@ -1,3 +1,5 @@ +/* NOTE: May only be included into target-dependent code */ +#ifndef QEMU_MIPS_DEFS_H #define QEMU_MIPS_DEFS_H
target/moxie/cpu.h +3 -0
@@ -17,6 +17,9 @@* along with this program. If not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MOXIE_CPU_H #define MOXIE_CPU_H
target/moxie/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(raise_exception, void, env, int)DEF_HELPER_1 (debug, void, env)
target/moxie/machine.h +2 -0
@@ -1 +1,3 @@ +/* FIXME Does not pass make check-headers, yet! */ +extern const VMStateDescription vmstate_moxie_cpu;
target/moxie/mmu.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#define MOXIE_MMU_ERR_EXEC 0#define MOXIE_MMU_ERR_READ 1#define MOXIE_MMU_ERR_WRITE 2
target/nios2/cpu.h +3 -0
@@ -18,6 +18,9 @@* <http://www.gnu.org/licenses/lgpl-2.1.html> */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_CPU_H #define NIOS2_CPU_H
target/nios2/helper.h +2 -0
@@ -18,6 +18,8 @@* <http://www.gnu.org/licenses/lgpl-2.1.html> */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(raise_exception, void, env, i32)#if !defined(CONFIG_USER_ONLY )
target/nios2/mmu.h +2 -0
@@ -18,6 +18,8 @@* <http://www.gnu.org/licenses/lgpl-2.1.html> */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef NIOS2_MMU_H #define NIOS2_MMU_H
target/openrisc/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef OPENRISC_CPU_H #define OPENRISC_CPU_H
target/openrisc/exception.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_OPENRISC_EXCEPTION_H #define TARGET_OPENRISC_EXCEPTION_H
target/openrisc/helper.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +/* exception */ DEF_HELPER_FLAGS_2(exception, TCG_CALL_NO_WG, void, env, i32)DEF_HELPER_FLAGS_1 (ove_cy,TCG_CALL_NO_WG , void, env)
target/ppc/cpu-models.h +3 -0
@@ -18,6 +18,9 @@* You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ + +/* NOTE: May only be included into target-dependent code */ +#ifndef TARGET_PPC_CPU_MODELS_H #define TARGET_PPC_CPU_MODELS_H
target/ppc/cpu-qom.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see * <http://www.gnu.org/licenses/lgpl-2.1.html> */ + +/* NOTE: May only be included into target-dependent code */ +#ifndef QEMU_PPC_CPU_QOM_H #define QEMU_PPC_CPU_QOM_H
target/ppc/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_CPU_H #define PPC_CPU_H
target/ppc/helper.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_FLAGS_3(raise_exception_err, TCG_CALL_NO_WG, void, env, i32, i32) DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, void, env, i32)DEF_HELPER_FLAGS_4 (tw,TCG_CALL_NO_WG , void, env, tl, tl, i32)
target/ppc/helper_regs.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef HELPER_REGS_H #define HELPER_REGS_H
target/ppc/internal.h +3 -0
@@ -15,6 +15,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_INTERNAL_H #define PPC_INTERNAL_H
target/ppc/kvm_ppc.h +3 -0
@@ -6,6 +6,9 @@* */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef KVM_PPC_H #define KVM_PPC_H
target/ppc/mmu-book3s-v3.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef PPC_MMU_BOOK3S_V3_H #define PPC_MMU_BOOK3S_V3_H
target/ppc/mmu-hash32.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MMU_HASH32_H #define MMU_HASH32_H
target/ppc/mmu-hash64.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MMU_HASH64_H #define MMU_HASH64_H
target/ppc/mmu-radix64.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MMU_RADIX64_H #define MMU_RADIX64_H
target/riscv/cpu.h +3 -0
@@ -17,6 +17,9 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_CPU_H #define RISCV_CPU_H
target/riscv/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ +/* Exceptions */ DEF_HELPER_2 (raise_exception, noreturn, env, i32)
target/riscv/instmap.h +2 -0
@@ -16,6 +16,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#define MASK_OP_MAJOR (op) (op & 0x7F)enum {/* rv32i, rv64i, rv32m */
target/riscv/pmp.h +2 -0
@@ -19,6 +19,8 @@* this program. If not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_PMP_H #define RISCV_PMP_H
target/s390x/cpu.h +2 -0
@@ -18,6 +18,8 @@* along with this program; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_CPU_H #define S390X_CPU_H
target/s390x/cpu_features.h +2 -0
@@ -11,6 +11,8 @@* directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_S390X_CPU_FEATURES_H #define TARGET_S390X_CPU_FEATURES_H
target/s390x/cpu_models.h +2 -0
@@ -10,6 +10,8 @@* directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_S390X_CPU_MODELS_H #define TARGET_S390X_CPU_MODELS_H
target/s390x/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(exception, noreturn, env, i32) DEF_HELPER_2(data_exception, noreturn, env, i32)DEF_HELPER_FLAGS_4 (nc,TCG_CALL_NO_WG , i32, env, i32, i64, i64)
target/s390x/internal.h +2 -0
@@ -7,6 +7,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390X_INTERNAL_H #define S390X_INTERNAL_H
target/s390x/tcg_s390x.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TCG_S390X_H #define TCG_S390X_H
target/sh4/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SH4_CPU_H #define SH4_CPU_H
target/sh4/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_1(ldtlb, void, env) DEF_HELPER_1(raise_illegal_instruction, noreturn, env)DEF_HELPER_1 (raise_slot_illegal_instruction, noreturn, env)
target/sparc/cpu-qom.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see * <http://www.gnu.org/licenses/lgpl-2.1.html> */ + +/* NOTE: May only be included into target-dependent code */ +#ifndef QEMU_SPARC_CPU_QOM_H #define QEMU_SPARC_CPU_QOM_H
target/sparc/cpu.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef SPARC_CPU_H #define SPARC_CPU_H
target/sparc/helper.h +3 -0
@@ -1,3 +1,6 @@ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TARGET_SPARC64 DEF_HELPER_1(rett, void, env)DEF_HELPER_2 (wrpsr, void, env, tl)
target/tilegx/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TILEGX_CPU_H #define TILEGX_CPU_H
target/tilegx/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(exception, noreturn, env, i32) DEF_HELPER_1(ext01_ics, void, env)DEF_HELPER_FLAGS_1 (revbits,TCG_CALL_NO_RWG_SE , i64, i64)
target/tricore/cpu.h +3 -0
@@ -17,6 +17,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef TRICORE_CPU_H #define TRICORE_CPU_H
target/tricore/helper.h +2 -0
@@ -15,6 +15,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +/* Arithmetic */ DEF_HELPER_3(add_ssov, i32, env, i32, i32)DEF_HELPER_3 (add64_ssov, i64, env, i64, i64)
target/tricore/tricore-defs.h +2 -0
@@ -15,6 +15,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef QEMU_TRICORE_DEFS_H #define QEMU_TRICORE_DEFS_H
target/tricore/tricore-opcodes.h +2 -0
@@ -15,6 +15,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +/* * Opcode Masks for Tricore * Format MASK_OP_InstrFormatName_Field
target/unicore32/cpu.h +3 -0
@@ -9,6 +9,9 @@* later version. See the COPYING file in the top-level directory. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef UNICORE32_CPU_H #define UNICORE32_CPU_H
target/unicore32/helper.h +2 -0
@@ -7,6 +7,8 @@* later version. See the COPYING file in the top-level directory. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef CONFIG_USER_ONLY DEF_HELPER_4(cp0_set, void, env, i32, i32, i32)DEF_HELPER_3 (cp0_get, i32, env, i32, i32)
target/xtensa/cpu.h +3 -0
@@ -25,6 +25,9 @@* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_CPU_H #define XTENSA_CPU_H
target/xtensa/helper.h +2 -0
@@ -1,3 +1,5 @@ +/* FIXME Does not pass make check-headers, yet! */ + DEF_HELPER_2(exception, noreturn, env, i32) DEF_HELPER_3(exception_cause, noreturn, env, i32, i32)DEF_HELPER_4 (exception_cause_vaddr, noreturn, env, i32, i32, i32)
target/xtensa/overlay_tool.h +3 -0
@@ -25,6 +25,9 @@* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#define XTREG (idx, ofs, bi, sz, al, no, fl, cp, typ, grp, name, \ a1, a2, a3, a4, a5, a6) { \ .targno = (no), \
target/xtensa/xtensa-isa-internal.h +2 -0
@@ -22,6 +22,8 @@* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef XTENSA_ISA_INTERNAL_H #define XTENSA_ISA_INTERNAL_H
tcg/aarch64/tcg-target.h +2 -0
@@ -10,6 +10,8 @@* See the COPYING file in the top-level directory for details. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef AARCH64_TCG_TARGET_H #define AARCH64_TCG_TARGET_H
tcg/aarch64/tcg-target.opc.h +3 -0
@@ -2,4 +2,7 @@emitted by tcg_expand_vec_op. For those familiar with GCC internals, consider these to be UNSPEC with names. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +DEF (aa64_sshl_vec,1 ,2 ,0 ,IMPLVEC )
tcg/arm/tcg-target.h +2 -0
@@ -23,6 +23,8 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef ARM_TCG_TARGET_H #define ARM_TCG_TARGET_H
tcg/i386/tcg-target.h +3 -0
@@ -22,6 +22,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef I386_TCG_TARGET_H #define I386_TCG_TARGET_H
tcg/i386/tcg-target.opc.h +2 -0
@@ -2,6 +2,8 @@emitted by tcg_expand_vec_op. For those familiar with GCC internals, consider these to be UNSPEC with names. */ +/* FIXME Does not pass make check-headers, yet! */ + DEF(x86_shufps_vec, 1, 2, 1, IMPLVEC) DEF(x86_vpblendvb_vec, 1, 3, 0, IMPLVEC)DEF (x86_blend_vec,1 ,2 ,1 ,IMPLVEC )
tcg/mips/tcg-target.h +2 -0
@@ -24,6 +24,8 @@* THE SOFTWARE. */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef MIPS_TCG_TARGET_H #define MIPS_TCG_TARGET_H
tcg/ppc/tcg-target.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef PPC_TCG_TARGET_H #define PPC_TCG_TARGET_H
tcg/riscv/tcg-target.h +3 -0
@@ -22,6 +22,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef RISCV_TCG_TARGET_H #define RISCV_TCG_TARGET_H
tcg/s390/tcg-target.h +3 -0
@@ -22,6 +22,9 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +#ifndef S390_TCG_TARGET_H #define S390_TCG_TARGET_H
tcg/tcg-gvec-desc.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +/* ??? These bit widths are set for ARM SVE, maxing out at 256 byte vectors. */ #define SIMD_OPRSZ_SHIFT 0#define SIMD_OPRSZ_BITS 5
tcg/tcg-op-gvec.h +2 -0
@@ -17,6 +17,8 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* FIXME Does not pass make check-headers, yet! */ +/* * "Generic" vectors. All operands are given as offsets from ENV, * and therefore cannot also be allocated via tcg_global_mem_new_*.
tcg/tcg-op.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +#ifndef TCG_TCG_OP_H #define TCG_TCG_OP_H
tcg/tcg-opc.h +4 -0
@@ -22,11 +22,15 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +/* * DEF(name, oargs, iargs, cargs, flags) */ /* predefined ops */ + DEF(discard, 1, 0, 0, TCG_OPF_NOT_PRESENT)DEF (set_label,0 ,0 ,1 ,TCG_OPF_BB_END |TCG_OPF_NOT_PRESENT )
tcg/tcg.h +2 -0
@@ -22,6 +22,8 @@* THE SOFTWARE. */ +/* NOTE: May only be included into target-dependent code */
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.17.2
Part of the diff is not shown here. View the raw message.
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/
Quoted 1 line · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>
Please add a proper patch description. You don't really expect someone to review this monster patch without instructions where to look first?
Thomas
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/
Quoted 5 lines · Thomas Huth
Quoted 1 line · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Please add a proper patch description. You don't really expect someone to review this monster patch without instructions where to look first?
From the cover letter:
PATCH 5 adds the tests, but only for include/. 764 headers, 179 known-bad. We may decide to clean up include/ some before we apply PATCH 6+7.
PATCH 6 extends them to all headers, except for generated ones. Adds 797 headers, 409 known-bad.
Markus, you could have use "This patch is RFC, see the cover letter of this series" :)
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/
In reply to Thomas HuthQuoted 5 lines · Thomas Huth
Quoted 1 line · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Please add a proper patch description. You don't really expect someone to review this monster patch without instructions where to look first?
Fair point. RFC is no excuse for making review harder than necessary.
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/
In reply to Markus ArmbrusterQuoted 11 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>---
432 files changed, 1035 insertions(+), 8 deletions(-)accel/tcg/atomic_template.h +0
-0
accel/tcg/atomic_template.h line 23
Quoted 6 lines
accel/tcg/atomic_template.h +3
-0@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ +/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +
I'm not sure I see much point in touching several hundred header files just to add a FIXME note. We can fix them, or we can just leave things as they are...
thanks
-- PMM
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/
Quoted 15 lines · Peter Maydell
Quoted 14 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>---
432 files changed, 1035 insertions(+), 8 deletions(-)accel/tcg/atomic_template.h +0
-0@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */
Quoted 7 lines
accel/tcg/atomic_template.h line 23
Quoted 3 lines
accel/tcg/atomic_template.h +3
-0+/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +I'm not sure I see much point in touching several hundred header files just to add a FIXME note. We can fix them, or we can just leave things as they are...
Adding FIXMEs without an intent to actually fix them would be stupid.
The FIXMEs direct "make check-headers" to skip the headers so marked. Without the FIXMEs, "make check-headers" fails. I want it to succeed, so we can run it from "make check", and gain protection against clean headers becoming unclean.
What "make check-headers" covers is for us to choose. This RFC series starts with include/, then widens to everything in two big steps:
* PATCH 5: include/. 764 headers, 179 known-bad.
* PATCH 6: all of the source tree. Adds 797 headers, 409 known-bad.
* PATCH 7: plus generated headers. Adds 177 headers, 3 known-bad.
We can start smaller, and take smaller steps.
Re: [Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/
Quoted 26 lines · Markus Armbruster
Quoted 15 lines · Peter Maydell
Quoted 14 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>---
432 files changed, 1035 insertions(+), 8 deletions(-)accel/tcg/atomic_template.h +0
-0@@ -18,6 +18,9 @@* License along with this library; if not, see <http://www.gnu.org/licenses/>. */ Quoted 7 lines
accel/tcg/atomic_template.h line 23
Quoted 3 lines
accel/tcg/atomic_template.h +3
-0+/* NOTE: May only be included into target-dependent code */ +/* FIXME Does not pass make check-headers, yet! */ +I'm not sure I see much point in touching several hundred header files just to add a FIXME note. We can fix them, or we can just leave things as they are...
Quoted 3 lines
Adding FIXMEs without an intent to actually fix them would be stupid.
The FIXMEs direct "make check-headers" to skip the headers so marked.
Ah, right. It wasn't clear that this is a directive to the script:
it looks like the usual free-text aimed-at-human-readers kind of FIXME/TODO comment.
thanks
-- PMM
RFC v4 7/7 tests: Make check-source cover generated headers
In reply to Markus ArmbrusterFIXME Computation of generated target-dependent headers
--- tests/check-headers.mak | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
tests/check-headers.mak +13 -2
@@ -4,16 +4,26 @@ ifneq ($(wildcard $(SRC_PATH)/.git),) # All headers: src-headers := $(filter %.h, $(shell cd $(SRC_PATH) && git ls-files)) +gen-headers := $(filter %.h, $(generated-files-y)) +ifeq ($(generated-files-y),) # FIXME empty when included from Makefile.target +$(warning warning: working around empty generated-files-y) +# Work-around: hard-code the generated headers that are actually +# target-dependent +gen-headers := qapi/qapi-types-target.h qapi/qapi-visit-target.h qapi/qapi-commands-target.h qapi/qapi-events-target.h qapi/qapi-types.h qapi/qapi-visit.h qapi/qapi-commands.h qapi/qapi-events.h +endif # Third party headers we don't want to mess with: excluded-headers := $(filter disas/libvixl/vixl/% include/standard-headers/% linux-headers/% pc-bios/% slirp/%, $(src-headers)) +excluded-headers += $(filter trace-dtrace-root.h %/trace-dtrace.h, $(gen-headers)) # Funny stuff we don't want to mess with: excluded-headers += $(filter tests/multiboot/% tests/tcg/% tests/uefi-test-tools/%, $(src-headers)) excluded-headers += scripts/cocci-macro-file.h # Headers that require -DNEED_CPU_H etc. target-header-comment := NOTE: May only be included into target-dependent code -target-headers := $(shell cd $(SRC_PATH) && egrep -l '$(target-header-comment)' $(src-headers)) +target-headers := $(filter qapi/qapi-%-target.h, $(gen-headers)) +target-headers += $(target-headers:-target.h=.h) +target-headers += $(shell cd $(SRC_PATH) && egrep -l '$(target-header-comment)' $(src-headers)) # Headers carrying a FIXME about this test: bad-header-without-linux$(CONFIG_LINUX) := | without CONFIG_LINUX
@@ -28,10 +38,11 @@ bad-header-without-x11$(CONFIG_X11) := | without CONFIG_X11 bad-header-without-xen$(CONFIG_XEN) := | without CONFIG_XEN bad-header-comment := FIXME Does not pass make check-headers($(bad-header-without-linux)$(bad-header-without-opengl)$(bad-header-without-posix)$(bad-header-without-rdma)$(bad-header-without-replication)$(bad-header-without-spice)$(bad-header-without-system-emu)$(bad-header-without-win32)$(bad-header-without-x11)$(bad-header-without-xen)), yet! bad-headers := $(shell cd $(SRC_PATH) && egrep -l '$(bad-header-comment)' $(src-headers)) +bad-headers += trace/generated-tcg-tracers.h trace/generated-helpers-wrappers.h trace/generated-helpers.h bad-target-headers := $(filter $(target-headers), $(bad-headers)) # Checked headers (all less excluded and bad): -checked-headers := $(filter-out $(excluded-headers) $(bad-headers) $(target-headers), $(src-headers)) +checked-headers := $(filter-out $(excluded-headers) $(bad-headers) $(target-headers), $(src-headers) $(gen-headers)) check-header-tests := $(patsubst %.h, tests/headers/%.c, $(checked-headers)) checked-target-headers := $(filter-out $(excluded-headers) $(bad-headers), $(target-headers)) check-target-header-tests := $(patsubst %.h, tests/headers/%.c, $(checked-target-headers))
Signature · 1 line
2.17.2