drm/amd/scheduler:fix duplicate operation in entity fini
Subsystems (2)
PATCH 1/1 drm/amd/scheduler:fix duplicate operation in entity fini
no need to manually cleanup job and fence after sched_fence_finish(), they are auto handled by the callback
Change-Id I9da26064c9e73c178949663bed1e490539e95e41
Signed-off-by Monk Liu <[email protected]>
--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +1 -2
@@ -230,11 +230,10 @@ void amd_sched_entity_fini(struct amd_gpu_scheduler *sched,kthread_unpark (sched->thread);while (kfifo_out (&entity->job_queue, &job,sizeof (job))) {struct amd_sched_fence *s_fence = job->s_fence; +amd_sched_fence_scheduled (s_fence);dma_fence_set_error (&s_fence->finished, -ESRCH );amd_sched_fence_finished (s_fence); -dma_fence_put (&s_fence->finished); - sched->ops->free_job (job); } }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1508738432-27426-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org
Christian König
Reviewed-byAm 23.10.2017 um 08:00 schrieb Monk Liu:
Quoted 5 lines
no need to manually cleanup job and fence after
sched_fence_finish(), they are auto handled by the callbackChange-Id I9da26064c9e73c178949663bed1e490539e95e41Signed-off-by Monk Liu <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 11 lines
--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +0
-0@@ -230,11 +230,10 @@ void amd_sched_entity_fini(struct amd_gpu_scheduler *sched,kthread_unpark (sched->thread);while (kfifo_out (&entity->job_queue, &job,sizeof (job))) {
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c void amd_sched_entity_fini(struct amd_gpu_scheduler *sched, · line 239
Quoted 10 lines
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c +1
-2struct amd_sched_fence *s_fence = job->s_fence; +amd_sched_fence_scheduled (s_fence);dma_fence_set_error (&s_fence->finished, -ESRCH );amd_sched_fence_finished (s_fence); -dma_fence_put (&s_fence->finished); - sched->ops->free_job (job); } }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx