Skip to contentSkip to conversation

gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

PATCH In review Peter Robinson 4 participants 5 messages Dec 18, 2019 – Mar 5, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4.

---
 drivers/gpu/drm/v3d/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/v3d/Kconfig +1 -1
index 9a5c44606337..b0e048697964 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_V3D
 	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on COMMON_CLK
 	depends on MMU
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hi Peter,

Quoted 6 lines · Peter Robinson

On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4.

---

v3d's upstream implementation doesn't support RPi4 for now. So I don't see how we could benefit from this.

That said you're more than welcome to have a go at adding support for RPi4. It seems to me that the divergence betweeen us and Raspberry Pi foundation's kernel isn't that big. Maybe Eric can share some extra light on this.

Regards,
Nicolas

Quoted 8 lines
 drivers/gpu/drm/v3d/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/v3d/Kconfig +0 -0
index 9a5c44606337..b0e048697964 100644

drivers/gpu/drm/v3d/Kconfig line 7

Quoted 8 lines
drivers/gpu/drm/v3d/Kconfig +1 -1
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_V3D
 	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on COMMON_CLK
 	depends on MMU

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 7 lines · Nicolas Saenz Julienne

Hi Peter,

Quoted 4 lines · Peter Robinson

On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4.

Quoted 5 lines
Quoted 2 lines

---

v3d's upstream implementation doesn't support RPi4 for now. So I don't see how we could benefit from this.

Right, but it should support the Pi3 running in 64-bit mode too, so maybe that would be a better justification to put in the commit message?

Quoted 25 lines

That said you're more than welcome to have a go at adding support for RPi4. It seems to me that the divergence betweeen us and Raspberry Pi foundation's kernel isn't that big. Maybe Eric can share some extra light on this.

Regards,
Nicolas

Quoted 16 lines
 drivers/gpu/drm/v3d/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/v3d/Kconfig +1 -1
index 9a5c44606337..b0e048697964 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_V3D
 	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on COMMON_CLK
 	depends on MMU
Signature · 6 lines
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Hi Florian,

Quoted 11 lines · Florian Fainelli
Quoted 10 lines · Nicolas Saenz Julienne

Hi Peter,

Quoted 6 lines · Peter Robinson

On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4.

---

Quoted 6 lines
Quoted 3 lines

v3d's upstream implementation doesn't support RPi4 for now. So I don't see how
we could benefit from this.

Right, but it should support the Pi3 running in 64-bit mode too, so maybe that would be a better justification to put in the commit message?

Correct me if I'm wrong, but this 'v3d' isn't the same as 'vc4_v3d'. From the initial commit for the driver[1] I understood this is only valid for bcm2711.

Regards,
Nicolas

[1] https://lore.kernel.org/lkml/[email protected]/

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
In reply to Nicolas Saenz Julienne
Quoted 8 lines · Nicolas Saenz Julienne

Hi Peter,

Quoted 4 lines · Peter Robinson

On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4.

Quoted 5 lines
Quoted 2 lines

---

v3d's upstream implementation doesn't support RPi4 for now. So I don't see how we could benefit from this.

All you need is a compatible string for making this driver work on pi4's v3d, so this seems like a good change to be making, to me.

Peter, feel like defining the compatible string too?
_______________________________________________
dri-devel mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel