Skip to contentSkip to conversation

add new extrausers command passwd-expire

PATCH In review Joseph Reynolds 2 participants 4 messages Oct 26, 2020 – Oct 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add new extrausers command passwd-expire

This enhances extrausers with a new passwd-expire command that causes a local user's password to be expired as if the passwd --expire command was run, so the password needs to be changed on initial login.

Example: EXTRA_USERS_PARAMS += " useradd ... sofia; passwd-expire sofia;"

Tested: on useradd accounts
When configured with Linux-PAM, console login prompts for and can successfully change the password.  OpenSSH server works.  Dropbear SSH server notes the password must be changed but does not offer a password change dialog and rejects the login request.

---
 meta/classes/extrausers.bbclass   |  3 +++ meta/classes/useradd_base.bbclass | 18 ++++++++++++++++++

 2 files changed, 21 insertions(+)
meta/classes/extrausers.bbclass +0 -0
index 32569e9..90811bf 100644
@@ -46,6 +46,9 @@ set_user_group () {

             usermod)
                 perform_usermod "${IMAGE_ROOTFS}" "-R ${IMAGE_ROOTFS} $opts" ;;
+            passwd-expire)
+                perform_passwd_expire "${IMAGE_ROOTFS}" "$opts" +                ;;
             groupmod)
                 perform_groupmod "${IMAGE_ROOTFS}" "-R ${IMAGE_ROOTFS} $opts" ;;

meta/classes/useradd_base.bbclass +0 -0
index 0d0bdb8..7f5b9b7 100644
@@ -145,3 +145,21 @@ perform_usermod () {

     fi
     set -e
 }
+
+perform_passwd_expire () {
+    local rootdir="$1"
+    local opts="$2"
+    bbnote "${PN}: Performing equivalent of passwd --expire with [$opts]"
+    # Directly set sp_lstchg to 0 without using the passwd command: Only root can do that
+    local username=echo "$opts" | awk '{ print $NF }'
+    local user_exists="grep "^$username:" $rootdir/etc/passwd || true"
+    if test "x$user_exists" != "x"; then
+        eval flock -x $rootdir${sysconfdir} -c \"$PSEUDO sed -i \''s/^\('$username':[^:]*\):[^:]*:/\1:0:/'\' $rootdir/etc/shadow \" || tru e
+        local passwd_lastchanged="grep "^$username:" $rootdir/etc/shadow | cut -d: -f3"
+        if test "x$passwd_lastchanged" != "x0"; then
+            bbfatal "${PN}: passwd --expire operation did not succeed."
+        fi
+    else
+        bbnote "${PN}: user $username doesn't exist, not expiring its password"
+    fi
+}

Signature · 1 line
2.7.2
#1 lore raw

Hi Joseph,

Quoted 29 lines · Joseph Reynolds

This enhances extrausers with a new passwd-expire command that causes a local user's password to be expired as if the passwd --expire command was run, so the password needs to be changed on initial login.

Example: EXTRA_USERS_PARAMS += " useradd ... sofia; passwd-expire sofia;"

Tested: on useradd accounts
When configured with Linux-PAM, console login prompts for and can successfully change the password. OpenSSH server works. Dropbear SSH server notes the password must be changed but does not offer a password change dialog and rejects the login request.

---
  meta/classes/extrausers.bbclass   |  3 +++
  meta/classes/useradd_base.bbclass | 18 ++++++++++++++++++
  2 files changed, 21 insertions(+)
meta/classes/extrausers.bbclass +0 -0
index 32569e9..90811bf 100644
@@ -46,6 +46,9 @@ set_user_group () {
              usermod)
                  perform_usermod "${IMAGE_ROOTFS}" "-R
 ${IMAGE_ROOTFS} 
Quoted 1 line

$opts"

Unfortunately this patch is coming through line wrapped which makes it hard to apply. Can you resend it without the line wrapping, or point at a git tree with the patch in please?

I do remember the patch from the last time around and I think this was the issue last time as well, I couldn't get it to apply. It does seem like a reasonable addition and it would be good to work with openBMC on common issues like this!

Cheers,

Richard

#2 lore raw

Re: [OE-core] [PATCH] add new extrausers command passwd-expire - moved to PR 63

Quoted 23 lines · Richard Purdie

Hi Joseph,

Quoted 20 lines · Joseph Reynolds

This enhances extrausers with a new passwd-expire command that causes a local user's password to be expired as if the passwd --expire command was run, so the password needs to be changed on initial login.

Example: EXTRA_USERS_PARAMS += " useradd ... sofia; passwd-expire sofia;"

Tested: on useradd accounts
When configured with Linux-PAM, console login prompts for and can successfully change the password. OpenSSH server works. Dropbear SSH server notes the password must be changed but does not offer a password change dialog and rejects the login request.

---
   meta/classes/extrausers.bbclass   |  3 +++
   meta/classes/useradd_base.bbclass | 18 ++++++++++++++++++
   2 files changed, 21 insertions(+)
Quoted 13 lines
Quoted 10 lines
meta/classes/extrausers.bbclass +0 -0
index 32569e9..90811bf 100644
@@ -46,6 +46,9 @@ set_user_group () {
               usermod)
                   perform_usermod "${IMAGE_ROOTFS}" "-R
 ${IMAGE_ROOTFS}

$opts"

Unfortunately this patch is coming through line wrapped which makes it hard to apply. Can you resend it without the line wrapping, or point at a git tree with the patch in please?

Thanks.  The PR work flow is much easier for me.  I didn't realize OE was on github.com. I hereby withdraw & abandon my email patch request and replace it with:
https://github.com/openembedded/openembedded-core/pull/63

- Joseph

Quoted 10 lines

I do remember the patch from the last time around and I think this was the issue last time as well, I couldn't get it to apply. It does seem like a reasonable addition and it would be good to work with openBMC on common issues like this!

Cheers,

Richard

#3 lore raw

Re: [OE-core] [PATCH] add new extrausers command passwd-expire - moved to PR 63

Quoted 43 lines · Joseph Reynolds
Quoted 26 lines · Richard Purdie

Hi Joseph,

Quoted 23 lines · Joseph Reynolds

This enhances extrausers with a new passwd-expire command that causes
a local user's password to be expired as if the passwd --expire command was run, so the password needs to be changed on initial login.

Example: EXTRA_USERS_PARAMS += " useradd ... sofia; passwd-expire sofia;"

Tested: on useradd accounts
When configured with Linux-PAM, console login prompts for and can successfully change the password. OpenSSH server works. Dropbear
SSH server notes the password must be changed but does not offer a
password change dialog and rejects the login request.

---
   meta/classes/extrausers.bbclass   |  3 +++
   meta/classes/useradd_base.bbclass | 18 ++++++++++++++++++
   2 files changed, 21 insertions(+)
Quoted 15 lines
Quoted 10 lines
meta/classes/extrausers.bbclass +0 -0
index 32569e9..90811bf 100644
@@ -46,6 +46,9 @@ set_user_group () {
               usermod)
                   perform_usermod "${IMAGE_ROOTFS}" "-R
 ${IMAGE_ROOTFS}

$opts"

Unfortunately this patch is coming through line wrapped which makes it
hard to apply. Can you resend it without the line wrapping, or point at
a git tree with the patch in please?

Quoted 6 lines

Thanks. The PR work flow is much easier for me. I didn't realize OE
was on github.com.
I hereby withdraw & abandon my email patch request and replace it with:
https://github.com/openembedded/openembedded-core/pull/63

We don't. In this case since its mangled, I'm willing to pull from somewhere. We do need patches on the mailing list for review since that is where people look to review them. github works fine for a single maintainer, I can't merge pretty much anything without public peer review though.

Cheers,

Richard