Skip to contentSkip to conversation

net/9p: Fix iov_iter usage

PATCH In review Andy Lutomirski 2 participants 2 messages Nov 4, 2018 9P file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/9p: Fix iov_iter usage

Trying to use 9pfs causes QEMU to complain:

qemu-system-x86_64: virtio: bogus descriptor or out of resources

This happens because 9p was broken by the iov_iter refactoring because a ! got lost. Put it back. The offending hunk was:

net/9p/trans_virtio.c +1 -1
index 7728b0acde09..4d7d2070e9c8 100644
@@ -322,7 +322,7 @@ static int p9_get_mapped_pages(struct virtio_chan *chan,
 	if (!iov_iter_count(data))
 		return 0;
 
-	if (!(data->type & ITER_KVEC)) {
+	if (iov_iter_is_kvec(data)) {
 
Cc David Howells <[email protected]>
Cc Al Viro <[email protected]>
Fixes 00e23707442a ("iov_iter: Use accessor function")
---
 net/9p/trans_virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/9p/trans_virtio.c +1 -1
index 91981970f542..b1d39cabf125 100644
@@ -329,7 +329,7 @@ static int p9_get_mapped_pages(struct virtio_chan *chan,
 	if (!iov_iter_count(data))
 		return 0;
 
-	if (iov_iter_is_kvec(data)) {
+	if (!iov_iter_is_kvec(data)) {
 		int n;
 		/*
 		 * We allow only p9_max_pages pinned. We wait for the
Signature · 1 line
2.17.2
#1 lore raw
Quoted 1 line · Andy Lutomirski

Trying to use 9pfs causes QEMU to complain:

commit 2cbfdf4df58330f6cb493500387427dae1c5551d

Author: Marc Zyngier <[email protected]>
Date:   Fri Nov 2 17:16:51 2018 +0000

iov_iter: Fix 9p virtio breakage