Skip to contentSkip to conversation

x86/mwait-idle: add missing newline

PATCH In review Roger Pau Monne 3 participants 3 messages May 16, 2022 – May 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mwait-idle: add missing newline

Fixes 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 enabled')
---
 xen/arch/x86/cpu/mwait-idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/cpu/mwait-idle.c +1 -1
index 6add64dc5f..5d77672f6b 100644
@@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init(
 		/* if state marked as disabled, skip it */
 		if (cpuidle_state_table[cstate].flags &
 		    CPUIDLE_FLAG_DISABLED) {
-			printk(XENLOG_DEBUG PREFIX "state %s is disabled",
+			printk(XENLOG_DEBUG PREFIX "state %s is disabled\n",
 			       cpuidle_state_table[cstate].name);
 			continue;
 		}
Signature · 1 line
2.36.0
#2 lore raw
In reply to Roger Pau Monne
Quoted 2 lines · Roger Pau Monne
Fixes 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 enabled')

Thanks for spotting. I wonder whether we shouldn't mention the Linux commit (654d08a42a56) which did this as a "side effect". Obviously the fix here isn't really a port thereof.

Jan

Quoted 11 lines
xen/arch/x86/cpu/mwait-idle.c +1 -1
@@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init(
 		/* if state marked as disabled, skip it */
 		if (cpuidle_state_table[cstate].flags &
 		    CPUIDLE_FLAG_DISABLED) {
-			printk(XENLOG_DEBUG PREFIX "state %s is disabled",
+			printk(XENLOG_DEBUG PREFIX "state %s is disabled\n",
 			       cpuidle_state_table[cstate].name);
 			continue;
 		}