riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency
PATCH 1/1 riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency
From: Bin Meng <[email protected]>
SPL_RAM_SUPPORT and SPL_RAM_DEVICE are only visible in an SPL config.
---
This patch should be applied after the following one:
http://patchwork.ozlabs.org/project/uboot/patch/20201104114901.9420-2-xypron.glpk at gmx.de/
board/AndesTech/ax25-ae350/Kconfig | 4 ++-- board/emulation/qemu-riscv/Kconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
board/AndesTech/ax25-ae350/Kconfig +2 -2
@@ -32,7 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select RISCV_NDS select SUPPORT_SPL imply SMP - imply SPL_RAM_SUPPORT - imply SPL_RAM_DEVICE + imply SPL_RAM_SUPPORT if SPL + imply SPL_RAM_DEVICE if SPL endif
board/emulation/qemu-riscv/Kconfig +2 -2
@@ -33,8 +33,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply SMP imply BOARD_LATE_INIT imply PCI_INIT_R - imply SPL_RAM_SUPPORT - imply SPL_RAM_DEVICE + imply SPL_RAM_SUPPORT if SPL + imply SPL_RAM_DEVICE if SPL imply CMD_PCI imply CMD_POWEROFF imply CMD_SCSI
Signature · 1 line
2.7.4
PATCH 1/1 riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency
On Thu, Nov 5, 2020 at 4:16 PM Bin Meng <[email protected]> wrote:>
Quoted 5 lines
From: Bin Meng <[email protected]>
SPL_RAM_SUPPORTandSPL_RAM_DEVICEare only visible in an SPL config.Reported-by Heinrich Schuchardt <[email protected]>
+Heinrich Schuchardt in CC
Quoted 9 lines
Signed-off-by Bin Meng <[email protected]>---
This patch should be applied after the following one:
http://patchwork.ozlabs.org/project/uboot/patch/20201104114901.9420-2-xypron.glpk at gmx.de/board/AndesTech/ax25-ae350/Kconfig | 4 ++-- board/emulation/qemu-riscv/Kconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
Regards,
Bin
PATCH 1/1 riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency
In reply to Bin MengQuoted 3 lines · Bin Meng
From: Bin Meng <[email protected]>
SPL_RAM_SUPPORTandSPL_RAM_DEVICEare only visible in an SPL config.
'if SPL' would only be required if you would use 'select'. With 'imply' the Kconfig build system takes care of this dependency.
My question was about CONFIG_RAM which is not selected on QEMU. But of cause you do not need a RAM driver on QEMU.
So I think you can drop this patch.
Best regards
Heinrich
Quoted 41 lines
Reported-by Heinrich Schuchardt <[email protected]>Signed-off-by Bin Meng <[email protected]>---
This patch should be applied after the following one:
http://patchwork.ozlabs.org/project/uboot/patch/20201104114901.9420-2-xypron.glpk at gmx.de/board/AndesTech/ax25-ae350/Kconfig | 4 ++-- board/emulation/qemu-riscv/Kconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)board/AndesTech/ax25-ae350/Kconfig +2
-2@@ -32,7 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select RISCV_NDS select SUPPORT_SPL imply SMP - imply SPL_RAM_SUPPORT - imply SPL_RAM_DEVICE + imply SPL_RAM_SUPPORT if SPL + imply SPL_RAM_DEVICE if SPL endifboard/emulation/qemu-riscv/Kconfig +2
-2@@ -33,8 +33,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply SMP imply BOARD_LATE_INIT imply PCI_INIT_R - imply SPL_RAM_SUPPORT - imply SPL_RAM_DEVICE + imply SPL_RAM_SUPPORT if SPL + imply SPL_RAM_DEVICE if SPL imply CMD_PCI imply CMD_POWEROFF imply CMD_SCSI
PATCH 1/1 riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency
Hi Heinrich,
Quoted 8 lines · Heinrich Schuchardt
Quoted 3 lines · Bin Meng
From: Bin Meng <[email protected]>
SPL_RAM_SUPPORTandSPL_RAM_DEVICEare only visible in an SPL config.'if SPL' would only be required if you would use 'select'. With 'imply' the
Kconfigbuild system takes care of this dependency.
Yes, but I feel that adding a "if" seems to be express the dependency explicitly to avoid confusions.
Quoted 4 lines
My question was about
CONFIG_RAMwhich is not selected on QEMU. But of cause you do not need a RAM driver on QEMU.
Correct.
Quoted 2 lines
So I think you can drop this patch.
I am fine to drop this if there is no concern.
Regards,
Bin