Skip to contentSkip to conversation

wcn36xx: remove space before ')'

PATCH In review [email protected] 3 participants 3 messages Jul 17, 2023 – Jul 21, 2023 1 message not in the archive Qualcomm WCN36XX wireless driver

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 wcn36xx: remove space before ')'

Fixes checkpatch.pl error:

./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')' ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'

---
 drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/wcn36xx/dxe.c +2 -2
index 9013f05..b8d7676 100644
@@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)
                        WCN36XX_DXE_0_INT_CLR,
                        WCN36XX_INT_MASK_CHAN_TX_H);
 
-        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
             wcn36xx_dxe_write_register(wcn,
                            WCN36XX_DXE_0_INT_ERR_CLR,
                            WCN36XX_INT_MASK_CHAN_TX_H);
@@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)
                        WCN36XX_DXE_0_INT_CLR,
                        WCN36XX_INT_MASK_CHAN_TX_L);
 
-        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
             wcn36xx_dxe_write_register(wcn,
                            WCN36XX_DXE_0_INT_ERR_CLR,
                            WCN36XX_INT_MASK_CHAN_TX_L);
#2 lore raw
Quoted 6 lines · On 7/17/2023 12:04 AM, [email protected] wrote:

Fixes checkpatch.pl error:

./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')' ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'

For all of your recent patches you have the issue that your Signed-off-by does not seem to be a legal name, and that it does not match the From address in your e-mail.

Refer to <https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#sign-your-work-the-developer-s-certificate-of-origin>

Also all wifi drivers should have a subject prefix of "wifi: <drivername>:", in this case "wifi: wcn36xx: "

The actual patch LGTM

Quoted 28 lines
---
  drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/wcn36xx/dxe.c +1 -1
index 9013f05..b8d7676 100644
@@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, 
 void *dev)
                         WCN36XX_DXE_0_INT_CLR,
                         WCN36XX_INT_MASK_CHAN_TX_H);
 
-        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
              wcn36xx_dxe_write_register(wcn,
                             WCN36XX_DXE_0_INT_ERR_CLR,

                            WCN36XX_INT_MASK_CHAN_TX_H);

drivers/net/wireless/ath/wcn36xx/dxe.c +1 -1
@@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, 
 void *dev)
                         WCN36XX_DXE_0_INT_CLR,
                         WCN36XX_INT_MASK_CHAN_TX_L);
 
-        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+        if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
              wcn36xx_dxe_write_register(wcn,
                             WCN36XX_DXE_0_INT_ERR_CLR,

                            WCN36XX_INT_MASK_CHAN_TX_L);

#3 lore raw
In reply to [email protected]
Quoted 8 lines · [email protected] wrote:

Fixes checkpatch.pl error:

./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')' ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'

ERROR: Missing Signed-off-by: [email protected]

Patch set to Changes Requested.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches