wcn36xx: remove space before ')'
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 wcn36xx: remove space before ')'
Fixes checkpatch.pl error:
./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')' ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'
--- drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/wcn36xx/dxe.c +2 -2
@@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)WCN36XX_DXE_0_INT_CLR , WCN36XX_INT_MASK_CHAN_TX_H); -if (int_reason &WCN36XX_CH_STAT_INT_ERR_MASK ) { +if (int_reason &WCN36XX_CH_STAT_INT_ERR_MASK ) {wcn36xx_dxe_write_register (wcn,WCN36XX_DXE_0_INT_ERR_CLR ,WCN36XX_INT_MASK_CHAN_TX_H );
@@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev)WCN36XX_DXE_0_INT_CLR , WCN36XX_INT_MASK_CHAN_TX_L); -if (int_reason &WCN36XX_CH_STAT_INT_ERR_MASK ) { +if (int_reason &WCN36XX_CH_STAT_INT_ERR_MASK ) {wcn36xx_dxe_write_register (wcn,WCN36XX_DXE_0_INT_ERR_CLR ,WCN36XX_INT_MASK_CHAN_TX_L );
Quoted 6 lines · On 7/17/2023 12:04 AM, [email protected] wrote:
Fixes checkpatch.pl error:
./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')'./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'Signed-off-by maqimei <[email protected]>
For all of your recent patches you have the issue that your Signed-off-by does not seem to be a legal name, and that it does not match the From address in your e-mail.
Also all wifi drivers should have a subject prefix of "wifi: <drivername>:", in this case "wifi: wcn36xx: "
The actual patch LGTM
Quoted 28 lines
--- drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/wireless/ath/wcn36xx/dxe.c +1
-1@@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev) WCN36XX_DXE_0_INT_CLR, WCN36XX_INT_MASK_CHAN_TX_H); - if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) { + if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) { wcn36xx_dxe_write_register(wcn, WCN36XX_DXE_0_INT_ERR_CLR,
WCN36XX_INT_MASK_CHAN_TX_H);drivers/net/wireless/ath/wcn36xx/dxe.c +1
-1@@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq, void *dev) WCN36XX_DXE_0_INT_CLR, WCN36XX_INT_MASK_CHAN_TX_L); - if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) { + if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) { wcn36xx_dxe_write_register(wcn, WCN36XX_DXE_0_INT_ERR_CLR,
WCN36XX_INT_MASK_CHAN_TX_L);
Quoted 8 lines · [email protected] wrote:
Fixes checkpatch.pl error:
./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited before that close parenthesis ')'./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited before that close parenthesis ')'Signed-off-by maqimei <[email protected]>
ERROR: Missing Signed-off-by: [email protected]
Patch set to Changes Requested.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches