Skip to contentSkip to conversation

drm/amd/pm: open brace '{' following struct go on the same line

PATCH In review [email protected] 2 participants 2 messages Jul 21, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/amd/pm: open brace '{' following struct go on the same line

ERROR: open brace '{' following struct go on the same line

---
 drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h +0 -0
index ddc488251313..0cf564ea1ed8 100644
@@ -429,10 +429,10 @@ int amdgpu_pm_load_smu_firmware(struct amdgpu_device *adev, uint32_t *smu_versio
 int amdgpu_dpm_handle_passthrough_sbr(struct amdgpu_device *adev, bool 

enable);
int amdgpu_dpm_send_hbm_bad_pages_num(struct amdgpu_device *adev,
uint32_t size);
int amdgpu_dpm_send_hbm_bad_channel_flag(struct amdgpu_device *adev,
uint32_t size);
-int amdgpu_dpm_get_dpm_freq_range(struct amdgpu_device *adev,enum pp_clock_type type,
- uint32_t *min,uint32_t *max);
-int amdgpu_dpm_set_soft_freq_range(struct amdgpu_device *adev,enum pp_clock_type type,
- uint32_t min,uint32_t max);
+int amdgpu_dpm_get_dpm_freq_range(struct amdgpu_device *adev, enum pp_clock_type type,
+ uint32_t *min, uint32_t *max);
+int amdgpu_dpm_set_soft_freq_range(struct amdgpu_device *adev, enum pp_clock_type type,
+ uint32_t min, uint32_t max);
int amdgpu_dpm_write_watermarks_table(struct amdgpu_device *adev);
int amdgpu_dpm_wait_for_event(struct amdgpu_device *adev, enum
smu_event_type event,
uint64_t event_arg);

#2 lore raw
Quoted 3 lines · On Thu, Jul 20, 2023 at 11:53 PM <[email protected]> wrote:

ERROR: open brace '{' following struct go on the same line

The description doesn't match what the patch is doing.

Alex

Quoted 34 lines
---
  drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h +0 -0
index ddc488251313..0cf564ea1ed8 100644
@@ -429,10 +429,10 @@ int amdgpu_pm_load_smu_firmware(struct

amdgpu_device *adev, uint32_t *smu_versio
int amdgpu_dpm_handle_passthrough_sbr(struct amdgpu_device *adev, bool
enable);
int amdgpu_dpm_send_hbm_bad_pages_num(struct amdgpu_device *adev,
uint32_t size);
int amdgpu_dpm_send_hbm_bad_channel_flag(struct amdgpu_device *adev,
uint32_t size);
-int amdgpu_dpm_get_dpm_freq_range(struct amdgpu_device *adev,enum pp_clock_type type,

drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h +0 -2
-                                 uint32_t *min,uint32_t *max);
-int amdgpu_dpm_set_soft_freq_range(struct amdgpu_device *adev,enum

pp_clock_type type,

drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h +1 -1
-                                  uint32_t min,uint32_t max);
+int amdgpu_dpm_get_dpm_freq_range(struct amdgpu_device *adev, enum

pp_clock_type type,

drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h +2 -0
+                                 uint32_t *min, uint32_t *max);
+int amdgpu_dpm_set_soft_freq_range(struct amdgpu_device *adev, enum

pp_clock_type type,
+ uint32_t min, uint32_t max);
int amdgpu_dpm_write_watermarks_table(struct amdgpu_device *adev); int amdgpu_dpm_wait_for_event(struct amdgpu_device *adev, enum
smu_event_type event,

                              uint64_t event_arg);