Skip to contentSkip to conversation

psplash: add psplash-default in rdepends

PATCH In review Thomas Perrot 2 participants 2 messages Oct 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 psplash: add psplash-default in rdepends

Otherwise when the installation of recommended packages is prevented (NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.

---
 meta/recipes-core/psplash/psplash_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/psplash/psplash_git.bb +1 -1
index edc0ac1d8961..9532ed1534a6 100644
@@ -58,7 +58,7 @@ python __anonymous() {
         d.setVarFlag("ALTERNATIVE_TARGET_%s" % ep, 'psplash', '${bindir}/%s' % p)
         d.appendVar("RDEPENDS:%s" % ep, " %s" % pn)
         if p == "psplash-default":
-            d.appendVar("RRECOMMENDS:%s" % pn, " %s" % ep)
+            d.appendVar("RDEPENDS:%s" % pn, " %s" % ep)
 }
 
 S = "${WORKDIR}/git"
Signature · 1 line
2.37.3
#1 lore raw

Hello Thomas

Thanks for the patch!

Quoted 4 lines · Thomas Perrot via lists.openembedded.org

Otherwise when the installation of recommended packages is prevented (NO_RECOMMENDATIONS = "1"), then splash screen will not be cast.

There's a problem with the way you send your patches though. I used to have the same one.

If I apply your patch through "git am", the author of the commit is:
Thomas Perrot via lists.openembedded.org <[email protected]> instead of
Thomas Perrot <[email protected]>

Because of this issue, the maintainer has to manually fix this field when accepting your patch. Worse, if he doesn't catch this, that's harder to fix afterwards.

You should be able to fix this by running:

git config --global sendemail.from "[email protected]"

At least this worked for me from the same domain ;-) See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Could you try to send an update? You could send it to me again through private-mail first.

Thanks in advance
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com