virt: sevguest: add CONFIG_CRYPTO dependency
PATCH 1/1 virt: sevguest: add CONFIG_CRYPTO dependency
From: Arnd Bergmann <[email protected]>
This driver fails to link when CRYPTO is disabled, or in a loadable module:
WARNING: unmet direct dependencies detected for CRYPTO_GCM
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
Depends on [m]: CRYPTO [=m]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
--- drivers/virt/coco/sev-guest/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/virt/coco/sev-guest/Kconfig +1 -0
@@ -2,6 +2,7 @@ config SEV_GUEST tristate "AMD SEV Guest driver" default m depends on AMD_MEM_ENCRYPT + select CRYPTO select CRYPTO_AEAD2 select CRYPTO_GCM help
Signature · 1 line
2.39.0
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver fails to link when CRYPTO is disabled, or in a loadable module:
WARNING: unmet direct dependencies detected for
CRYPTO_GCM
WARNING: unmet direct dependencies detected forCRYPTO_AEAD2
Depends on [m]: CRYPTO [=m]
Selected by [y]:
-SEV_GUEST[=y] &&VIRT_DRIVERS[=y] &&AMD_MEM_ENCRYPT[=y]
Quoted 3 lines
x86_64-linux-ld:
crypto/aead.o: in function `crypto_register_aeads':Fixes d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")
This has been present from when the driver was first added, so I think the correct Fixes: tag should be:
Correct?
Thanks,
Tom
Quoted 17 lines
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/virt/coco/sev-guest/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/virt/coco/sev-guest/Kconfig +1
-0@@ -2,6 +2,7 @@ config SEV_GUEST tristate "AMD SEV Guest driver" default m depends on AMD_MEM_ENCRYPT + select CRYPTO select CRYPTO_AEAD2 select CRYPTO_GCM help
Updating email for Boris.
Quoted 41 lines · Tom Lendacky
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver fails to link when CRYPTO is disabled, or in a loadable module:
WARNING: unmet direct dependencies detected for
CRYPTO_GCM
WARNING: unmet direct dependencies detected forCRYPTO_AEAD2Depends on [m]: CRYPTO [=m]
Selected by [y]:
-SEV_GUEST[=y] &&VIRT_DRIVERS[=y] &&AMD_MEM_ENCRYPT[=y]Quoted 3 lines
x86_64-linux-ld:
crypto/aead.o: in function `crypto_register_aeads':Fixes d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")This has been present from when the driver was first added, so I think the correct Fixes: tag should be:
Fixes fce96cf04430 ("virt: Add SEV-SNP guest driver")Correct?
Thanks,
TomQuoted 17 lines
Signed-off-by Arnd Bergmann <[email protected]>---
drivers/virt/coco/sev-guest/Kconfig| 1 +1 file changed, 1 insertion(+)drivers/virt/coco/sev-guest/Kconfig +0
-0@@ -2,6 +2,7 @@ config SEV_GUESTtristate "AMD SEV Guest driver"
default m
depends onAMD_MEM_ENCRYPT
+ select CRYPTO
selectCRYPTO_AEAD2
selectCRYPTO_GCM
help
[tip: x86/cc] virt: sevguest: Add CONFIG_CRYPTO dependency
In reply to Arnd BergmannThe following commit has been merged into the x86/cc branch of tip:
The following commit has been merged into the x86/cc branch of tip:
Commit-ID: 84b9b44b99780d35fe72ac63c4724f158771e898 Gitweb: https://git.kernel.org/tip/84b9b44b99780d35fe72ac63c4724f158771e898 Author: Arnd Bergmann <[email protected]> AuthorDate: Tue, 17 Jan 2023 18:13:56 +01:00 Committer: Borislav Petkov (AMD) <[email protected]> CommitterDate: Fri, 09 Jun 2023 15:53:07 +02:00
virt: sevguest: Add CONFIG_CRYPTO dependency
This driver fails to link when CRYPTO is disabled, or in a loadable module:
WARNING: unmet direct dependencies detected for CRYPTO_GCM
WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
Depends on [m]: CRYPTO [=m]
Selected by [y]:
- SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
--- drivers/virt/coco/sev-guest/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/virt/coco/sev-guest/Kconfig +1 -0
@@ -2,6 +2,7 @@ config SEV_GUEST tristate "AMD SEV Guest driver" default m depends on AMD_MEM_ENCRYPT + select CRYPTO select CRYPTO_AEAD2 select CRYPTO_GCM help