ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding
Subsystems (2)
PATCH 1/3 ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding
KCS nodes compatible property in the 'aspeed-g5.dtsi' file was changed to use v2 binding in the commit fa4c8ec6feaa ("ARM: dts: aspeed: Change KCS nodes to v2 binding"). For the proper initialization of /dev/ipmi-kcs* devices KCS node variables also need to be changed to use v2 binding.
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +3 -3
@@ -139,17 +139,17 @@ &kcs1 { status = "okay"; - kcs_addr = <0x60>; + aspeed,lpc-io-reg = <0x60>; }; &kcs2 { status = "okay"; - kcs_addr = <0x62>; + aspeed,lpc-io-reg = <0x62>; }; &kcs4 { status = "okay"; - kcs_addr = <0x97DE>; + aspeed,lpc-io-reg = <0x97DE>; }; &lpc_snoop {
Signature · 1 line
2.17.1
PATCH 2/3 ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3
The KCS interface on the LPC channel 3 in the controller is used for the in-band BMC<->BIOS IPMI communication. 0xCA2 is a default host CPU LPC IO address for this interface.
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +5 -0
@@ -147,6 +147,11 @@ aspeed,lpc-io-reg = <0x62>; }; +&kcs3 { + status = "okay"; + aspeed,lpc-io-reg = <0xCA2>; +}; + &kcs4 { status = "okay"; aspeed,lpc-io-reg = <0x97DE>;
Signature · 1 line
2.17.1
Re: [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3
Quoted 7 lines · Konstantin Aladyshev
The KCS interface on the LPC channel 3 in the controller is used for the in-band BMC<->BIOS IPMI communication.
0xCA2is a default host CPU LPC IO address for this interface.Signed-off-by Konstantin Aladyshev <[email protected]>
I don't have any docs on the platform so I'll wait for a review from Supreeth before applying this one.
It's a correct use of the bindings:
Quoted 23 lines
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++ 1 file changed, 5 insertions(+)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +5
-1@@ -147,6 +147,11 @@ aspeed,lpc-io-reg = <0x62>; }; +&kcs3 { + status = "okay"; + aspeed,lpc-io-reg = <0xCA2>; +}; + &kcs4 { status = "okay"; aspeed,lpc-io-reg = <0x97DE>; --2.17.1
Supreeth Venkatesh
Reviewed-byRe: [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3
Thanks Konstantin for this patch.
Thanks Joel for reviewing this.
Quoted 10 lines · Joel Stanley
[CAUTION: External Email]
Quoted 6 lines · Konstantin Aladyshev
The KCS interface on the LPC channel 3 in the controller is used for the in-band BMC<->BIOS IPMI communication.
0xCA2is a default host CPU LPC IO address for this interface.
Quoted 4 lines
Quoted 1 line
Signed-off-by Konstantin Aladyshev <[email protected]>I don't have any docs on the platform so I'll wait for a review from Supreeth before applying this one.
Done.
Quoted 4 lines
It's a correct use of the bindings:
Reviewed-by Joel Stanley <[email protected]>
Quoted 24 lines
Quoted 24 lines
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++ 1 file changed, 5 insertions(+)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +5
-1@@ -147,6 +147,11 @@ aspeed,lpc-io-reg = <0x62>; }; +&kcs3 { + status = "okay"; + aspeed,lpc-io-reg = <0xCA2>; +}; + &kcs4 { status = "okay"; aspeed,lpc-io-reg = <0x97DE>; --2.17.1
PATCH 3/3 ARM: dts: aspeed: amd-ethanolx: Enable devices for the iKVM functionality
In reply to Konstantin AladyshevEnable the USB 2.0 Virtual Hub Controller and
the Video Engine with it's reserved memory region for the implementation of the iKVM functionality in the BMC.
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)
arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +22 -0
@@ -13,6 +13,21 @@ memory at 80000000 { reg = <0x80000000 0x20000000>; }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + video_engine_memory: jpegbuffer { + size = <0x02000000>; /* 32M */ + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + }; + }; + + aliases { serial0 = &uart1; serial4 = &uart5;
@@ -220,5 +235,12 @@ }; }; +&video { + status = "okay"; + memory-region = <&video_engine_memory>; +}; +&vhub { + status = "okay"; +};
Signature · 1 line
2.17.1
Re: [PATCH 3/3] ARM: dts: aspeed: amd-ethanolx: Enable devices for the iKVM functionality
Quoted 7 lines · Konstantin Aladyshev
[CAUTION: External Email]
Enable the USB 2.0 Virtual Hub Controller and
the Video Engine with it's reserved memory region for the implementation of the iKVM functionality in the BMC.Signed-off-by Konstantin Aladyshev <[email protected]>
Quoted 46 lines
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +22
-1@@ -13,6 +13,21 @@ memory at 80000000 { reg = <0x80000000 0x20000000>; }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + video_engine_memory: jpegbuffer { + size = <0x02000000>; /* 32M */ + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + }; + }; + + aliases { serial0 = &uart1; serial4 = &uart5;@@ -220,5 +235,12 @@ }; }; +&video { + status = "okay"; + memory-region = <&video_engine_memory>; +}; +&vhub { + status = "okay"; +}; --2.17.1
Re: [PATCH 3/3] ARM: dts: aspeed: amd-ethanolx: Enable devices for the iKVM functionality
In reply to Konstantin AladyshevQuoted 6 lines · Konstantin Aladyshev
Enable the USB 2.0 Virtual Hub Controller and
the Video Engine with it's reserved memory region for the implementation of the iKVM functionality in the BMC.Signed-off-by Konstantin Aladyshev <[email protected]>
Quoted 46 lines
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +22
-1@@ -13,6 +13,21 @@ memory at 80000000 { reg = <0x80000000 0x20000000>; }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + video_engine_memory: jpegbuffer { + size = <0x02000000>; /* 32M */ + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + }; + }; + + aliases { serial0 = &uart1; serial4 = &uart5;@@ -220,5 +235,12 @@ }; }; +&video { + status = "okay"; + memory-region = <&video_engine_memory>; +}; +&vhub { + status = "okay"; +}; --2.17.1
These changes are already merged in https://github.com/openbmc/linux/blob/dev-5.8/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts by Joel. Please abandon these changes.
Thanks,
Supreeth
Quoted 41 lines · Konstantin Aladyshev
[CAUTION: External Email]
KCS nodes compatible property in the '
aspeed-g5.dtsi' file was changed to use v2 binding in the commitfa4c8ec6feaa("ARM: dts: aspeed: Change KCS nodes to v2 binding"). For the proper initialization of/dev/ipmi-kcs*devices KCS node variables also need to be changed to use v2 binding.Signed-off-by Konstantin Aladyshev <[email protected]>--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +3
-4@@ -139,17 +139,17 @@ &kcs1 { status = "okay"; - kcs_addr = <0x60>; + aspeed,lpc-io-reg = <0x60>; }; &kcs2 { status = "okay"; - kcs_addr = <0x62>; + aspeed,lpc-io-reg = <0x62>; }; &kcs4 { status = "okay"; - kcs_addr = <0x97DE>; + aspeed,lpc-io-reg = <0x97DE>; }; &lpc_snoop { --2.17.1
These changes got picked up from my backport patch to the 'dev-5.8' branch of the OpenBMC Linux repository.
This patch also needed to be added to the main ASPEED Linux kernel, so it could get into subsequent branches of the OpenBMC Linux repository.
Best regards,
Konstantin Aladyshev
Quoted 49 lines · Supreeth Venkatesh
These changes are already merged in https://github.com/openbmc/linux/blob/dev-5.8/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts by Joel. Please abandon these changes.
Thanks,
SupreethQuoted 41 lines · Konstantin Aladyshev
[CAUTION: External Email]
KCS nodes compatible property in the '
aspeed-g5.dtsi' file was changed to use v2 binding in the commitfa4c8ec6feaa("ARM: dts: aspeed: Change KCS nodes to v2 binding"). For the proper initialization of/dev/ipmi-kcs*devices KCS node variables also need to be changed to use v2 binding.Signed-off-by Konstantin Aladyshev <[email protected]>--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +3
-4@@ -139,17 +139,17 @@ &kcs1 { status = "okay"; - kcs_addr = <0x60>; + aspeed,lpc-io-reg = <0x60>; }; &kcs2 { status = "okay"; - kcs_addr = <0x62>; + aspeed,lpc-io-reg = <0x62>; }; &kcs4 { status = "okay"; - kcs_addr = <0x97DE>; + aspeed,lpc-io-reg = <0x97DE>; }; &lpc_snoop { --2.17.1
Joel Stanley
maintainerQuoted 3 lines · Supreeth Venkatesh
These changes are already merged in https://github.com/openbmc/linux/blob/dev-5.8/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts by Joel. Please abandon these changes.
That is the openbmc kernel tree, where we stage patches on their way to mainline. This submission is for mainline, where this patch has not been merged.
Cheers,
Joel
Quoted 46 lines
Thanks,
SupreethQuoted 41 lines · Konstantin Aladyshev
[CAUTION: External Email]
KCS nodes compatible property in the '
aspeed-g5.dtsi' file was changed to use v2 binding in the commitfa4c8ec6feaa("ARM: dts: aspeed: Change KCS nodes to v2 binding"). For the proper initialization of/dev/ipmi-kcs*devices KCS node variables also need to be changed to use v2 binding.Signed-off-by Konstantin Aladyshev <[email protected]>--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +3
-4@@ -139,17 +139,17 @@ &kcs1 { status = "okay"; - kcs_addr = <0x60>; + aspeed,lpc-io-reg = <0x60>; }; &kcs2 { status = "okay"; - kcs_addr = <0x62>; + aspeed,lpc-io-reg = <0x62>; }; &kcs4 { status = "okay"; - kcs_addr = <0x97DE>; + aspeed,lpc-io-reg = <0x97DE>; }; &lpc_snoop { --2.17.1
Quoted 8 lines · Konstantin Aladyshev
KCS nodes compatible property in the '
aspeed-g5.dtsi' file was changed to use v2 binding in the commitfa4c8ec6feaa("ARM: dts: aspeed: Change KCS nodes to v2 binding"). For the proper initialization of/dev/ipmi-kcs*devices KCS node variables also need to be changed to use v2 binding.Signed-off-by Konstantin Aladyshev <[email protected]>
Quoted 32 lines
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +3
-4@@ -139,17 +139,17 @@ &kcs1 { status = "okay"; - kcs_addr = <0x60>; + aspeed,lpc-io-reg = <0x60>; }; &kcs2 { status = "okay"; - kcs_addr = <0x62>; + aspeed,lpc-io-reg = <0x62>; }; &kcs4 { status = "okay"; - kcs_addr = <0x97DE>; + aspeed,lpc-io-reg = <0x97DE>; }; &lpc_snoop { --2.17.1
Joel Stanley
maintainerQuoted 10 lines · Joel Stanley
Quoted 7 lines · Konstantin Aladyshev
KCS nodes compatible property in the '
aspeed-g5.dtsi' file was changed to use v2 binding in the commitfa4c8ec6feaa("ARM: dts: aspeed: Change KCS nodes to v2 binding"). For the proper initialization of/dev/ipmi-kcs*devices KCS node variables also need to be changed to use v2 binding.
Quoted 3 lines
Quoted 1 line
Signed-off-by Konstantin Aladyshev <[email protected]>Fixes 09f5f680707e ("ipmi: kcs: aspeed: Implement v2 bindings")
Actually, this is probably better:
I slightly reworked your commit message when applying.
Quoted 34 lines
Reviewed-by Joel Stanley <[email protected]>Quoted 32 lines
--- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +3
-4@@ -139,17 +139,17 @@ &kcs1 { status = "okay"; - kcs_addr = <0x60>; + aspeed,lpc-io-reg = <0x60>; }; &kcs2 { status = "okay"; - kcs_addr = <0x62>; + aspeed,lpc-io-reg = <0x62>; }; &kcs4 { status = "okay"; - kcs_addr = <0x97DE>; + aspeed,lpc-io-reg = <0x97DE>; }; &lpc_snoop { --2.17.1