Skip to contentSkip to conversation

drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon

PATCH In review [email protected] 2 participants 3 messages Jun 14, 2023 1 message not in the archive Thermal

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon

./drivers/thermal/mediatek/lvts_thermal.c:522:2-3: Unneeded semicolon

---
 drivers/thermal/mediatek/lvts_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/mediatek/lvts_thermal.c +0 -0
index d0a3f95b7884..1a5ae51b2c51 100644
@@ -519,7 +519,7 @@ static int lvts_sensor_init(struct device *dev, struct lvts_ctrl *lvts_ctrl,
          */
         lvts_sensor[i].msr = lvts_ctrl_data->mode == 

LVTS_MSR_IMMEDIATE_MODE ?

             imm_regs[i] : msr_regs[i];

- };
+ }

     lvts_ctrl->num_lvts_sensor = lvts_ctrl_data->num_lvts_sensor;
#2 lore raw
Quoted 1 line · On 14/06/2023 10:48, [email protected] wrote:

./drivers/thermal/mediatek/lvts_thermal.c:522:2-3: Unneeded semicolon

Please elaborate a bit the changelog when submitting patches.

I did not see this warning/error when compiling. So in which circumstances this message appears?

Quoted 19 lines
---
  drivers/thermal/mediatek/lvts_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/mediatek/lvts_thermal.c +0 -0
index d0a3f95b7884..1a5ae51b2c51 100644
@@ -519,7 +519,7 @@ static int lvts_sensor_init(struct device *dev, 
 struct lvts_ctrl *lvts_ctrl,
           */
          lvts_sensor[i].msr = lvts_ctrl_data->mode == 

LVTS_MSR_IMMEDIATE_MODE ?
             imm_regs[i] : msr_regs[i];
-    };
+    }

     lvts_ctrl->num_lvts_sensor = lvts_ctrl_data->num_lvts_sensor;

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#3 lore raw

PATCH 1/1 drivers/thermal/mediatek/lvts_thermal: Remove unneeded semicolon

In reply to a message not in the archive

fix the following coccicheck warning:

./drivers/thermal/mediatek/lvts_thermal.c:522:2-3: Unneeded semicolon

---
 drivers/thermal/mediatek/lvts_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/mediatek/lvts_thermal.c +0 -0
index d0a3f95b7884..1a5ae51b2c51 100644
@@ -519,7 +519,7 @@ static int lvts_sensor_init(struct device *dev, struct lvts_ctrl *lvts_ctrl,
          */
         lvts_sensor[i].msr = lvts_ctrl_data->mode == 

LVTS_MSR_IMMEDIATE_MODE ?

             imm_regs[i] : msr_regs[i];

- };
+ }

     lvts_ctrl->num_lvts_sensor = lvts_ctrl_data->num_lvts_sensor;