Skip to contentSkip to conversation

gpu: drm/tilcdc: Fix switch case fallthrough

PATCH In review Keerthy 2 participants 2 messages Jul 17, 2019 – Jul 30, 2019

Subsystems (3)
lore
Share & tools
lore

Keerthy

author
#0 lore raw

PATCH 1/1 gpu: drm/tilcdc: Fix switch case fallthrough

Fix the below build warning/Error

drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall through [-Werror=implicit-fallthrough=]

    reg |= LCDC_V2_TFT_24BPP_UNPACK;
    ~~~~^~~~~~~~~~~~~~~~~~~~~~

drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
case DRM_FORMAT_BGR888:
^~~~
cc1: all warnings being treated as errors
make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1 make[4]: *** [drivers/gpu/drm/tilcdc] Error 2 make[4]: *** Waiting for unfinished jobs....

Fixes f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/tilcdc/tilcdc_crtc.c +2 -1
index 650d162e374b..c95b0652c6ab 100644
@@ -382,7 +382,8 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
 		case DRM_FORMAT_XBGR8888:
 		case DRM_FORMAT_XRGB8888:
 			reg |= LCDC_V2_TFT_24BPP_UNPACK;
-			/* fallthrough */
+			reg |= LCDC_V2_TFT_24BPP_MODE;
+			break;
 		case DRM_FORMAT_BGR888:
 		case DRM_FORMAT_RGB888:
 			reg |= LCDC_V2_TFT_24BPP_MODE;
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Keerthy

Fix the below build warning/Error

drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall through [-Werror=implicit-fallthrough=]

     reg |= LCDC_V2_TFT_24BPP_UNPACK;
     ~~~~^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
    case DRM_FORMAT_BGR888:
    ^~~~

cc1: all warnings being treated as errors
make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1 make[4]: *** [drivers/gpu/drm/tilcdc] Error 2 make[4]: *** Waiting for unfinished jobs....

Quoted 5 lines
Fixes f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
---
  drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki