Skip to contentSkip to conversation

doc: Fix build of documentation after i915 file rename

PATCH In review José Roberto de Souza 3 participants 4 messages Dec 14, 2020 – Dec 15, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: Fix build of documentation after i915 file rename

Commit 70a2b431c364 ("drm/i915/gt: Rename lrc.c to execlists_submission.c") renamed intel_lrc.c to intel_execlists_submission.c but forgot to update i915.rst.

Fixes 70a2b431c364 ("drm/i915/gt: Rename lrc.c to execlists_submission.c")
Cc Chris Wilson <[email protected]>
---
 Documentation/gpu/i915.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/gpu/i915.rst +1 -1
index 20868f3d0123..486c720f3890 100644
@@ -428,7 +428,7 @@ User Batchbuffer Execution
 Logical Rings, Logical Ring Contexts and Execlists
 --------------------------------------------------
 
-.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c
+.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_execlists_submission.c
    :doc: Logical Rings, Logical Ring Contexts and Execlists
 
 Global GTT views
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for doc: Fix build of documentation after i915 file rename

== Series Details ==

== Series Details ==

Series: doc: Fix build of documentation after i915 file rename
URL : https://patchwork.freedesktop.org/series/84914/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19140
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_19140 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19140, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_19140:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@memory_region:
- fi-cfl-8109u: [PASS][1] -> [DMESG-WARN][2] +12 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-cfl-8109u/igt@i915_selftest@live@memory_region.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-cfl-8109u/igt@i915_selftest@live@memory_region.html

Known issues
------------

Here are the changes found in Patchwork_19140 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@core_hotunplug@unbind-rebind:
- fi-kbl-7500u: [PASS][3] -> [DMESG-WARN][4] ([i915#2605])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-kbl-7500u/igt@[email protected]

* igt@i915_selftest@live@coherency:
- fi-gdg-551: [PASS][5] -> [DMESG-FAIL][6] ([i915#1748])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-gdg-551/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-gdg-551/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [PASS][7] -> [DMESG-WARN][8] ([i915#1037])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-cfl-8109u/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-cfl-8109u/igt@i915_selftest@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html

[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1748]: https://gitlab.freedesktop.org/drm/intel/issues/1748
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (44 -> 39)
------------------------------

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9481 -> Patchwork_19140

CI-20190529: 20190529
CI_DRM_9481: 968d6b8835487575d68732a7c0a1588795900de4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5893: ec4073d30b428aaf199c0f4de6c0a5ebdc1c1c65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19140: 5d11f6b95eb18bc1c213b4b6e675aad0e08327a6 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5d11f6b95eb1 doc: Fix build of documentation after i915 file rename

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for doc: Fix build of documentation after i915 file rename

On Mon, 2020-12-14 at 19:42 +0000, Patchwork wrote:
Patch Details

Series: doc: Fix build of documentation after i915 file rename
URL:    https://patchwork.freedesktop.org/series/84914/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/index.html

CI Bug Log - changes from CI_DRM_9481 -> Patchwork_19140 Summary

FAILURE

Serious unknown changes coming with Patchwork_19140 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19140, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/index.html

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_19140:

IGT changes
Possible regressions

* igt@i915_selftest@live@memory_region:
* fi-cfl-8109u: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-cfl-8109u/igt@i915_selftest@live@memory_region.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-cfl-8109u/igt@i915_selftest@live@memory_region.html> +12 similar issues

This is a documentation fix, it will not affect any test. Pushed to drm-intel-gt-next, thanks for the review Chris.

Known issues

Here are the changes found in Patchwork_19140 that come from known issues:

IGT changes
Issues hit

* igt@core_hotunplug@unbind-rebind:

* fi-kbl-7500u: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-kbl-7500u/igt@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-kbl-7500u/igt@[email protected]> (i915#2605<https://gitlab.freedesktop.org/drm/intel/issues/2605>)
* igt@i915_selftest@live@coherency:

* fi-gdg-551: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-gdg-551/igt@i915_selftest@[email protected]> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-gdg-551/igt@i915_selftest@[email protected]> (i915#1748<https://gitlab.freedesktop.org/drm/intel/issues/1748>)
* igt@i915_selftest@live@execlists:

* fi-cfl-8109u: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-cfl-8109u/igt@i915_selftest@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-cfl-8109u/igt@i915_selftest@[email protected]> (i915#1037<https://gitlab.freedesktop.org/drm/intel/issues/1037>)
* igt@prime_vgem@basic-userptr:

* fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-tgl-y/igt@[email protected]> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-tgl-y/igt@[email protected]> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) +1 similar issue

Possible fixes

* igt@prime_self_import@basic-with_one_bo_two_files:
* fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9481/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19140/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html>

Participating hosts (44 -> 39)

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes

* Linux: CI_DRM_9481 -> Patchwork_19140

CI-20190529: 20190529
CI_DRM_9481: 968d6b8835487575d68732a7c0a1588795900de4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5893: ec4073d30b428aaf199c0f4de6c0a5ebdc1c1c65 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19140: 5d11f6b95eb18bc1c213b4b6e675aad0e08327a6 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5d11f6b95eb1 doc: Fix build of documentation after i915 file rename

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#3 lore raw
In reply to José Roberto de Souza

Quoting José Roberto de Souza (2020-12-14 18:54:40)

Quoted 16 lines

Commit 70a2b431c364 ("drm/i915/gt: Rename lrc.c to execlists_submission.c") renamed intel_lrc.c to intel_execlists_submission.c but forgot to update i915.rst.

Fixes 70a2b431c364 ("drm/i915/gt: Rename lrc.c to execlists_submission.c")
Cc Chris Wilson <[email protected]>
---
 Documentation/gpu/i915.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/gpu/i915.rst +0 -0
index 20868f3d0123..486c720f3890 100644

Documentation/gpu/i915.rst User Batchbuffer Execution · line 432

Quoted 6 lines
Documentation/gpu/i915.rst +1 -1
@@ -428,7 +428,7 @@ User Batchbuffer Execution
 Logical Rings, Logical Ring Contexts and Execlists
 --------------------------------------------------
 
-.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c
+.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_execlists_submission.c
    :doc: Logical Rings, Logical Ring Contexts and Execlists

It's no longer apropos to intel_execlists_submission.c, but nevertheless

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx