Skip to contentSkip to conversation

clk: hi3620: Fix memory leak in hi3620_mmc_clk_init()

PATCH Applied Kuan-Wei Chiu 2 participants 2 messages Dec 10, 2023 – Dec 17, 2023 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: hi3620: Fix memory leak in hi3620_mmc_clk_init()

In cases where kcalloc() fails for the 'clk_data->clks' allocation, the code path does not handle the failure gracefully, potentially leading to a memory leak. This fix ensures proper cleanup by freeing the allocated memory for 'clk_data' before returning.

---
 drivers/clk/hisilicon/clk-hi3620.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/hisilicon/clk-hi3620.c +3 -1
index 2d7186905abd..5d0226530fdb 100644
@@ -466,8 +466,10 @@ static void __init hi3620_mmc_clk_init(struct device_node *node)
 		return;
 
 	clk_data->clks = kcalloc(num, sizeof(*clk_data->clks), GFP_KERNEL);
-	if (!clk_data->clks)
+	if (!clk_data->clks) {
+		kfree(clk_data);
 		return;
+	}
 
 	for (i = 0; i < num; i++) {
 		struct hisi_mmc_clock *mmc_clk = &hi3620_mmc_clks[i];
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw

Quoting Kuan-Wei Chiu (2023-12-10 08:50:40)

Quoted 7 lines

In cases where kcalloc() fails for the 'clk_data->clks' allocation, the code path does not handle the failure gracefully, potentially leading to a memory leak. This fix ensures proper cleanup by freeing the allocated memory for 'clk_data' before returning.

---

Applied to clk-next