Skip to contentSkip to conversation

netfilter: nft_meta: fix iifgroup matching

PATCH Applied Florian Westphal 3 participants 3 messages Aug 2, 2020

Subsystems (2)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nft_meta: fix iifgroup matching

iifgroup matching errounously checks the output interface.

Fixes 8724e819cc9a ("netfilter: nft_meta: move all interface related keys to helper")
---
 net/netfilter/nft_meta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nft_meta.c +1 -1
index 951b6e87ed5d..7bc6537f3ccb 100644
@@ -253,7 +253,7 @@ static bool nft_meta_get_eval_ifname(enum nft_meta_keys key, u32 *dest,
 			return false;
 		break;
 	case NFT_META_IIFGROUP:
-		if (!nft_meta_store_ifgroup(dest, nft_out(pkt)))
+		if (!nft_meta_store_ifgroup(dest, nft_in(pkt)))
 			return false;
 		break;
 	case NFT_META_OIFGROUP:
Signature · 1 line
2.26.2
maintainer Applied
#1 lore raw
Quoted 1 line · Florian Westphal

iifgroup matching errounously checks the output interface.

Applied, thanks.

#2 lore raw
Quoted 4 lines · Pablo Neira Ayuso
Quoted 1 line · Florian Westphal

iifgroup matching errounously checks the output interface.

Applied, thanks.

Would you mind also marking this for backport to 5.7?

Thank you,

Demi