drm/syncobj: Extend EXPORT_SYNC_FILE for timeline syncobjs
Subsystems (3)
PATCH v4 1/1 drm/syncobj: Extend EXPORT_SYNC_FILE for timeline syncobjs
From: Rob Clark <[email protected]>
Add support for exporting a dma_fence fd for a specific point on a timeline. This is needed for vtest/vpipe[1][2] to implement timeline syncobj support, as it needs a way to turn a point on a timeline back into a dma_fence fd. It also closes an odd omission from the syncobj UAPI.
[1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33433
[2] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/805
v2: Add DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINE
v3: Add unstaged uabi header hunk
v4: Also handle IMPORT_SYNC_FILE case
--- drivers/gpu/drm/drm_syncobj.c | 41 ++++++++++++++++++++++++++--------- include/uapi/drm/drm.h | 4 ++++ 2 files changed, 35 insertions(+), 10 deletions(-)
drivers/gpu/drm/drm_syncobj.c +31 -10
@@ -741,7 +741,7 @@ static int drm_syncobj_fd_to_handle(struct drm_file *file_private, }static int drm_syncobj_import_sync_file_fence (struct drm_file *file_private, -int fd,int handle) +int fd,int handle,u64 point) {struct dma_fence *fence =sync_file_get_fence (fd);struct drm_syncobj *syncobj;
@@ -755,14 +755,18 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private,return -ENOENT ; } -drm_syncobj_replace_fence (syncobj, fence); +if (point) { +drm_syncobj_add_point (syncobj,dma_fence_chain_alloc (), fence, point); + }else { +drm_syncobj_replace_fence (syncobj, fence); + }dma_fence_put (fence);drm_syncobj_put (syncobj);return 0 ; }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;
@@ -772,7 +776,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;
@@ -869,6 +873,9 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data, struct drm_file *file_private) {struct drm_syncobj_handle *args = data; +unsigned valid_flags =DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINE | +DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE ; +u64 point =0 ;if (!drm_core_check_feature (dev,DRIVER_SYNCOBJ ))return -EOPNOTSUPP ;
@@ -876,13 +883,18 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; -if (args->flags !=0 && - args->flags !=DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE ) +if (args->flags !=0 && (args->flags & ~valid_flags))return -EINVAL ; +if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINE ) + point = args->point; +if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE )return drm_syncobj_export_sync_file (file_private, args->handle, - &args->fd); + point, &args->fd); + +if (args->point) +return -EINVAL ;return drm_syncobj_handle_to_fd (file_private, args->handle, &args->fd);
@@ -893,6 +905,9 @@ drm_syncobj_fd_to_handle_ioctl(struct drm_device *dev, void *data, struct drm_file *file_private) {struct drm_syncobj_handle *args = data; +unsigned valid_flags =DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_TIMELINE | +DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_IMPORT_SYNC_FILE ; +u64 point =0 ;if (!drm_core_check_feature (dev,DRIVER_SYNCOBJ ))return -EOPNOTSUPP ;
@@ -900,14 +915,20 @@ drm_syncobj_fd_to_handle_ioctl(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; -if (args->flags !=0 && - args->flags !=DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_IMPORT_SYNC_FILE ) +if (args->flags !=0 && (args->flags & ~valid_flags))return -EINVAL ; +if (args->flags &DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_TIMELINE ) + point = args->point; +if (args->flags &DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_IMPORT_SYNC_FILE )return drm_syncobj_import_sync_file_fence (file_private, args->fd, - args->handle); + args->handle, + point); + +if (args->point) +return -EINVAL ;return drm_syncobj_fd_to_handle (file_private, args->fd, &args->handle);
include/uapi/drm/drm.h +4 -0
@@ -905,13 +905,17 @@ struct drm_syncobj_destroy { };#define DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_IMPORT_SYNC_FILE (1 << 0) +#define DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_TIMELINE (1 << 1)#define DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE (1 << 0) +#define DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINE (1 << 1)struct drm_syncobj_handle {__u32 handle;__u32 flags;__s32 fd;__u32 pad; + +__u64 point; };struct drm_syncobj_transfer {
Signature · 1 line
2.49.0
On 3/28/25 00:36, Rob Clark wrote:
...
drivers/gpu/drm/drm_syncobj.c static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, · line 759
Quoted 13 lines
static int drm_syncobj_import_sync_file_fence(struct
drm_file*file_private,drivers/gpu/drm/drm_syncobj.c +3
-2- int fd, int handle) + int fd, int handle, u64 point) { struct dma_fence *fence = sync_file_get_fence(fd);struct drm_syncobj *syncobj;@@ -755,14 +755,18 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private,return -ENOENT ; } -drm_syncobj_replace_fence (syncobj, fence); +if (point) { +drm_syncobj_add_point (syncobj,dma_fence_chain_alloc (), fence, point);
Nit: check dma_fence_chain_alloc() for ENOMEM
drivers/gpu/drm/drm_syncobj.c static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, · line 762
Quoted 3 lines
drivers/gpu/drm/drm_syncobj.c +3
-0+ }else { +drm_syncobj_replace_fence (syncobj, fence); + }
Nit: checkpath should complain about the unnecessary braces
Quoted 31 lines
drivers/gpu/drm/drm_syncobj.c +5
-2dma_fence_put (fence);drm_syncobj_put (syncobj);return 0 ; }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;@@ -772,7 +776,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;@@ -869,6 +873,9 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data, struct drm_file *file_private) {struct drm_syncobj_handle *args = data; +unsigned valid_flags =DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINE | +DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE ; +u64 point =0 ;if (!drm_core_check_feature (dev,DRIVER_SYNCOBJ ))return -EOPNOTSUPP ;
drivers/gpu/drm/drm_syncobj.c drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data, · line 887
Quoted 7 lines
drivers/gpu/drm/drm_syncobj.c +1
-2@@ -876,13 +883,18 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; -if (args->flags !=0 && - args->flags !=DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE ) +if (args->flags !=0 && (args->flags & ~valid_flags))return -EINVAL ;
Nit: args->flags!=0 not needed as (0 & ~valid_flags) is always false, same for import
...
Signature · 2 lines
Best regards, Dmitry