hidp: Let hidp_send_message return number of queued bytes
Subsystems (2)
PATCH 1/1 hidp: Let hidp_send_message return number of queued bytes
Let hidp_send_message return the number of successfully queued bytes instead of an unconditional 0.
With the return value fixed to 0, other drivers relying on hidp, such as hidraw, can not return meaningful values from their respective implementations of write(). In particular, with the current behavior, a hidraw device's write() will have different return values depending on whether the device is connected via USB or Bluetooth, which makes it harder to abstract away the transport layer.
--- net/bluetooth/hidp/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
net/bluetooth/hidp/core.c +7 -2
@@ -101,6 +101,7 @@ static int hidp_send_message(struct hidp_session *session, struct socket *sock, {struct sk_buff *skb;struct sock *sk = sock->sk; +int ret;BT_DBG ("session %p data %p size %d" , session, data, size);
@@ -114,13 +115,17 @@ static int hidp_send_message(struct hidp_session *session, struct socket *sock, }skb_put_u8 (skb, hdr); -if (data && size >0 ) +if (data && size >0 ) {skb_put_data (skb, data, size); + ret = size; + }else { + ret =0 ; + }skb_queue_tail (transmit, skb);wake_up_interruptible (sk_sleep (sk)); -return 0 ; +return ret; } static int hidp_send_ctrl_message(struct hidp_session *session,
Signature · 1 line
2.20.1
Marcel Holtmann
maintainerHi Fabian,
Quoted 10 lines
Let
hidp_send_messagereturn the number of successfully queued bytes instead of an unconditional 0.With the return value fixed to 0, other drivers relying on hidp, such as hidraw, can not return meaningful values from their respective implementations of
write(). In particular, with the current behavior, a hidraw device'swrite()will have different return values depending on whether the device is connected via USB or Bluetooth, which makes it harder to abstract away the transport layer.
Quoted 4 lines
Signed-off-by Fabian Henneke <[email protected]>---
net/bluetooth/hidp/core.c| 9 +++++++--1 file changed, 7 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel