Skip to contentSkip to conversation

net/ice: revert removing IPID from default hash field

PATCH In review Wenjun Wu 3 participants 4 messages Sep 7, 2021 – Sep 8, 2021 Network drivers

lore
Share & tools
lore

Wenjun Wu

author
#0 lore raw

PATCH 1/1 net/ice: revert removing IPID from default hash field

We try to refine default RSS for IP fragment packets. However, the change will lead to more serious errors. The scenario that there is overlap/conflict between the new characteristics and the existing ones has not been supported, so non-fragment packets and fragment packets cannot share the same hash fields, or all related profiles will be removed.

Therefore, IPID field is necessary for fragment packets.

Fixes cf37e1e5e9d2 ("net/ice: fix default RSS hash for IP fragment packets")
---
 drivers/net/ice/ice_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
index 8d62b84805..0683296584 100644
@@ -2981,7 +2981,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	if (rss_hf & ETH_RSS_FRAG_IPV4) {
 		cfg.addl_hdrs = ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_FRAG;
-		cfg.hash_flds = ICE_FLOW_HASH_IPV4;
+		cfg.hash_flds = ICE_FLOW_HASH_IPV4 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_ID);
 		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);
 		if (ret)
 			PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d",
@@ -2990,7 +2990,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
 
 	if (rss_hf & ETH_RSS_FRAG_IPV6) {
 		cfg.addl_hdrs = ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_FRAG;
-		cfg.hash_flds = ICE_FLOW_HASH_IPV6;
+		cfg.hash_flds = ICE_FLOW_HASH_IPV6 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_ID);
 		ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);
 		if (ret)
 			PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d",
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Wenjun Wu

We try to refine default RSS for IP fragment packets. However, the change will lead to more serious errors. The scenario that there is overlap/conflict between the new characteristics and the existing ones has not been supported, so non-fragment packets and fragment packets cannot share the same hash fields, or all related profiles will be removed.

Quoted 5 lines

Therefore, IPID field is necessary for fragment packets.

Fixes cf37e1e5e9d2 ("net/ice: fix default RSS hash for IP fragment packets")

- If this is a revert of cf37e1e5e9d2, maybe it is simpler to drop the original change in next-net before it gets pulled in the main repo.
- A similar change has been applied to net/iavf? Is it still relevant?

Signature · 1 line
David Marchand
#2 lore raw

Default RSS for outer src/dst IP address field in iavf is not supported before, so it does not cause any error. However, if it can be dropped, I suggest to do so. It seems to be safer to add IPID field here.

Quoted 33 lines

-----Original Message-----
From: David Marchand <[email protected]>
Sent: Tuesday, September 7, 2021 3:10 PM
To: Wu, Wenjun1 <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: dev <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default hash field

Quoted 8 lines · Wenjun Wu

We try to refine default RSS for IP fragment packets. However, the change will lead to more serious errors. The scenario that there is overlap/conflict between the new characteristics and the existing ones has not been supported, so non-fragment packets and fragment packets cannot share the same hash fields, or all related profiles will be removed.

Quoted 6 lines

Therefore, IPID field is necessary for fragment packets.

Fixes cf37e1e5e9d2 ("net/ice: fix default RSS hash for IP fragment

packets")

- If this is a revert of cf37e1e5e9d2, maybe it is simpler to drop the original change in next-net before it gets pulled in the main repo.
- A similar change has been applied to net/iavf? Is it still relevant?

--
David Marchand

#3 lore raw
Quoted 28 lines

-----Original Message-----
From: Wu, Wenjun1 <[email protected]>
Sent: Tuesday, September 7, 2021 3:28 PM
To: David Marchand <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>
Subject: RE: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default hash field

Default RSS for outer src/dst IP address field in iavf is not supported before, so it does not cause any error.
However, if it can be dropped, I suggest to do so. It seems to be safer to add IPID field here.

Quoted 10 lines

-----Original Message-----
From: David Marchand <[email protected]>
Sent: Tuesday, September 7, 2021 3:10 PM
To: Wu, Wenjun1 <[email protected]>; Yigit, Ferruh <[email protected]>
Cc: dev <[email protected]>; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default hash field

Quoted 14 lines
Quoted 1 line

On Tue, Sep 7, 2021 at 9:05 AM Wenjun Wu <[email protected]>

Quoted 12 lines · wrote:
Quoted 12 lines

We try to refine default RSS for IP fragment packets. However, the change will lead to more serious errors. The scenario that there is overlap/conflict between the new characteristics and the existing ones has not been supported, so non-fragment packets and fragment packets cannot share the same hash fields, or all related profiles will be removed.

Therefore, IPID field is necessary for fragment packets.

Fixes cf37e1e5e9d2 ("net/ice: fix default RSS hash for IP fragment

packets")

The original fix has no issue, there should be a fix for the real problem, this patch can be rejected after sync with author.

Quoted 11 lines
Quoted 10 lines
Quoted 2 lines

- If this is a revert of cf37e1e5e9d2, maybe it is simpler to drop the original change in next-net before it gets pulled in the main repo.
- A similar change has been applied to net/iavf? Is it still relevant?

--
David Marchand