Skip to contentSkip to conversation

samples: mei: remove unused parameter

PATCH In review [email protected] 2 participants 2 messages Jan 19, 2024 – Feb 1, 2024 Intel management engine (mei)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samples: mei: remove unused parameter

From: Alex Shi <[email protected]>

The timeout parameter isn't used in func mei_send_msg(), better to remove it.

To: [email protected]
To: Tomas Winkler <[email protected]>

---
 samples/mei/mei-amt-version.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
samples/mei/mei-amt-version.c +2 -4
index 867debd3b912..bf14d8a819b9 100644
@@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
 	return rc;
 }
 
-static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
-			ssize_t len, unsigned long timeout)
+static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
 {
 	ssize_t written;
 	ssize_t rc;
@@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
 	memset(*read_buf, 0, in_buf_sz);
 	msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
 
-	written = mei_send_msg(&acmd->mei_cl,
-				command, command_sz, acmd->send_timeout);
+	written = mei_send_msg(&acmd->mei_cl, command, command_sz);
 	if (written != command_sz)
 		return AMT_STATUS_INTERNAL_ERROR;
 
Signature · 1 line
2.43.0
#1 lore raw

ping

Quoted 36 lines · On 1/19/24 12:00 PM, [email protected] wrote:

From: Alex Shi <[email protected]>

The timeout parameter isn't used in func mei_send_msg(), better to remove it.

To: [email protected]
To: Tomas Winkler <[email protected]>

---
 samples/mei/mei-amt-version.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
samples/mei/mei-amt-version.c +2 -4
index 867debd3b912..bf14d8a819b9 100644
@@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
 	return rc;
 }
 
-static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
-			ssize_t len, unsigned long timeout)
+static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
 {
 	ssize_t written;
 	ssize_t rc;
@@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
 	memset(*read_buf, 0, in_buf_sz);
 	msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
 
-	written = mei_send_msg(&acmd->mei_cl,
-				command, command_sz, acmd->send_timeout);
+	written = mei_send_msg(&acmd->mei_cl, command, command_sz);
 	if (written != command_sz)
 		return AMT_STATUS_INTERNAL_ERROR;