softmmu/memory: Log invalid memory accesses
PATCH 1/1 softmmu/memory: Log invalid memory accesses
Log invalid memory accesses with as GUEST_ERROR.
This is particularly useful since commit 5d971f9e67 which reverted ("memory: accept mismatching sizes in memory_region_access_valid").
--- softmmu/memory.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
softmmu/memory.c +16 -0
@@ -14,6 +14,7 @@*/ #include "qemu/osdep.h" +#include "qemu/log.h" #include "qapi/error.h" #include "cpu.h" #include "exec/memory.h"
@@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr, {if (mr->ops->valid.accepts && !mr->ops->valid.accepts (mr->opaque, addr, size, is_write, attrs)) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: rejected\n" , + addr, size,memory_region_name (mr));return false; }if (!mr->ops->valid.unaligned && (addr & (size -1 ))) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: unaligned\n" , + addr, size,memory_region_name (mr));return false; }
@@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,if (size > mr->ops->valid.max_access_size || size < mr->ops->valid.min_access_size) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: invalid size " +"(min:%u max:%u)\n" , + addr, size,memory_region_name (mr), + mr->ops->valid.min_access_size, + mr->ops->valid.max_access_size);return false; }return true;
Signature · 1 line
2.26.2
Quoted 6 lines · Philippe Mathieu-Daudé
Log invalid memory accesses with as
GUEST_ERROR.This is particularly useful since commit
5d971f9e67which reverted ("memory: accept mismatching sizes inmemory_region_access_valid").Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Paolo's tree I assume?
Quoted 51 lines
--- softmmu/memory.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)softmmu/memory.c +16
-0@@ -14,6 +14,7 @@*/ #include "qemu/osdep.h" +#include "qemu/log.h" #include "qapi/error.h" #include "cpu.h" #include "exec/memory.h" @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr, {if (mr->ops->valid.accepts && !mr->ops->valid.accepts (mr->opaque, addr, size, is_write, attrs)) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: rejected\n" , + addr, size,memory_region_name (mr));return false; }if (!mr->ops->valid.unaligned && (addr & (size -1 ))) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: unaligned\n" , + addr, size,memory_region_name (mr));return false; }@@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,if (size > mr->ops->valid.max_access_size || size < mr->ops->valid.min_access_size) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: invalid size " +"(min:%u max:%u)\n" , + addr, size,memory_region_name (mr), + mr->ops->valid.min_access_size, + mr->ops->valid.max_access_size);return false; }return true;Signature · 1 line
2.26.2
Quoted 11 lines · Michael S. Tsirkin
Quoted 6 lines · Philippe Mathieu-Daudé
Log invalid memory accesses with as
GUEST_ERROR.This is particularly useful since commit
5d971f9e67which reverted ("memory: accept mismatching sizes inmemory_region_access_valid").Signed-off-by Philippe Mathieu-Daudé <[email protected]>Reviewed-by Michael S. Tsirkin <[email protected]>Paolo's tree I assume?
Or qemu-trivial, whichever is less busy :)
Quoted 53 lines
Quoted 52 lines
--- softmmu/memory.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)softmmu/memory.c +16
-0@@ -14,6 +14,7 @@*/ #include "qemu/osdep.h" +#include "qemu/log.h" #include "qapi/error.h" #include "cpu.h" #include "exec/memory.h" @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr, {if (mr->ops->valid.accepts && !mr->ops->valid.accepts (mr->opaque, addr, size, is_write, attrs)) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: rejected\n" , + addr, size,memory_region_name (mr));return false; }if (!mr->ops->valid.unaligned && (addr & (size -1 ))) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: unaligned\n" , + addr, size,memory_region_name (mr));return false; }@@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,if (size > mr->ops->valid.max_access_size || size < mr->ops->valid.min_access_size) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: invalid size " +"(min:%u max:%u)\n" , + addr, size,memory_region_name (mr), + mr->ops->valid.min_access_size, + mr->ops->valid.max_access_size);return false; }return true;Signature · 1 line
2.26.2
Laurent Vivier
AppliedLe 05/10/2020 à 17:27, Philippe Mathieu-Daudé a écrit :
Quoted 46 lines
Log invalid memory accesses with as
GUEST_ERROR.This is particularly useful since commit
5d971f9e67which reverted ("memory: accept mismatching sizes inmemory_region_access_valid").Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- softmmu/memory.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)softmmu/memory.c +9
-0@@ -14,6 +14,7 @@*/ #include "qemu/osdep.h" +#include "qemu/log.h" #include "qapi/error.h" #include "cpu.h" #include "exec/memory.h" @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr, {if (mr->ops->valid.accepts && !mr->ops->valid.accepts (mr->opaque, addr, size, is_write, attrs)) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: rejected\n" , + addr, size,memory_region_name (mr));return false; }if (!mr->ops->valid.unaligned && (addr & (size -1 ))) { +qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: unaligned\n" , + addr, size,memory_region_name (mr));return false; }@@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,if (size > mr->ops->valid.max_access_size || size < mr->ops->valid.min_access_size) {
softmmu/memory.c bool memory_region_access_valid(MemoryRegion *mr, · line 1388
Quoted 10 lines
softmmu/memory.c +7
-0+qemu_log_mask (LOG_GUEST_ERROR ,"Invalid access at addr " +"0x%" HWADDR_PRIX ", size %u, " +"region '%s', reason: invalid size " +"(min:%u max:%u)\n" , + addr, size,memory_region_name (mr), + mr->ops->valid.min_access_size, + mr->ops->valid.max_access_size);return false; }return true;
Applied to my trivial-patches branch.
Thanks,
Laurent