ARM: imx: Correct ocotp id for serial number support of i.MX6ULL/ULZ SoCs
Subsystems (3)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 ARM: imx: Correct ocotp id for serial number support of i.MX6ULL/ULZ SoCs
After the commit 8267ff89b713 ("ARM: imx: Add serial number support for i.MX6/7 SoCs") the kernel doesn't start on i.MX6ULL/ULZ SoC.
Tested on next-20191205.
For i.MX6ULL/ULZ the variable "ocotp_compat" is set to "fsl,imx6ul-ocotp", but with commit ffbc34bf0e9c ("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") and commit f243bc821ee3 ("ARM: dts: imx6ull: Fix i.MX6ULL/ULZ ocotp compatible") the value "fsl,imx6ull-ocotp" is already defined and set in device tree...
By setting "ocotp_compat" to "fsl,imx6ull-ocotp" the kernel does boot.
--- arch/arm/mach-imx/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/cpu.c +2 -2
@@ -148,11 +148,11 @@ struct device * __init imx_soc_device_init(void) soc_id ="i.MX6UL" ;break ;case MXC_CPU_IMX6ULL : - ocotp_compat ="fsl,imx6ul-ocotp" ; + ocotp_compat ="fsl,imx6ull-ocotp" ; soc_id ="i.MX6ULL" ;break ;case MXC_CPU_IMX6ULZ : - ocotp_compat ="fsl,imx6ul-ocotp" ; + ocotp_compat ="fsl,imx6ull-ocotp" ; soc_id ="i.MX6ULZ" ;break ;case MXC_CPU_IMX6SLL :
Signature · 7 lines
2.11.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Christoph,
Quoted 1 line · Christoph Niedermaier
Tested on next-20191205.
Just a nit: this information should be better removed from the commit log and put under the --- line.
Quoted 10 lines
For i.MX6ULL/ULZ the variable "
ocotp_compat" is set to "fsl,imx6ul-ocotp", but with commitffbc34bf0e9c("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") and commitf243bc821ee3("ARM: dts: imx6ull: Fix i.MX6ULL/ULZ ocotp compatible") the value "fsl,imx6ull-ocotp" is already defined and set in device tree...By setting "
ocotp_compat" to "fsl,imx6ull-ocotp" the kernel does boot.Fixes 8267ff89b713 ("ARM: imx: Add serial number support for i.MX6/7 SoCs")Signed-off-by Christoph Niedermaier <[email protected]>
Thanks for the fix.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo
AppliedQuoted 9 lines · Christoph Niedermaier
After the commit
8267ff89b713("ARM: imx: Add serial number support for i.MX6/7 SoCs") the kernel doesn't start on i.MX6ULL/ULZ SoC.
Tested on next-20191205.For i.MX6ULL/ULZ the variable "
ocotp_compat" is set to "fsl,imx6ul-ocotp", but with commitffbc34bf0e9c("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") and commitf243bc821ee3("ARM: dts: imx6ull: Fix i.MX6ULL/ULZ ocotp compatible") the value "fsl,imx6ull-ocotp" is already defined and set in device tree...
Quoted 4 lines
By setting "
ocotp_compat" to "fsl,imx6ull-ocotp" the kernel does boot.Fixes 8267ff89b713 ("ARM: imx: Add serial number support for i.MX6/7 SoCs")Signed-off-by Christoph Niedermaier <[email protected]>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel