serial: Fix SIFIVE debug serial dependency
PATCH 1/1 serial: Fix SIFIVE debug serial dependency
The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x.
---
drivers/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/Kconfig +1 -1
@@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX config DEBUG_UART_SIFIVE bool "SiFive UART" - depends on PL01X_SERIAL + depends on SIFIVE_SERIAL help Select this to enable a debug UART using the serial_sifive driver. You will need to provide parameters to make this work. The driver will
Signature · 1 line
2.27.0
PATCH 1/1 serial: Fix SIFIVE debug serial dependency
Hi Michal,
Quoted 4 lines · Michal Simek
The commit
4cc24aeaf420("serial: Add missingKconfigdependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x.
Does that mean this should have a Fixes: tag?
Quoted 7 lines
Signed-off-by Michal Simek <[email protected]>---
drivers/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Regards,
Simon
PATCH 1/1 serial: Fix SIFIVE debug serial dependency
Hi Simon,
Quoted 9 lines · Simon Glass
Hi Michal,
Quoted 4 lines · Michal Simek
The commit
4cc24aeaf420("serial: Add missingKconfigdependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x.Does that mean this should have a Fixes: tag?
TBH I had it there but removed it because commit is pointing to it anyway. And also I am not aware about any stable process in place. Or is there any process around that people are looking for fixed tags and picking them to any u-boot stable tree?
Thanks,
Michal
PATCH 1/1 serial: Fix SIFIVE debug serial dependency
Quoted 12 lines · Michal Simek
Hi Simon,
Quoted 8 lines · Simon Glass
Hi Michal,
Quoted 4 lines · Michal Simek
The commit
4cc24aeaf420("serial: Add missingKconfigdependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x.
Quoted 7 lines
Quoted 1 line
Does that mean this should have a Fixes: tag?
TBH I had it there but removed it because commit is pointing to it anyway. And also I am not aware about any stable process in place. Or is there any process around that people are looking for fixed tags and picking them to any u-boot stable tree?
+Tom Rini who may know
PATCH 1/1 serial: Fix SIFIVE debug serial dependency
Quoted 13 lines · Simon Glass
Quoted 12 lines · Michal Simek
Hi Simon,
Quoted 8 lines · Simon Glass
Hi Michal,
Quoted 4 lines · Michal Simek
The commit
4cc24aeaf420("serial: Add missingKconfigdependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Does that mean this should have a Fixes: tag?
TBH I had it there but removed it because commit is pointing to it anyway. And also I am not aware about any stable process in place. Or is there any process around that people are looking for fixed tags and picking them to any u-boot stable tree?
+Tom Rini who may know
We do fixes tags because it's good history.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200714/af6d9fbd/attachment.sig>
PATCH 1/1 serial: Fix SIFIVE debug serial dependency
Quoted 16 lines · Tom Rini
Quoted 15 lines · Simon Glass
Quoted 14 lines · Michal Simek
Hi Simon,
Quoted 9 lines · Simon Glass
Hi Michal,
Quoted 4 lines · Michal Simek
The commit
4cc24aeaf420("serial: Add missingKconfigdependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x.Does that mean this should have a Fixes: tag?
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
TBH I had it there but removed it because commit is pointing to it anyway. And also I am not aware about any stable process in place. Or is there any process around that people are looking for fixed tags and picking them to any u-boot stable tree?
+Tom Rini who may know
We do fixes tags because it's good history.
ok. Thx.
M