net: phy: broadcom: set features explicitly for BCM54616S
Subsystems (4)
PATCH 1/2 net: phy: broadcom: set features explicitly for BCM54616S
BCM54616S feature "PHY_GBIT_FEATURES" was removed by commit dcdecdcfe1fc ("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.
--- drivers/net/phy/broadcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/broadcom.c +1 -1
@@ -650,7 +650,7 @@ static struct phy_driver broadcom_drivers[] = { .phy_id = PHY_ID_BCM54616S, .phy_id_mask = 0xfffffff0, .name = "Broadcom BCM54616S", -/* PHY_GBIT_FEATURES */ + .features = PHY_GBIT_FEATURES, .config_init = bcm54xx_config_init, .config_aneg = bcm54616s_config_aneg, .ack_interrupt = bcm_phy_ack_intr,
Signature · 1 line
2.17.1
Andrew Lunn
maintainerQuoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.
Hi Tao
What exactly does it get wrong?
Thanks
Andrew
Quoted 7 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.
Quoted 6 lines
Hi Tao
What exactly does it get wrong?
Thanks
Andrew
Hi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.
Thanks,
Tao
Heiner Kallweit
maintainerQuoted 10 lines · Tao Ren
Quoted 9 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Hi Tao
Quoted 9 lines
Quoted 4 lines
What exactly does it get wrong?
Thanks
AndrewHi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.
Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?
Quoted 5 lines
Thanks,
Tao
Heiner
Quoted 16 lines · Heiner Kallweit
Quoted 15 lines · Tao Ren
Quoted 13 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Hi Tao
What exactly does it get wrong?
Thanks
Andrew
Quoted 7 lines
Quoted 4 lines
Hi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?
Hi Heiner,
The phy starts in fiber mode and that's the mode I want.
My observation is: phydev->link is always 0 (Link status bit is never set in MII_BMSR) by using dynamic ability detection on my machine. I checked phydev->supported and it's set to "AutoNeg | TP | MII | Pause | Asym_Pause" by dynamic ability detection. Is it normal/expected? Or maybe the fix should go to different places? Thank you for your help.
Thanks,
Tao
Heiner Kallweit
maintainerQuoted 21 lines · Tao Ren
Quoted 20 lines · Heiner Kallweit
Quoted 19 lines · Tao Ren
Quoted 7 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Quoted 6 lines
Hi Tao
What exactly does it get wrong?
Thanks
AndrewHi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.
Quoted 9 lines
Quoted 3 lines
Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?Hi Heiner,
The phy starts in fiber mode and that's the mode I want.
My observation is:phydev->linkis always 0 (Link status bit is never set inMII_BMSR) by using dynamic ability detection on my machine. I checkedphydev->supportedand it's set to "AutoNeg | TP | MII | Pause |Asym_Pause" by dynamic ability detection. Is it normal/expected? Or maybe the fix should go to different places? Thank you for your help.
Not sure whether you stated already which kernel version you're using. There's a brand-new extension to auto-detect 1000BaseX:f30e33bcdab9 ("net: phy: Add more 1000BaseX support detection") It's included in the 5.3-rc series.
If a feature can be read from a vendor-specific register only, then the preferred way is: Implement callback get_features in the PHY driver, call genphy_read_abilities for the basic features and complement it with reading the vendor-specific register(s).
Quoted 5 lines
Thanks,
Tao
Heiner
Quoted 28 lines · Heiner Kallweit
Quoted 27 lines · Tao Ren
Quoted 16 lines · Heiner Kallweit
Quoted 15 lines · Tao Ren
Quoted 13 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Hi Tao
What exactly does it get wrong?
Thanks
AndrewQuoted 7 lines
Quoted 4 lines
Hi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?Hi Heiner,
Quoted 8 lines
Quoted 3 lines
The phy starts in fiber mode and that's the mode I want.
My observation is:phydev->linkis always 0 (Link status bit is never set inMII_BMSR) by using dynamic ability detection on my machine. I checkedphydev->supportedand it's set to "AutoNeg | TP | MII | Pause |Asym_Pause" by dynamic ability detection. Is it normal/expected? Or maybe the fix should go to different places? Thank you for your help.Not sure whether you stated already which kernel version you're using. There's a brand-new extension to auto-detect 1000BaseX:
f30e33bcdab9("net: phy: Add more 1000BaseX support detection") It's included in the 5.3-rc series.
I'm running kernel 5.2.0. Thank you for the sharing and I didn't know the patch. Let me check it out.
Quoted 4 lines
If a feature can be read from a vendor-specific register only, then the preferred way is: Implement callback
get_featuresin the PHY driver, callgenphy_read_abilitiesfor the basic features and complement it with reading the vendor-specific register(s).
Got it. Let me update my code and will come back soon.
Thanks,
Tao
Quoted 33 lines · Tao Ren
Quoted 32 lines · Heiner Kallweit
Quoted 30 lines · Tao Ren
Quoted 16 lines · Heiner Kallweit
Quoted 15 lines · Tao Ren
Quoted 13 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Hi Tao
What exactly does it get wrong?
Thanks
AndrewQuoted 7 lines
Quoted 4 lines
Hi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?Hi Heiner,
The phy starts in fiber mode and that's the mode I want.
My observation is:phydev->linkis always 0 (Link status bit is never set inMII_BMSR) by using dynamic ability detection on my machine. I checkedphydev->supportedand it's set to "AutoNeg | TP | MII | Pause |Asym_Pause" by dynamic ability detection. Is it normal/expected? Or maybe the fix should go to different places? Thank you for your help.
Quoted 6 lines
Quoted 4 lines
Not sure whether you stated already which kernel version you're using. There's a brand-new extension to auto-detect 1000BaseX:
f30e33bcdab9("net: phy: Add more 1000BaseX support detection") It's included in the 5.3-rc series.I'm running kernel 5.2.0. Thank you for the sharing and I didn't know the patch. Let me check it out.
I applied above patch and ca72efb6bdc7 ("net: phy: Add detection of 1000BaseX link mode support") to my 5.2.0 tree but got following warning when booting up my machine:
"PHY advertising (0,00000200,000062c0) more modes than genphy supports, some modes not advertised".
The BCM54616S PHY on my machine only reports 1000-X features in RGMII->1000Base-KX mode. Is it a known problem?
Anyways let me see if I missed some dependency/follow-up patches..
Cheers,
Tao
Quoted 41 lines · Tao Ren
Quoted 33 lines · Tao Ren
Quoted 32 lines · Heiner Kallweit
Quoted 30 lines · Tao Ren
Quoted 16 lines · Heiner Kallweit
Quoted 15 lines · Tao Ren
Quoted 13 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Hi Tao
What exactly does it get wrong?
Thanks
AndrewQuoted 7 lines
Quoted 4 lines
Hi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?Hi Heiner,
The phy starts in fiber mode and that's the mode I want.
My observation is:phydev->linkis always 0 (Link status bit is never set inMII_BMSR) by using dynamic ability detection on my machine. I checkedphydev->supportedand it's set to "AutoNeg | TP | MII | Pause |Asym_Pause" by dynamic ability detection. Is it normal/expected? Or maybe the fix should go to different places? Thank you for your help.Quoted 6 lines
Quoted 4 lines
Not sure whether you stated already which kernel version you're using. There's a brand-new extension to auto-detect 1000BaseX:
f30e33bcdab9("net: phy: Add more 1000BaseX support detection") It's included in the 5.3-rc series.I'm running kernel 5.2.0. Thank you for the sharing and I didn't know the patch. Let me check it out.
Quoted 7 lines
I applied above patch and
ca72efb6bdc7("net: phy: Add detection of 1000BaseX link mode support") to my 5.2.0 tree but got following warning when booting up my machine:"PHY advertising (0,00000200,000062c0) more modes than genphy supports, some modes not advertised".
The BCM54616S PHY on my machine only reports 1000-X features in RGMII->1000Base-KX mode. Is it a known problem?
Anyways let me see if I missed some dependency/follow-up patches..
Let's ignore the patch ("net: phy: broadcom: set features explicitly for BCM54616S"): as Heiner pointed out, it doesn't make sense to turn on copper features for fiber mode (even though it "works" in my environment). I will work out new patch if 1000bx-auto-detection patches cannot solve my problem.
Thank you all for spending time on this.
Cheers,
Tao
Heiner Kallweit
maintainerQuoted 39 lines · Tao Ren
Quoted 38 lines · Tao Ren
Quoted 36 lines · Heiner Kallweit
Quoted 21 lines · Tao Ren
Quoted 20 lines · Heiner Kallweit
Quoted 19 lines · Tao Ren
Quoted 7 lines · Andrew Lunn
Quoted 5 lines · Tao Ren
BCM54616S feature "
PHY_GBIT_FEATURES" was removed by commitdcdecdcfe1fc("net: phy: switch drivers to use dynamic feature detection"). As dynamic feature detection doesn't work when BCM54616S is working in RGMII-Fiber mode (different sets of MII Control/Status registers being used), let's set "PHY_GBIT_FEATURES" for BCM54616S explicitly.Quoted 6 lines
Hi Tao
What exactly does it get wrong?
Thanks
AndrewHi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by
genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.Quoted 9 lines
Quoted 3 lines
Are you going to use the PHY in copper or fibre mode?
In case you use fibre mode, why do you need the copper modes set as supported? Or does the PHY just start in fibre mode and you want to switch it to copper mode?Hi Heiner,
The phy starts in fiber mode and that's the mode I want.
My observation is:phydev->linkis always 0 (Link status bit is never set inMII_BMSR) by using dynamic ability detection on my machine. I checkedphydev->supportedand it's set to "AutoNeg | TP | MII | Pause |Asym_Pause" by dynamic ability detection. Is it normal/expected? Or maybe the fix should go to different places? Thank you for your help.Not sure whether you stated already which kernel version you're using. There's a brand-new extension to auto-detect 1000BaseX:
f30e33bcdab9("net: phy: Add more 1000BaseX support detection") It's included in the 5.3-rc series.
Quoted 6 lines
Quoted 1 line
I'm running kernel 5.2.0. Thank you for the sharing and I didn't know the patch. Let me check it out.
I applied above patch and
ca72efb6bdc7("net: phy: Add detection of 1000BaseX link mode support") to my 5.2.0 tree but got following warning when booting up my machine:"PHY advertising (0,00000200,000062c0) more modes than genphy supports, some modes not advertised".
It's genphy_config_advert complaining which is called from genphy_config_aneg. genphy_config_aneg deals with the standard Base-T modes. Therefore in your case most likely you want to provide an own config_aneg callback (in case autoneg is applicable at all).
Quoted 9 lines
The BCM54616S PHY on my machine only reports 1000-X features in RGMII->1000Base-KX mode. Is it a known problem?
Anyways let me see if I missed some dependency/follow-up patches..
Cheers,
Tao
Heiner