Skip to contentSkip to conversation

test: call hexdump tests via `ut lib`

PATCH New Heinrich Schuchardt 3 participants 4 messages Feb 11, 2019 – Apr 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: call hexdump tests via `ut lib`

The unit tests in test/lib/hexdump.c are not related to the device tree. So they should be executed via ut lib and not via ut dm.

---
 test/lib/hexdump.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
test/lib/hexdump.c +5 -4
index 567b57686a..5dccf43886 100644
@@ -6,7 +6,8 @@
 
 #include <common.h>
 #include <hexdump.h>
-#include <dm/test.h>
+#include <test/lib.h>
+#include <test/test.h>
 #include <test/ut.h>
 
 static int lib_test_hex_to_bin(struct unit_test_state *uts)
@@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct unit_test_state *uts)
 	return 0;
 }
 
-DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex_to_bin, 0);
 
 static int lib_test_hex2bin(struct unit_test_state *uts)
 {
@@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state *uts)
 	return 0;
 }
 
-DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex2bin, 0);
 
 static int lib_test_bin2hex(struct unit_test_state *uts)
 {
@@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state *uts)
 	return 0;
 }
 
-DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_bin2hex, 0);
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 test: call hexdump tests via `ut lib`

Am 11.02.2019 um 18:29 schrieb Heinrich Schuchardt:

Quoted 4 lines

The unit tests in test/lib/hexdump.c are not related to the device tree. So they should be executed via ut lib and not via ut dm.

Excellent idea, I'll send the same for test/lib/lmb.c.

Thanks,
Simon

Quoted 43 lines
---
  test/lib/hexdump.c | 9 +++++----
  1 file changed, 5 insertions(+), 4 deletions(-)
test/lib/hexdump.c +5 -4
index 567b57686a..5dccf43886 100644
@@ -6,7 +6,8 @@
 
  #include <common.h>
  #include <hexdump.h>
-#include <dm/test.h>
+#include <test/lib.h>
+#include <test/test.h>
  #include <test/ut.h>
 
  static int lib_test_hex_to_bin(struct unit_test_state *uts)
@@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct unit_test_state *uts)
  	return 0;
  }
 
-DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex_to_bin, 0);
 
  static int lib_test_hex2bin(struct unit_test_state *uts)
  {
@@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state *uts)
  	return 0;
  }
 
-DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex2bin, 0);
 
  static int lib_test_bin2hex(struct unit_test_state *uts)
  {
@@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state *uts)
  	return 0;
  }
 
-DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_bin2hex, 0);
#2 lore raw

PATCH 1/1 test: call hexdump tests via `ut lib`

Quoted 7 lines · Simon Goldschmidt

Am 11.02.2019 um 18:29 schrieb Heinrich Schuchardt:

Quoted 4 lines

The unit tests in test/lib/hexdump.c are not related to the device tree. So they should be executed via ut lib and not via ut dm.

Hello Tom,

please, consider the patch for v2019-07.

Best regards

Heinrich

Quoted 47 lines

Excellent idea, I'll send the same for test/lib/lmb.c.

Thanks,
Simon

Quoted 39 lines

---
  test/lib/hexdump.c | 9 +++++----

  1 file changed, 5 insertions(+), 4 deletions(-)
test/lib/hexdump.c +5 -1
index 567b57686a..5dccf43886 100644
@@ -6,7 +6,8 @@
     #include <common.h>
   #include <hexdump.h>
-#include <dm/test.h>
+#include <test/lib.h>
+#include <test/test.h>
   #include <test/ut.h>
     static int lib_test_hex_to_bin(struct unit_test_state *uts)
@@ -32,7 +33,7 @@ static int lib_test_hex_to_bin(struct
 unit_test_state *uts)
       return 0;
   }
   -DM_TEST(lib_test_hex_to_bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex_to_bin, 0);
     static int lib_test_hex2bin(struct unit_test_state *uts)
   {
@@ -62,7 +63,7 @@ static int lib_test_hex2bin(struct unit_test_state
 *uts)
       return 0;
   }
   -DM_TEST(lib_test_hex2bin, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_hex2bin, 0);
     static int lib_test_bin2hex(struct unit_test_state *uts)
   {
@@ -92,4 +93,4 @@ static int lib_test_bin2hex(struct unit_test_state
 *uts)
       return 0;
   }
   -DM_TEST(lib_test_bin2hex, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+LIB_TEST(lib_test_bin2hex, 0);
#3 lore raw

PATCH 1/1 test: call hexdump tests via `ut lib`

In reply to Heinrich Schuchardt
Quoted 5 lines · Heinrich Schuchardt

The unit tests in test/lib/hexdump.c are not related to the device tree. So they should be executed via ut lib and not via ut dm.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/a917d4ba/attachment.sig>