Skip to contentSkip to conversation

media: venus: vdec: fix error state assignment for zero bytesused

PATCH Superseded Renjiang Han 2 participants 3 messages Dec 8, 2025 – Dec 10, 2025

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 media: venus: vdec: fix error state assignment for zero bytesused

When hfi_session_flush is issued, all queued buffers are returned to the V4L2 driver. Some of these buffers are not processed and have bytesused = 0. Currently, the driver marks such buffers as error even during drain operations, which can incorrectly flag EOS buffers.

This patch moves the zero-bytesused check inside the non-EOS branch so that only capture buffers with zero payload (and not EOS) are marked with VB2_BUF_STATE_ERROR.

Fixes 51df3c81ba10b ("media: venus: vdec: Mark flushed buffers with error state")

---
This patch refines the error state assignment logic in the Venus vdec
driver for Qualcomm platforms. Specifically, it ensures that the buffer
state is only set to VB2_BUF_STATE_ERROR for non-EOS capture buffers
with zero bytesused, preventing false error reporting during drain
operations.
---
Changes in v2:
- 1. Update commit message.
- 2. Add a Fixes tag.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 drivers/media/platform/qcom/venus/vdec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/platform/qcom/venus/vdec.c +3 -3
index 4a6641fdffcf79705893be58c7ec5cf485e2fab9..d0bd2d86a31f9a18cb68b08ba66affdf8fc5092d 100644
@@ -1440,10 +1440,10 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type,
 				inst->drain_active = false;
 				inst->codec_state = VENUS_DEC_STATE_STOPPED;
 			}
+		} else {
+			if (!bytesused)
+				state = VB2_BUF_STATE_ERROR;
 		}
-
-		if (!bytesused)
-			state = VB2_BUF_STATE_ERROR;
 	} else {
 		vbuf->sequence = inst->sequence_out++;
 	}

---
base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f
change-id: 20251126-fix-error-state-24183a8538cd

Best regards,

Signature · 1 line
Renjiang Han <[email protected]>
#1 lore raw
Quoted 6 lines · Renjiang Han

When hfi_session_flush is issued, all queued buffers are returned to the V4L2 driver. Some of these buffers are not processed and have bytesused = 0. Currently, the driver marks such buffers as error even during drain operations, which can incorrectly flag EOS buffers.

This patch moves the zero-bytesused check inside the non-EOS branch

Documentation/process/submitting-patches.rst, "This patch".

Quoted 6 lines

so that only capture buffers with zero payload (and not EOS) are marked with VB2_BUF_STATE_ERROR.

Fixes 51df3c81ba10b ("media: venus: vdec: Mark flushed buffers with error state")

No empty lines between tags.

Quoted 42 lines

---
This patch refines the error state assignment logic in the Venus vdec
driver for Qualcomm platforms. Specifically, it ensures that the buffer
state is only set to VB2_BUF_STATE_ERROR for non-EOS capture buffers
with zero bytesused, preventing false error reporting during drain
operations.
---
Changes in v2:
- 1. Update commit message.
- 2. Add a Fixes tag.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 drivers/media/platform/qcom/venus/vdec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/platform/qcom/venus/vdec.c +3 -4
index 4a6641fdffcf79705893be58c7ec5cf485e2fab9..d0bd2d86a31f9a18cb68b08ba66affdf8fc5092d 100644
@@ -1440,10 +1440,10 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type,
 				inst->drain_active = false;
 				inst->codec_state = VENUS_DEC_STATE_STOPPED;
 			}
+		} else {
+			if (!bytesused)
+				state = VB2_BUF_STATE_ERROR;
 		}
-
-		if (!bytesused)
-			state = VB2_BUF_STATE_ERROR;
 	} else {
 		vbuf->sequence = inst->sequence_out++;
 	}
 
---

base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f
change-id: 20251126-fix-error-state-24183a8538cd

Best regards,

Signature · 1 line
Renjiang Han <[email protected]>
Signature · 2 lines
With best wishes
Dmitry
#2 lore raw
Quoted 8 lines · Dmitry Baryshkov
Quoted 6 lines · Renjiang Han

When hfi_session_flush is issued, all queued buffers are returned to the V4L2 driver. Some of these buffers are not processed and have bytesused = 0. Currently, the driver marks such buffers as error even during drain operations, which can incorrectly flag EOS buffers.

This patch moves the zero-bytesused check inside the non-EOS branch

Documentation/process/submitting-patches.rst, "This patch".

OK, thanks for your reminder. I will update it.

Quoted 8 lines
Quoted 7 lines

so that only capture buffers with zero payload (and not EOS) are marked with VB2_BUF_STATE_ERROR.

Fixes 51df3c81ba10b ("media: venus: vdec: Mark flushed buffers with error state")

No empty lines between tags.

OK, thanks for your comment. I will update it.

Quoted 43 lines
Quoted 43 lines

---
This patch refines the error state assignment logic in the Venus vdec
driver for Qualcomm platforms. Specifically, it ensures that the buffer
state is only set to VB2_BUF_STATE_ERROR for non-EOS capture buffers
with zero bytesused, preventing false error reporting during drain
operations.
---
Changes in v2:
- 1. Update commit message.
- 2. Add a Fixes tag.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
  drivers/media/platform/qcom/venus/vdec.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/platform/qcom/venus/vdec.c +3 -4
index 4a6641fdffcf79705893be58c7ec5cf485e2fab9..d0bd2d86a31f9a18cb68b08ba66affdf8fc5092d 100644
@@ -1440,10 +1440,10 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type,
  				inst->drain_active = false;
  				inst->codec_state = VENUS_DEC_STATE_STOPPED;
  			}
+		} else {
+			if (!bytesused)
+				state = VB2_BUF_STATE_ERROR;
  		}
-
-		if (!bytesused)
-			state = VB2_BUF_STATE_ERROR;
  	} else {
  		vbuf->sequence = inst->sequence_out++;
  	}
 
---

base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f
change-id: 20251126-fix-error-state-24183a8538cd

Best regards,

Signature · 1 line
Renjiang Han <[email protected]>
Signature · 2 lines
Best regards,
Renjiang Han