Skip to contentSkip to conversation

drm/nouveau/flcn/cmdq: Move assignment outside if condition

PATCH New [email protected] 1 participant 1 message Jul 11, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/nouveau/flcn/cmdq: Move assignment outside if condition

Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c +2 -1
index 211ebe7afac6..a8beb55097a6 100644
@@ -203,7 +203,8 @@ nvkm_falcon_cmdq_new(struct nvkm_falcon_qmgr *qmgr, const char *name,
 {
     struct nvkm_falcon_cmdq *cmdq = *pcmdq;
 
-    if (!(cmdq = *pcmdq = kzalloc(sizeof(*cmdq), GFP_KERNEL)))
+    cmdq = *pcmdq = kzalloc(sizeof(*cmdq), GFP_KERNEL);
+    if (!cmdq)
         return -ENOMEM;
 
     cmdq->qmgr = qmgr;